<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208399] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208399">208399</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-11-04 14:54:44 -0700 (Fri, 04 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a setting and preferences to enable/disable async image decoding
https://bugs.webkit.org/show_bug.cgi?id=164417
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-11-04
Reviewed by Simon Fraser.
Source/WebCore:
Add an asyncImageDecodingEnabled setting. This setting controls whether an
image "can" be asynchronously decoded on a separate thread or not. The
function ImageSource::isAsyncDecodingRequired() will be used in conjunction
with this setting to decide whether an image "should" be asynchronously
decoded or not.
* page/Settings.in:
Source/WebKit/mac:
Hook up the asyncImageDecodingEnabled setting for WebKit1.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences asyncImageDecodingEnabled]):
(-[WebPreferences setAsyncImageDecodingEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Hook up the asyncImageDecodingEnabled setting for WebKit2.
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _asyncImageDecodingEnabled]):
(-[WKPreferences _setAsyncImageDecodingEnabled:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleAsyncImageDecodingEnabled:]):
(-[SettingsController asyncImageDecodingEnabled]):
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsermacSettingsControllerh">trunk/Tools/MiniBrowser/mac/SettingsController.h</a></li>
<li><a href="#trunkToolsMiniBrowsermacSettingsControllerm">trunk/Tools/MiniBrowser/mac/SettingsController.m</a></li>
<li><a href="#trunkToolsMiniBrowsermacWK1BrowserWindowControllerm">trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m</a></li>
<li><a href="#trunkToolsMiniBrowsermacWK2BrowserWindowControllerm">trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebCore/ChangeLog 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Add a setting and preferences to enable/disable async image decoding
+ https://bugs.webkit.org/show_bug.cgi?id=164417
+
+ Reviewed by Simon Fraser.
+
+ Add an asyncImageDecodingEnabled setting. This setting controls whether an
+ image "can" be asynchronously decoded on a separate thread or not. The
+ function ImageSource::isAsyncDecodingRequired() will be used in conjunction
+ with this setting to decide whether an image "should" be asynchronously
+ decoded or not.
+
+ * page/Settings.in:
+
</ins><span class="cx"> 2016-11-04 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Apply post-landing review comments for r208347
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebCore/page/Settings.in 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -286,3 +286,5 @@
</span><span class="cx"> youTubeFlashPluginReplacementEnabled initial=defaultYouTubeFlashPluginReplacementEnabled
</span><span class="cx">
</span><span class="cx"> forcedPrefersReducedMotionValue type=ForcedPrefersReducedMotionValue, initial=defaultForcedPrefersReducedMotionValue
</span><ins>+
+asyncImageDecodingEnabled initial=true
</ins></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Add a setting and preferences to enable/disable async image decoding
+ https://bugs.webkit.org/show_bug.cgi?id=164417
+
+ Reviewed by Simon Fraser.
+
+ Hook up the asyncImageDecodingEnabled setting for WebKit1.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences asyncImageDecodingEnabled]):
+ (-[WebPreferences setAsyncImageDecodingEnabled:]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2016-11-01 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove PassRefPtr from DumpRenderTree
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -140,6 +140,7 @@
</span><span class="cx"> #define WebKitSuppressesIncrementalRenderingKey @"WebKitSuppressesIncrementalRendering"
</span><span class="cx"> #define WebKitSubpixelCSSOMElementMetricsEnabledPreferenceKey @"WebKitSubpixelCSSOMElementMetricsEnabled"
</span><span class="cx"> #define WebKitResourceLoadStatisticsEnabledPreferenceKey @"WebKitResourceLoadStatisticsEnabled"
</span><ins>+#define WebKitAsyncImageDecodingEnabledPreferenceKey @"WebKitAsyncImageDecodingEnabledEnabled"
</ins><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> #define WebKitAudioSessionCategoryOverride @"WebKitAudioSessionCategoryOverride"
</span><span class="cx"> #define WebKitAVKitEnabled @"WebKitAVKitEnabled"
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -507,6 +507,7 @@
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitAccelerated2dCanvasEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitSubpixelCSSOMElementMetricsEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitResourceLoadStatisticsEnabledPreferenceKey,
</span><ins>+ [NSNumber numberWithBool:YES], WebKitAsyncImageDecodingEnabledPreferenceKey,
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitFrameFlatteningEnabledPreferenceKey,
</span><span class="cx"> #else
</span><span class="lines">@@ -1874,6 +1875,16 @@
</span><span class="cx"> [self _setBoolValue:enabled forKey:WebKitResourceLoadStatisticsEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)asyncImageDecodingEnabled
+{
+ return [self _boolValueForKey:WebKitAsyncImageDecodingEnabledPreferenceKey];
+}
+
+- (void)setAsyncImageDecodingEnabled:(BOOL)enabled
+{
+ [self _setBoolValue:enabled forKey:WebKitAsyncImageDecodingEnabledPreferenceKey];
+}
+
</ins><span class="cx"> - (BOOL)canvasUsesAcceleratedDrawing
</span><span class="cx"> {
</span><span class="cx"> return [self _boolValueForKey:WebKitCanvasUsesAcceleratedDrawingPreferenceKey];
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -504,6 +504,7 @@
</span><span class="cx"> - (BOOL)modernMediaControlsEnabled;
</span><span class="cx">
</span><span class="cx"> @property (nonatomic) BOOL visualViewportEnabled;
</span><ins>+@property (nonatomic) BOOL asyncImageDecodingEnabled;
</ins><span class="cx"> @property (nonatomic) BOOL javaScriptMarkupEnabled;
</span><span class="cx"> @property (nonatomic) BOOL mediaDataLoadsAutomatically;
</span><span class="cx"> @property (nonatomic) BOOL attachmentElementEnabled;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -2601,6 +2601,8 @@
</span><span class="cx"> settings.setAllowWindowOpenWithoutUserGesture(shouldAllowWindowOpenWithoutUserGesture());
</span><span class="cx">
</span><span class="cx"> settings.setShouldConvertInvalidURLsToBlank(shouldConvertInvalidURLsToBlank());
</span><ins>+
+ settings.setAsyncImageDecodingEnabled([preferences asyncImageDecodingEnabled]);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline IMP getMethod(id o, SEL s)
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit2/ChangeLog 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Add a setting and preferences to enable/disable async image decoding
+ https://bugs.webkit.org/show_bug.cgi?id=164417
+
+ Reviewed by Simon Fraser.
+
+ Hook up the asyncImageDecodingEnabled setting for WebKit2.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _asyncImageDecodingEnabled]):
+ (-[WKPreferences _setAsyncImageDecodingEnabled:]):
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2016-11-04 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename some ScrollingTree/Node-related functions to reduce the number of uses of "update"
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -233,6 +233,7 @@
</span><span class="cx"> macro(ApplePayEnabled, applePayEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(ApplePayCapabilityDisclosureAllowed, applePayCapabilityDisclosureAllowed, Bool, bool, true, "", "") \
</span><span class="cx"> macro(VisualViewportEnabled, visualViewportEnabled, Bool, bool, false, "", "") \
</span><ins>+ macro(AsyncImageDecodingEnabled, asyncImageDecodingEnabled, Bool, bool, true, "", "") \
</ins><span class="cx"> \
</span><span class="cx">
</span><span class="cx"> #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -325,6 +325,16 @@
</span><span class="cx"> _preferences->setVisualViewportEnabled(_visualViewportEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)_asyncImageDecodingEnabled
+{
+ return _preferences->asyncImageDecodingEnabled();
+}
+
+- (void)_setAsyncImageDecodingEnabled:(BOOL)_asyncImageDecodingEnabled
+{
+ _preferences->setAsyncImageDecodingEnabled(_asyncImageDecodingEnabled);
+}
+
</ins><span class="cx"> - (BOOL)_textAutosizingEnabled
</span><span class="cx"> {
</span><span class="cx"> return _preferences->textAutosizingEnabled();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -64,6 +64,7 @@
</span><span class="cx"> @property (nonatomic, setter=_setAcceleratedDrawingEnabled:) BOOL _acceleratedDrawingEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
</span><span class="cx"> @property (nonatomic, setter=_setDisplayListDrawingEnabled:) BOOL _displayListDrawingEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
</span><span class="cx"> @property (nonatomic, setter=_setVisualViewportEnabled:) BOOL _visualViewportEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
</span><ins>+@property (nonatomic, setter=_setAsyncImageDecodingEnabled:) BOOL _asyncImageDecodingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
</ins><span class="cx"> @property (nonatomic, setter=_setTextAutosizingEnabled:) BOOL _textAutosizingEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
</span><span class="cx">
</span><span class="cx"> @property (nonatomic, setter=_setDeveloperExtrasEnabled:) BOOL _developerExtrasEnabled WK_API_AVAILABLE(macosx(10.11), ios(9.0));
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -236,7 +236,9 @@
</span><span class="cx"> macro(WebKitDisplayImagesKey, LoadsImagesAutomatically, loadsImagesAutomatically) \
</span><span class="cx"> macro(WebKitMediaStreamEnabled, MediaStreamEnabled, mediaStreamEnabled) \
</span><span class="cx"> macro(WebKitHTTPEquivEnabled, HttpEquivEnabled, httpEquivEnabled) \
</span><del>- macro(WebKitVisualViewportEnabled, VisualViewportEnabled, visualViewportEnabled)
</del><ins>+ macro(WebKitVisualViewportEnabled, VisualViewportEnabled, visualViewportEnabled) \
+ macro(WebKitAsyncImageDecodingEnabled, AsyncImageDecodingEnabled, asyncImageDecodingEnabled) \
+ \
</ins><span class="cx">
</span><span class="cx"> #define OVERRIDE_PREFERENCE_AND_SET_IN_EXISTING_PAGES(TestRunnerName, SettingsName, WebPreferencesName) \
</span><span class="cx"> if (preference == #TestRunnerName) { \
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -3241,6 +3241,7 @@
</span><span class="cx"> m_viewportConfiguration.setCanIgnoreScalingConstraints(m_ignoreViewportScalingConstraints);
</span><span class="cx"> setForceAlwaysUserScalable(m_forceAlwaysUserScalable || store.getBoolValueForKey(WebPreferencesKey::forceAlwaysUserScalableKey()));
</span><span class="cx"> #endif
</span><ins>+ settings.setAsyncImageDecodingEnabled(store.getBoolValueForKey(WebPreferencesKey::asyncImageDecodingEnabledKey()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(DATA_DETECTION)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Tools/ChangeLog 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Add a setting and preferences to enable/disable async image decoding
+ https://bugs.webkit.org/show_bug.cgi?id=164417
+
+ Reviewed by Simon Fraser.
+
+ Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
+
+ * MiniBrowser/mac/SettingsController.h:
+ * MiniBrowser/mac/SettingsController.m:
+ (-[SettingsController _populateMenu]):
+ (-[SettingsController validateMenuItem:]):
+ (-[SettingsController toggleAsyncImageDecodingEnabled:]):
+ (-[SettingsController asyncImageDecodingEnabled]):
+ * MiniBrowser/mac/WK1BrowserWindowController.m:
+ (-[WK1BrowserWindowController didChangeSettings]):
+ * MiniBrowser/mac/WK2BrowserWindowController.m:
+ (-[WK2BrowserWindowController didChangeSettings]):
+
</ins><span class="cx"> 2016-11-04 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacSettingsControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/SettingsController.h (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/SettingsController.h 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.h 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -50,6 +50,7 @@
</span><span class="cx"> @property (nonatomic, readonly) BOOL displayListDrawingEnabled;
</span><span class="cx"> @property (nonatomic, readonly) BOOL resourceLoadStatisticsEnabled;
</span><span class="cx"> @property (nonatomic, readonly) BOOL visualViewportEnabled;
</span><ins>+@property (nonatomic, readonly) BOOL asyncImageDecodingEnabled;
</ins><span class="cx"> @property (nonatomic, readonly) BOOL usesGameControllerFramework;
</span><span class="cx">
</span><span class="cx"> @property (nonatomic, readonly) NSString *defaultURL;
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacSettingsControllerm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/SettingsController.m 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -55,6 +55,7 @@
</span><span class="cx"> static NSString * const EnableSubPixelCSSOMMetricsPreferenceKey = @"EnableSubPixelCSSOMMetrics";
</span><span class="cx">
</span><span class="cx"> static NSString * const VisualViewportEnabledPreferenceKey = @"VisualViewportEnabled";
</span><ins>+static NSString * const AsyncImageDecodingEnabledPreferenceKey = @"AsyncImageDecodingEnabled";
</ins><span class="cx">
</span><span class="cx"> // This default name intentionally overlaps with the key that WebKit2 checks when creating a view.
</span><span class="cx"> static NSString * const UseRemoteLayerTreeDrawingAreaPreferenceKey = @"WebKit2UseRemoteLayerTreeDrawingArea";
</span><span class="lines">@@ -126,6 +127,7 @@
</span><span class="cx"> [self _addItemWithTitle:@"Enable Display List Drawing" action:@selector(toggleDisplayListDrawingEnabled:) indented:NO];
</span><span class="cx"> [self _addItemWithTitle:@"Enable Visual Viewport" action:@selector(toggleVisualViewportEnabled:) indented:NO];
</span><span class="cx"> [self _addItemWithTitle:@"Enable Resource Load Statistics" action:@selector(toggleResourceLoadStatisticsEnabled:) indented:NO];
</span><ins>+ [self _addItemWithTitle:@"Enable Async Image Decoding" action:@selector(toggleAsyncImageDecodingEnabled:) indented:NO];
</ins><span class="cx">
</span><span class="cx"> [self _addHeaderWithTitle:@"WebKit2-only Settings"];
</span><span class="cx">
</span><span class="lines">@@ -199,6 +201,8 @@
</span><span class="cx"> [menuItem setState:[self displayListDrawingEnabled] ? NSOnState : NSOffState];
</span><span class="cx"> else if (action == @selector(toggleResourceLoadStatisticsEnabled:))
</span><span class="cx"> [menuItem setState:[self resourceLoadStatisticsEnabled] ? NSOnState : NSOffState];
</span><ins>+ else if (action == @selector(toggleAsyncImageDecodingEnabled:))
+ [menuItem setState:[self asyncImageDecodingEnabled] ? NSOnState : NSOffState];
</ins><span class="cx"> else if (action == @selector(toggleVisualViewportEnabled:))
</span><span class="cx"> [menuItem setState:[self visualViewportEnabled] ? NSOnState : NSOffState];
</span><span class="cx"> else if (action == @selector(toggleShowTiledScrollingIndicator:))
</span><span class="lines">@@ -394,6 +398,16 @@
</span><span class="cx"> return [[NSUserDefaults standardUserDefaults] boolForKey:ResourceLoadStatisticsEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)toggleAsyncImageDecodingEnabled:(id)sender
+{
+ [self _toggleBooleanDefault:AsyncImageDecodingEnabledPreferenceKey];
+}
+
+- (BOOL)asyncImageDecodingEnabled
+{
+ return [[NSUserDefaults standardUserDefaults] boolForKey:AsyncImageDecodingEnabledPreferenceKey];
+}
+
</ins><span class="cx"> - (void)toggleEnableSubPixelCSSOMMetrics:(id)sender
</span><span class="cx"> {
</span><span class="cx"> [self _toggleBooleanDefault:EnableSubPixelCSSOMMetricsPreferenceKey];
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacWK1BrowserWindowControllerm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -282,6 +282,7 @@
</span><span class="cx"> [[WebPreferences standardPreferences] setAcceleratedDrawingEnabled:settings.acceleratedDrawingEnabled];
</span><span class="cx"> [[WebPreferences standardPreferences] setResourceLoadStatisticsEnabled:settings.resourceLoadStatisticsEnabled];
</span><span class="cx"> [[WebPreferences standardPreferences] setVisualViewportEnabled:settings.visualViewportEnabled];
</span><ins>+ [[WebPreferences standardPreferences] setAsyncImageDecodingEnabled:settings.asyncImageDecodingEnabled];
</ins><span class="cx">
</span><span class="cx"> BOOL useTransparentWindows = settings.useTransparentWindows;
</span><span class="cx"> if (useTransparentWindows != !self.window.isOpaque) {
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacWK2BrowserWindowControllerm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (208398 => 208399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2016-11-04 21:04:28 UTC (rev 208398)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2016-11-04 21:54:44 UTC (rev 208399)
</span><span class="lines">@@ -368,6 +368,7 @@
</span><span class="cx"> preferences._resourceUsageOverlayVisible = settings.resourceUsageOverlayVisible;
</span><span class="cx"> preferences._displayListDrawingEnabled = settings.displayListDrawingEnabled;
</span><span class="cx"> preferences._visualViewportEnabled = settings.visualViewportEnabled;
</span><ins>+ preferences._asyncImageDecodingEnabled = settings.asyncImageDecodingEnabled;
</ins><span class="cx">
</span><span class="cx"> _webView.configuration.websiteDataStore._resourceLoadStatisticsEnabled = settings.resourceLoadStatisticsEnabled;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>