<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208381] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208381">208381</a></dd>
<dt>Author</dt> <dd>pvollan@apple.com</dd>
<dt>Date</dt> <dd>2016-11-04 02:35:36 -0700 (Fri, 04 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Win] Page visibility tests are timing out.
https://bugs.webkit.org/show_bug.cgi?id=164363
Reviewed by Brent Fulgham.
Source/WebKit/win:
Add method to set page visibility.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::QueryInterface):
(WebView::findString):
(WebView::setVisibilityState):
* WebView.h:
Tools:
Implement methods to set page visibility.
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
LayoutTests:
Unskip page visibility tests.
* platform/win/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebViewPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebViewh">trunk/Source/WebKit/win/WebView.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreewinTestRunnerWincpp">trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/LayoutTests/ChangeLog 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-11-04 Per Arne Vollan <pvollan@apple.com>
+
+ [Win] Page visibility tests are timing out.
+ https://bugs.webkit.org/show_bug.cgi?id=164363
+
+ Reviewed by Brent Fulgham.
+
+ Unskip page visibility tests.
+
+ * platform/win/TestExpectations:
+
</ins><span class="cx"> 2016-11-03 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r207669): Crash under SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/LayoutTests/platform/win/TestExpectations 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -2709,11 +2709,7 @@
</span><span class="cx"> webkit.org/b/97026 [ Release ] fast/events/keydown-leftright-keys.html [ Failure ]
</span><span class="cx"> webkit.org/b/97026 [ Debug ] fast/events/keydown-leftright-keys.html [ Skip ] # Debug Assertion
</span><span class="cx"> # fast/events/page-visibility tests timeout.
</span><del>-webkit.org/b/121509 fast/events/page-visibility-iframe-delete-test.html [ Skip ] # [ Timeout ]
</del><span class="cx"> webkit.org/b/121509 fast/events/wheelevent-mousewheel-interaction.html [ Skip ] # [ Timeout ]
</span><del>-webkit.org/b/121509 fast/events/page-visibility-iframe-propagation-test.html [ Skip ] # [ Timeout ]
-webkit.org/b/121509 fast/events/page-visibility-transition-test.html [ Skip ] # [ Timeout ]
-webkit.org/b/121509 fast/events/page-visibility-iframe-move-test.html [ Skip ] # [ Timeout ]
</del><span class="cx"> fast/events/special-key-events-in-input-text.html [ Failure ]
</span><span class="cx"> fast/events/attribute-listener-cloned-from-frameless-doc-context.html [ Pass Failure ]
</span><span class="cx"> [ Release ] fast/events/drag-outside-window.html [ Pass Timeout ]
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/Source/WebKit/win/ChangeLog 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-11-04 Per Arne Vollan <pvollan@apple.com>
+
+ [Win] Page visibility tests are timing out.
+ https://bugs.webkit.org/show_bug.cgi?id=164363
+
+ Reviewed by Brent Fulgham.
+
+ Add method to set page visibility.
+
+ * Interfaces/IWebViewPrivate.idl:
+ * WebView.cpp:
+ (WebView::QueryInterface):
+ (WebView::findString):
+ (WebView::setVisibilityState):
+ * WebView.h:
+
</ins><span class="cx"> 2016-11-01 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove CUSTOM_ELEMENTS build flag
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebViewPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -336,3 +336,15 @@
</span><span class="cx"> HRESULT layerTreeAsString([out] BSTR*);
</span><span class="cx"> HRESULT findString([in] BSTR, [in] WebFindOptions, [out] BOOL* found);
</span><span class="cx"> }
</span><ins>+
+typedef enum {
+ WebPageVisibilityStateVisible,
+ WebPageVisibilityStateHidden,
+ WebPageVisibilityStatePrerender
+} WebPageVisibilityState;
+
+[ uuid(793565B9-5168-4FF4-B841-1BE78DB1B1F8) ]
+interface IWebViewPrivate4 : IWebViewPrivate3
+{
+ HRESULT setVisibilityState([in] WebPageVisibilityState);
+}
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -2887,6 +2887,8 @@
</span><span class="cx"> *ppvObject = static_cast<IWebViewPrivate2*>(this);
</span><span class="cx"> else if (IsEqualGUID(riid, IID_IWebViewPrivate3))
</span><span class="cx"> *ppvObject = static_cast<IWebViewPrivate3*>(this);
</span><ins>+ else if (IsEqualGUID(riid, IID_IWebViewPrivate4))
+ *ppvObject = static_cast<IWebViewPrivate4*>(this);
</ins><span class="cx"> else if (IsEqualGUID(riid, IID_IWebIBActions))
</span><span class="cx"> *ppvObject = static_cast<IWebIBActions*>(this);
</span><span class="cx"> else if (IsEqualGUID(riid, IID_IWebViewCSS))
</span><span class="lines">@@ -7794,3 +7796,16 @@
</span><span class="cx"> *found = m_page->findString(toString(string), options);
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><ins>+
+HRESULT WebView::setVisibilityState(WebPageVisibilityState visibilityState)
+{
+ if (!m_page)
+ return E_FAIL;
+
+ m_page->setIsVisible(visibilityState == WebPageVisibilityStateVisible);
+
+ if (visibilityState == WebPageVisibilityStatePrerender)
+ m_page->setIsPrerender();
+
+ return S_OK;
+}
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.h (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.h 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/Source/WebKit/win/WebView.h 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx">
</span><span class="cx"> class WebView
</span><span class="cx"> : public IWebView
</span><del>- , public IWebViewPrivate3
</del><ins>+ , public IWebViewPrivate4
</ins><span class="cx"> , public IWebIBActions
</span><span class="cx"> , public IWebViewCSS
</span><span class="cx"> , public IWebViewEditing
</span><span class="lines">@@ -399,6 +399,9 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE layerTreeAsString(_Deref_opt_out_ BSTR*);
</span><span class="cx"> HRESULT STDMETHODCALLTYPE findString(_In_ BSTR, WebFindOptions, _Deref_opt_out_ BOOL*);
</span><span class="cx">
</span><ins>+ // IWebViewPrivate4
+ HRESULT STDMETHODCALLTYPE setVisibilityState(WebPageVisibilityState);
+
</ins><span class="cx"> // WebView
</span><span class="cx"> bool shouldUseEmbeddedView(const WTF::String& mimeType) const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/Tools/ChangeLog 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-11-04 Per Arne Vollan <pvollan@apple.com>
+
+ [Win] Page visibility tests are timing out.
+ https://bugs.webkit.org/show_bug.cgi?id=164363
+
+ Reviewed by Brent Fulgham.
+
+ Implement methods to set page visibility.
+
+ * DumpRenderTree/win/TestRunnerWin.cpp:
+ (TestRunner::resetPageVisibility):
+ (TestRunner::setPageVisibility):
+
</ins><span class="cx"> 2016-11-03 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Give all the geometry classes a single-argument scale() function for consistency
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinTestRunnerWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp (208380 => 208381)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp 2016-11-04 06:37:09 UTC (rev 208380)
+++ trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp 2016-11-04 09:35:36 UTC (rev 208381)
</span><span class="lines">@@ -1312,12 +1312,36 @@
</span><span class="cx">
</span><span class="cx"> void TestRunner::resetPageVisibility()
</span><span class="cx"> {
</span><del>- // FIXME: Implement this.
</del><ins>+ COMPtr<IWebView> webView;
+ if (FAILED(frame->webView(&webView)))
+ return;
+
+ COMPtr<IWebViewPrivate4> viewPrivate;
+ if (FAILED(webView->QueryInterface(&viewPrivate)))
+ return;
+
+ viewPrivate->setVisibilityState(WebPageVisibilityStateVisible);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void TestRunner::setPageVisibility(const char*)
</del><ins>+void TestRunner::setPageVisibility(const char* newVisibility)
</ins><span class="cx"> {
</span><del>- // FIXME: Implement this.
</del><ins>+ if (!newVisibility)
+ return;
+
+ COMPtr<IWebView> webView;
+ if (FAILED(frame->webView(&webView)))
+ return;
+
+ COMPtr<IWebViewPrivate4> viewPrivate;
+ if (FAILED(webView->QueryInterface(&viewPrivate)))
+ return;
+
+ if (!strcmp(newVisibility, "visible"))
+ viewPrivate->setVisibilityState(WebPageVisibilityStateVisible);
+ else if (!strcmp(newVisibility, "hidden"))
+ viewPrivate->setVisibilityState(WebPageVisibilityStateHidden);
+ else if (!strcmp(newVisibility, "prerender"))
+ viewPrivate->setVisibilityState(WebPageVisibilityStatePrerender);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TestRunner::grantWebNotificationPermission(JSStringRef origin)
</span></span></pre>
</div>
</div>
</body>
</html>