<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208343] trunk/Source/JavaScriptCore/ChangeLog</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208343">208343</a></dd>
<dt>Author</dt> <dd>keith_miller@apple.com</dd>
<dt>Date</dt> <dd>2016-11-03 13:53:27 -0700 (Thu, 03 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, changelog fix due to failed git rebase..</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (208342 => 208343)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-11-03 20:53:00 UTC (rev 208342)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-11-03 20:53:27 UTC (rev 208343)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2016-11-03 Keith Miller <keith_miller@apple.com>
+
+ Unreviewed, changelog fix due to failed git rebase..
+
+2016-11-03 Keith Miller <keith_miller@apple.com>
+
+ Wasm starts a new stack whenever it adds a new block and has return types for blocks.
+ https://bugs.webkit.org/show_bug.cgi?id=164100
+
+ Reviewed by Saam Barati.
+
+ This patch overhauls much of the Wasm function parser, validator, and B3 IR generator
+ to work with block return types. In Wasm, blocks can act as expressions and have a
+ return value. Most of the control flow operators needed to be rewritten in order to
+ support this feature. To enable return types the function parser needed to be able
+ to save and restore the expression stack from previous blocks, which is done via the
+ control stack.
+
+ This patch also removes the lazy continuation block system added previously. It's
+ not clear if there would be any performance win from such a system. There are likely
+ many other things with orders of magnitude more impact on B3 IR generation. The
+ complexity cost of such a system is not worth the effort without sufficient evidence
+ otherwise.
+
+ * testWasm.cpp:
+ (runWasmTests):
+ * wasm/WasmB3IRGenerator.cpp:
+ * wasm/WasmFunctionParser.h:
+ (JSC::Wasm::FunctionParser<Context>::parseBlock):
+ (JSC::Wasm::FunctionParser<Context>::addReturn):
+ (JSC::Wasm::FunctionParser<Context>::parseExpression):
+ (JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):
+ (JSC::Wasm::FunctionParser<Context>::popExpressionStack):
+ * wasm/WasmValidate.cpp:
+ (JSC::Wasm::Validate::ControlData::hasNonVoidSignature):
+ (JSC::Wasm::Validate::addElse):
+ (JSC::Wasm::Validate::addElseToUnreachable):
+ (JSC::Wasm::Validate::addBranch):
+ (JSC::Wasm::Validate::endBlock):
+ (JSC::Wasm::Validate::addEndToUnreachable):
+ (JSC::Wasm::Validate::dump):
+ (JSC::Wasm::validateFunction):
+ (JSC::Wasm::Validate::isContinuationReachable): Deleted.
+
</ins><span class="cx"> 2016-11-03 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Asking for a value profile prediction should be defensive against not finding a value profile
</span><span class="lines">@@ -2792,46 +2836,6 @@
</span><span class="cx">
</span><span class="cx"> 2016-11-02 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><del>- Wasm starts a new stack whenever it adds a new block and has return types for blocks.
- https://bugs.webkit.org/show_bug.cgi?id=164100
-
- Reviewed by Saam Barati.
-
- This patch overhauls much of the Wasm function parser, validator, and B3 IR generator
- to work with block return types. In Wasm, blocks can act as expressions and have a
- return value. Most of the control flow operators needed to be rewritten in order to
- support this feature. To enable return types the function parser needed to be able
- to save and restore the expression stack from previous blocks, which is done via the
- control stack.
-
- This patch also removes the lazy continuation block system added previously. It's
- not clear if there would be any performance win from such a system. There are likely
- many other things with orders of magnitude more impact on B3 IR generation. The
- complexity cost of such a system is not worth the effort without sufficient evidence
- otherwise.
-
- * testWasm.cpp:
- (runWasmTests):
- * wasm/WasmB3IRGenerator.cpp:
- * wasm/WasmFunctionParser.h:
- (JSC::Wasm::FunctionParser<Context>::parseBlock):
- (JSC::Wasm::FunctionParser<Context>::addReturn):
- (JSC::Wasm::FunctionParser<Context>::parseExpression):
- (JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):
- (JSC::Wasm::FunctionParser<Context>::popExpressionStack):
- * wasm/WasmValidate.cpp:
- (JSC::Wasm::Validate::ControlData::hasNonVoidSignature):
- (JSC::Wasm::Validate::addElse):
- (JSC::Wasm::Validate::addElseToUnreachable):
- (JSC::Wasm::Validate::addBranch):
- (JSC::Wasm::Validate::endBlock):
- (JSC::Wasm::Validate::addEndToUnreachable):
- (JSC::Wasm::Validate::dump):
- (JSC::Wasm::validateFunction):
- (JSC::Wasm::Validate::isContinuationReachable): Deleted.
-
-2016-11-02 Keith Miller <keith_miller@apple.com>
-
</del><span class="cx"> We should not pop from an empty stack in the Wasm function parser.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=164275
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>