<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208289] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208289">208289</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2016-11-02 10:43:32 -0700 (Wed, 02 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove PassRefPtr from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=164307
Reviewed by Sam Weinig.
Source/WebKit/ios:
* Misc/WebGeolocationProviderIOS.mm:
Source/WebKit/mac:
* WebView/WebGeolocationPosition.mm:
(-[WebGeolocationPosition initWithGeolocationPosition:]):
Tools:
* DumpRenderTree/PixelDumpSupport.h:
* DumpRenderTree/TestRunner.cpp:
(TestRunner::create):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(createBitmapContext):
* DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::createByAdoptingBitmapAndContext):
* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):
(createPagedBitmapContext):
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
* DumpRenderTree/win/TextInputController.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitiosChangeLog">trunk/Source/WebKit/ios/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitiosMiscWebGeolocationProviderIOSmm">trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebGeolocationPositionmm">trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreePixelDumpSupporth">trunk/Tools/DumpRenderTree/PixelDumpSupport.h</a></li>
<li><a href="#trunkToolsDumpRenderTreeTestRunnercpp">trunk/Tools/DumpRenderTree/TestRunner.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreeTestRunnerh">trunk/Tools/DumpRenderTree/TestRunner.h</a></li>
<li><a href="#trunkToolsDumpRenderTreecgPixelDumpSupportCGcpp">trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreecgPixelDumpSupportCGh">trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.h</a></li>
<li><a href="#trunkToolsDumpRenderTreeiosPixelDumpSupportIOSmm">trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreemacPixelDumpSupportMacmm">trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreemacTestRunnerMacmm">trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreewinPixelDumpSupportWincpp">trunk/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreewinTextInputControllerh">trunk/Tools/DumpRenderTree/win/TextInputController.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitiosChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/ChangeLog (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/ChangeLog 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/ios/ChangeLog 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-01 Alex Christensen <achristensen@webkit.org>
+
+ Remove PassRefPtr from DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=164307
+
+ Reviewed by Sam Weinig.
+
+ * Misc/WebGeolocationProviderIOS.mm:
+
</ins><span class="cx"> 2016-10-26 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Tried to fix the iOS build after r207934.
</span></span></pre></div>
<a id="trunkSourceWebKitiosMiscWebGeolocationProviderIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="cx"> @interface WebGeolocationPosition (Internal)
</span><del>-- (id)initWithGeolocationPosition:(PassRefPtr<GeolocationPosition>)coreGeolocationPosition;
</del><ins>+- (id)initWithGeolocationPosition:(RefPtr<GeolocationPosition>)coreGeolocationPosition;
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> // CoreLocation runs in the main thread. WebGeolocationProviderIOS lives on the WebThread.
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-11-01 Alex Christensen <achristensen@webkit.org>
+
+ Remove PassRefPtr from DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=164307
+
+ Reviewed by Sam Weinig.
+
+ * WebView/WebGeolocationPosition.mm:
+ (-[WebGeolocationPosition initWithGeolocationPosition:]):
+
</ins><span class="cx"> 2016-11-02 Romain Bellessort <romain.bellessort@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> [Readable Streams API] Enable creation of ReadableByteStreamController
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebGeolocationPositionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.mm 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> return self;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (id)initWithGeolocationPosition:(PassRefPtr<GeolocationPosition>)coreGeolocationPosition
</del><ins>+- (id)initWithGeolocationPosition:(RefPtr<GeolocationPosition>)coreGeolocationPosition
</ins><span class="cx"> {
</span><span class="cx"> self = [super init];
</span><span class="cx"> if (!self)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/ChangeLog 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-11-01 Alex Christensen <achristensen@webkit.org>
+
+ Remove PassRefPtr from DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=164307
+
+ Reviewed by Sam Weinig.
+
+ * DumpRenderTree/PixelDumpSupport.h:
+ * DumpRenderTree/TestRunner.cpp:
+ (TestRunner::create):
+ * DumpRenderTree/TestRunner.h:
+ * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
+ (createBitmapContext):
+ * DumpRenderTree/cg/PixelDumpSupportCG.h:
+ (BitmapContext::createByAdoptingBitmapAndContext):
+ * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
+ (createBitmapContextFromWebView):
+ * DumpRenderTree/mac/PixelDumpSupportMac.mm:
+ (createBitmapContextFromWebView):
+ (createPagedBitmapContext):
+ * DumpRenderTree/mac/TestRunnerMac.mm:
+ * DumpRenderTree/win/PixelDumpSupportWin.cpp:
+ (createBitmapContextFromWebView):
+ * DumpRenderTree/win/TextInputController.h:
+
</ins><span class="cx"> 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreePixelDumpSupporth"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/PixelDumpSupport.h (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/PixelDumpSupport.h 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/PixelDumpSupport.h 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -26,20 +26,16 @@
</span><span class="cx"> * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#ifndef PixelDumpSupport_h
-#define PixelDumpSupport_h
</del><ins>+#pragma once
</ins><span class="cx">
</span><span class="cx"> #include <string>
</span><ins>+#include <wtf/RefPtr.h>
</ins><span class="cx">
</span><del>-#include <wtf/PassRefPtr.h>
-
</del><span class="cx"> class BitmapContext;
</span><span class="cx">
</span><span class="cx"> void computeMD5HashStringForBitmapContext(BitmapContext*, char hashString[33]);
</span><del>-PassRefPtr<BitmapContext> createPagedBitmapContext();
-PassRefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect);
</del><ins>+RefPtr<BitmapContext> createPagedBitmapContext();
+RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect);
</ins><span class="cx"> void dumpBitmap(BitmapContext*, const char* checksum);
</span><span class="cx"> void dumpWebViewAsPixelsAndCompareWithExpected(const std::string& expectedHash);
</span><span class="cx"> void printPNG(const unsigned char* data, const size_t dataLength, const char* checksum);
</span><del>-
-#endif // PixelDumpSupport_h
</del></span></pre></div>
<a id="trunkToolsDumpRenderTreeTestRunnercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/TestRunner.cpp (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/TestRunner.cpp 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/TestRunner.cpp 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -123,9 +123,9 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<TestRunner> TestRunner::create(const std::string& testURL, const std::string& expectedPixelHash)
</del><ins>+Ref<TestRunner> TestRunner::create(const std::string& testURL, const std::string& expectedPixelHash)
</ins><span class="cx"> {
</span><del>- return adoptRef(new TestRunner(testURL, expectedPixelHash));
</del><ins>+ return adoptRef(*new TestRunner(testURL, expectedPixelHash));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Static Functions
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeTestRunnerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/TestRunner.h (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/TestRunner.h 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/TestRunner.h 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -25,10 +25,9 @@
</span><span class="cx"> * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
</span><span class="cx"> * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><del>-
-#ifndef TestRunner_h
-#define TestRunner_h
</del><span class="cx">
</span><ins>+#pragma once
+
</ins><span class="cx"> #include "UIScriptContext.h"
</span><span class="cx"> #include <JavaScriptCore/JSObjectRef.h>
</span><span class="cx"> #include <map>
</span><span class="lines">@@ -35,13 +34,12 @@
</span><span class="cx"> #include <set>
</span><span class="cx"> #include <string>
</span><span class="cx"> #include <vector>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> class TestRunner : public WTR::UIScriptContextDelegate, public RefCounted<TestRunner> {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(TestRunner);
</span><span class="cx"> public:
</span><del>- static PassRefPtr<TestRunner> create(const std::string& testURL, const std::string& expectedPixelHash);
</del><ins>+ static Ref<TestRunner> create(const std::string& testURL, const std::string& expectedPixelHash);
</ins><span class="cx">
</span><span class="cx"> static const unsigned viewWidth;
</span><span class="cx"> static const unsigned viewHeight;
</span><span class="lines">@@ -466,5 +464,3 @@
</span><span class="cx">
</span><span class="cx"> int m_timeout;
</span><span class="cx"> };
</span><del>-
-#endif // TestRunner_h
</del></span></pre></div>
<a id="trunkToolsDumpRenderTreecgPixelDumpSupportCGcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>-PassRefPtr<BitmapContext> createBitmapContext(size_t pixelsWide, size_t pixelsHigh, size_t& rowBytes, void*& buffer)
</del><ins>+RefPtr<BitmapContext> createBitmapContext(size_t pixelsWide, size_t pixelsHigh, size_t& rowBytes, void*& buffer)
</ins><span class="cx"> {
</span><span class="cx"> rowBytes = (4 * pixelsWide + 63) & ~63; // Use a multiple of 64 bytes to improve CG performance
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreecgPixelDumpSupportCGh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.h (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.h 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/cg/PixelDumpSupportCG.h 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -28,10 +28,8 @@
</span><span class="cx"> * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#ifndef PixelDumpSupportCG_h
-#define PixelDumpSupportCG_h
</del><ins>+#pragma once
</ins><span class="cx">
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="lines">@@ -49,9 +47,9 @@
</span><span class="cx">
</span><span class="cx"> class BitmapContext : public RefCounted<BitmapContext> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<BitmapContext> createByAdoptingBitmapAndContext(PlatformBitmapBuffer buffer, CGContextRef context)
</del><ins>+ static Ref<BitmapContext> createByAdoptingBitmapAndContext(PlatformBitmapBuffer buffer, CGContextRef context)
</ins><span class="cx"> {
</span><del>- return adoptRef(new BitmapContext(buffer, context));
</del><ins>+ return adoptRef(*new BitmapContext(buffer, context));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ~BitmapContext()
</span><span class="lines">@@ -80,8 +78,6 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>-PassRefPtr<BitmapContext> createBitmapContext(size_t pixelsWide, size_t pixelsHigh, size_t& rowBytes, void*& buffer);
</del><ins>+RefPtr<BitmapContext> createBitmapContext(size_t pixelsWide, size_t pixelsHigh, size_t& rowBytes, void*& buffer);
</ins><span class="cx"> #endif
</span><del>-PassRefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect);
-
-#endif // PixelDumpSupportCG_h
</del><ins>+RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect);
</ins></span></pre></div>
<a id="trunkToolsDumpRenderTreeiosPixelDumpSupportIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> extern DumpRenderTreeWindow *gDrtWindow;
</span><span class="cx"> extern DumpRenderTreeBrowserView *gWebBrowserView;
</span><span class="cx">
</span><del>-PassRefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
</del><ins>+RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
</ins><span class="cx"> {
</span><span class="cx"> // TODO: <rdar://problem/6558366> DumpRenderTree: Investigate testRepaintSweepHorizontally and dumpSelectionRect
</span><span class="cx"> BEGIN_BLOCK_OBJC_EXCEPTIONS;
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacPixelDumpSupportMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> CGContextRestoreGState(context);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
</del><ins>+RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
</ins><span class="cx"> {
</span><span class="cx"> WebView* view = [mainFrame webView];
</span><span class="cx">
</span><span class="lines">@@ -174,7 +174,7 @@
</span><span class="cx"> return bitmapContext;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<BitmapContext> createPagedBitmapContext()
</del><ins>+RefPtr<BitmapContext> createPagedBitmapContext()
</ins><span class="cx"> {
</span><span class="cx"> int pageWidthInPixels = TestRunner::viewWidth;
</span><span class="cx"> int pageHeightInPixels = TestRunner::viewHeight;
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacTestRunnerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> @interface WebGeolocationPosition (Internal)
</span><del>-- (id)initWithGeolocationPosition:(PassRefPtr<WebCore::GeolocationPosition>)coreGeolocationPosition;
</del><ins>+- (id)initWithGeolocationPosition:(RefPtr<WebCore::GeolocationPosition>)coreGeolocationPosition;
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> TestRunner::~TestRunner()
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinPixelDumpSupportWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
</del><ins>+RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
</ins><span class="cx"> {
</span><span class="cx"> RECT frame;
</span><span class="cx"> if (!GetWindowRect(webViewWindow, &frame))
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinTextInputControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/TextInputController.h (208288 => 208289)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/TextInputController.h 2016-11-02 17:42:41 UTC (rev 208288)
+++ trunk/Tools/DumpRenderTree/win/TextInputController.h 2016-11-02 17:43:32 UTC (rev 208289)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include <JavaScriptCore/JSStringRef.h>
</span><span class="cx"> #include <JavaScriptCore/JSValueRef.h>
</span><span class="cx"> #include <vector>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx">
</span><span class="cx"> using namespace std;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>