<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208301] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208301">208301</a></dd>
<dt>Author</dt> <dd>hyatt@apple.com</dd>
<dt>Date</dt> <dd>2016-11-02 14:30:58 -0700 (Wed, 02 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Parser] Clean up new parser's grid layout ifdefs/runtime checking
https://bugs.webkit.org/show_bug.cgi?id=164341
Reviewed by Dean Jackson.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeGridTrackRepeatFunction):
(WebCore::consumeGridTrackList):
(WebCore::CSSPropertyParser::parseSingleValue):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSPropertyParsercpp">trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208300 => 208301)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-02 21:29:43 UTC (rev 208300)
+++ trunk/Source/WebCore/ChangeLog 2016-11-02 21:30:58 UTC (rev 208301)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-11-02 Dave Hyatt <hyatt@apple.com>
+
+ [CSS Parser] Clean up new parser's grid layout ifdefs/runtime checking
+ https://bugs.webkit.org/show_bug.cgi?id=164341
+
+ Reviewed by Dean Jackson.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeGridTrackRepeatFunction):
+ (WebCore::consumeGridTrackList):
+ (WebCore::CSSPropertyParser::parseSingleValue):
+
</ins><span class="cx"> 2016-11-02 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove Battery Status API from the tree
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSPropertyParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (208300 => 208301)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-11-02 21:29:43 UTC (rev 208300)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-11-02 21:30:58 UTC (rev 208301)
</span><span class="lines">@@ -2698,6 +2698,7 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if ENABLE(CSS_GRID_LAYOUT)
</ins><span class="cx"> static RefPtr<CSSPrimitiveValue> consumeSelfPositionKeyword(CSSParserTokenRange& range)
</span><span class="cx"> {
</span><span class="cx"> CSSValueID id = range.peek().id();
</span><span class="lines">@@ -3023,7 +3024,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> if (allTracksAreFixedSized)
</span><span class="cx"> allTracksAreFixedSized = isGridTrackFixedSized(*trackSize);
</span><del>- repeatedValues->append(*trackSize);
</del><ins>+ repeatedValues->append(trackSize.releaseNonNull());
</ins><span class="cx"> ++numberOfTracks;
</span><span class="cx"> lineNames = consumeGridLineNames(args);
</span><span class="cx"> if (lineNames)
</span><span class="lines">@@ -3040,7 +3041,7 @@
</span><span class="cx"> repetitions = std::min(repetitions, kGridMaxTracks / numberOfTracks);
</span><span class="cx"> for (size_t i = 0; i < repetitions; ++i) {
</span><span class="cx"> for (size_t j = 0; j < repeatedValues->length(); ++j)
</span><del>- list.append(adoptRef(*repeatedValues->item(j)));
</del><ins>+ list.append(adoptRef(*repeatedValues->itemWithoutBoundsCheck(j)));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> return true;
</span><span class="lines">@@ -3085,7 +3086,7 @@
</span><span class="cx"> if (lineNames) {
</span><span class="cx"> if (!allowGridLineNames)
</span><span class="cx"> return nullptr;
</span><del>- values->append(*lineNames);
</del><ins>+ values->append(lineNames.releaseNonNull());
</ins><span class="cx"> }
</span><span class="cx"> } while (!range.atEnd() && range.peek().type() != DelimiterToken);
</span><span class="cx"> return values;
</span><span class="lines">@@ -3118,6 +3119,7 @@
</span><span class="cx"> ASSERT(columnCount);
</span><span class="cx"> return CSSGridTemplateAreasValue::create(gridAreaMap, rowCount, columnCount);
</span><span class="cx"> }
</span><ins>+#endif
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span><span class="cx"> static RefPtr<CSSValue> consumeFlowProperty(CSSParserTokenRange& range)
</span><span class="lines">@@ -3702,28 +3704,46 @@
</span><span class="cx"> case CSSPropertyWebkitMaskRepeatX:
</span><span class="cx"> case CSSPropertyWebkitMaskRepeatY:
</span><span class="cx"> return nullptr;
</span><ins>+#if ENABLE(CSS_GRID_LAYOUT)
</ins><span class="cx"> case CSSPropertyAlignItems:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeAlignItems(m_range);
</span><span class="cx"> case CSSPropertyJustifySelf:
</span><span class="cx"> case CSSPropertyAlignSelf:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeSelfPositionOverflowPosition(m_range);
</span><span class="cx"> case CSSPropertyJustifyItems:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeJustifyItems(m_range);
</span><span class="cx"> case CSSPropertyGridColumnEnd:
</span><span class="cx"> case CSSPropertyGridColumnStart:
</span><span class="cx"> case CSSPropertyGridRowEnd:
</span><span class="cx"> case CSSPropertyGridRowStart:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeGridLine(m_range);
</span><span class="cx"> case CSSPropertyGridAutoColumns:
</span><span class="cx"> case CSSPropertyGridAutoRows:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeGridTrackList(m_range, m_context.mode, GridAuto);
</span><span class="cx"> case CSSPropertyGridTemplateColumns:
</span><span class="cx"> case CSSPropertyGridTemplateRows:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeGridTemplatesRowsOrColumns(m_range, m_context.mode);
</span><span class="cx"> case CSSPropertyGridTemplateAreas:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeGridTemplateAreas(m_range);
</span><span class="cx"> case CSSPropertyGridAutoFlow:
</span><ins>+ if (!m_context.cssGridLayoutEnabled)
+ return nullptr;
</ins><span class="cx"> return consumeGridAutoFlow(m_range);
</span><ins>+#endif
</ins><span class="cx"> #if ENABLE(CSS_REGIONS)
</span><span class="cx"> case CSSPropertyWebkitFlowInto:
</span><span class="cx"> case CSSPropertyWebkitFlowFrom:
</span></span></pre>
</div>
</div>
</body>
</html>