<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208083] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208083">208083</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-28 16:53:28 -0700 (Fri, 28 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>DOMStringMap reports properties as non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=164114
Reviewed by Sam Weinig.
Source/WebCore:
DOMStringMap's named properties should be configurable, enumerable
and writable as per:
- https://heycam.github.io/webidl/#getownproperty-guts (2.7-9)
- https://html.spec.whatwg.org/multipage/dom.html#domstringmap
Firefox and Chrome agree with the specification. However, WebKit
was doing the complete opposite.
No new tests, updated existing test.
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertySlotDelegate):
LayoutTests:
Update existing test to reflect behavior change.
* fast/dom/dataset-name-getter-properties-expected.txt:
* fast/dom/dataset-name-getter-properties.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomdatasetnamegetterpropertiesexpectedtxt">trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomdatasetnamegetterpropertieshtml">trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMStringMapCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (208082 => 208083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/LayoutTests/ChangeLog 2016-10-28 23:53:28 UTC (rev 208083)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-10-28 Chris Dumez <cdumez@apple.com>
+
+ DOMStringMap reports properties as non-enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=164114
+
+ Reviewed by Sam Weinig.
+
+ Update existing test to reflect behavior change.
+
+ * fast/dom/dataset-name-getter-properties-expected.txt:
+ * fast/dom/dataset-name-getter-properties.html:
+
</ins><span class="cx"> 2016-10-28 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add CEReactions to the remaining HTML DOM APIs
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdatasetnamegetterpropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt (208082 => 208083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt 2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt 2016-10-28 23:53:28 UTC (rev 208083)
</span><span class="lines">@@ -3,9 +3,9 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable is false
-PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable is false
-PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable is false
</del><ins>+PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable is true
+PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable is true
+PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').value is "yes"
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomdatasetnamegetterpropertieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html (208082 => 208083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html 2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html 2016-10-28 23:53:28 UTC (rev 208083)
</span><span class="lines">@@ -7,9 +7,9 @@
</span><span class="cx"> <script>
</span><span class="cx"> description('Test the JavaScript property descriptor of the name getter.');
</span><span class="cx">
</span><del>-shouldBe("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable", 'false');
-shouldBe("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable", 'false');
-shouldBe("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable", 'false');
</del><ins>+shouldBeTrue("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable");
+shouldBeTrue("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable");
+shouldBeTrue("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable");
</ins><span class="cx"> shouldBeEqualToString("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').value", 'yes');
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208082 => 208083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/Source/WebCore/ChangeLog 2016-10-28 23:53:28 UTC (rev 208083)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-10-28 Chris Dumez <cdumez@apple.com>
+
+ DOMStringMap reports properties as non-enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=164114
+
+ Reviewed by Sam Weinig.
+
+ DOMStringMap's named properties should be configurable, enumerable
+ and writable as per:
+ - https://heycam.github.io/webidl/#getownproperty-guts (2.7-9)
+ - https://html.spec.whatwg.org/multipage/dom.html#domstringmap
+
+ Firefox and Chrome agree with the specification. However, WebKit
+ was doing the complete opposite.
+
+ No new tests, updated existing test.
+
+ * bindings/js/JSDOMStringMapCustom.cpp:
+ (WebCore::JSDOMStringMap::getOwnPropertySlotDelegate):
+
</ins><span class="cx"> 2016-10-28 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add CEReactions to the remaining HTML DOM APIs
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMStringMapCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp (208082 => 208083)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp 2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp 2016-10-28 23:53:28 UTC (rev 208083)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> bool nameIsValid;
</span><span class="cx"> const AtomicString& item = wrapped().item(propertyNameToString(propertyName), nameIsValid);
</span><span class="cx"> if (nameIsValid) {
</span><del>- slot.setValue(this, ReadOnly | DontDelete | DontEnum, toJS<IDLDOMString>(*exec, item));
</del><ins>+ slot.setValue(this, 0, toJS<IDLDOMString>(*exec, item));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span></span></pre>
</div>
</div>
</body>
</html>