<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208026] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208026">208026</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-10-27 20:21:58 -0700 (Thu, 27 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename StyleRareNonInheritedData::opacity to m_opacity
https://bugs.webkit.org/show_bug.cgi?id=164104
Reviewed by Dave Hyatt.
Pure rename.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayerRepaint):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::opacity):
(WebCore::RenderStyle::setOpacity):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(WebCore::StyleRareNonInheritedData::hasOpacity):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStyleh">trunk/Source/WebCore/rendering/style/RenderStyle.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleRareNonInheritedDatacpp">trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleRareNonInheritedDatah">trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208025 => 208026)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-28 03:20:32 UTC (rev 208025)
+++ trunk/Source/WebCore/ChangeLog 2016-10-28 03:21:58 UTC (rev 208026)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-10-27 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Rename StyleRareNonInheritedData::opacity to m_opacity
+ https://bugs.webkit.org/show_bug.cgi?id=164104
+
+ Reviewed by Dave Hyatt.
+
+ Pure rename.
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::changeRequiresLayerRepaint):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::opacity):
+ (WebCore::RenderStyle::setOpacity):
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
+ (WebCore::StyleRareNonInheritedData::operator==):
+ * rendering/style/StyleRareNonInheritedData.h:
+ (WebCore::StyleRareNonInheritedData::hasOpacity):
+
+2016-10-27 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> If an animation's keyframes affect stacking context properties, create stacking context while the animation is running
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=164094
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (208025 => 208026)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-10-28 03:20:32 UTC (rev 208025)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-10-28 03:21:58 UTC (rev 208026)
</span><span class="lines">@@ -795,7 +795,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- if (rareNonInheritedData->opacity != other.rareNonInheritedData->opacity) {
</del><ins>+ if (rareNonInheritedData->m_opacity != other.rareNonInheritedData->m_opacity) {
</ins><span class="cx"> changedContextSensitiveProperties |= ContextSensitivePropertyOpacity;
</span><span class="cx"> // Don't return; keep looking for another change.
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStyleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (208025 => 208026)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2016-10-28 03:20:32 UTC (rev 208025)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2016-10-28 03:21:58 UTC (rev 208026)
</span><span class="lines">@@ -907,7 +907,7 @@
</span><span class="cx"> void getTextShadowBlockDirectionExtent(LayoutUnit& logicalTop, LayoutUnit& logicalBottom) const { getShadowBlockDirectionExtent(textShadow(), logicalTop, logicalBottom); }
</span><span class="cx">
</span><span class="cx"> float textStrokeWidth() const { return rareInheritedData->textStrokeWidth; }
</span><del>- float opacity() const { return rareNonInheritedData->opacity; }
</del><ins>+ float opacity() const { return rareNonInheritedData->m_opacity; }
</ins><span class="cx"> ControlPart appearance() const { return static_cast<ControlPart>(rareNonInheritedData->m_appearance); }
</span><span class="cx"> AspectRatioType aspectRatioType() const { return static_cast<AspectRatioType>(rareNonInheritedData->m_aspectRatioType); }
</span><span class="cx"> float aspectRatio() const { return aspectRatioNumerator() / aspectRatioDenominator(); }
</span><span class="lines">@@ -1514,7 +1514,7 @@
</span><span class="cx"> void setTextStrokeColor(const Color& c) { SET_VAR(rareInheritedData, textStrokeColor, c); }
</span><span class="cx"> void setTextStrokeWidth(float w) { SET_VAR(rareInheritedData, textStrokeWidth, w); }
</span><span class="cx"> void setTextFillColor(const Color& c) { SET_VAR(rareInheritedData, textFillColor, c); }
</span><del>- void setOpacity(float f) { float v = clampTo<float>(f, 0, 1); SET_VAR(rareNonInheritedData, opacity, v); }
</del><ins>+ void setOpacity(float f) { float v = clampTo<float>(f, 0, 1); SET_VAR(rareNonInheritedData, m_opacity, v); }
</ins><span class="cx"> void setAppearance(ControlPart a) { SET_VAR(rareNonInheritedData, m_appearance, a); }
</span><span class="cx"> // For valid values of box-align see http://www.w3.org/TR/2009/WD-css3-flexbox-20090723/#alignment
</span><span class="cx"> void setBoxAlign(EBoxAlignment a) { SET_NESTED_VAR(rareNonInheritedData, m_deprecatedFlexibleBox, align, a); }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleRareNonInheritedDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp (208025 => 208026)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp 2016-10-28 03:20:32 UTC (rev 208025)
+++ trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp 2016-10-28 03:21:58 UTC (rev 208026)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> StyleRareNonInheritedData::StyleRareNonInheritedData()
</span><del>- : opacity(RenderStyle::initialOpacity())
</del><ins>+ : m_opacity(RenderStyle::initialOpacity())
</ins><span class="cx"> , m_aspectRatioDenominator(RenderStyle::initialAspectRatioDenominator())
</span><span class="cx"> , m_aspectRatioNumerator(RenderStyle::initialAspectRatioNumerator())
</span><span class="cx"> , m_perspective(RenderStyle::initialPerspective())
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx">
</span><span class="cx"> inline StyleRareNonInheritedData::StyleRareNonInheritedData(const StyleRareNonInheritedData& o)
</span><span class="cx"> : RefCounted<StyleRareNonInheritedData>()
</span><del>- , opacity(o.opacity)
</del><ins>+ , m_opacity(o.m_opacity)
</ins><span class="cx"> , m_aspectRatioDenominator(o.m_aspectRatioDenominator)
</span><span class="cx"> , m_aspectRatioNumerator(o.m_aspectRatioNumerator)
</span><span class="cx"> , m_perspective(o.m_perspective)
</span><span class="lines">@@ -225,7 +225,7 @@
</span><span class="cx">
</span><span class="cx"> bool StyleRareNonInheritedData::operator==(const StyleRareNonInheritedData& o) const
</span><span class="cx"> {
</span><del>- return opacity == o.opacity
</del><ins>+ return m_opacity == o.m_opacity
</ins><span class="cx"> && m_aspectRatioDenominator == o.m_aspectRatioDenominator
</span><span class="cx"> && m_aspectRatioNumerator == o.m_aspectRatioNumerator
</span><span class="cx"> && m_perspective == o.m_perspective
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleRareNonInheritedDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h (208025 => 208026)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h 2016-10-28 03:20:32 UTC (rev 208025)
+++ trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h 2016-10-28 03:21:58 UTC (rev 208026)
</span><span class="lines">@@ -96,11 +96,11 @@
</span><span class="cx"> #if ENABLE(FILTERS_LEVEL_2)
</span><span class="cx"> bool hasBackdropFilters() const;
</span><span class="cx"> #endif
</span><del>- bool hasOpacity() const { return opacity < 1; }
</del><ins>+ bool hasOpacity() const { return m_opacity < 1; }
</ins><span class="cx">
</span><span class="cx"> bool hasAnimationsOrTransitions() const { return m_animations || m_transitions; }
</span><span class="cx">
</span><del>- float opacity;
</del><ins>+ float m_opacity;
</ins><span class="cx">
</span><span class="cx"> float m_aspectRatioDenominator;
</span><span class="cx"> float m_aspectRatioNumerator;
</span></span></pre>
</div>
</div>
</body>
</html>