<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208039] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208039">208039</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-27 23:27:29 -0700 (Thu, 27 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Fetch API] Fetch ReadableStream should only clone the second branch
https://bugs.webkit.org/show_bug.cgi?id=164058
Patch by Youenn Fablet <youenn@apple.com> on 2016-10-27
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/response/response-clone-expected.txt:
Source/WebCore:
Covered by rebased tests.
* Modules/streams/ReadableStreamInternals.js:
(readableStreamTeePullFunction):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapiresponseresponsecloneexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamInternalsjs">trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208038 => 208039)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-28 06:27:29 UTC (rev 208039)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-10-27 Youenn Fablet <youenn@apple.com>
+
+ [Fetch API] Fetch ReadableStream should only clone the second branch
+ https://bugs.webkit.org/show_bug.cgi?id=164058
+
+ Reviewed by Darin Adler.
+
+ * web-platform-tests/fetch/api/response/response-clone-expected.txt:
+
</ins><span class="cx"> 2016-10-27 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Include ConsoleAgent in Workers - real console.log support
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapiresponseresponsecloneexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt (208038 => 208039)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt 2016-10-28 06:27:29 UTC (rev 208039)
</span><span class="lines">@@ -6,15 +6,15 @@
</span><span class="cx"> PASS Cannot clone a disturbed response
</span><span class="cx"> PASS Cloned responses should provide the same data
</span><span class="cx"> PASS Cancelling stream should not affect cloned one
</span><del>-FAIL Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (DataViewchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
</del><ins>+PASS Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (DataViewchunk)
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208038 => 208039)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/Source/WebCore/ChangeLog 2016-10-28 06:27:29 UTC (rev 208039)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-10-27 Youenn Fablet <youenn@apple.com>
+
+ [Fetch API] Fetch ReadableStream should only clone the second branch
+ https://bugs.webkit.org/show_bug.cgi?id=164058
+
+ Reviewed by Darin Adler.
+
+ Covered by rebased tests.
+
+ * Modules/streams/ReadableStreamInternals.js:
+ (readableStreamTeePullFunction):
+
</ins><span class="cx"> 2016-10-27 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Update ANGLE
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamInternalsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js (208038 => 208039)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js 2016-10-28 06:27:29 UTC (rev 208039)
</span><span class="lines">@@ -183,7 +183,7 @@
</span><span class="cx"> if (teeState.closedOrErrored)
</span><span class="cx"> return;
</span><span class="cx"> if (!teeState.canceled1)
</span><del>- @readableStreamDefaultControllerEnqueue(teeState.branch1.@readableStreamController, shouldClone ? @doStructuredClone(result.value) : result.value);
</del><ins>+ @readableStreamDefaultControllerEnqueue(teeState.branch1.@readableStreamController, result.value);
</ins><span class="cx"> if (!teeState.canceled2)
</span><span class="cx"> @readableStreamDefaultControllerEnqueue(teeState.branch2.@readableStreamController, shouldClone ? @doStructuredClone(result.value) : result.value);
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>