<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207928] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207928">207928</a></dd>
<dt>Author</dt> <dd>bburg@apple.com</dd>
<dt>Date</dt> <dd>2016-10-26 17:17:52 -0700 (Wed, 26 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
https://bugs.webkit.org/show_bug.cgi?id=164046
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
* inspector/InspectorFrontendChannel.h:
* inspector/remote/RemoteConnectionToTarget.h:
* inspector/remote/RemoteConnectionToTarget.mm:
(Inspector::RemoteConnectionToTarget::sendMessageToFrontend):
Source/WebCore:
* inspector/InspectorClient.cpp:
(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
* inspector/InspectorClient.h:
* testing/Internals.cpp:
(WebCore::InspectorStubFrontend::sendMessageToFrontend):
Source/WebKit/cf:
* WebCoreSupport/WebInspectorClientCF.cpp:
(WebInspectorClient::sendMessageToFrontend):
Source/WebKit/mac:
* WebCoreSupport/WebInspectorClient.h:
Source/WebKit/win:
* WebCoreSupport/WebInspectorClient.h:
Source/WebKit2:
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::sendMessageToFrontend):
* WebProcess/WebPage/WebInspector.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInspectorFrontendChannelh">trunk/Source/JavaScriptCore/inspector/InspectorFrontendChannel.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorremoteRemoteConnectionToTargeth">trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorremoteRemoteConnectionToTargetmm">trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorClientcpp">trunk/Source/WebCore/inspector/InspectorClient.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorClienth">trunk/Source/WebCore/inspector/InspectorClient.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebKitcfChangeLog">trunk/Source/WebKit/cf/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitcfWebCoreSupportWebInspectorClientCFcpp">trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebInspectorClienth">trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinWebCoreSupportWebInspectorClienth">trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorcpp">trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorh">trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-10-26 Brian Burg <bburg@apple.com>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InspectorFrontendChannel.h:
+ * inspector/remote/RemoteConnectionToTarget.h:
+ * inspector/remote/RemoteConnectionToTarget.mm:
+ (Inspector::RemoteConnectionToTarget::sendMessageToFrontend):
+
</ins><span class="cx"> 2016-10-26 JF Bastien <jfbastien@apple.com>
</span><span class="cx">
</span><span class="cx"> WebAssembly: remove now-dead JSWasmModule
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInspectorFrontendChannelh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InspectorFrontendChannel.h (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InspectorFrontendChannel.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/JavaScriptCore/inspector/InspectorFrontendChannel.h 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> virtual ~FrontendChannel() { }
</span><span class="cx"> virtual ConnectionType connectionType() const = 0;
</span><del>- virtual bool sendMessageToFrontend(const String& message) = 0;
</del><ins>+ virtual void sendMessageToFrontend(const String& message) = 0;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace Inspector
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorremoteRemoteConnectionToTargeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.h (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.h 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx">
</span><span class="cx"> // FrontendChannel overrides.
</span><span class="cx"> ConnectionType connectionType() const override { return ConnectionType::Remote; }
</span><del>- bool sendMessageToFrontend(const String&) override;
</del><ins>+ void sendMessageToFrontend(const String&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void dispatchAsyncOnTarget(void (^block)());
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorremoteRemoteConnectionToTargetmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -228,13 +228,12 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool RemoteConnectionToTarget::sendMessageToFrontend(const String& message)
</del><ins>+void RemoteConnectionToTarget::sendMessageToFrontend(const String& message)
</ins><span class="cx"> {
</span><del>- if (!m_target)
- return false;
</del><ins>+ if (!targetIdentifier())
+ return;
</ins><span class="cx">
</span><span class="cx"> RemoteInspector::singleton().sendMessageToRemote(targetIdentifier().value(), message);
</span><del>- return true;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RemoteConnectionToTarget::setupRunLoop()
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-10-26 Brian Burg <bburg@apple.com>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InspectorClient.cpp:
+ (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
+ * inspector/InspectorClient.h:
+ * testing/Internals.cpp:
+ (WebCore::InspectorStubFrontend::sendMessageToFrontend):
+
</ins><span class="cx"> 2016-10-26 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> The URLSearchParams constructor should take a union in parameter
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorClient.cpp (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorClient.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/inspector/InspectorClient.cpp 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -41,16 +41,13 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-bool InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message)
</del><ins>+void InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message)
</ins><span class="cx"> {
</span><span class="cx"> if (!frontendPage)
</span><del>- return false;
</del><ins>+ return;
</ins><span class="cx">
</span><del>- String dispatchToFrontend = "InspectorFrontendAPI.dispatchMessageAsync(" + message + ");";
-
- // FIXME: This should execute the script in the appropriate world.
</del><ins>+ String dispatchToFrontend = makeString("InspectorFrontendAPI.dispatchMessageAsync(", message, ");");
</ins><span class="cx"> frontendPage->mainFrame().script().evaluate(ScriptSourceCode(dispatchToFrontend));
</span><del>- return true;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorClient.h (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorClient.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx">
</span><span class="cx"> virtual bool handleJavaScriptDialog(bool, const String*) { return false; }
</span><span class="cx">
</span><del>- WEBCORE_EXPORT static bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
</del><ins>+ WEBCORE_EXPORT static void doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/testing/Internals.cpp 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -250,7 +250,7 @@
</span><span class="cx"> void setAttachedWindowHeight(unsigned) final { }
</span><span class="cx"> void setAttachedWindowWidth(unsigned) final { }
</span><span class="cx">
</span><del>- bool sendMessageToFrontend(const String& message) final;
</del><ins>+ void sendMessageToFrontend(const String& message) final;
</ins><span class="cx"> ConnectionType connectionType() const final { return ConnectionType::Local; }
</span><span class="cx">
</span><span class="cx"> Page* frontendPage() const
</span><span class="lines">@@ -293,11 +293,11 @@
</span><span class="cx"> m_frontendWindow = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool InspectorStubFrontend::sendMessageToFrontend(const String& message)
</del><ins>+void InspectorStubFrontend::sendMessageToFrontend(const String& message)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT_ARG(message, !message.isEmpty());
</span><span class="cx">
</span><del>- return InspectorClient::doDispatchMessageOnFrontendPage(frontendPage(), message);
</del><ins>+ InspectorClient::doDispatchMessageOnFrontendPage(frontendPage(), message);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool markerTypeFrom(const String& markerType, DocumentMarker::MarkerType& result)
</span></span></pre></div>
<a id="trunkSourceWebKitcfChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/cf/ChangeLog (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/cf/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/cf/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-10-26 Brian Burg <bburg@apple.com>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebInspectorClientCF.cpp:
+ (WebInspectorClient::sendMessageToFrontend):
+
</ins><span class="cx"> 2016-10-11 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove dead networking code
</span></span></pre></div>
<a id="trunkSourceWebKitcfWebCoreSupportWebInspectorClientCFcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -89,9 +89,9 @@
</span><span class="cx"> CFPreferencesSetAppValue(createKeyForPreferences(key).get(), setting.createCFString().get(), kCFPreferencesCurrentApplication);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebInspectorClient::sendMessageToFrontend(const String& message)
</del><ins>+void WebInspectorClient::sendMessageToFrontend(const String& message)
</ins><span class="cx"> {
</span><del>- return doDispatchMessageOnFrontendPage(m_frontendPage, message);
</del><ins>+ doDispatchMessageOnFrontendPage(m_frontendPage, message);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool WebInspectorClient::inspectorAttachDisabled()
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-10-26 Brian Burg <bburg@apple.com>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebInspectorClient.h:
+
</ins><span class="cx"> 2016-10-21 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> URL::port should return Optional<uint16_t>
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx">
</span><span class="cx"> void didSetSearchingForNode(bool) override;
</span><span class="cx">
</span><del>- bool sendMessageToFrontend(const String&) override;
</del><ins>+ void sendMessageToFrontend(const String&) override;
</ins><span class="cx"> ConnectionType connectionType() const override { return ConnectionType::Local; }
</span><span class="cx">
</span><span class="cx"> bool inspectorStartsAttached();
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/win/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-10-26 Brian Burg <bburg@apple.com>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebInspectorClient.h:
+
</ins><span class="cx"> 2016-10-19 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Revert r207151
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebCoreSupportWebInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx">
</span><span class="cx"> // FrontendChannel API.
</span><span class="cx"> ConnectionType connectionType() const override { return ConnectionType::Local; }
</span><del>- bool sendMessageToFrontend(const WTF::String&) override;
</del><ins>+ void sendMessageToFrontend(const WTF::String&) override;
</ins><span class="cx">
</span><span class="cx"> bool inspectorStartsAttached();
</span><span class="cx"> void setInspectorStartsAttached(bool);
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit2/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-10-26 Brian Burg <bburg@apple.com>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebProcess/WebPage/WebInspector.cpp:
+ (WebKit::WebInspector::sendMessageToFrontend):
+ * WebProcess/WebPage/WebInspector.h:
+
</ins><span class="cx"> 2016-10-26 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Add "has capture device" bit to media state flags
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -279,7 +279,7 @@
</span><span class="cx"> m_page->corePage()->inspectorController().dispatchMessageFromFrontend(message);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WebInspector::sendMessageToFrontend(const String& message)
</del><ins>+void WebInspector::sendMessageToFrontend(const String& message)
</ins><span class="cx"> {
</span><span class="cx"> #if ENABLE(INSPECTOR_SERVER)
</span><span class="cx"> if (m_remoteFrontendConnected)
</span><span class="lines">@@ -287,7 +287,6 @@
</span><span class="cx"> else
</span><span class="cx"> #endif
</span><span class="cx"> m_frontendConnection->send(Messages::WebInspectorUI::SendMessageToFrontend(message), 0);
</span><del>- return true;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INSPECTOR_SERVER)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h (207927 => 207928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2016-10-27 00:17:52 UTC (rev 207928)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx">
</span><span class="cx"> void updateDockingAvailability();
</span><span class="cx">
</span><del>- bool sendMessageToFrontend(const String& message) override;
</del><ins>+ void sendMessageToFrontend(const String& message) override;
</ins><span class="cx"> ConnectionType connectionType() const override { return ConnectionType::Local; }
</span><span class="cx">
</span><span class="cx"> // Implemented in generated WebInspectorMessageReceiver.cpp
</span></span></pre>
</div>
</div>
</body>
</html>