<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207895] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207895">207895</a></dd>
<dt>Author</dt> <dd>nael.ouedraogo@crf.canon.fr</dd>
<dt>Date</dt> <dd>2016-10-26 05:54:46 -0700 (Wed, 26 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebRTC: The RTCTrackEventInit dictionary needs required members
https://bugs.webkit.org/show_bug.cgi?id=158536
Source/WebCore:
Reviewed by Chris Dumez.
Update RTCTrackEvent IDL as per specification.
No additional test required, rebase existing tests.
* Modules/mediastream/RTCTrackEvent.idl:
LayoutTests:
Update RTCTrackEvent IDL as per specification. Rebase existing tests.
Reviewed by Chris Dumez.
* fast/mediastream/RTCTrackEvent-constructor-expected.txt:
* fast/mediastream/RTCTrackEvent-constructor.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCTrackEventconstructorexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCTrackEventconstructorhtml">trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCTrackEventidl">trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207894 => 207895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-26 10:09:01 UTC (rev 207894)
+++ trunk/LayoutTests/ChangeLog 2016-10-26 12:54:46 UTC (rev 207895)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-10-26 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
+ WebRTC: The RTCTrackEventInit dictionary needs required members
+ https://bugs.webkit.org/show_bug.cgi?id=158536
+
+ Update RTCTrackEvent IDL as per specification. Rebase existing tests.
+
+ Reviewed by Chris Dumez.
+
+ * fast/mediastream/RTCTrackEvent-constructor-expected.txt:
+ * fast/mediastream/RTCTrackEvent-constructor.html:
+
</ins><span class="cx"> 2016-10-25 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Updating attribute by textContent must create a single mutation record and custom element reaction
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCTrackEventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor-expected.txt (207894 => 207895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor-expected.txt 2016-10-26 10:09:01 UTC (rev 207894)
+++ trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor-expected.txt 2016-10-26 12:54:46 UTC (rev 207895)
</span><span class="lines">@@ -20,14 +20,14 @@
</span><span class="cx"> PASS new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [1], transceiver: transceiver}) threw exception TypeError: Type error.
</span><span class="cx">
</span><span class="cx"> Dictionary members receiver, track and transceiver are not nullable
</span><del>-FAIL new RTCTrackEvent('eventType', { receiver: null, track: track, transceiver: transceiver}) should throw an exception. Was [object RTCTrackEvent].
-FAIL new RTCTrackEvent('eventType', { receiver: receiver, track: null, transceiver: transceiver}) should throw an exception. Was [object RTCTrackEvent].
-FAIL new RTCTrackEvent('eventType', { receiver: receiver, track: track, transceiver: null}) should throw an exception. Was [object RTCTrackEvent].
</del><ins>+PASS new RTCTrackEvent('eventType', { receiver: null, track: track, transceiver: transceiver}) threw exception TypeError: Type error.
+PASS new RTCTrackEvent('eventType', { receiver: receiver, track: null, transceiver: transceiver}) threw exception TypeError: Type error.
+PASS new RTCTrackEvent('eventType', { receiver: receiver, track: track, transceiver: null}) threw exception TypeError: Type error.
</ins><span class="cx">
</span><span class="cx"> Dictionary members receiver, track and transceiver are required
</span><del>-FAIL new RTCTrackEvent('eventType', { track: track, transceiver: transceiver}) should throw an exception. Was [object RTCTrackEvent].
-FAIL new RTCTrackEvent('eventType', { receiver: receiver, transceiver: transceiver}) should throw an exception. Was [object RTCTrackEvent].
-FAIL new RTCTrackEvent('eventType', { receiver: receiver, track: track}) should throw an exception. Was [object RTCTrackEvent].
</del><ins>+PASS new RTCTrackEvent('eventType', { track: track, transceiver: transceiver}) threw exception TypeError: Member RTCTrackEventInit.receiver is required and must be an instance of RTCRtpReceiver.
+PASS new RTCTrackEvent('eventType', { receiver: receiver, transceiver: transceiver}) threw exception TypeError: Member RTCTrackEventInit.track is required and must be an instance of MediaStreamTrack.
+PASS new RTCTrackEvent('eventType', { receiver: receiver, track: track}) threw exception TypeError: Member RTCTrackEventInit.transceiver is required and must be an instance of RTCRtpTransceiver.
</ins><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCTrackEventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor.html (207894 => 207895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor.html 2016-10-26 10:09:01 UTC (rev 207894)
+++ trunk/LayoutTests/fast/mediastream/RTCTrackEvent-constructor.html 2016-10-26 12:54:46 UTC (rev 207895)
</span><span class="lines">@@ -45,23 +45,22 @@
</span><span class="cx"> shouldBe("new RTCTrackEvent('eventType', { receiver: receiver, track: track, streams: [stream], transceiver: transceiver}).streams", "[stream]");
</span><span class="cx"> debug("");
</span><span class="cx">
</span><del>- shouldThrow("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [stream, null], transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [null], transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [{}], transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [1], transceiver: transceiver})");
</del><ins>+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [stream, null], transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [null], transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [{}], transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: track, track: track, streams: [1], transceiver: transceiver})", "TypeError");
</ins><span class="cx"> debug("");
</span><span class="cx">
</span><del>- // The tests below are expected to fail (bug: webkit.org/b/158536)
</del><span class="cx"> debug("Dictionary members receiver, track and transceiver are not nullable");
</span><del>- shouldThrow("new RTCTrackEvent('eventType', { receiver: null, track: track, transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, track: null, transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, track: track, transceiver: null})");
</del><ins>+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: null, track: track, transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: receiver, track: null, transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: receiver, track: track, transceiver: null})", "TypeError");
</ins><span class="cx"> debug("");
</span><span class="cx">
</span><span class="cx"> debug("Dictionary members receiver, track and transceiver are required");
</span><del>- shouldThrow("new RTCTrackEvent('eventType', { track: track, transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, transceiver: transceiver})");
- shouldThrow("new RTCTrackEvent('eventType', { receiver: receiver, track: track})");
</del><ins>+ shouldThrowErrorName("new RTCTrackEvent('eventType', { track: track, transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: receiver, transceiver: transceiver})", "TypeError");
+ shouldThrowErrorName("new RTCTrackEvent('eventType', { receiver: receiver, track: track})", "TypeError");
</ins><span class="cx"> debug("");
</span><span class="cx">
</span><span class="cx"> finishJSTest();
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207894 => 207895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-26 10:09:01 UTC (rev 207894)
+++ trunk/Source/WebCore/ChangeLog 2016-10-26 12:54:46 UTC (rev 207895)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-10-26 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
+
+ WebRTC: The RTCTrackEventInit dictionary needs required members
+ https://bugs.webkit.org/show_bug.cgi?id=158536
+
+ Reviewed by Chris Dumez.
+
+ Update RTCTrackEvent IDL as per specification.
+
+ No additional test required, rebase existing tests.
+
+ * Modules/mediastream/RTCTrackEvent.idl:
+
</ins><span class="cx"> 2016-10-26 Enrique Ocaña González <eocanha@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GStreamer][GTK+][MSE] Unreviewed debug build fix.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCTrackEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl (207894 => 207895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl 2016-10-26 10:09:01 UTC (rev 207894)
+++ trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl 2016-10-26 12:54:46 UTC (rev 207895)
</span><span class="lines">@@ -30,19 +30,17 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=WEB_RTC,
</span><del>- Constructor(DOMString type, optional RTCTrackEventInit eventInitDict),
</del><ins>+ Constructor(DOMString type, RTCTrackEventInit eventInitDict),
</ins><span class="cx"> ] interface RTCTrackEvent : Event {
</span><del>- readonly attribute RTCRtpReceiver? receiver;
- readonly attribute MediaStreamTrack? track;
- readonly attribute sequence<MediaStream> streams;
- readonly attribute RTCRtpTransceiver? transceiver;
</del><ins>+ readonly attribute RTCRtpReceiver receiver;
+ readonly attribute MediaStreamTrack track;
+ readonly attribute FrozenArray<MediaStream> streams;
+ readonly attribute RTCRtpTransceiver transceiver;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> dictionary RTCTrackEventInit : EventInit {
</span><ins>+ required RTCRtpReceiver receiver;
+ required MediaStreamTrack track;
</ins><span class="cx"> sequence<MediaStream> streams = [];
</span><del>-
- // FIXME: The specification says that these members should be required and non-nullable.
- RTCRtpReceiver? receiver = null;
- MediaStreamTrack? track = null;
- RTCRtpTransceiver? transceiver = null;
</del><ins>+ required RTCRtpTransceiver transceiver;
</ins><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>