<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207864] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207864">207864</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-25 21:45:04 -0700 (Tue, 25 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Updating attribute by textContent must create a single mutation record and custom element reaction
https://bugs.webkit.org/show_bug.cgi?id=164003
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Rebaselined the test now that all test cases are passing.
* web-platform-tests/custom-elements/reactions/Node-expected.txt:
Source/WebCore:
The bug was caused by setTextContent not invoking setNodeValue for Attr nodes.
Use setNodeValue to match the specification: https://dom.spec.whatwg.org/#dom-node-textcontent
Test: fast/dom/MutationObserver/text-content-on-attr.html
* dom/Node.cpp:
(WebCore::Node::setTextContent):
LayoutTests:
Added a test for ensuring mutating the attribute by nodeValue and textContent creates exactly one mutation record.
* fast/custom-elements/reactions-for-webkit-extensions.html: Updated the description.
* fast/dom/MutationObserver/text-content-on-attr-expected.txt: Added.
* fast/dom/MutationObserver/text-content-on-attr.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcustomelementsreactionsforwebkitextensionshtml">trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsNodeexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Node-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomMutationObservertextcontentonattrexpectedtxt">trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomMutationObservertextcontentonattrhtml">trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207863 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-26 01:57:44 UTC (rev 207863)
+++ trunk/LayoutTests/ChangeLog 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-10-25 Ryosuke Niwa <rniwa@webkit.org>
+
+ Updating attribute by textContent must create a single mutation record and custom element reaction
+ https://bugs.webkit.org/show_bug.cgi?id=164003
+
+ Reviewed by Chris Dumez.
+
+ Added a test for ensuring mutating the attribute by nodeValue and textContent creates exactly one mutation record.
+
+ * fast/custom-elements/reactions-for-webkit-extensions.html: Updated the description.
+ * fast/dom/MutationObserver/text-content-on-attr-expected.txt: Added.
+ * fast/dom/MutationObserver/text-content-on-attr.html: Added.
+
</ins><span class="cx"> 2016-10-25 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, fix duplicate GTK expectations
</span></span></pre></div>
<a id="trunkLayoutTestsfastcustomelementsreactionsforwebkitextensionshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html (207863 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html 2016-10-26 01:57:44 UTC (rev 207863)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -1,9 +1,9 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><del>-<title>Custom Elements: CEReactions on Attr interface</title>
</del><ins>+<title>Custom Elements: CEReactions on HTMLElement interface</title>
</ins><span class="cx"> <meta name="author" title="Ryosuke Niwa" href="mailto:rniwa@webkit.org">
</span><del>-<meta name="assert" content="value of Attr interface must have CEReactions">
</del><ins>+<meta name="assert" content="webkitdropzone of HTMLElement interface must have CEReactions">
</ins><span class="cx"> <meta name="help" content="https://dom.spec.whatwg.org/#node">
</span><span class="cx"> <script src="../../resources/testharness.js"></script>
</span><span class="cx"> <script src="../../resources/testharnessreport.js"></script>
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomMutationObservertextcontentonattrexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr-expected.txt (0 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr-expected.txt 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+This tests mutating the attribute value by the setters of textContent and nodeValue. WebKit should insert exactly one record
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+element.attributes.title.textContent = "new"; records = observer.takeRecords()
+PASS records[0].attributeName is "title"
+PASS records.length is 1
+
+element.attributes.title.nodeValue = "world"; records = observer.takeRecords()
+PASS records[0].attributeName is "title"
+PASS records.length is 1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomMutationObservertextcontentonattrhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr.html (0 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr.html (rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/text-content-on-attr.html 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test.js"></script>
+<script>
+
+description('This tests mutating the attribute value by the setters of textContent and nodeValue. WebKit should insert exactly one record');
+
+let element = document.createElement('div');
+element.setAttribute('title', 'hello');
+
+let observer = new MutationObserver(function (records) { });
+observer.observe(element, {attributes: true});
+
+var records;
+evalAndLog('element.attributes.title.textContent = "new"; records = observer.takeRecords()');
+shouldBe('records[0].attributeName', '"title"');
+shouldBe('records.length', '1');
+
+debug('');
+
+evalAndLog('element.attributes.title.nodeValue = "world"; records = observer.takeRecords()');
+shouldBe('records[0].attributeName', '"title"');
+shouldBe('records.length', '1');
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (207863 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-26 01:57:44 UTC (rev 207863)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-10-25 Ryosuke Niwa <rniwa@webkit.org>
+
+ Updating attribute by textContent must create a single mutation record and custom element reaction
+ https://bugs.webkit.org/show_bug.cgi?id=164003
+
+ Reviewed by Chris Dumez.
+
+ Rebaselined the test now that all test cases are passing.
+
+ * web-platform-tests/custom-elements/reactions/Node-expected.txt:
+
</ins><span class="cx"> 2016-10-25 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IndexedDB 2.0: Support IDBObjectStore openKeyCursor.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsNodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Node-expected.txt (207863 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Node-expected.txt 2016-10-26 01:57:44 UTC (rev 207863)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Node-expected.txt 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx">
</span><span class="cx"> PASS nodeValue on Node must enqueue an attributeChanged reaction when replacing an existing attribute
</span><span class="cx"> PASS nodeValue on Node must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute
</span><del>-FAIL textContent on Node must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 1 got 2
</del><ins>+PASS textContent on Node must enqueue an attributeChanged reaction when replacing an existing attribute
</ins><span class="cx"> PASS textContent on Node must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute
</span><span class="cx"> PASS cloneNode on Node must enqueue an attributeChanged reaction when cloning an element with an observed attribute
</span><span class="cx"> PASS cloneNode on Node must not enqueue an attributeChanged reaction when cloning an element with an unobserved attribute
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207863 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-26 01:57:44 UTC (rev 207863)
+++ trunk/Source/WebCore/ChangeLog 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-10-25 Ryosuke Niwa <rniwa@webkit.org>
+
+ Updating attribute by textContent must create a single mutation record and custom element reaction
+ https://bugs.webkit.org/show_bug.cgi?id=164003
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by setTextContent not invoking setNodeValue for Attr nodes.
+ Use setNodeValue to match the specification: https://dom.spec.whatwg.org/#dom-node-textcontent
+
+ Test: fast/dom/MutationObserver/text-content-on-attr.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::setTextContent):
+
</ins><span class="cx"> 2016-10-25 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win][Direct2D] Use smart pointers for Direct2D Path types
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (207863 => 207864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2016-10-26 01:57:44 UTC (rev 207863)
+++ trunk/Source/WebCore/dom/Node.cpp 2016-10-26 04:45:04 UTC (rev 207864)
</span><span class="lines">@@ -1475,27 +1475,27 @@
</span><span class="cx"> void Node::setTextContent(const String& text, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> switch (nodeType()) {
</span><del>- case TEXT_NODE:
- case CDATA_SECTION_NODE:
- case COMMENT_NODE:
- case PROCESSING_INSTRUCTION_NODE:
- setNodeValue(text, ec);
- return;
- case ELEMENT_NODE:
- case ATTRIBUTE_NODE:
- case DOCUMENT_FRAGMENT_NODE: {
- auto container = makeRef(downcast<ContainerNode>(*this));
- ChildListMutationScope mutation(container);
- container->removeChildren();
- if (!text.isEmpty())
- container->appendChild(document().createTextNode(text), ec);
- return;
- }
- case DOCUMENT_NODE:
- case DOCUMENT_TYPE_NODE:
- // Do nothing.
- return;
</del><ins>+ case ATTRIBUTE_NODE:
+ case TEXT_NODE:
+ case CDATA_SECTION_NODE:
+ case COMMENT_NODE:
+ case PROCESSING_INSTRUCTION_NODE:
+ setNodeValue(text, ec);
+ return;
+ case ELEMENT_NODE:
+ case DOCUMENT_FRAGMENT_NODE: {
+ auto container = makeRef(downcast<ContainerNode>(*this));
+ ChildListMutationScope mutation(container);
+ container->removeChildren();
+ if (!text.isEmpty())
+ container->appendChild(document().createTextNode(text), ec);
+ return;
</ins><span class="cx"> }
</span><ins>+ case DOCUMENT_NODE:
+ case DOCUMENT_TYPE_NODE:
+ // Do nothing.
+ return;
+ }
</ins><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>