<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207814] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207814">207814</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2016-10-25 03:27:12 -0700 (Tue, 25 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>More PassRefPtr purging in WebCore.
<https://webkit.org/b/163895>
Reviewed by Antti Koivisto.
Source/WebCore:
Remove PassRefPtr usage in RenderStyle, RenderTheme and Scrollbar, then fix up all the fallout.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
(WebCore::shapePropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertQuotes):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::usesMenuList):
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
* html/InputType.cpp:
(WebCore::InputType::themeSupportsDataListUI):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldHaveSpinButton):
(WebCore::TextFieldInputType::shouldHaveCapsLockIndicator):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
* page/FrameView.cpp:
(WebCore::FrameView::createScrollbar):
* page/FrameView.h:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::PropertyWrapperClipPath::PropertyWrapperClipPath):
(WebCore::PropertyWrapperShape::PropertyWrapperShape):
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
* platform/PopupMenuClient.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::createScrollbar):
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::createNativeScrollbar):
* platform/Scrollbar.h:
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
* rendering/FilterEffectRenderer.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(RenderMenuList::createScrollbar):
* rendering/RenderMenuList.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
* rendering/RenderScrollbar.h:
* rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::createScrollbar):
* rendering/RenderSearchField.h:
* rendering/RenderTheme.h:
(WebCore::RenderTheme::defaultTheme):
* rendering/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::create):
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeEfl.h:
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeMac.mm:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
* rendering/RenderWidget.h:
* rendering/style/CursorData.h:
(WebCore::CursorData::CursorData):
(WebCore::CursorData::setImage):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::setImage):
* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create):
* rendering/style/QuotesData.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCursor):
(WebCore::RenderStyle::setCursorList):
(WebCore::RenderStyle::setQuotes):
(WebCore::RenderStyle::setWillChange):
(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setListStyleImage):
(WebCore::RenderStyle::setBorderImageSource):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setMaskImage):
(WebCore::RenderStyle::setMaskBoxImageSource):
(WebCore::RenderStyle::setBoxReflect):
(WebCore::RenderStyle::setShapeOutside):
(WebCore::RenderStyle::setClipPath):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::cssValue):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::cssValue):
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
* rendering/style/StyleMultiColData.h:
* rendering/style/StyleRareInheritedData.h:
Source/WebKit2:
* WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
* WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::createScrollbar):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleBuilderConverterh">trunk/Source/WebCore/css/StyleBuilderConverter.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlInputTypecpp">trunk/Source/WebCore/html/InputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypecpp">trunk/Source/WebCore/html/TextFieldInputType.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderSubframeLoadercpp">trunk/Source/WebCore/loader/SubframeLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewh">trunk/Source/WebCore/page/FrameView.h</a></li>
<li><a href="#trunkSourceWebCorepageanimationCSSPropertyAnimationcpp">trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformPopupMenuClienth">trunk/Source/WebCore/platform/PopupMenuClient.h</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewcpp">trunk/Source/WebCore/platform/ScrollView.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewh">trunk/Source/WebCore/platform/ScrollView.h</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollbarcpp">trunk/Source/WebCore/platform/Scrollbar.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollbarh">trunk/Source/WebCore/platform/Scrollbar.h</a></li>
<li><a href="#trunkSourceWebCorerenderingFilterEffectRenderercpp">trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingFilterEffectRendererh">trunk/Source/WebCore/rendering/FilterEffectRenderer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerh">trunk/Source/WebCore/rendering/RenderLayer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderListBoxcpp">trunk/Source/WebCore/rendering/RenderListBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderListBoxh">trunk/Source/WebCore/rendering/RenderListBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMenuListcpp">trunk/Source/WebCore/rendering/RenderMenuList.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMenuListh">trunk/Source/WebCore/rendering/RenderMenuList.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderScrollbarcpp">trunk/Source/WebCore/rendering/RenderScrollbar.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderScrollbarh">trunk/Source/WebCore/rendering/RenderScrollbar.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderSearchFieldcpp">trunk/Source/WebCore/rendering/RenderSearchField.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderSearchFieldh">trunk/Source/WebCore/rendering/RenderSearchField.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeh">trunk/Source/WebCore/rendering/RenderTheme.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeEflcpp">trunk/Source/WebCore/rendering/RenderThemeEfl.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeEflh">trunk/Source/WebCore/rendering/RenderThemeEfl.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeGtkcpp">trunk/Source/WebCore/rendering/RenderThemeGtk.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeIOSmm">trunk/Source/WebCore/rendering/RenderThemeIOS.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMacmm">trunk/Source/WebCore/rendering/RenderThemeMac.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeWincpp">trunk/Source/WebCore/rendering/RenderThemeWin.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderWidgetcpp">trunk/Source/WebCore/rendering/RenderWidget.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderWidgeth">trunk/Source/WebCore/rendering/RenderWidget.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleCursorDatah">trunk/Source/WebCore/rendering/style/CursorData.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleFillLayerh">trunk/Source/WebCore/rendering/style/FillLayer.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleQuotesDatacpp">trunk/Source/WebCore/rendering/style/QuotesData.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleQuotesDatah">trunk/Source/WebCore/rendering/style/QuotesData.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStyleh">trunk/Source/WebCore/rendering/style/RenderStyle.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleCachedImagecpp">trunk/Source/WebCore/rendering/style/StyleCachedImage.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleCachedImageh">trunk/Source/WebCore/rendering/style/StyleCachedImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleGeneratedImagecpp">trunk/Source/WebCore/rendering/style/StyleGeneratedImage.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleGeneratedImageh">trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleImageh">trunk/Source/WebCore/rendering/style/StyleImage.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleMultiColDatah">trunk/Source/WebCore/rendering/style/StyleMultiColData.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleStyleRareInheritedDatah">trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPDFDeprecatedPDFPluginh">trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPDFDeprecatedPDFPluginmm">trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/ChangeLog 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -1,3 +1,115 @@
</span><ins>+2016-10-25 Andreas Kling <akling@apple.com>
+
+ More PassRefPtr purging in WebCore.
+ <https://webkit.org/b/163895>
+
+ Reviewed by Antti Koivisto.
+
+ Remove PassRefPtr usage in RenderStyle, RenderTheme and Scrollbar, then fix up all the fallout.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::contentToCSSValue):
+ (WebCore::shapePropertyValue):
+ (WebCore::ComputedStyleExtractor::propertyValue):
+ * css/StyleBuilderConverter.h:
+ (WebCore::StyleBuilderConverter::convertQuotes):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::usesMenuList):
+ (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
+ (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
+ * html/InputType.cpp:
+ (WebCore::InputType::themeSupportsDataListUI):
+ * html/TextFieldInputType.cpp:
+ (WebCore::TextFieldInputType::shouldHaveSpinButton):
+ (WebCore::TextFieldInputType::shouldHaveCapsLockIndicator):
+ * loader/SubframeLoader.cpp:
+ (WebCore::SubframeLoader::loadPlugin):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::createScrollbar):
+ * page/FrameView.h:
+ * page/animation/CSSPropertyAnimation.cpp:
+ (WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
+ (WebCore::PropertyWrapperClipPath::PropertyWrapperClipPath):
+ (WebCore::PropertyWrapperShape::PropertyWrapperShape):
+ (WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
+ (WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
+ (WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
+ * platform/PopupMenuClient.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::createScrollbar):
+ * platform/ScrollView.h:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::createNativeScrollbar):
+ * platform/Scrollbar.h:
+ * rendering/FilterEffectRenderer.cpp:
+ (WebCore::FilterEffectRenderer::buildReferenceFilter):
+ * rendering/FilterEffectRenderer.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::createScrollbar):
+ (WebCore::RenderLayer::createLocalTransformState):
+ (WebCore::RenderLayer::hitTestLayerByApplyingTransform):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::createScrollbar):
+ * rendering/RenderListBox.h:
+ * rendering/RenderMenuList.cpp:
+ (RenderMenuList::createScrollbar):
+ * rendering/RenderMenuList.h:
+ * rendering/RenderScrollbar.cpp:
+ (WebCore::RenderScrollbar::createCustomScrollbar):
+ * rendering/RenderScrollbar.h:
+ * rendering/RenderSearchField.cpp:
+ (WebCore::RenderSearchField::createScrollbar):
+ * rendering/RenderSearchField.h:
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::defaultTheme):
+ * rendering/RenderThemeEfl.cpp:
+ (WebCore::RenderThemeEfl::create):
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeEfl.h:
+ * rendering/RenderThemeGtk.cpp:
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeIOS.mm:
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderTheme::themeForPage):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::setWidget):
+ * rendering/RenderWidget.h:
+ * rendering/style/CursorData.h:
+ (WebCore::CursorData::CursorData):
+ (WebCore::CursorData::setImage):
+ * rendering/style/FillLayer.h:
+ (WebCore::FillLayer::setImage):
+ * rendering/style/QuotesData.cpp:
+ (WebCore::QuotesData::create):
+ * rendering/style/QuotesData.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::addCursor):
+ (WebCore::RenderStyle::setCursorList):
+ (WebCore::RenderStyle::setQuotes):
+ (WebCore::RenderStyle::setWillChange):
+ (WebCore::RenderStyle::setContent):
+ (WebCore::RenderStyle::setListStyleImage):
+ (WebCore::RenderStyle::setBorderImageSource):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::setMaskImage):
+ (WebCore::RenderStyle::setMaskBoxImageSource):
+ (WebCore::RenderStyle::setBoxReflect):
+ (WebCore::RenderStyle::setShapeOutside):
+ (WebCore::RenderStyle::setClipPath):
+ * rendering/style/StyleCachedImage.cpp:
+ (WebCore::StyleCachedImage::cssValue):
+ * rendering/style/StyleCachedImage.h:
+ * rendering/style/StyleGeneratedImage.cpp:
+ (WebCore::StyleGeneratedImage::cssValue):
+ * rendering/style/StyleGeneratedImage.h:
+ * rendering/style/StyleImage.h:
+ * rendering/style/StyleMultiColData.h:
+ * rendering/style/StyleRareInheritedData.h:
+
</ins><span class="cx"> 2016-10-24 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Custom elements reactions should have a queue per element
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -1861,7 +1861,7 @@
</span><span class="cx"> if (is<CounterContentData>(*contentData))
</span><span class="cx"> list.get().append(cssValuePool.createValue(downcast<CounterContentData>(*contentData).counter().identifier(), CSSPrimitiveValue::CSS_COUNTER_NAME));
</span><span class="cx"> else if (is<ImageContentData>(*contentData))
</span><del>- list.get().append(*downcast<ImageContentData>(*contentData).image().cssValue());
</del><ins>+ list.get().append(downcast<ImageContentData>(*contentData).image().cssValue());
</ins><span class="cx"> else if (is<TextContentData>(*contentData))
</span><span class="cx"> list.get().append(cssValuePool.createValue(downcast<TextContentData>(*contentData).text(), CSSPrimitiveValue::CSS_STRING));
</span><span class="cx"> }
</span><span class="lines">@@ -2437,7 +2437,7 @@
</span><span class="cx">
</span><span class="cx"> if (shapeValue->type() == ShapeValue::Type::Image) {
</span><span class="cx"> if (shapeValue->image())
</span><del>- return *shapeValue->image()->cssValue();
</del><ins>+ return shapeValue->image()->cssValue();
</ins><span class="cx"> return CSSValuePool::singleton().createIdentifierValue(CSSValueNone);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2584,7 +2584,7 @@
</span><span class="cx"> RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();
</span><span class="cx"> for (const FillLayer* currLayer = layers; currLayer; currLayer = currLayer->next()) {
</span><span class="cx"> if (currLayer->image())
</span><del>- list->append(*currLayer->image()->cssValue());
</del><ins>+ list->append(currLayer->image()->cssValue());
</ins><span class="cx"> else
</span><span class="cx"> list->append(cssValuePool.createIdentifierValue(CSSValueNone));
</span><span class="cx"> }
</span><span class="lines">@@ -2837,7 +2837,7 @@
</span><span class="cx"> list = CSSValueList::createCommaSeparated();
</span><span class="cx"> for (unsigned i = 0; i < cursors->size(); ++i)
</span><span class="cx"> if (StyleImage* image = cursors->at(i).image())
</span><del>- list->append(*image->cssValue());
</del><ins>+ list->append(image->cssValue());
</ins><span class="cx"> }
</span><span class="cx"> auto value = cssValuePool.createValue(style->cursor());
</span><span class="cx"> if (list) {
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleBuilderConverterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleBuilderConverter.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleBuilderConverter.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/css/StyleBuilderConverter.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> static EResize convertResize(StyleResolver&, CSSValue&);
</span><span class="cx"> static int convertMarqueeRepetition(StyleResolver&, CSSValue&);
</span><span class="cx"> static int convertMarqueeSpeed(StyleResolver&, CSSValue&);
</span><del>- static PassRefPtr<QuotesData> convertQuotes(StyleResolver&, CSSValue&);
</del><ins>+ static Ref<QuotesData> convertQuotes(StyleResolver&, CSSValue&);
</ins><span class="cx"> static TextUnderlinePosition convertTextUnderlinePosition(StyleResolver&, CSSValue&);
</span><span class="cx"> static RefPtr<StyleReflection> convertReflection(StyleResolver&, CSSValue&);
</span><span class="cx"> static IntSize convertInitialLetter(StyleResolver&, CSSValue&);
</span><span class="lines">@@ -585,7 +585,7 @@
</span><span class="cx"> return speed;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline PassRefPtr<QuotesData> StyleBuilderConverter::convertQuotes(StyleResolver&, CSSValue& value)
</del><ins>+inline Ref<QuotesData> StyleBuilderConverter::convertQuotes(StyleResolver&, CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (is<CSSPrimitiveValue>(value)) {
</span><span class="cx"> ASSERT(downcast<CSSPrimitiveValue>(value).valueID() == CSSValueNone);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -196,9 +196,7 @@
</span><span class="cx"> bool HTMLSelectElement::usesMenuList() const
</span><span class="cx"> {
</span><span class="cx"> #if !PLATFORM(IOS)
</span><del>- const Page* page = document().page();
- RefPtr<RenderTheme> renderTheme = page ? &page->theme() : RenderTheme::defaultTheme();
- if (renderTheme->delegatesMenuListRendering())
</del><ins>+ if (RenderTheme::themeForPage(document().page())->delegatesMenuListRendering())
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> return !m_multiple && m_size <= 1;
</span><span class="lines">@@ -1092,10 +1090,7 @@
</span><span class="cx">
</span><span class="cx"> bool HTMLSelectElement::platformHandleKeydownEvent(KeyboardEvent* event)
</span><span class="cx"> {
</span><del>- const Page* page = document().page();
- RefPtr<RenderTheme> renderTheme = page ? &page->theme() : RenderTheme::defaultTheme();
-
- if (!renderTheme->popsMenuByArrowKeys())
</del><ins>+ if (!RenderTheme::themeForPage(document().page())->popsMenuByArrowKeys())
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (!isSpatialNavigationEnabled(document().frame())) {
</span><span class="lines">@@ -1129,8 +1124,7 @@
</span><span class="cx"> ASSERT(renderer());
</span><span class="cx"> ASSERT(renderer()->isMenuList());
</span><span class="cx">
</span><del>- const Page* page = document().page();
- RefPtr<RenderTheme> renderTheme = page ? &page->theme() : RenderTheme::defaultTheme();
</del><ins>+ RefPtr<RenderTheme> renderTheme = RenderTheme::themeForPage(document().page());
</ins><span class="cx">
</span><span class="cx"> if (event.type() == eventNames().keydownEvent) {
</span><span class="cx"> if (!is<KeyboardEvent>(event))
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/InputType.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/InputType.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/html/InputType.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -173,8 +173,7 @@
</span><span class="cx"> bool InputType::themeSupportsDataListUI(InputType* type)
</span><span class="cx"> {
</span><span class="cx"> Document& document = type->element().document();
</span><del>- RefPtr<RenderTheme> theme = document.page() ? &document.page()->theme() : RenderTheme::defaultTheme();
- return theme->supportsDataListUI(type->formControlType());
</del><ins>+ return RenderTheme::themeForPage(document.page())->supportsDataListUI(type->formControlType());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool InputType::isTextField() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlTextFieldInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -244,16 +244,12 @@
</span><span class="cx">
</span><span class="cx"> bool TextFieldInputType::shouldHaveSpinButton() const
</span><span class="cx"> {
</span><del>- Document& document = element().document();
- RefPtr<RenderTheme> theme = document.page() ? &document.page()->theme() : RenderTheme::defaultTheme();
- return theme->shouldHaveSpinButton(element());
</del><ins>+ return RenderTheme::themeForPage(element().document().page())->shouldHaveSpinButton(element());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool TextFieldInputType::shouldHaveCapsLockIndicator() const
</span><span class="cx"> {
</span><del>- Document& document = element().document();
- RefPtr<RenderTheme> theme = document.page() ? &document.page()->theme() : RenderTheme::defaultTheme();
- return theme->shouldHaveCapsLockIndicator(element());
</del><ins>+ return RenderTheme::themeForPage(element().document().page())->shouldHaveCapsLockIndicator(element());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TextFieldInputType::createShadowSubtree()
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderSubframeLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/SubframeLoader.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/SubframeLoader.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/loader/SubframeLoader.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -421,7 +421,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> pluginElement.subframeLoaderDidCreatePlugIn(*widget);
</span><del>- renderer->setWidget(widget);
</del><ins>+ renderer->setWidget(WTFMove(widget));
</ins><span class="cx"> m_containsPlugins = true;
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/page/FrameView.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -609,7 +609,7 @@
</span><span class="cx"> setCanHaveScrollbars(true);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> FrameView::createScrollbar(ScrollbarOrientation orientation)
</del><ins>+Ref<Scrollbar> FrameView::createScrollbar(ScrollbarOrientation orientation)
</ins><span class="cx"> {
</span><span class="cx"> if (!frame().settings().allowCustomScrollbarInMainFrame() && frame().isMainFrame())
</span><span class="cx"> return ScrollView::createScrollbar(orientation);
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/page/FrameView.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> WEBCORE_EXPORT void setCanHaveScrollbars(bool) override;
</span><span class="cx"> WEBCORE_EXPORT void updateCanHaveScrollbars();
</span><span class="cx">
</span><del>- PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation) override;
</del><ins>+ Ref<Scrollbar> createScrollbar(ScrollbarOrientation) override;
</ins><span class="cx">
</span><span class="cx"> bool avoidScrollbarCreation() const override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationCSSPropertyAnimationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -474,7 +474,7 @@
</span><span class="cx"> class RefCountedPropertyWrapper : public PropertyWrapperGetter<T*> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- RefCountedPropertyWrapper(CSSPropertyID prop, T* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(PassRefPtr<T>))
</del><ins>+ RefCountedPropertyWrapper(CSSPropertyID prop, T* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(RefPtr<T>&&))
</ins><span class="cx"> : PropertyWrapperGetter<T*>(prop, getter)
</span><span class="cx"> , m_setter(setter)
</span><span class="cx"> {
</span><span class="lines">@@ -486,7 +486,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- void (RenderStyle::*m_setter)(PassRefPtr<T>);
</del><ins>+ void (RenderStyle::*m_setter)(RefPtr<T>&&);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> template <typename T>
</span><span class="lines">@@ -511,7 +511,7 @@
</span><span class="cx"> class PropertyWrapperClipPath : public RefCountedPropertyWrapper<ClipPathOperation> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- PropertyWrapperClipPath(CSSPropertyID prop, ClipPathOperation* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(PassRefPtr<ClipPathOperation>))
</del><ins>+ PropertyWrapperClipPath(CSSPropertyID prop, ClipPathOperation* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(RefPtr<ClipPathOperation>&&))
</ins><span class="cx"> : RefCountedPropertyWrapper<ClipPathOperation>(prop, getter, setter)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -563,7 +563,7 @@
</span><span class="cx"> class PropertyWrapperShape : public RefCountedPropertyWrapper<ShapeValue> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- PropertyWrapperShape(CSSPropertyID prop, ShapeValue* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(PassRefPtr<ShapeValue>))
</del><ins>+ PropertyWrapperShape(CSSPropertyID prop, ShapeValue* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(RefPtr<ShapeValue>&&))
</ins><span class="cx"> : RefCountedPropertyWrapper<ShapeValue>(prop, getter, setter)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -590,7 +590,7 @@
</span><span class="cx"> class StyleImagePropertyWrapper : public RefCountedPropertyWrapper<StyleImage> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- StyleImagePropertyWrapper(CSSPropertyID prop, StyleImage* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(PassRefPtr<StyleImage>))
</del><ins>+ StyleImagePropertyWrapper(CSSPropertyID prop, StyleImage* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(RefPtr<StyleImage>&&))
</ins><span class="cx"> : RefCountedPropertyWrapper<StyleImage>(prop, getter, setter)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -1014,7 +1014,7 @@
</span><span class="cx"> class FillLayerRefCountedPropertyWrapper : public FillLayerPropertyWrapperGetter<T*> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- FillLayerRefCountedPropertyWrapper(T* (FillLayer::*getter)() const, void (FillLayer::*setter)(PassRefPtr<T>))
</del><ins>+ FillLayerRefCountedPropertyWrapper(T* (FillLayer::*getter)() const, void (FillLayer::*setter)(RefPtr<T>&&))
</ins><span class="cx"> : FillLayerPropertyWrapperGetter<T*>(getter)
</span><span class="cx"> , m_setter(setter)
</span><span class="cx"> {
</span><span class="lines">@@ -1026,13 +1026,13 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- void (FillLayer::*m_setter)(PassRefPtr<T>);
</del><ins>+ void (FillLayer::*m_setter)(RefPtr<T>&&);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> class FillLayerStyleImagePropertyWrapper : public FillLayerRefCountedPropertyWrapper<StyleImage> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- FillLayerStyleImagePropertyWrapper(StyleImage* (FillLayer::*getter)() const, void (FillLayer::*setter)(PassRefPtr<StyleImage>))
</del><ins>+ FillLayerStyleImagePropertyWrapper(StyleImage* (FillLayer::*getter)() const, void (FillLayer::*setter)(RefPtr<StyleImage>&&))
</ins><span class="cx"> : FillLayerRefCountedPropertyWrapper<StyleImage>(getter, setter)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformPopupMenuClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/PopupMenuClient.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/PopupMenuClient.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/platform/PopupMenuClient.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> virtual FontSelector* fontSelector() const = 0;
</span><span class="cx"> virtual HostWindow* hostWindow() const = 0;
</span><span class="cx">
</span><del>- virtual PassRefPtr<Scrollbar> createScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize) = 0;
</del><ins>+ virtual Ref<Scrollbar> createScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize) = 0;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -118,7 +118,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> ScrollView::createScrollbar(ScrollbarOrientation orientation)
</del><ins>+Ref<Scrollbar> ScrollView::createScrollbar(ScrollbarOrientation orientation)
</ins><span class="cx"> {
</span><span class="cx"> return Scrollbar::createNativeScrollbar(*this, orientation, RegularScrollbar);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/platform/ScrollView.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> WEBCORE_EXPORT void setDelegatesScrolling(bool);
</span><span class="cx">
</span><span class="cx"> // Overridden by FrameView to create custom CSS scrollbars if applicable.
</span><del>- virtual PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation);
</del><ins>+ virtual Ref<Scrollbar> createScrollbar(ScrollbarOrientation);
</ins><span class="cx">
</span><span class="cx"> void styleDidChange();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollbarcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Scrollbar.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Scrollbar.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/platform/Scrollbar.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -43,9 +43,9 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> Scrollbar::createNativeScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize size)
</del><ins>+Ref<Scrollbar> Scrollbar::createNativeScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize size)
</ins><span class="cx"> {
</span><del>- return adoptRef(new Scrollbar(scrollableArea, orientation, size));
</del><ins>+ return adoptRef(*new Scrollbar(scrollableArea, orientation, size));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int Scrollbar::maxOverlapBetweenPages()
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollbarh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Scrollbar.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Scrollbar.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/platform/Scrollbar.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> #include "ScrollTypes.h"
</span><span class="cx"> #include "Timer.h"
</span><span class="cx"> #include "Widget.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/WeakPtr.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -43,7 +42,7 @@
</span><span class="cx"> class Scrollbar : public Widget {
</span><span class="cx"> public:
</span><span class="cx"> // Must be implemented by platforms that can't simply use the Scrollbar base class. Right now the only platform that is not using the base class is GTK.
</span><del>- WEBCORE_EXPORT static PassRefPtr<Scrollbar> createNativeScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize);
</del><ins>+ WEBCORE_EXPORT static Ref<Scrollbar> createNativeScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize);
</ins><span class="cx">
</span><span class="cx"> virtual ~Scrollbar();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingFilterEffectRenderercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> return sourceImage() ? &sourceImage()->context() : nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<FilterEffect> FilterEffectRenderer::buildReferenceFilter(RenderElement* renderer, PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation* filterOperation)
</del><ins>+RefPtr<FilterEffect> FilterEffectRenderer::buildReferenceFilter(RenderElement* renderer, PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation* filterOperation)
</ins><span class="cx"> {
</span><span class="cx"> if (!renderer)
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingFilterEffectRendererh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/FilterEffectRenderer.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/FilterEffectRenderer.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -36,7 +36,6 @@
</span><span class="cx"> #include "LayoutRect.h"
</span><span class="cx"> #include "SVGFilterBuilder.h"
</span><span class="cx"> #include "SourceGraphic.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx">
</span><span class="lines">@@ -108,7 +107,7 @@
</span><span class="cx"> ImageBuffer* output() const { return lastEffect()->asImageBuffer(); }
</span><span class="cx">
</span><span class="cx"> bool build(RenderElement*, const FilterOperations&, FilterConsumer);
</span><del>- PassRefPtr<FilterEffect> buildReferenceFilter(RenderElement*, PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation*);
</del><ins>+ RefPtr<FilterEffect> buildReferenceFilter(RenderElement*, PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation*);
</ins><span class="cx"> bool updateBackingStoreRect(const FloatRect& filterRect);
</span><span class="cx"> void allocateBackingStoreIfNeeded(const GraphicsContext&);
</span><span class="cx"> void clearIntermediateResults();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -3105,7 +3105,7 @@
</span><span class="cx"> return &renderer;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> RenderLayer::createScrollbar(ScrollbarOrientation orientation)
</del><ins>+Ref<Scrollbar> RenderLayer::createScrollbar(ScrollbarOrientation orientation)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<Scrollbar> widget;
</span><span class="cx"> RenderElement* actualRenderer = rendererForScrollbar(renderer());
</span><span class="lines">@@ -3121,7 +3121,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> renderer().view().frameView().addChild(widget.get());
</span><del>- return WTFMove(widget);
</del><ins>+ return widget.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderLayer::destroyScrollbar(ScrollbarOrientation orientation)
</span><span class="lines">@@ -4926,7 +4926,7 @@
</span><span class="cx"> return backmappedPoint.z();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HitTestingTransformState> RenderLayer::createLocalTransformState(RenderLayer* rootLayer, RenderLayer* containerLayer,
</del><ins>+Ref<HitTestingTransformState> RenderLayer::createLocalTransformState(RenderLayer* rootLayer, RenderLayer* containerLayer,
</ins><span class="cx"> const LayoutRect& hitTestRect, const HitTestLocation& hitTestLocation,
</span><span class="cx"> const HitTestingTransformState* containerTransformState,
</span><span class="cx"> const LayoutSize& translationOffset) const
</span><span class="lines">@@ -4954,7 +4954,7 @@
</span><span class="cx"> transformState->translate(offset.width(), offset.height(), HitTestingTransformState::AccumulateTransform);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return transformState;
</del><ins>+ return transformState.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -5308,7 +5308,7 @@
</span><span class="cx"> const LayoutSize& translationOffset)
</span><span class="cx"> {
</span><span class="cx"> // Create a transform state to accumulate this transform.
</span><del>- RefPtr<HitTestingTransformState> newTransformState = createLocalTransformState(rootLayer, containerLayer, hitTestRect, hitTestLocation, transformState, translationOffset);
</del><ins>+ Ref<HitTestingTransformState> newTransformState = createLocalTransformState(rootLayer, containerLayer, hitTestRect, hitTestLocation, transformState, translationOffset);
</ins><span class="cx">
</span><span class="cx"> // If the transform can't be inverted, then don't hit test this layer at all.
</span><span class="cx"> if (!newTransformState->m_accumulatedTransform.isInvertible())
</span><span class="lines">@@ -5330,7 +5330,7 @@
</span><span class="cx"> newHitTestLocation = HitTestLocation(localPoint);
</span><span class="cx">
</span><span class="cx"> // Now do a hit test with the root layer shifted to be us.
</span><del>- return hitTestLayer(this, containerLayer, request, result, localHitTestRect, newHitTestLocation, true, newTransformState.get(), zOffset);
</del><ins>+ return hitTestLayer(this, containerLayer, request, result, localHitTestRect, newHitTestLocation, true, newTransformState.ptr(), zOffset);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool RenderLayer::hitTestContents(const HitTestRequest& request, HitTestResult& result, const LayoutRect& layerBounds, const HitTestLocation& hitTestLocation, HitTestFilter hitTestFilter) const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -213,7 +213,7 @@
</span><span class="cx"> void setHasHorizontalScrollbar(bool);
</span><span class="cx"> void setHasVerticalScrollbar(bool);
</span><span class="cx">
</span><del>- PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation);
</del><ins>+ Ref<Scrollbar> createScrollbar(ScrollbarOrientation);
</ins><span class="cx"> void destroyScrollbar(ScrollbarOrientation);
</span><span class="cx">
</span><span class="cx"> bool hasHorizontalScrollbar() const { return horizontalScrollbar(); }
</span><span class="lines">@@ -830,7 +830,7 @@
</span><span class="cx"> const HitTestingTransformState* unflattenedTransformState,
</span><span class="cx"> bool depthSortDescendants);
</span><span class="cx">
</span><del>- PassRefPtr<HitTestingTransformState> createLocalTransformState(RenderLayer* rootLayer, RenderLayer* containerLayer,
</del><ins>+ Ref<HitTestingTransformState> createLocalTransformState(RenderLayer* rootLayer, RenderLayer* containerLayer,
</ins><span class="cx"> const LayoutRect& hitTestRect, const HitTestLocation&,
</span><span class="cx"> const HitTestingTransformState* containerTransformState,
</span><span class="cx"> const LayoutSize& translationOffset = LayoutSize()) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderListBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderListBox.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderListBox.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -896,7 +896,7 @@
</span><span class="cx"> document().addConsoleMessage(MessageSource::Other, MessageLevel::Debug, "RenderListBox: " + message);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> RenderListBox::createScrollbar()
</del><ins>+Ref<Scrollbar> RenderListBox::createScrollbar()
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<Scrollbar> widget;
</span><span class="cx"> bool hasCustomScrollbarStyle = style().hasPseudoStyle(SCROLLBAR);
</span><span class="lines">@@ -911,7 +911,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> view().frameView().addChild(widget.get());
</span><del>- return WTFMove(widget);
</del><ins>+ return widget.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderListBox::destroyScrollbar()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderListBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderListBox.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderListBox.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderListBox.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> void paintItem(PaintInfo&, const LayoutPoint&, PaintFunction);
</span><span class="cx">
</span><span class="cx"> void setHasVerticalScrollbar(bool hasScrollbar);
</span><del>- PassRefPtr<Scrollbar> createScrollbar();
</del><ins>+ Ref<Scrollbar> createScrollbar();
</ins><span class="cx"> void destroyScrollbar();
</span><span class="cx">
</span><span class="cx"> int maximumNumberOfItemsThatFitInPaddingBottomArea() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMenuListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMenuList.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMenuList.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderMenuList.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -570,15 +570,12 @@
</span><span class="cx"> return view().frameView().hostWindow();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> RenderMenuList::createScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize controlSize)
</del><ins>+Ref<Scrollbar> RenderMenuList::createScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize controlSize)
</ins><span class="cx"> {
</span><del>- RefPtr<Scrollbar> widget;
</del><span class="cx"> bool hasCustomScrollbarStyle = style().hasPseudoStyle(SCROLLBAR);
</span><span class="cx"> if (hasCustomScrollbarStyle)
</span><del>- widget = RenderScrollbar::createCustomScrollbar(scrollableArea, orientation, &selectElement());
- else
- widget = Scrollbar::createNativeScrollbar(scrollableArea, orientation, controlSize);
- return WTFMove(widget);
</del><ins>+ return RenderScrollbar::createCustomScrollbar(scrollableArea, orientation, &selectElement());
+ return Scrollbar::createNativeScrollbar(scrollableArea, orientation, controlSize);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int RenderMenuList::clientInsetLeft() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMenuListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMenuList.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMenuList.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderMenuList.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx"> bool multiple() const override;
</span><span class="cx"> FontSelector* fontSelector() const override;
</span><span class="cx"> HostWindow* hostWindow() const override;
</span><del>- PassRefPtr<Scrollbar> createScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize) override;
</del><ins>+ Ref<Scrollbar> createScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize) override;
</ins><span class="cx">
</span><span class="cx"> bool hasLineIfEmpty() const override { return true; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderScrollbarcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderScrollbar.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderScrollbar.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderScrollbar.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -36,9 +36,9 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-RefPtr<Scrollbar> RenderScrollbar::createCustomScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, Element* ownerElement, Frame* owningFrame)
</del><ins>+Ref<Scrollbar> RenderScrollbar::createCustomScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, Element* ownerElement, Frame* owningFrame)
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderScrollbar(scrollableArea, orientation, ownerElement, owningFrame));
</del><ins>+ return adoptRef(*new RenderScrollbar(scrollableArea, orientation, ownerElement, owningFrame));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderScrollbar::RenderScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, Element* ownerElement, Frame* owningFrame)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderScrollbarh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderScrollbar.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderScrollbar.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderScrollbar.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> class RenderScrollbar final : public Scrollbar {
</span><span class="cx"> public:
</span><span class="cx"> friend class Scrollbar;
</span><del>- static RefPtr<Scrollbar> createCustomScrollbar(ScrollableArea&, ScrollbarOrientation, Element*, Frame* owningFrame = nullptr);
</del><ins>+ static Ref<Scrollbar> createCustomScrollbar(ScrollableArea&, ScrollbarOrientation, Element*, Frame* owningFrame = nullptr);
</ins><span class="cx"> virtual ~RenderScrollbar();
</span><span class="cx">
</span><span class="cx"> RenderBox* owningRenderer() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderSearchFieldcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderSearchField.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderSearchField.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderSearchField.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -346,15 +346,12 @@
</span><span class="cx"> return view().frameView().hostWindow();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> RenderSearchField::createScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize controlSize)
</del><ins>+Ref<Scrollbar> RenderSearchField::createScrollbar(ScrollableArea& scrollableArea, ScrollbarOrientation orientation, ScrollbarControlSize controlSize)
</ins><span class="cx"> {
</span><del>- RefPtr<Scrollbar> widget;
</del><span class="cx"> bool hasCustomScrollbarStyle = style().hasPseudoStyle(SCROLLBAR);
</span><span class="cx"> if (hasCustomScrollbarStyle)
</span><del>- widget = RenderScrollbar::createCustomScrollbar(scrollableArea, orientation, &inputElement());
- else
- widget = Scrollbar::createNativeScrollbar(scrollableArea, orientation, controlSize);
- return WTFMove(widget);
</del><ins>+ return RenderScrollbar::createCustomScrollbar(scrollableArea, orientation, &inputElement());
+ return Scrollbar::createNativeScrollbar(scrollableArea, orientation, controlSize);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> LayoutUnit RenderSearchField::computeLogicalHeightLimit() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderSearchFieldh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderSearchField.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderSearchField.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderSearchField.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx"> void setTextFromItem(unsigned listIndex) override;
</span><span class="cx"> FontSelector* fontSelector() const override;
</span><span class="cx"> HostWindow* hostWindow() const override;
</span><del>- PassRefPtr<Scrollbar> createScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize) override;
</del><ins>+ Ref<Scrollbar> createScrollbar(ScrollableArea&, ScrollbarOrientation, ScrollbarControlSize) override;
</ins><span class="cx">
</span><span class="cx"> HTMLElement* resultsButtonElement() const;
</span><span class="cx"> HTMLElement* cancelButtonElement() const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> #include "PaintInfo.h"
</span><span class="cx"> #include "PopupMenuStyle.h"
</span><span class="cx"> #include "ScrollTypes.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><ins>+#include <wtf/Ref.h>
</ins><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -67,12 +67,12 @@
</span><span class="cx"> // This function is to be implemented in your platform-specific theme implementation to hand back the
</span><span class="cx"> // appropriate platform theme. When the theme is needed in non-page dependent code, a default theme is
</span><span class="cx"> // used as fallback, which is returned for a nulled page, so the platform code needs to account for this.
</span><del>- static PassRefPtr<RenderTheme> themeForPage(Page* page);
</del><ins>+ static Ref<RenderTheme> themeForPage(Page*);
</ins><span class="cx">
</span><span class="cx"> // When the theme is needed in non-page dependent code, the defaultTheme() is used as fallback.
</span><del>- static inline PassRefPtr<RenderTheme> defaultTheme()
</del><ins>+ static inline Ref<RenderTheme> defaultTheme()
</ins><span class="cx"> {
</span><del>- return themeForPage(0);
</del><ins>+ return themeForPage(nullptr);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // This method is called whenever style has been computed for an element and the appearance
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeEfl.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeEfl.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderThemeEfl.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -410,17 +410,17 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderThemeEfl::create(Page* page)
</del><ins>+Ref<RenderTheme> RenderThemeEfl::create(Page* page)
</ins><span class="cx"> {
</span><del>- return adoptRef(new RenderThemeEfl(page));
</del><ins>+ return adoptRef(*new RenderThemeEfl(page));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
</del><ins>+Ref<RenderTheme> RenderTheme::themeForPage(Page* page)
</ins><span class="cx"> {
</span><span class="cx"> if (page)
</span><span class="cx"> return RenderThemeEfl::create(page);
</span><span class="cx">
</span><del>- static RenderTheme* fallback = RenderThemeEfl::create(0).leakRef();
</del><ins>+ static RenderTheme& fallback = RenderThemeEfl::create(0).leakRef();
</ins><span class="cx"> return fallback;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeEflh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeEfl.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeEfl.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderThemeEfl.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> virtual ~RenderThemeEfl();
</span><span class="cx">
</span><span class="cx"> public:
</span><del>- static PassRefPtr<RenderTheme> create(Page*);
</del><ins>+ static Ref<RenderTheme> create(Page*);
</ins><span class="cx">
</span><span class="cx"> // A method asking if the theme's controls actually care about redrawing when hovered.
</span><span class="cx"> bool supportsHover(const RenderStyle&) const override { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -67,10 +67,10 @@
</span><span class="cx"> return adoptRef(*new RenderThemeGtk());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
</del><ins>+Ref<RenderTheme> RenderTheme::themeForPage(Page*)
</ins><span class="cx"> {
</span><span class="cx"> static RenderTheme& rt = RenderThemeGtk::create().leakRef();
</span><del>- return &rt;
</del><ins>+ return rt;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static double getScreenDPI()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -294,10 +294,10 @@
</span><span class="cx"> CFNotificationCenterAddObserver(CFNotificationCenterGetLocalCenter(), this, contentSizeCategoryDidChange, UIContentSizeCategoryDidChangeNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
</del><ins>+Ref<RenderTheme> RenderTheme::themeForPage(Page*)
</ins><span class="cx"> {
</span><span class="cx"> static RenderTheme& renderTheme = RenderThemeIOS::create().leakRef();
</span><del>- return &renderTheme;
</del><ins>+ return renderTheme;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<RenderTheme> RenderThemeIOS::create()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -197,10 +197,10 @@
</span><span class="cx"> leftPadding
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
</del><ins>+Ref<RenderTheme> RenderTheme::themeForPage(Page*)
</ins><span class="cx"> {
</span><span class="cx"> static RenderTheme& rt = RenderThemeMac::create().leakRef();
</span><del>- return &rt;
</del><ins>+ return rt;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<RenderTheme> RenderThemeMac::create()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeWin.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -188,10 +188,10 @@
</span><span class="cx"> return adoptRef(*new RenderThemeWin);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
</del><ins>+Ref<RenderTheme> RenderTheme::themeForPage(Page* page)
</ins><span class="cx"> {
</span><span class="cx"> static RenderTheme& winTheme = RenderThemeWin::create().leakRef();
</span><del>- return &winTheme;
</del><ins>+ return winTheme;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderThemeWin::RenderThemeWin()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderWidgetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderWidget.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderWidget.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderWidget.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -161,7 +161,7 @@
</span><span class="cx"> return setWidgetGeometry(absoluteContentBox);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderWidget::setWidget(PassRefPtr<Widget> widget)
</del><ins>+void RenderWidget::setWidget(RefPtr<Widget>&& widget)
</ins><span class="cx"> {
</span><span class="cx"> if (widget == m_widget)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderWidgeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderWidget.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderWidget.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/RenderWidget.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> HTMLFrameOwnerElement& frameOwnerElement() const { return downcast<HTMLFrameOwnerElement>(nodeForNonAnonymous()); }
</span><span class="cx">
</span><span class="cx"> Widget* widget() const { return m_widget.get(); }
</span><del>- WEBCORE_EXPORT void setWidget(PassRefPtr<Widget>);
</del><ins>+ WEBCORE_EXPORT void setWidget(RefPtr<Widget>&&);
</ins><span class="cx">
</span><span class="cx"> static RenderWidget* find(const Widget*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleCursorDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/CursorData.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/CursorData.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/CursorData.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -32,8 +32,8 @@
</span><span class="cx">
</span><span class="cx"> class CursorData {
</span><span class="cx"> public:
</span><del>- CursorData(PassRefPtr<StyleImage> image, const IntPoint& hotSpot)
- : m_image(image)
</del><ins>+ CursorData(RefPtr<StyleImage>&& image, const IntPoint& hotSpot)
+ : m_image(WTFMove(image))
</ins><span class="cx"> , m_hotSpot(hotSpot)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> StyleImage* image() const { return m_image.get(); }
</span><del>- void setImage(PassRefPtr<StyleImage> image) { m_image = image; }
</del><ins>+ void setImage(RefPtr<StyleImage>&& image) { m_image = WTFMove(image); }
</ins><span class="cx">
</span><span class="cx"> // Hot spot in the image in logical pixels.
</span><span class="cx"> const IntPoint& hotSpot() const { return m_hotSpot; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleFillLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/FillLayer.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/FillLayer.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/FillLayer.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> bool isSizeSet() const { return m_sizeType != SizeNone; }
</span><span class="cx"> bool isMaskSourceTypeSet() const { return m_maskSourceTypeSet; }
</span><span class="cx">
</span><del>- void setImage(PassRefPtr<StyleImage> image) { m_image = image; m_imageSet = true; }
</del><ins>+ void setImage(RefPtr<StyleImage>&& image) { m_image = WTFMove(image); m_imageSet = true; }
</ins><span class="cx"> void setXPosition(Length length) { m_xPosition = WTFMove(length); m_xPosSet = true; }
</span><span class="cx"> void setYPosition(Length length) { m_yPosition = WTFMove(length); m_yPosSet = true; }
</span><span class="cx"> void setBackgroundXOrigin(Edge o) { m_backgroundXOrigin = static_cast<unsigned>(o); m_backgroundOriginSet = true; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleQuotesDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/QuotesData.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/QuotesData.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/QuotesData.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -29,10 +29,10 @@
</span><span class="cx"> return sizeof(QuotesData) + sizeof(std::pair<String, String>) * count;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<QuotesData> QuotesData::create(const Vector<std::pair<String, String>>& quotes)
</del><ins>+Ref<QuotesData> QuotesData::create(const Vector<std::pair<String, String>>& quotes)
</ins><span class="cx"> {
</span><span class="cx"> void* slot = fastMalloc(sizeForQuotesDataWithQuoteCount(quotes.size()));
</span><del>- return adoptRef(new (NotNull, slot) QuotesData(quotes));
</del><ins>+ return adoptRef(*new (NotNull, slot) QuotesData(quotes));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> QuotesData::QuotesData(const Vector<std::pair<String, String>>& quotes)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleQuotesDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/QuotesData.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/QuotesData.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/QuotesData.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -22,7 +22,6 @@
</span><span class="cx"> #ifndef QuotesData_h
</span><span class="cx"> #define QuotesData_h
</span><span class="cx">
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="lines">@@ -36,7 +35,7 @@
</span><span class="cx">
</span><span class="cx"> class QuotesData : public RefCounted<QuotesData> {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<QuotesData> create(const Vector<std::pair<String, String>>& quotes);
</del><ins>+ static Ref<QuotesData> create(const Vector<std::pair<String, String>>& quotes);
</ins><span class="cx"> ~QuotesData();
</span><span class="cx">
</span><span class="cx"> friend bool operator==(const QuotesData&, const QuotesData&);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -945,27 +945,27 @@
</span><span class="cx"> data->clip.left() = left;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderStyle::addCursor(PassRefPtr<StyleImage> image, const IntPoint& hotSpot)
</del><ins>+void RenderStyle::addCursor(RefPtr<StyleImage>&& image, const IntPoint& hotSpot)
</ins><span class="cx"> {
</span><span class="cx"> if (!rareInheritedData.access()->cursorData)
</span><span class="cx"> rareInheritedData.access()->cursorData = CursorList::create();
</span><del>- rareInheritedData.access()->cursorData->append(CursorData(image, hotSpot));
</del><ins>+ rareInheritedData.access()->cursorData->append(CursorData(WTFMove(image), hotSpot));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderStyle::setCursorList(PassRefPtr<CursorList> other)
</del><ins>+void RenderStyle::setCursorList(RefPtr<CursorList>&& list)
</ins><span class="cx"> {
</span><del>- rareInheritedData.access()->cursorData = other;
</del><ins>+ rareInheritedData.access()->cursorData = WTFMove(list);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderStyle::setQuotes(PassRefPtr<QuotesData> q)
</del><ins>+void RenderStyle::setQuotes(RefPtr<QuotesData>&& q)
</ins><span class="cx"> {
</span><span class="cx"> if (rareInheritedData->quotes == q || (rareInheritedData->quotes && q && *rareInheritedData->quotes == *q))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- rareInheritedData.access()->quotes = q;
</del><ins>+ rareInheritedData.access()->quotes = WTFMove(q);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderStyle::setWillChange(PassRefPtr<WillChangeData> willChangeData)
</del><ins>+void RenderStyle::setWillChange(RefPtr<WillChangeData>&& willChangeData)
</ins><span class="cx"> {
</span><span class="cx"> if (arePointingToEqualData(rareNonInheritedData->m_willChange.get(), willChangeData.get()))
</span><span class="cx"> return;
</span><span class="lines">@@ -998,7 +998,7 @@
</span><span class="cx"> content = WTFMove(contentData);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderStyle::setContent(PassRefPtr<StyleImage> image, bool add)
</del><ins>+void RenderStyle::setContent(RefPtr<StyleImage>&& image, bool add)
</ins><span class="cx"> {
</span><span class="cx"> if (!image)
</span><span class="cx"> return;
</span><span class="lines">@@ -1008,7 +1008,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- rareNonInheritedData.access()->m_content = std::make_unique<ImageContentData>(image);
</del><ins>+ rareNonInheritedData.access()->m_content = std::make_unique<ImageContentData>(WTFMove(image));
</ins><span class="cx"> if (!rareNonInheritedData.access()->m_altText.isNull())
</span><span class="cx"> rareNonInheritedData.access()->m_content->setAltText(rareNonInheritedData.access()->m_altText);
</span><span class="cx"> }
</span><span class="lines">@@ -1179,10 +1179,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> StyleImage* RenderStyle::listStyleImage() const { return rareInheritedData->listStyleImage.get(); }
</span><del>-void RenderStyle::setListStyleImage(PassRefPtr<StyleImage> v)
</del><ins>+void RenderStyle::setListStyleImage(RefPtr<StyleImage>&& v)
</ins><span class="cx"> {
</span><span class="cx"> if (rareInheritedData->listStyleImage != v)
</span><del>- rareInheritedData.access()->listStyleImage = v;
</del><ins>+ rareInheritedData.access()->listStyleImage = WTFMove(v);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const Color& RenderStyle::color() const
</span><span class="lines">@@ -1879,11 +1879,11 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderStyle::setBorderImageSource(PassRefPtr<StyleImage> image)
</del><ins>+void RenderStyle::setBorderImageSource(RefPtr<StyleImage>&& image)
</ins><span class="cx"> {
</span><span class="cx"> if (surround->border.m_image.image() == image.get())
</span><span class="cx"> return;
</span><del>- surround.access()->border.m_image.setImage(image);
</del><ins>+ surround.access()->border.m_image.setImage(WTFMove(image));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderStyle::setBorderImageSlices(LengthBox slices)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStyleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -1303,7 +1303,7 @@
</span><span class="cx"> void setBackgroundSizeLength(LengthSize size) { SET_VAR(m_background, m_background.m_sizeLength, WTFMove(size)); }
</span><span class="cx">
</span><span class="cx"> void setBorderImage(const NinePieceImage& b) { SET_VAR(surround, border.m_image, b); }
</span><del>- void setBorderImageSource(PassRefPtr<StyleImage>);
</del><ins>+ void setBorderImageSource(RefPtr<StyleImage>&&);
</ins><span class="cx"> void setBorderImageSlices(LengthBox);
</span><span class="cx"> void setBorderImageWidth(LengthBox);
</span><span class="cx"> void setBorderImageOutset(LengthBox);
</span><span class="lines">@@ -1443,10 +1443,10 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void setMaskImage(PassRefPtr<StyleImage> v) { rareNonInheritedData.access()->m_mask.setImage(v); }
</del><ins>+ void setMaskImage(RefPtr<StyleImage>&& v) { rareNonInheritedData.access()->m_mask.setImage(WTFMove(v)); }
</ins><span class="cx">
</span><span class="cx"> void setMaskBoxImage(const NinePieceImage& b) { SET_VAR(rareNonInheritedData, m_maskBoxImage, b); }
</span><del>- void setMaskBoxImageSource(PassRefPtr<StyleImage> v) { rareNonInheritedData.access()->m_maskBoxImage.setImage(v); }
</del><ins>+ void setMaskBoxImageSource(RefPtr<StyleImage>&& v) { rareNonInheritedData.access()->m_maskBoxImage.setImage(WTFMove(v)); }
</ins><span class="cx"> void setMaskXPosition(Length length) { SET_VAR(rareNonInheritedData, m_mask.m_xPosition, WTFMove(length)); }
</span><span class="cx"> void setMaskYPosition(Length length) { SET_VAR(rareNonInheritedData, m_mask.m_yPosition, WTFMove(length)); }
</span><span class="cx"> void setMaskSize(LengthSize size) { SET_VAR(rareNonInheritedData, m_mask.m_sizeLength, WTFMove(size)); }
</span><span class="lines">@@ -1462,7 +1462,7 @@
</span><span class="cx"> void setAspectRatioNumerator(float v) { SET_VAR(rareNonInheritedData, m_aspectRatioNumerator, v); }
</span><span class="cx">
</span><span class="cx"> void setListStyleType(EListStyleType v) { inherited_flags._list_style_type = v; }
</span><del>- void setListStyleImage(PassRefPtr<StyleImage>);
</del><ins>+ void setListStyleImage(RefPtr<StyleImage>&&);
</ins><span class="cx"> void setListStylePosition(EListStylePosition v) { inherited_flags._list_style_position = v; }
</span><span class="cx">
</span><span class="cx"> void resetMargin() { SET_VAR(surround, margin, LengthBox(Fixed)); }
</span><span class="lines">@@ -1481,8 +1481,8 @@
</span><span class="cx"> void setPaddingRight(Length length) { SET_VAR(surround, padding.right(), WTFMove(length)); }
</span><span class="cx">
</span><span class="cx"> void setCursor(ECursor c) { inherited_flags._cursor_style = c; }
</span><del>- void addCursor(PassRefPtr<StyleImage>, const IntPoint& hotSpot = IntPoint());
- void setCursorList(PassRefPtr<CursorList>);
</del><ins>+ void addCursor(RefPtr<StyleImage>&&, const IntPoint& hotSpot = IntPoint());
+ void setCursorList(RefPtr<CursorList>&&);
</ins><span class="cx"> void clearCursorList();
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CURSOR_VISIBILITY)
</span><span class="lines">@@ -1529,7 +1529,7 @@
</span><span class="cx"> void setBoxOrient(EBoxOrient o) { SET_NESTED_VAR(rareNonInheritedData, m_deprecatedFlexibleBox, orient, o); }
</span><span class="cx"> void setBoxPack(EBoxPack p) { SET_NESTED_VAR(rareNonInheritedData, m_deprecatedFlexibleBox, pack, p); }
</span><span class="cx"> void setBoxShadow(std::unique_ptr<ShadowData>, bool add = false);
</span><del>- void setBoxReflect(PassRefPtr<StyleReflection> reflect) { if (rareNonInheritedData->m_boxReflect != reflect) rareNonInheritedData.access()->m_boxReflect = reflect; }
</del><ins>+ void setBoxReflect(RefPtr<StyleReflection>&& reflect) { if (rareNonInheritedData->m_boxReflect != reflect) rareNonInheritedData.access()->m_boxReflect = WTFMove(reflect); }
</ins><span class="cx"> void setBoxSizing(EBoxSizing s) { SET_VAR(m_box, m_boxSizing, s); }
</span><span class="cx"> void setFlexGrow(float f) { SET_NESTED_VAR(rareNonInheritedData, m_flexibleBox, m_flexGrow, f); }
</span><span class="cx"> void setFlexShrink(float f) { SET_NESTED_VAR(rareNonInheritedData, m_flexibleBox, m_flexShrink, f); }
</span><span class="lines">@@ -1793,11 +1793,11 @@
</span><span class="cx"> SVGLength kerning() const { return svgStyle().kerning(); }
</span><span class="cx"> void setKerning(SVGLength k) { accessSVGStyle().setKerning(k); }
</span><span class="cx">
</span><del>- void setShapeOutside(PassRefPtr<ShapeValue> value)
</del><ins>+ void setShapeOutside(RefPtr<ShapeValue>&& value)
</ins><span class="cx"> {
</span><span class="cx"> if (rareNonInheritedData->m_shapeOutside == value)
</span><span class="cx"> return;
</span><del>- rareNonInheritedData.access()->m_shapeOutside = value;
</del><ins>+ rareNonInheritedData.access()->m_shapeOutside = WTFMove(value);
</ins><span class="cx"> }
</span><span class="cx"> ShapeValue* shapeOutside() const { return rareNonInheritedData->m_shapeOutside.get(); }
</span><span class="cx">
</span><span class="lines">@@ -1815,10 +1815,10 @@
</span><span class="cx"> }
</span><span class="cx"> static float initialShapeImageThreshold() { return 0; }
</span><span class="cx">
</span><del>- void setClipPath(PassRefPtr<ClipPathOperation> operation)
</del><ins>+ void setClipPath(RefPtr<ClipPathOperation>&& operation)
</ins><span class="cx"> {
</span><span class="cx"> if (rareNonInheritedData->m_clipPath != operation)
</span><del>- rareNonInheritedData.access()->m_clipPath = operation;
</del><ins>+ rareNonInheritedData.access()->m_clipPath = WTFMove(operation);
</ins><span class="cx"> }
</span><span class="cx"> ClipPathOperation* clipPath() const { return rareNonInheritedData->m_clipPath.get(); }
</span><span class="cx">
</span><span class="lines">@@ -1829,7 +1829,7 @@
</span><span class="cx"> bool contentDataEquivalent(const RenderStyle* otherStyle) const { return const_cast<RenderStyle*>(this)->rareNonInheritedData->contentDataEquivalent(*const_cast<RenderStyle*>(otherStyle)->rareNonInheritedData); }
</span><span class="cx"> void clearContent();
</span><span class="cx"> void setContent(const String&, bool add = false);
</span><del>- void setContent(PassRefPtr<StyleImage>, bool add = false);
</del><ins>+ void setContent(RefPtr<StyleImage>&&, bool add = false);
</ins><span class="cx"> void setContent(std::unique_ptr<CounterContent>, bool add = false);
</span><span class="cx"> void setContent(QuoteType, bool add = false);
</span><span class="cx"> void setContentAltText(const String&);
</span><span class="lines">@@ -1842,10 +1842,10 @@
</span><span class="cx"> const CounterDirectives getCounterDirectives(const AtomicString& identifier) const;
</span><span class="cx">
</span><span class="cx"> QuotesData* quotes() const { return rareInheritedData->quotes.get(); }
</span><del>- void setQuotes(PassRefPtr<QuotesData>);
</del><ins>+ void setQuotes(RefPtr<QuotesData>&&);
</ins><span class="cx">
</span><span class="cx"> WillChangeData* willChange() const { return rareNonInheritedData->m_willChange.get(); }
</span><del>- void setWillChange(PassRefPtr<WillChangeData>);
</del><ins>+ void setWillChange(RefPtr<WillChangeData>&&);
</ins><span class="cx">
</span><span class="cx"> bool willChangeCreatesStackingContext() const
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleCachedImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleCachedImage.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleCachedImage.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleCachedImage.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -96,9 +96,9 @@
</span><span class="cx"> return m_cachedImage.get();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSValue> StyleCachedImage::cssValue() const
</del><ins>+Ref<CSSValue> StyleCachedImage::cssValue() const
</ins><span class="cx"> {
</span><del>- return const_cast<CSSValue*>(m_cssValue.ptr());
</del><ins>+ return const_cast<CSSValue&>(m_cssValue.get());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool StyleCachedImage::canRender(const RenderElement* renderer, float multiplier) const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleCachedImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleCachedImage.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleCachedImage.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleCachedImage.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> WrappedImagePtr data() const override { return m_cachedImage.get(); }
</span><span class="cx">
</span><del>- PassRefPtr<CSSValue> cssValue() const override;
</del><ins>+ Ref<CSSValue> cssValue() const override;
</ins><span class="cx">
</span><span class="cx"> bool canRender(const RenderElement*, float multiplier) const override;
</span><span class="cx"> bool isPending() const override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleGeneratedImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleGeneratedImage.cpp (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleGeneratedImage.cpp 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleGeneratedImage.cpp 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx"> m_isGeneratedImage = true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSValue> StyleGeneratedImage::cssValue() const
</del><ins>+Ref<CSSValue> StyleGeneratedImage::cssValue() const
</ins><span class="cx"> {
</span><del>- return const_cast<CSSImageGeneratorValue*>(m_imageGeneratorValue.ptr());
</del><ins>+ return const_cast<CSSImageGeneratorValue&>(m_imageGeneratorValue.get());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool StyleGeneratedImage::isPending() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleGeneratedImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx">
</span><span class="cx"> WrappedImagePtr data() const override { return m_imageGeneratorValue.ptr(); }
</span><span class="cx">
</span><del>- PassRefPtr<CSSValue> cssValue() const override;
</del><ins>+ Ref<CSSValue> cssValue() const override;
</ins><span class="cx">
</span><span class="cx"> bool isPending() const override;
</span><span class="cx"> void load(CachedResourceLoader&, const ResourceLoaderOptions&) override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleImage.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleImage.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleImage.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #include "CSSValue.h"
</span><span class="cx"> #include "FloatSize.h"
</span><span class="cx"> #include "Image.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx"> #include <wtf/TypeCasts.h>
</span><span class="lines">@@ -49,7 +48,7 @@
</span><span class="cx">
</span><span class="cx"> virtual bool operator==(const StyleImage& other) const = 0;
</span><span class="cx">
</span><del>- virtual PassRefPtr<CSSValue> cssValue() const = 0;
</del><ins>+ virtual Ref<CSSValue> cssValue() const = 0;
</ins><span class="cx">
</span><span class="cx"> virtual bool canRender(const RenderElement*, float /*multiplier*/) const { return true; }
</span><span class="cx"> virtual bool isPending() const = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleMultiColDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleMultiColData.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleMultiColData.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleMultiColData.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #include "BorderValue.h"
</span><span class="cx"> #include "Length.h"
</span><span class="cx"> #include "RenderStyleConstants.h"
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleStyleRareInheritedDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx"> #include "Length.h"
</span><span class="cx"> #include "StyleCustomPropertyData.h"
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><del>-#include <wtf/PassRefPtr.h>
</del><span class="cx"> #include <wtf/text/AtomicString.h>
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TEXT_AUTOSIZING)
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebKit2/ChangeLog 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-10-25 Andreas Kling <akling@apple.com>
+
+ More PassRefPtr purging in WebCore.
+ <https://webkit.org/b/163895>
+
+ Reviewed by Antti Koivisto.
+
+ * WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
+ * WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
+ (WebKit::PDFPlugin::createScrollbar):
+
</ins><span class="cx"> 2016-10-25 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPDFDeprecatedPDFPluginh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -218,7 +218,7 @@
</span><span class="cx">
</span><span class="cx"> // PDFPlugin functions.
</span><span class="cx"> void updateScrollbars();
</span><del>- PassRefPtr<WebCore::Scrollbar> createScrollbar(WebCore::ScrollbarOrientation);
</del><ins>+ Ref<WebCore::Scrollbar> createScrollbar(WebCore::ScrollbarOrientation);
</ins><span class="cx"> void destroyScrollbar(WebCore::ScrollbarOrientation);
</span><span class="cx"> void pdfDocumentDidLoad();
</span><span class="cx"> void addArchiveResource();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPDFDeprecatedPDFPluginmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm (207813 => 207814)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm 2016-10-25 10:25:29 UTC (rev 207813)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm 2016-10-25 10:27:12 UTC (rev 207814)
</span><span class="lines">@@ -649,7 +649,7 @@
</span><span class="cx"> return static_cast<const PluginView*>(controller());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Scrollbar> PDFPlugin::createScrollbar(ScrollbarOrientation orientation)
</del><ins>+Ref<Scrollbar> PDFPlugin::createScrollbar(ScrollbarOrientation orientation)
</ins><span class="cx"> {
</span><span class="cx"> auto widget = Scrollbar::createNativeScrollbar(*this, orientation, RegularScrollbar);
</span><span class="cx"> if (orientation == HorizontalScrollbar) {
</span><span class="lines">@@ -659,7 +659,7 @@
</span><span class="cx"> m_verticalScrollbarLayer = adoptNS([[WKPDFPluginScrollbarLayer alloc] initWithPDFPlugin:this]);
</span><span class="cx"> [m_containerLayer addSublayer:m_verticalScrollbarLayer.get()];
</span><span class="cx"> }
</span><del>- didAddScrollbar(widget.get(), orientation);
</del><ins>+ didAddScrollbar(widget.ptr(), orientation);
</ins><span class="cx"> if (Frame* frame = webFrame()->coreFrame()) {
</span><span class="cx"> if (Page* page = frame->page()) {
</span><span class="cx"> if (page->expectsWheelEventTriggers())
</span><span class="lines">@@ -666,7 +666,7 @@
</span><span class="cx"> scrollAnimator().setWheelEventTestTrigger(page->testTrigger());
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- pluginView()->frame()->view()->addChild(widget.get());
</del><ins>+ pluginView()->frame()->view()->addChild(widget.ptr());
</ins><span class="cx"> return widget;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>