<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207784] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207784">207784</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-24 15:09:29 -0700 (Mon, 24 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Scope chain shouldn't show empty Closure sections
https://bugs.webkit.org/show_bug.cgi?id=152348
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-10-24
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
* inspector/InjectedScriptSource.js:
(isEmptyObject):
(InjectedScript.CallFrameProxy._createScopeJson):
If the scope object has no properties, set empty to true.
* inspector/protocol/Debugger.json:
Added empty property to Scope type.
Source/WebInspectorUI:
* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
* UserInterface/Models/ScopeChainNode.js:
(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get empty):
Added support for new empty property.
* UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
Only create and display a DetailsSection if the scope is not empty (via empty).
LayoutTests:
* inspector/model/scope-chain-node-expected.txt:
* inspector/model/scope-chain-node.html:
Added "empty" indicators to scopes without any property descriptors.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectormodelscopechainnodeexpectedtxt">trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectormodelscopechainnodehtml">trunk/LayoutTests/inspector/model/scope-chain-node.html</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorInjectedScriptSourcejs">trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorprotocolDebuggerjson">trunk/Source/JavaScriptCore/inspector/protocol/Debugger.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersDebuggerManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsScopeChainNodejs">trunk/Source/WebInspectorUI/UserInterface/Models/ScopeChainNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsScopeChainDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/LayoutTests/ChangeLog 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-10-24 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Scope chain shouldn't show empty Closure sections
+ https://bugs.webkit.org/show_bug.cgi?id=152348
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/model/scope-chain-node-expected.txt:
+ * inspector/model/scope-chain-node.html:
+ Added "empty" indicators to scopes without any property descriptors.
+
+2016-10-24 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Improve Quick Open sorting algorithm
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=163705
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectormodelscopechainnodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/LayoutTests/inspector/model/scope-chain-node-expected.txt 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -55,9 +55,11 @@
</span><span class="cx"> -- Running test case: WebInspector.ScopeChainNode.FunctionNameInFunctionExpression
</span><span class="cx"> SCOPE CHAIN:
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> FunctionName
</span><span class="cx"> - functionName: function functionName() {
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> GlobalLexicalEnvironment
</span><span class="cx"> - lexicalGlobalVariable: 2
</span><span class="cx"> Global
</span><span class="lines">@@ -65,9 +67,11 @@
</span><span class="cx"> -- Running test case: WebInspector.ScopeChainNode.FunctionNameInClassMethod
</span><span class="cx"> SCOPE CHAIN:
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> Block
</span><span class="cx"> - MyClass: class MyClass
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> GlobalLexicalEnvironment
</span><span class="cx"> - lexicalGlobalVariable: 2
</span><span class="cx"> Global
</span><span class="lines">@@ -101,6 +105,7 @@
</span><span class="cx"> Closure
</span><span class="cx"> - a: 1
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> GlobalLexicalEnvironment
</span><span class="cx"> - lexicalGlobalVariable: 2
</span><span class="cx"> Global
</span><span class="lines">@@ -107,11 +112,13 @@
</span><span class="cx"> PASS: Pause #17 - Contains a Block scope.
</span><span class="cx"> SCOPE CHAIN:
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> Block
</span><span class="cx"> - MyClass: class MyClass
</span><span class="cx"> Closure
</span><span class="cx"> - a: 1
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> GlobalLexicalEnvironment
</span><span class="cx"> - lexicalGlobalVariable: 2
</span><span class="cx"> Global
</span><span class="lines">@@ -118,11 +125,13 @@
</span><span class="cx"> PASS: Pause #18 - Contains a Block scope.
</span><span class="cx"> SCOPE CHAIN:
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> Block
</span><span class="cx"> - MyClassWithStaticMethod: class MyClassWithStaticMethod
</span><span class="cx"> Closure
</span><span class="cx"> - a: 1
</span><span class="cx"> Closure
</span><ins>+ (empty)
</ins><span class="cx"> GlobalLexicalEnvironment
</span><span class="cx"> - lexicalGlobalVariable: 2
</span><span class="cx"> Global
</span></span></pre></div>
<a id="trunkLayoutTestsinspectormodelscopechainnodehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/scope-chain-node.html (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/scope-chain-node.html 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/LayoutTests/inspector/model/scope-chain-node.html 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -45,10 +45,17 @@
</span><span class="cx"> InspectorTest.log("SCOPE CHAIN:");
</span><span class="cx"> for (let {scope, propertyDescriptors} of results) {
</span><span class="cx"> InspectorTest.log(` ${scopeTypeToString(scope.type)}`);
</span><del>- if (scope.type !== WebInspector.ScopeChainNode.Type.Global) {
- for (let descriptor of propertyDescriptors)
- InspectorTest.log(` - ${descriptor.name}: ${firstLine(descriptor.value.description)}`);
</del><ins>+ if (scope.type === WebInspector.ScopeChainNode.Type.Global)
+ continue;
+
+ if (!propertyDescriptors.length) {
+ InspectorTest.assert(scope.empty, "Scope should be empty if there are no property descriptors.");
+ InspectorTest.log(" (empty)");
+ continue;
</ins><span class="cx"> }
</span><ins>+
+ for (let descriptor of propertyDescriptors)
+ InspectorTest.log(` - ${descriptor.name}: ${firstLine(descriptor.value.description)}`);
</ins><span class="cx"> }
</span><span class="cx"> return results;
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-10-24 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: Scope chain shouldn't show empty Closure sections
+ https://bugs.webkit.org/show_bug.cgi?id=152348
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InjectedScriptSource.js:
+ (isEmptyObject):
+ (InjectedScript.CallFrameProxy._createScopeJson):
+ If the scope object has no properties, set empty to true.
+
+ * inspector/protocol/Debugger.json:
+ Added empty property to Scope type.
+
</ins><span class="cx"> 2016-10-24 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Wasm should support floating point operations.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorInjectedScriptSourcejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -68,6 +68,13 @@
</span><span class="cx"> return typeof obj === "symbol";
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function isEmptyObject(object)
+{
+ for (let key in object)
+ return false;
+ return true;
+}
+
</ins><span class="cx"> var InjectedScript = function()
</span><span class="cx"> {
</span><span class="cx"> this._lastBoundObjectId = 1;
</span><span class="lines">@@ -1335,7 +1342,7 @@
</span><span class="cx">
</span><span class="cx"> InjectedScript.CallFrameProxy._createScopeJson = function(object, {name, type, location}, groupId)
</span><span class="cx"> {
</span><del>- var scope = {
</del><ins>+ let scope = {
</ins><span class="cx"> object: injectedScript._wrapObject(object, groupId),
</span><span class="cx"> type: InjectedScript.CallFrameProxy._scopeTypeNames[type],
</span><span class="cx"> };
</span><span class="lines">@@ -1342,9 +1349,13 @@
</span><span class="cx">
</span><span class="cx"> if (name)
</span><span class="cx"> scope.name = name;
</span><ins>+
</ins><span class="cx"> if (location)
</span><span class="cx"> scope.location = location;
</span><span class="cx">
</span><ins>+ if (isEmptyObject(object))
+ scope.empty = true;
+
</ins><span class="cx"> return scope;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorprotocolDebuggerjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/protocol/Debugger.json (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/protocol/Debugger.json 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/JavaScriptCore/inspector/protocol/Debugger.json 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -84,7 +84,8 @@
</span><span class="cx"> { "name": "object", "$ref": "Runtime.RemoteObject", "description": "Object representing the scope. For <code>global</code> and <code>with</code> scopes it represents the actual object; for the rest of the scopes, it is artificial transient object enumerating scope variables as its properties." },
</span><span class="cx"> { "name": "type", "type": "string", "enum": ["global", "with", "closure", "catch", "functionName", "globalLexicalEnvironment", "nestedLexical"], "description": "Scope type." },
</span><span class="cx"> { "name": "name", "type": "string", "optional": true, "description": "Name associated with the scope." },
</span><del>- { "name": "location", "$ref": "Location", "optional": true, "description": "Location if available of the scope definition." }
</del><ins>+ { "name": "location", "$ref": "Location", "optional": true, "description": "Location if available of the scope definition." },
+ { "name": "empty", "type": "boolean", "optional": true, "description": "Whether the scope has any variables." }
</ins><span class="cx"> ],
</span><span class="cx"> "description": "Scope description."
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2016-10-24 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Scope chain shouldn't show empty Closure sections
+ https://bugs.webkit.org/show_bug.cgi?id=152348
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/DebuggerManager.js:
+ (WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
+ * UserInterface/Models/ScopeChainNode.js:
+ (WebInspector.ScopeChainNode):
+ (WebInspector.ScopeChainNode.prototype.get empty):
+ Added support for new empty property.
+
+ * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
+ Only create and display a DetailsSection if the scope is not empty (via empty).
+
+2016-10-24 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Improve Quick Open sorting algorithm
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=163705
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersDebuggerManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -686,8 +686,8 @@
</span><span class="cx"> console.error("Unknown type: " + payload.type);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- var object = WebInspector.RemoteObject.fromPayload(payload.object);
- return new WebInspector.ScopeChainNode(type, [object], payload.name, payload.location);
</del><ins>+ let object = WebInspector.RemoteObject.fromPayload(payload.object);
+ return new WebInspector.ScopeChainNode(type, [object], payload.name, payload.location, payload.empty);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _pauseReasonFromPayload(payload)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsScopeChainNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScopeChainNode.js (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ScopeChainNode.js 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScopeChainNode.js 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx">
</span><span class="cx"> WebInspector.ScopeChainNode = class ScopeChainNode extends WebInspector.Object
</span><span class="cx"> {
</span><del>- constructor(type, objects, name, location)
</del><ins>+ constructor(type, objects, name, location, empty)
</ins><span class="cx"> {
</span><span class="cx"> super();
</span><span class="cx">
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> this._objects = objects || [];
</span><span class="cx"> this._name = name || "";
</span><span class="cx"> this._location = location || null;
</span><ins>+ this._empty = empty || false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Public
</span><span class="lines">@@ -47,6 +48,7 @@
</span><span class="cx"> get objects() { return this._objects; }
</span><span class="cx"> get name() { return this._name; }
</span><span class="cx"> get location() { return this._location; }
</span><ins>+ get empty() { return this._empty; }
</ins><span class="cx">
</span><span class="cx"> get hash()
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsScopeChainDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js (207783 => 207784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2016-10-24 21:51:44 UTC (rev 207783)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2016-10-24 22:09:29 UTC (rev 207784)
</span><span class="lines">@@ -168,6 +168,10 @@
</span><span class="cx">
</span><span class="cx"> let scopeChain = callFrame.mergedScopeChain();
</span><span class="cx"> for (let scope of scopeChain) {
</span><ins>+ // Don't show sections for empty scopes unless it is the local scope, since it has "this".
+ if (scope.empty && scope.type !== WebInspector.ScopeChainNode.Type.Local)
+ continue;
+
</ins><span class="cx"> let title = null;
</span><span class="cx"> let extraPropertyDescriptor = null;
</span><span class="cx"> let collapsedByDefault = false;
</span></span></pre>
</div>
</div>
</body>
</html>