<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207640] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207640">207640</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-20 14:00:54 -0700 (Thu, 20 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make table.deleteRow(-1) a no-op when there are no rows
https://bugs.webkit.org/show_bug.cgi?id=163746
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Import test coverage from:
- https://github.com/w3c/web-platform-tests/pull/4001
* web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt:
* web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html:
* web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt:
* web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html:
* web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt:
* web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html:
Source/WebCore:
Make table.deleteRow(-1) a no-op when there are no rows, instead of throwing:
- https://github.com/whatwg/html/pull/1924
This is more consistent with the behavior of tbody.deleteRow(-1) and
tr.deleteCell(-1). This is also consistent with Gecko. Blink is doing the
same change via:
- https://codereview.chromium.org/2427963004/
No new tests, updated existing tests.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::deleteRow):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementremoverowexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementremoverowhtml">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetbodyelementdeleteRowexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetbodyelementdeleteRowhtml">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetrelementdeleteCellexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetrelementdeleteCellhtml">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementcpp">trunk/Source/WebCore/html/HTMLTableElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-10-20 Chris Dumez <cdumez@apple.com>
+
+ Make table.deleteRow(-1) a no-op when there are no rows
+ https://bugs.webkit.org/show_bug.cgi?id=163746
+
+ Reviewed by Alex Christensen.
+
+ Import test coverage from:
+ - https://github.com/w3c/web-platform-tests/pull/4001
+
+ * web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt:
+ * web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html:
+ * web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt:
+ * web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html:
+ * web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt:
+ * web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html:
+
</ins><span class="cx"> 2016-10-19 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Import W3C CSS Shapes tests
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementremoverowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -1,7 +1,8 @@
</span><del>-First column Second column
</del><span class="cx">
</span><span class="cx"> PASS deleteRow function invalid argument
</span><span class="cx"> PASS deleteRow function invalid argument bis
</span><span class="cx"> PASS check normal deleteRow
</span><span class="cx"> PASS check normal deleteRow bis
</span><ins>+PASS deleteRow(-1) with no rows
+PASS deleteRow(0) with no rows
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementremoverowhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -42,9 +42,23 @@
</span><span class="cx"> assert_equals(old_length, el.rows.length);
</span><span class="cx"> }, "check normal deleteRow");
</span><span class="cx"> test(function() {
</span><del>- while (el.rows.length > 1) {
</del><ins>+ assert_equals(el.rows.length, 3);
+ do {
+ var old_length = el.rows.length;
</ins><span class="cx"> el.deleteRow(-1);
</span><del>- }
- assert_equals(1, el.rows.length);
</del><ins>+ assert_equals(el.rows.length, old_length - 1);
+ } while (el.rows.length);
</ins><span class="cx"> }, "check normal deleteRow bis");
</span><ins>+
+test(function() {
+ assert_equals(el.rows.length, 0);
+ el.deleteRow(-1);
+}, 'deleteRow(-1) with no rows');
+
+test(function() {
+ assert_equals(el.rows.length, 0);
+ assert_throws("IndexSizeError", function() {
+ el.deleteRow(0);
+ });
+}, 'deleteRow(0) with no rows');
</ins><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetbodyelementdeleteRowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -4,4 +4,5 @@
</span><span class="cx"> PASS HTMLTableSectionElement deleteRow(rows.length)
</span><span class="cx"> PASS HTMLTableSectionElement deleteRow(-2)
</span><span class="cx"> PASS HTMLTableSectionElement deleteRow(-1) with no rows
</span><ins>+PASS HTMLTableSectionElement deleteRow(0) with no rows
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetbodyelementdeleteRowhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -51,4 +51,11 @@
</span><span class="cx"> assert_equals(tbody.rows.length, 0);
</span><span class="cx"> }, "HTMLTableSectionElement deleteRow(-1) with no rows");
</span><span class="cx">
</span><ins>+test(function () {
+ assert_equals(tbody.rows.length, 0);
+ assert_throws("IndexSizeError", function () {
+ tbody.deleteRow(0);
+ });
+}, "HTMLTableSectionElement deleteRow(0) with no rows");
+
</ins><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetrelementdeleteCellexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -4,4 +4,5 @@
</span><span class="cx"> PASS HTMLTableRowElement deleteCell(-2)
</span><span class="cx"> PASS HTMLTableRowElement deleteCell(cells.length)
</span><span class="cx"> PASS HTMLTableRowElement deleteCell(-1) with no cells
</span><ins>+PASS HTMLTableRowElement deleteCell(0) with no cells
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetrelementdeleteCellhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -51,4 +51,11 @@
</span><span class="cx"> assert_equals(tr.cells.length, 0);
</span><span class="cx"> }, "HTMLTableRowElement deleteCell(-1) with no cells");
</span><span class="cx">
</span><ins>+test(function () {
+ assert_equals(tr.cells.length, 0);
+ assert_throws("IndexSizeError", function () {
+ tr.deleteCell(0);
+ });
+}, "HTMLTableRowElement deleteCell(0) with no cells");
+
</ins><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/Source/WebCore/ChangeLog 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-10-20 Chris Dumez <cdumez@apple.com>
+
+ Make table.deleteRow(-1) a no-op when there are no rows
+ https://bugs.webkit.org/show_bug.cgi?id=163746
+
+ Reviewed by Alex Christensen.
+
+ Make table.deleteRow(-1) a no-op when there are no rows, instead of throwing:
+ - https://github.com/whatwg/html/pull/1924
+
+ This is more consistent with the behavior of tbody.deleteRow(-1) and
+ tr.deleteCell(-1). This is also consistent with Gecko. Blink is doing the
+ same change via:
+ - https://codereview.chromium.org/2427963004/
+
+ No new tests, updated existing tests.
+
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::deleteRow):
+
</ins><span class="cx"> 2016-10-20 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Make sure to handle prefixed transform-style
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (207639 => 207640)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.cpp 2016-10-20 20:28:17 UTC (rev 207639)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp 2016-10-20 21:00:54 UTC (rev 207640)
</span><span class="lines">@@ -250,19 +250,21 @@
</span><span class="cx"> void HTMLTableElement::deleteRow(int index, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> HTMLTableRowElement* row = nullptr;
</span><del>- if (index == -1)
</del><ins>+ if (index == -1) {
</ins><span class="cx"> row = HTMLTableRowsCollection::lastRow(*this);
</span><del>- else {
</del><ins>+ if (!row)
+ return;
+ } else {
</ins><span class="cx"> for (int i = 0; i <= index; ++i) {
</span><span class="cx"> row = HTMLTableRowsCollection::rowAfter(*this, row);
</span><span class="cx"> if (!row)
</span><span class="cx"> break;
</span><span class="cx"> }
</span><ins>+ if (!row) {
+ ec = INDEX_SIZE_ERR;
+ return;
+ }
</ins><span class="cx"> }
</span><del>- if (!row) {
- ec = INDEX_SIZE_ERR;
- return;
- }
</del><span class="cx"> row->remove(ec);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>