<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207571] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207571">207571</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-19 15:06:47 -0700 (Wed, 19 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Annotate more DOM and HTML IDLs with CEReactions
https://bugs.webkit.org/show_bug.cgi?id=163653
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaselined the tests now that more test cases are passing.
* web-platform-tests/custom-elements/attribute-changed-callback-expected.txt:
* web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt:
* web-platform-tests/custom-elements/reactions/Document-expected.txt:
* web-platform-tests/custom-elements/reactions/Element-expected.txt:
* web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt:
* web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt:
* web-platform-tests/custom-elements/reactions/Selection-expected.txt:
Source/WebCore:
Added CEReactions to more IDL files.
Test: fast/custom-elements/reactions-for-webkit-extensions.html
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty): Instantiate CustomElementReactionStack, which is equivalent to
adding CEReactions in IDL.
(WebCore::JSDOMStringMap::putDelegate): Ditto.
* dom/Document.idl:
* dom/Element.idl:
* html/HTMLElement.idl:
* page/DOMSelection.idl:
LayoutTests:
Added a regression test to make sure webkitdropzone IDL attribute on HTMLElement
honors CEReactions semantics using the web-platform-tests' infrastructure I added.
* fast/custom-elements/reactions-for-webkit-extensions-expected.txt: Added.
* fast/custom-elements/reactions-for-webkit-extensions.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsattributechangedcallbackexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsDOMStringMapexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsDocumentexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsElementexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsElementContentEditableexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsHTMLElementexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsSelectionexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMStringMapCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementidl">trunk/Source/WebCore/html/HTMLElement.idl</a></li>
<li><a href="#trunkSourceWebCorepageDOMSelectionidl">trunk/Source/WebCore/page/DOMSelection.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcustomelementsreactionsforwebkitextensionsexpectedtxt">trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcustomelementsreactionsforwebkitextensionshtml">trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/ChangeLog 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-10-19 Ryosuke Niwa <rniwa@webkit.org>
+
+ Annotate more DOM and HTML IDLs with CEReactions
+ https://bugs.webkit.org/show_bug.cgi?id=163653
+
+ Reviewed by Darin Adler.
+
+ Added a regression test to make sure webkitdropzone IDL attribute on HTMLElement
+ honors CEReactions semantics using the web-platform-tests' infrastructure I added.
+
+ * fast/custom-elements/reactions-for-webkit-extensions-expected.txt: Added.
+ * fast/custom-elements/reactions-for-webkit-extensions.html: Added.
+
</ins><span class="cx"> 2016-10-19 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r207557.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcustomelementsreactionsforwebkitextensionsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt (0 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+
+PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when adding webkitdropzone content attribute
+PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcustomelementsreactionsforwebkitextensionshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html (0 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html (rev 0)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>Custom Elements: CEReactions on Attr interface</title>
+<meta name="author" title="Ryosuke Niwa" href="mailto:rniwa@webkit.org">
+<meta name="assert" content="value of Attr interface must have CEReactions">
+<meta name="help" content="https://dom.spec.whatwg.org/#node">
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../../imported/w3c/web-platform-tests/custom-elements/resources/custom-elements-helpers.js"></script>
+<script src="../../imported/w3c/web-platform-tests/custom-elements/reactions/resources/reactions.js"></script>
+</head>
+<body>
+<div id="log"></div>
+<script>
+
+testReflectAttribute('webkitdropzone', 'webkitdropzone', 'copy', 'move', 'dropzone on HTMLElement');
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-10-19 Ryosuke Niwa <rniwa@webkit.org>
+
+ Annotate more DOM and HTML IDLs with CEReactions
+ https://bugs.webkit.org/show_bug.cgi?id=163653
+
+ Reviewed by Darin Adler.
+
+ Rebaselined the tests now that more test cases are passing.
+
+ * web-platform-tests/custom-elements/attribute-changed-callback-expected.txt:
+ * web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt:
+ * web-platform-tests/custom-elements/reactions/Document-expected.txt:
+ * web-platform-tests/custom-elements/reactions/Element-expected.txt:
+ * web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt:
+ * web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt:
+ * web-platform-tests/custom-elements/reactions/Selection-expected.txt:
+
</ins><span class="cx"> 2016-10-19 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Import encoding web-platform-tests
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsattributechangedcallbackexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -8,5 +8,5 @@
</span><span class="cx"> PASS Mutating observedAttributes after calling customElements.define must not affect the set of attributes for which attributedChangedCallback is invoked
</span><span class="cx"> PASS attributedChangedCallback must be enqueued for attributes specified in a non-Array iterable observedAttributes
</span><span class="cx"> FAIL attributedChangedCallback must be enqueued for style attribute change by mutating inline style declaration assert_equals: expected 1 but got 0
</span><del>-FAIL attributedChangedCallback must not be enqueued when mutating inline style declaration if the style attribute is not observed undefined is not an object (evaluating 'log.type')
</del><ins>+PASS attributedChangedCallback must not be enqueued when mutating inline style declaration if the style attribute is not observed
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsDOMStringMapexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,10 +1,10 @@
</span><span class="cx">
</span><del>-FAIL setter on DOMStringMap must enqueue an attributeChanged reaction when adding an observed data attribute assert_array_equals: lengths differ, expected 1 got 0
</del><ins>+PASS setter on DOMStringMap must enqueue an attributeChanged reaction when adding an observed data attribute
</ins><span class="cx"> PASS setter on DOMStringMap must not enqueue an attributeChanged reaction when adding an unobserved data attribute
</span><del>-FAIL setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value assert_array_equals: lengths differ, expected 2 got 1
</del><ins>+PASS setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute
+PASS setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value
</ins><span class="cx"> PASS setter on DOMStringMap must not enqueue an attributeChanged reaction when mutating the value of an unobserved data attribute
</span><del>-FAIL deleter on DOMStringMap must enqueue an attributeChanged reaction when removing an observed data attribute assert_array_equals: lengths differ, expected 2 got 1
</del><ins>+PASS deleter on DOMStringMap must enqueue an attributeChanged reaction when removing an observed data attribute
</ins><span class="cx"> PASS deleter on DOMStringMap must not enqueue an attributeChanged reaction when removing an unobserved data attribute
</span><span class="cx"> PASS deleter on DOMStringMap must not enqueue an attributeChanged reaction when it does not remove a data attribute
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsDocumentexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><span class="cx"> FAIL importNode on Document must construct a new custom element when importing a custom element assert_array_equals: lengths differ, expected 1 got 0
</span><span class="cx"> PASS adoptNode on Document must enqueue an adopted reaction when importing a custom element
</span><del>-FAIL execCommand on Document must enqueue a disconnected reaction when deleting a custom element from a contenteditable element assert_array_equals: lengths differ, expected 1 got 0
</del><ins>+PASS execCommand on Document must enqueue a disconnected reaction when deleting a custom element from a contenteditable element
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsElementexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -32,12 +32,12 @@
</span><span class="cx"> PASS removeAttributeNode on Element must not enqueue an attributeChanged reaction when removing an existing unobserved attribute
</span><span class="cx"> PASS insertAdjacentElement on Element must enqueue a connected reaction
</span><span class="cx"> PASS insertAdjacentElement on Element must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document
</span><del>-FAIL innerHTML on Element must enqueue a connected reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 2 got 1
-FAIL innerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 3 got 1
-FAIL innerHTML on Element must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
-FAIL outerHTML on Element must enqueue a connected reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 2 got 1
-FAIL outerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 3 got 1
-FAIL outerHTML on Element must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
-FAIL insertAdjacentHTML on Element must enqueue a connected reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 2 got 1
-FAIL insertAdjacentHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 3 got 1
</del><ins>+PASS innerHTML on Element must enqueue a connected reaction for a newly constructed custom element
+PASS innerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element
+PASS innerHTML on Element must enqueue a disconnected reaction
+PASS outerHTML on Element must enqueue a connected reaction for a newly constructed custom element
+PASS outerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element
+PASS outerHTML on Element must enqueue a disconnected reaction
+PASS insertAdjacentHTML on Element must enqueue a connected reaction for a newly constructed custom element
+PASS insertAdjacentHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsElementContentEditableexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx">
</span><del>-FAIL contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when adding contenteditable content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
</del><ins>+PASS contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when adding contenteditable content attribute
+PASS contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when replacing an existing attribute
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsHTMLElementexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,26 +1,26 @@
</span><span class="cx">
</span><del>-FAIL title on HTMLElement must enqueue an attributeChanged reaction when adding title content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL title on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL lang on HTMLElement must enqueue an attributeChanged reaction when adding lang content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL lang on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL translate on HTMLElement must enqueue an attributeChanged reaction when adding translate content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL translate on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL dir on HTMLElement must enqueue an attributeChanged reaction when adding dir content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL dir on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL hidden on HTMLElement must enqueue an attributeChanged reaction when adding hidden content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL hidden on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL tabIndex on HTMLElement must enqueue an attributeChanged reaction when adding tabindex content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL tabIndex on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL accessKey on HTMLElement must enqueue an attributeChanged reaction when adding accesskey content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL accessKey on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL draggable on HTMLElement must enqueue an attributeChanged reaction when adding draggable content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL draggable on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
</del><ins>+PASS title on HTMLElement must enqueue an attributeChanged reaction when adding title content attribute
+PASS title on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS lang on HTMLElement must enqueue an attributeChanged reaction when adding lang content attribute
+PASS lang on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS translate on HTMLElement must enqueue an attributeChanged reaction when adding translate content attribute
+PASS translate on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS dir on HTMLElement must enqueue an attributeChanged reaction when adding dir content attribute
+PASS dir on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS hidden on HTMLElement must enqueue an attributeChanged reaction when adding hidden content attribute
+PASS hidden on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS tabIndex on HTMLElement must enqueue an attributeChanged reaction when adding tabindex content attribute
+PASS tabIndex on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS accessKey on HTMLElement must enqueue an attributeChanged reaction when adding accesskey content attribute
+PASS accessKey on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS draggable on HTMLElement must enqueue an attributeChanged reaction when adding draggable content attribute
+PASS draggable on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
</ins><span class="cx"> FAIL dropzone on HTMLElement must enqueue an attributeChanged reaction when adding dropzone content attribute assert_array_equals: lengths differ, expected 1 got 0
</span><span class="cx"> FAIL dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
</span><span class="cx"> FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when adding contextmenu content attribute assert_array_equals: lengths differ, expected 1 got 0
</span><span class="cx"> FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
</span><del>-FAIL spellcheck on HTMLElement must enqueue an attributeChanged reaction when adding spellcheck content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL spellcheck on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL innerText on HTMLElement must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
-FAIL outerText on HTMLElement must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
</del><ins>+PASS spellcheck on HTMLElement must enqueue an attributeChanged reaction when adding spellcheck content attribute
+PASS spellcheck on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
+PASS innerText on HTMLElement must enqueue a disconnected reaction
+PASS outerText on HTMLElement must enqueue a disconnected reaction
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscustomelementsreactionsSelectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,3 +1,3 @@
</span><span class="cx">
</span><del>-FAIL deleteFromDocument on Selection must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
</del><ins>+PASS deleteFromDocument on Selection must enqueue a disconnected reaction
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/ChangeLog 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-10-19 Ryosuke Niwa <rniwa@webkit.org>
+
+ Annotate more DOM and HTML IDLs with CEReactions
+ https://bugs.webkit.org/show_bug.cgi?id=163653
+
+ Reviewed by Darin Adler.
+
+ Added CEReactions to more IDL files.
+
+ Test: fast/custom-elements/reactions-for-webkit-extensions.html
+
+ * bindings/js/JSDOMStringMapCustom.cpp:
+ (WebCore::JSDOMStringMap::deleteProperty): Instantiate CustomElementReactionStack, which is equivalent to
+ adding CEReactions in IDL.
+ (WebCore::JSDOMStringMap::putDelegate): Ditto.
+ * dom/Document.idl:
+ * dom/Element.idl:
+ * html/HTMLElement.idl:
+ * page/DOMSelection.idl:
+
</ins><span class="cx"> 2016-10-19 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r207557.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMStringMapCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSDOMStringMap.h"
</span><span class="cx">
</span><ins>+#include "CustomElementReactionQueue.h"
</ins><span class="cx"> #include "DOMStringMap.h"
</span><span class="cx"> #include "JSNode.h"
</span><span class="cx"> #include <runtime/IdentifierInlines.h>
</span><span class="lines">@@ -62,6 +63,10 @@
</span><span class="cx">
</span><span class="cx"> bool JSDOMStringMap::deleteProperty(JSCell* cell, ExecState* exec, PropertyName propertyName)
</span><span class="cx"> {
</span><ins>+#if ENABLE(CUSTOM_ELEMENTS)
+ CustomElementReactionStack customElementReactionStack;
+#endif
+
</ins><span class="cx"> JSDOMStringMap* thisObject = jsCast<JSDOMStringMap*>(cell);
</span><span class="cx"> if (propertyName.isSymbol())
</span><span class="cx"> return Base::deleteProperty(thisObject, exec, propertyName);
</span><span class="lines">@@ -81,6 +86,10 @@
</span><span class="cx"> if (propertyName.isSymbol())
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+#if ENABLE(CUSTOM_ELEMENTS)
+ CustomElementReactionStack customElementReactionStack;
+#endif
+
</ins><span class="cx"> String stringValue = value.toString(exec)->value(exec);
</span><span class="cx"> RETURN_IF_EXCEPTION(scope, false);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/dom/Document.idl 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx"> [MayThrowException] XPathResult evaluate(optional DOMString expression = "undefined", optional Node? contextNode, optional XPathNSResolver? resolver, optional unsigned short type = 0, optional XPathResult? inResult);
</span><span class="cx">
</span><span class="cx"> // FIXME: The default value for the last parameter should be the empty string.
</span><del>- boolean execCommand(DOMString command, optional boolean userInterface = false, optional DOMString? value = null);
</del><ins>+ [CEReactions] boolean execCommand(DOMString command, optional boolean userInterface = false, optional DOMString? value = null);
</ins><span class="cx">
</span><span class="cx"> boolean queryCommandEnabled(DOMString command);
</span><span class="cx"> boolean queryCommandIndeterm(DOMString command);
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/dom/Element.idl 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -97,8 +97,8 @@
</span><span class="cx"> sequence<DOMString> getAttributeNames();
</span><span class="cx">
</span><span class="cx"> HTMLCollection getElementsByClassName(DOMString name);
</span><del>- [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerHTML;
- [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString outerHTML;
</del><ins>+ [CEReactions, TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerHTML;
+ [CEReactions, TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString outerHTML;
</ins><span class="cx">
</span><span class="cx"> [CEReactions, Reflect=class] attribute DOMString className;
</span><span class="cx"> [PutForwards=value] readonly attribute DOMTokenList classList;
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> [CEReactions, MayThrowLegacyException] Element insertAdjacentElement(DOMString where, Element element);
</span><del>- [MayThrowLegacyException] void insertAdjacentHTML(DOMString where, DOMString html);
</del><ins>+ [CEReactions, MayThrowLegacyException] void insertAdjacentHTML(DOMString where, DOMString html);
</ins><span class="cx"> [MayThrowLegacyException] void insertAdjacentText(DOMString where, DOMString text);
</span><span class="cx">
</span><span class="cx"> [Conditional=POINTER_LOCK] void requestPointerLock();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.idl (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.idl 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/html/HTMLElement.idl 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -26,28 +26,28 @@
</span><span class="cx"> JSCustomPushEventHandlerScope,
</span><span class="cx"> ExportMacro=WEBCORE_EXPORT,
</span><span class="cx"> ] interface HTMLElement : Element {
</span><del>- [Reflect] attribute DOMString title;
- [Reflect] attribute DOMString lang;
- attribute boolean translate;
- attribute DOMString dir;
</del><ins>+ [CEReactions, Reflect] attribute DOMString title;
+ [CEReactions, Reflect] attribute DOMString lang;
+ [CEReactions] attribute boolean translate;
+ [CEReactions] attribute DOMString dir;
</ins><span class="cx">
</span><del>- attribute long tabIndex;
- attribute boolean draggable;
</del><ins>+ [CEReactions] attribute long tabIndex;
+ [CEReactions] attribute boolean draggable;
</ins><span class="cx">
</span><del>- [Reflect] attribute DOMString webkitdropzone;
</del><ins>+ [CEReactions, Reflect] attribute DOMString webkitdropzone;
</ins><span class="cx"> // FIXME: Support the standard HTML equivalent.
</span><span class="cx"> // [PutForwards=value] readonly attribute DOMTokenList dropzone;
</span><span class="cx">
</span><del>- [Reflect] attribute boolean hidden;
- [Reflect] attribute DOMString accessKey;
</del><ins>+ [CEReactions, Reflect] attribute boolean hidden;
+ [CEReactions, Reflect] attribute DOMString accessKey;
</ins><span class="cx">
</span><del>- [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerText;
- [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString outerText;
</del><ins>+ [CEReactions, SetterMayThrowLegacyException, TreatNullAs=EmptyString] attribute DOMString innerText;
+ [CEReactions, SetterMayThrowLegacyException, TreatNullAs=EmptyString] attribute DOMString outerText;
</ins><span class="cx">
</span><del>- [SetterMayThrowLegacyException] attribute DOMString contentEditable;
</del><ins>+ [CEReactions, SetterMayThrowLegacyException] attribute DOMString contentEditable;
</ins><span class="cx"> readonly attribute boolean isContentEditable;
</span><span class="cx">
</span><del>- attribute boolean spellcheck;
</del><ins>+ [CEReactions] attribute boolean spellcheck;
</ins><span class="cx">
</span><span class="cx"> void click();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMSelectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMSelection.idl (207570 => 207571)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMSelection.idl 2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/page/DOMSelection.idl 2016-10-19 22:06:47 UTC (rev 207571)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> [MayThrowException] void collapseToEnd();
</span><span class="cx"> [MayThrowException] void collapseToStart();
</span><span class="cx">
</span><del>- void deleteFromDocument();
</del><ins>+ [CEReactions] void deleteFromDocument();
</ins><span class="cx"> boolean containsNode(Node node, optional boolean allowPartial = false);
</span><span class="cx"> void selectAllChildren(Node node);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>