<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207542] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207542">207542</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2016-10-19 10:18:27 -0700 (Wed, 19 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Xcode] JavaScriptCore fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
https://bugs.webkit.org/show_bug.cgi?id=163642
Reviewed by Darin Adler.
* API/JSClassRef.cpp: Removed a bad headerdoc comment inside an implementation file.
* API/JSContext.h: Changed @methodgroup to @functiongroup, because the compiler requires the
former to be followed by a method (and we have a property), but not the latter. Changed
a couple of instances of “method” to “@method”. Removed empty @param entries.
* API/JSContextRefInternal.h: Named a parameter referenced in a @param entry.
* API/JSContextRefPrivate.h: Ditto.
* API/JSManagedValue.h: Removed empty @param entries.
* API/JSObjectRef.h: Corrected parameter name in @param entry.
* API/JSTypedArray.h: Ditto.
* API/JSValue.h: Removed empty @param entries, changed @methodgroup to @functiongroup, and
changed @method to @property where appropriate. Removed empty @param entries.
* API/JSValueRef.h: Named a parameter referenced in a @param entry.
* API/JSWeakObjectMapRefPrivate.h: Ditto.
* Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS. Made the compiler
treat the icu headers as system headers, to stop it from emitting warnings about headers
we don’t want to change.
* Configurations/ToolExecutable.xcconfig: Made the compiler treat the icu headers as system
headers.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPIJSClassRefcpp">trunk/Source/JavaScriptCore/API/JSClassRef.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSContexth">trunk/Source/JavaScriptCore/API/JSContext.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSContextRefInternalh">trunk/Source/JavaScriptCore/API/JSContextRefInternal.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSContextRefPrivateh">trunk/Source/JavaScriptCore/API/JSContextRefPrivate.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSManagedValueh">trunk/Source/JavaScriptCore/API/JSManagedValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSObjectRefh">trunk/Source/JavaScriptCore/API/JSObjectRef.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSTypedArrayh">trunk/Source/JavaScriptCore/API/JSTypedArray.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSValueh">trunk/Source/JavaScriptCore/API/JSValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSValueRefh">trunk/Source/JavaScriptCore/API/JSValueRef.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSWeakObjectMapRefPrivateh">trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsBasexcconfig">trunk/Source/JavaScriptCore/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsToolExecutablexcconfig">trunk/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPIJSClassRefcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSClassRef.cpp (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSClassRef.cpp 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSClassRef.cpp 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -174,14 +174,6 @@
</span><span class="cx"> return contextData(exec).staticFunctions.get();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-/*!
-// Doc here in case we make this public. (Hopefully we won't.)
-@function
- @abstract Returns the prototype that will be used when constructing an object with a given class.
- @param ctx The execution context to use.
- @param jsClass A JSClass whose prototype you want to get.
- @result The JSObject prototype that was automatically generated for jsClass, or NULL if no prototype was automatically generated. This is the prototype that will be used when constructing an object using jsClass.
-*/
</del><span class="cx"> JSObject* OpaqueJSClass::prototype(ExecState* exec)
</span><span class="cx"> {
</span><span class="cx"> /* Class (C++) and prototype (JS) inheritance are parallel, so:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSContext.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSContext.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSContext.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -125,8 +125,9 @@
</span><span class="cx"> + (NSArray *)currentArguments;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@methodgroup Global Properties
</del><ins>+@functiongroup Global Properties
</ins><span class="cx"> */
</span><ins>+
</ins><span class="cx"> /*!
</span><span class="cx"> @property
</span><span class="cx"> @abstract Get the global object of the context.
</span><span class="lines">@@ -197,18 +198,15 @@
</span><span class="cx"> @interface JSContext (SubscriptSupport)
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-method
</del><ins>+@method
</ins><span class="cx"> @abstract Get a particular property on the global object.
</span><del>-@param key
</del><span class="cx"> @result The JSValue for the global object's property.
</span><span class="cx"> */
</span><span class="cx"> - (JSValue *)objectForKeyedSubscript:(id)key;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-method
</del><ins>+@method
</ins><span class="cx"> @abstract Set a particular property on the global object.
</span><del>-@param object
-@param key
</del><span class="cx"> */
</span><span class="cx"> - (void)setObject:(id)object forKeyedSubscript:(NSObject <NSCopying> *)key;
</span><span class="cx">
</span><span class="lines">@@ -223,7 +221,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JSContext, wrapping its C API counterpart.
</span><del>-@param jsGlobalContextRef
</del><span class="cx"> @result The JSContext equivalent of the provided JSGlobalContextRef.
</span><span class="cx"> */
</span><span class="cx"> + (JSContext *)contextWithJSGlobalContextRef:(JSGlobalContextRef)jsGlobalContextRef;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSContextRefInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSContextRefInternal.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSContextRefInternal.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSContextRefInternal.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> @param ctx The JSGlobalContext that you want to change.
</span><span class="cx"> @param runLoop The new value of the setting for the context.
</span><span class="cx"> */
</span><del>-JS_EXPORT void JSGlobalContextSetDebuggerRunLoop(JSGlobalContextRef ctx, CFRunLoopRef) CF_AVAILABLE(10_10, 8_0);
</del><ins>+JS_EXPORT void JSGlobalContextSetDebuggerRunLoop(JSGlobalContextRef ctx, CFRunLoopRef runLoop) CF_AVAILABLE(10_10, 8_0);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #ifdef __cplusplus
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSContextRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSContextRefPrivate.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSContextRefPrivate.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSContextRefPrivate.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> need to call JSContextGroupSetExecutionTimeLimit before you start executing
</span><span class="cx"> any scripts.
</span><span class="cx"> */
</span><del>-JS_EXPORT void JSContextGroupSetExecutionTimeLimit(JSContextGroupRef, double limit, JSShouldTerminateCallback, void* context) CF_AVAILABLE(10_6, 7_0);
</del><ins>+JS_EXPORT void JSContextGroupSetExecutionTimeLimit(JSContextGroupRef group, double limit, JSShouldTerminateCallback callback, void* context) CF_AVAILABLE(10_6, 7_0);
</ins><span class="cx">
</span><span class="cx"> /*!
</span><span class="cx"> @function
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> @abstract Clears the script execution time limit.
</span><span class="cx"> @param group The JavaScript context group that the time limit is cleared on.
</span><span class="cx"> */
</span><del>-JS_EXPORT void JSContextGroupClearExecutionTimeLimit(JSContextGroupRef) CF_AVAILABLE(10_6, 7_0);
</del><ins>+JS_EXPORT void JSContextGroupClearExecutionTimeLimit(JSContextGroupRef group) CF_AVAILABLE(10_6, 7_0);
</ins><span class="cx">
</span><span class="cx"> /*!
</span><span class="cx"> @function
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> @function
</span><span class="cx"> @abstract Sets the include native call stack when reporting exceptions setting for a context.
</span><span class="cx"> @param ctx The JSGlobalContext that you want to change.
</span><del>-@param includeNativeCallStack The new value of the setting for the context.
</del><ins>+@param includesNativeCallStack The new value of the setting for the context.
</ins><span class="cx"> */
</span><span class="cx"> JS_EXPORT void JSGlobalContextSetIncludesNativeCallStackWhenReportingExceptions(JSGlobalContextRef ctx, bool includesNativeCallStack) CF_AVAILABLE(10_10, 8_0);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSManagedValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSManagedValue.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSManagedValue.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSManagedValue.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -54,7 +54,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JSManagedValue from a JSValue.
</span><del>-@param value
</del><span class="cx"> @result The new JSManagedValue.
</span><span class="cx"> */
</span><span class="cx"> + (JSManagedValue *)managedValueWithValue:(JSValue *)value;
</span><span class="lines">@@ -63,7 +62,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JSManagedValue.
</span><del>-@param value
</del><span class="cx"> @result The new JSManagedValue.
</span><span class="cx"> */
</span><span class="cx"> - (instancetype)initWithValue:(JSValue *)value;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSObjectRefh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSObjectRef.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSObjectRef.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSObjectRef.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx"> @abstract The callback invoked when collecting the names of an object's properties.
</span><span class="cx"> @param ctx The execution context to use.
</span><span class="cx"> @param object The JSObject whose property names are being collected.
</span><del>-@param accumulator A JavaScript property name accumulator in which to accumulate the names of object's properties.
</del><ins>+@param propertyNames A JavaScript property name accumulator in which to accumulate the names of object's properties.
</ins><span class="cx"> @discussion If you named your function GetPropertyNames, you would declare it like this:
</span><span class="cx">
</span><span class="cx"> void GetPropertyNames(JSContextRef ctx, JSObjectRef object, JSPropertyNameAccumulatorRef propertyNames);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSTypedArrayh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSTypedArray.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSTypedArray.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSTypedArray.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> /*!
</span><span class="cx"> @function
</span><span class="cx"> @abstract Returns a pointer to the data buffer that serves as the backing store for a JavaScript Typed Array object.
</span><del>- @param buffer The Array Buffer object whose internal backing store pointer to return.
</del><ins>+ @param object The Array Buffer object whose internal backing store pointer to return.
</ins><span class="cx"> @param exception A pointer to a JSValueRef in which to store an exception, if any. Pass NULL if you do not care to store an exception.
</span><span class="cx"> @result A pointer to the raw data buffer that serves as object's backing store or NULL if object is not an Array Buffer object.
</span><span class="cx"> @discussion The pointer returned by this function is temporary and is not guaranteed to remain valid across JavaScriptCore API calls.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSValue.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSValue.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSValue.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -68,7 +68,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JavaScript value from a BOOL primitive.
</span><del>-@param value
</del><span class="cx"> @param context The JSContext in which the resulting JSValue will be created.
</span><span class="cx"> @result The new JSValue representing the equivalent boolean value.
</span><span class="cx"> */
</span><span class="lines">@@ -77,7 +76,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JavaScript value from a double primitive.
</span><del>-@param value
</del><span class="cx"> @param context The JSContext in which the resulting JSValue will be created.
</span><span class="cx"> @result The new JSValue representing the equivalent boolean value.
</span><span class="cx"> */
</span><span class="lines">@@ -86,7 +84,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JavaScript value from an <code>int32_t</code> primitive.
</span><del>-@param value
</del><span class="cx"> @param context The JSContext in which the resulting JSValue will be created.
</span><span class="cx"> @result The new JSValue representing the equivalent boolean value.
</span><span class="cx"> */
</span><span class="lines">@@ -95,7 +92,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Create a JavaScript value from a <code>uint32_t</code> primitive.
</span><del>-@param value
</del><span class="cx"> @param context The JSContext in which the resulting JSValue will be created.
</span><span class="cx"> @result The new JSValue representing the equivalent boolean value.
</span><span class="cx"> */
</span><span class="lines">@@ -364,28 +360,29 @@
</span><span class="cx"> - (void)setValue:(id)value atIndex:(NSUInteger)index;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@methodgroup Checking JavaScript Types
</del><ins>+@functiongroup Checking JavaScript Types
</ins><span class="cx"> */
</span><ins>+
</ins><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue corresponds to the JavaScript value <code>undefined</code>.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isUndefined;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue corresponds to the JavaScript value <code>null</code>.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isNull;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue is a boolean.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isBoolean;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue is a number.
</span><span class="cx"> @discussion In JavaScript, there is no differentiation between types of numbers.
</span><span class="cx"> Semantically all numbers behave like doubles except in special cases like bit
</span><span class="lines">@@ -394,25 +391,25 @@
</span><span class="cx"> @property (readonly) BOOL isNumber;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue is a string.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isString;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue is an object.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isObject;
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue is an array.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isArray NS_AVAILABLE(10_11, 9_0);
</span><span class="cx">
</span><span class="cx"> /*!
</span><del>-@method
</del><ins>+@property
</ins><span class="cx"> @abstract Check if a JSValue is a date.
</span><span class="cx"> */
</span><span class="cx"> @property (readonly) BOOL isDate NS_AVAILABLE(10_11, 9_0);
</span><span class="lines">@@ -592,8 +589,6 @@
</span><span class="cx"> /*!
</span><span class="cx"> @method
</span><span class="cx"> @abstract Creates a JSValue, wrapping its C API counterpart.
</span><del>-@param value
-@param context
</del><span class="cx"> @result The Objective-C API equivalent of the specified JSValueRef.
</span><span class="cx"> */
</span><span class="cx"> + (JSValue *)valueWithJSValueRef:(JSValueRef)value inContext:(JSContext *)context;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSValueRefh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSValueRef.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSValueRef.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSValueRef.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> @param value The JSValue whose type you want to obtain.
</span><span class="cx"> @result A value of type JSType that identifies value's type.
</span><span class="cx"> */
</span><del>-JS_EXPORT JSType JSValueGetType(JSContextRef ctx, JSValueRef);
</del><ins>+JS_EXPORT JSType JSValueGetType(JSContextRef ctx, JSValueRef value);
</ins><span class="cx">
</span><span class="cx"> /*!
</span><span class="cx"> @function
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSWeakObjectMapRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> @param key The key to associate a weak reference with.
</span><span class="cx"> @param object The user defined object to associate with the key.
</span><span class="cx"> */
</span><del>-JS_EXPORT void JSWeakObjectMapSet(JSContextRef ctx, JSWeakObjectMapRef map, void* key, JSObjectRef);
</del><ins>+JS_EXPORT void JSWeakObjectMapSet(JSContextRef ctx, JSWeakObjectMapRef map, void* key, JSObjectRef object);
</ins><span class="cx">
</span><span class="cx"> /*!
</span><span class="cx"> @function
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-10-19 Dan Bernstein <mitz@apple.com>
+
+ [Xcode] JavaScriptCore fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=163642
+
+ Reviewed by Darin Adler.
+
+ * API/JSClassRef.cpp: Removed a bad headerdoc comment inside an implementation file.
+ * API/JSContext.h: Changed @methodgroup to @functiongroup, because the compiler requires the
+ former to be followed by a method (and we have a property), but not the latter. Changed
+ a couple of instances of “method” to “@method”. Removed empty @param entries.
+ * API/JSContextRefInternal.h: Named a parameter referenced in a @param entry.
+ * API/JSContextRefPrivate.h: Ditto.
+ * API/JSManagedValue.h: Removed empty @param entries.
+ * API/JSObjectRef.h: Corrected parameter name in @param entry.
+ * API/JSTypedArray.h: Ditto.
+ * API/JSValue.h: Removed empty @param entries, changed @methodgroup to @functiongroup, and
+ changed @method to @property where appropriate. Removed empty @param entries.
+ * API/JSValueRef.h: Named a parameter referenced in a @param entry.
+ * API/JSWeakObjectMapRefPrivate.h: Ditto.
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS. Made the compiler
+ treat the icu headers as system headers, to stop it from emitting warnings about headers
+ we don’t want to change.
+ * Configurations/ToolExecutable.xcconfig: Made the compiler treat the icu headers as system
+ headers.
+
</ins><span class="cx"> 2016-10-19 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed ARM buildfix after r207475.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/Base.xcconfig (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/Base.xcconfig 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/Configurations/Base.xcconfig 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -77,6 +77,7 @@
</span><span class="cx"> GCC_WARN_UNINITIALIZED_AUTOS = YES;
</span><span class="cx"> GCC_WARN_UNUSED_FUNCTION = YES;
</span><span class="cx"> GCC_WARN_UNUSED_VARIABLE = YES;
</span><ins>+CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
</ins><span class="cx"> PREBINDING = NO;
</span><span class="cx"> WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough;
</span><span class="cx">
</span><span class="lines">@@ -86,7 +87,7 @@
</span><span class="cx"> LLVM_SYSTEM_HEADER_PATH[sdk=macosx*] = /usr/local/LLVMForJavaScriptCore/include;
</span><span class="cx"> LLVM_SYSTEM_HEADER_PATH[sdk=iphoneos*] = /usr/local/include;
</span><span class="cx">
</span><del>-HEADER_SEARCH_PATHS = . icu $(LLVM_LOCAL_HEADER_PATH) "${BUILT_PRODUCTS_DIR}/ExtraIncludesForLocalLLVMBuild" $(LLVM_SYSTEM_HEADER_PATH) "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
</del><ins>+HEADER_SEARCH_PATHS = . $(LLVM_LOCAL_HEADER_PATH) "${BUILT_PRODUCTS_DIR}/ExtraIncludesForLocalLLVMBuild" $(LLVM_SYSTEM_HEADER_PATH) "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
</ins><span class="cx">
</span><span class="cx"> TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
</span><span class="cx"> TARGET_MAC_OS_X_VERSION_MAJOR_10 = 101000;
</span><span class="lines">@@ -137,8 +138,8 @@
</span><span class="cx">
</span><span class="cx"> SDKROOT = macosx.internal;
</span><span class="cx">
</span><del>-OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
-OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
</del><ins>+OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
+OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS) -isystem icu;
</ins><span class="cx"> OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
</span><span class="cx">
</span><span class="cx"> WK_EMPTY_ = YES;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsToolExecutablexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig (207541 => 207542)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig 2016-10-19 16:57:31 UTC (rev 207541)
+++ trunk/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig 2016-10-19 17:18:27 UTC (rev 207542)
</span><span class="lines">@@ -47,8 +47,8 @@
</span><span class="cx"> CLANG_ENABLE_OBJC_ARC_armv7s = YES;
</span><span class="cx"> CLANG_ENABLE_OBJC_ARC_arm64 = YES;
</span><span class="cx">
</span><del>-OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
-OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
</del><ins>+OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
+OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS) -isystem icu;
</ins><span class="cx"> OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
</span><span class="cx">
</span><span class="cx"> // Explicitly add the PrivateHeaders directory to the search path so that generated header files can be found in production builds.
</span></span></pre>
</div>
</div>
</body>
</html>