<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207483] trunk/Source/WebKit/mac</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207483">207483</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2016-10-18 13:30:53 -0700 (Tue, 18 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Showing and hiding candidates list is very distracting after selecting word
https://bugs.webkit.org/show_bug.cgi?id=163609
<rdar://problem/28747712>
Reviewed by Tim Horton.
Introduce WebView hooks for mousedown and mouseup. See radar for more details.
* WebView/WebHTMLView.mm:
(-[WebHTMLView mouseDown:mouseDown:]):
(-[WebHTMLView mouseUp:mouseUp:]):
* WebView/WebView.mm:
(-[WebView prepareForMouseDown]):
(-[WebView prepareForMouseUp]):
* WebView/WebViewInternal.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebHTMLViewmm">trunk/Source/WebKit/mac/WebView/WebHTMLView.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewInternalh">trunk/Source/WebKit/mac/WebView/WebViewInternal.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (207482 => 207483)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-10-18 20:22:58 UTC (rev 207482)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-10-18 20:30:53 UTC (rev 207483)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-10-18 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Showing and hiding candidates list is very distracting after selecting word
+ https://bugs.webkit.org/show_bug.cgi?id=163609
+ <rdar://problem/28747712>
+
+ Reviewed by Tim Horton.
+
+ Introduce WebView hooks for mousedown and mouseup. See radar for more details.
+
+ * WebView/WebHTMLView.mm:
+ (-[WebHTMLView mouseDown:mouseDown:]):
+ (-[WebHTMLView mouseUp:mouseUp:]):
+ * WebView/WebView.mm:
+ (-[WebView prepareForMouseDown]):
+ (-[WebView prepareForMouseUp]):
+ * WebView/WebViewInternal.h:
+
</ins><span class="cx"> 2016-10-17 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Move some history specific HistoryItem code to WebHistoryItem
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebHTMLViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (207482 => 207483)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2016-10-18 20:22:58 UTC (rev 207482)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2016-10-18 20:30:53 UTC (rev 207483)
</span><span class="lines">@@ -4502,6 +4502,8 @@
</span><span class="cx"> - (void)mouseDown:(WebEvent *)event
</span><span class="cx"> #endif
</span><span class="cx"> {
</span><ins>+ [[self _webView] prepareForMouseDown];
+
</ins><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> // There's a chance that responding to this event will run a nested event loop, and
</span><span class="cx"> // fetching a new event might release the old one. Retaining and then autoreleasing
</span><span class="lines">@@ -4721,6 +4723,8 @@
</span><span class="cx"> - (void)mouseUp:(WebEvent *)event
</span><span class="cx"> #endif
</span><span class="cx"> {
</span><ins>+ [[self _webView] prepareForMouseUp];
+
</ins><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> // There's a chance that responding to this event will run a nested event loop, and
</span><span class="cx"> // fetching a new event might release the old one. Retaining and then autoreleasing
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (207482 => 207483)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-10-18 20:22:58 UTC (rev 207482)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-10-18 20:30:53 UTC (rev 207483)
</span><span class="lines">@@ -6752,6 +6752,14 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)prepareForMouseDown
+{
+}
+
+- (void)prepareForMouseUp
+{
+}
+
</ins><span class="cx"> - (void)showCandidates:(NSArray *)candidates forString:(NSString *)string inRect:(NSRect)rectOfTypedString forSelectedRange:(NSRange)range view:(NSView *)view completionHandler:(void (^)(NSTextCheckingResult *acceptedCandidate))completionBlock
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebViewInternal.h (207482 => 207483)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2016-10-18 20:22:58 UTC (rev 207482)
+++ trunk/Source/WebKit/mac/WebView/WebViewInternal.h 2016-10-18 20:30:53 UTC (rev 207483)
</span><span class="lines">@@ -296,6 +296,8 @@
</span><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @interface WebView (WebUpdateWebViewAdditions)
</span><ins>+- (void)prepareForMouseUp;
+- (void)prepareForMouseDown;
</ins><span class="cx"> - (void)updateWebViewAdditions;
</span><span class="cx"> - (void)webViewAdditionsWillDestroyView;
</span><span class="cx"> - (id)candidateList;
</span></span></pre>
</div>
</div>
</body>
</html>