<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207515] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207515">207515</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-18 19:26:50 -0700 (Tue, 18 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Web IDL] Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor]
https://bugs.webkit.org/show_bug.cgi?id=163630
Reviewed by Darin Adler.
Source/WebCore:
Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor] in our
IDL now that all our events use proper constructors instead.
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(IsConstructable):
* bindings/scripts/IDLAttributes.txt:
* dom/Event.h:
(WebCore::Event::create):
* dom/Event.idl:
* dom/UIEvent.h:
(WebCore::UIEvent::create):
* dom/UIEvent.idl:
LayoutTests:
Update / rebaseline existing tests to reflect minor behavior changes.
* fast/events/constructors/event-constructors-expected.txt:
* fast/events/constructors/event-constructors.html:
* fast/events/constructors/ui-event-constructor-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorseventconstructorsexpectedtxt">trunk/LayoutTests/fast/events/constructors/event-constructors-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorseventconstructorshtml">trunk/LayoutTests/fast/events/constructors/event-constructors.html</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsuieventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/ui-event-constructor-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorpm">trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>
<li><a href="#trunkSourceWebCoredomEventh">trunk/Source/WebCore/dom/Event.h</a></li>
<li><a href="#trunkSourceWebCoredomEventidl">trunk/Source/WebCore/dom/Event.idl</a></li>
<li><a href="#trunkSourceWebCoredomUIEventh">trunk/Source/WebCore/dom/UIEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomUIEventidl">trunk/Source/WebCore/dom/UIEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/LayoutTests/ChangeLog 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-10-18 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ [Web IDL] Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor]
+ https://bugs.webkit.org/show_bug.cgi?id=163630
+
+ Reviewed by Darin Adler.
+
+ Update / rebaseline existing tests to reflect minor behavior changes.
+
+ * fast/events/constructors/event-constructors-expected.txt:
+ * fast/events/constructors/event-constructors.html:
+ * fast/events/constructors/ui-event-constructor-expected.txt:
+
+2016-10-18 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Changing details.open should cause a toggle event to be fired asynchronously
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=163568
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorseventconstructorsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/event-constructors-expected.txt (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/event-constructors-expected.txt 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/LayoutTests/fast/events/constructors/event-constructors-expected.txt 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -21,8 +21,7 @@
</span><span class="cx"> PASS (new Event('eventType', null)).cancelable is false
</span><span class="cx"> PASS (new Event('eventType', undefined)).bubbles is false
</span><span class="cx"> PASS (new Event('eventType', undefined)).cancelable is false
</span><del>-PASS (new Event('eventType', 0)).bubbles is false
-PASS (new Event('eventType', 0)).cancelable is false
</del><ins>+PASS new Event('eventType', 0) threw exception TypeError: Type error.
</ins><span class="cx"> PASS (new Event('eventType', window)).bubbles is false
</span><span class="cx"> PASS (new Event('eventType', window)).cancelable is false
</span><span class="cx"> PASS (new Event('eventType', window)).bubbles is true
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorseventconstructorshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/event-constructors.html (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/event-constructors.html 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/LayoutTests/fast/events/constructors/event-constructors.html 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -51,8 +51,7 @@
</span><span class="cx"> test("new Event('eventType', undefined)", false, false);
</span><span class="cx">
</span><span class="cx"> // A number as the initializer.
</span><del>-// FIXME: Should this throw?
-test("new Event('eventType', 0)", false, false);
</del><ins>+shouldThrowErrorName("new Event('eventType', 0)", "TypeError");
</ins><span class="cx">
</span><span class="cx"> // The window as the initializer.
</span><span class="cx"> test("new Event('eventType', window)", false, false);
</span><span class="lines">@@ -85,4 +84,4 @@
</span><span class="cx"> </script>
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span><del>-</html>
</del><span class="cx">\ No newline at end of file
</span><ins>+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsuieventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/ui-event-constructor-expected.txt (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/ui-event-constructor-expected.txt 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/LayoutTests/fast/events/constructors/ui-event-constructor-expected.txt 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -13,19 +13,19 @@
</span><span class="cx"> PASS new UIEvent('eventType', { cancelable: true }).cancelable is true
</span><span class="cx"> PASS new UIEvent('eventType', { view: window }).view is window
</span><span class="cx"> PASS new UIEvent('eventType', { view: this }).view is this
</span><del>-PASS new UIEvent('eventType', { view: testObject }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: document }).view threw exception TypeError: Dictionary member is not of type Window.
</del><ins>+PASS new UIEvent('eventType', { view: testObject }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: document }).view threw exception TypeError: Type error.
</ins><span class="cx"> PASS new UIEvent('eventType', { view: undefined }).view is null
</span><span class="cx"> PASS new UIEvent('eventType', { view: null }).view is null
</span><del>-PASS new UIEvent('eventType', { view: false }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: true }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: '' }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: 'chocolate' }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: 12345 }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: 18446744073709551615 }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: NaN }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { view: {valueOf: function () { return window; } } }).view threw exception TypeError: Dictionary member is not of type Window.
-PASS new UIEvent('eventType', { get view() { return 123; } }).view threw exception TypeError: Dictionary member is not of type Window.
</del><ins>+PASS new UIEvent('eventType', { view: false }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: true }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: '' }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: 'chocolate' }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: 12345 }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: 18446744073709551615 }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: NaN }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { view: {valueOf: function () { return window; } } }).view threw exception TypeError: Type error.
+PASS new UIEvent('eventType', { get view() { return 123; } }).view threw exception TypeError: Type error.
</ins><span class="cx"> PASS new UIEvent('eventType', { get view() { throw 'UIEvent Error'; } }) threw exception UIEvent Error.
</span><span class="cx"> PASS new UIEvent('eventType', { detail: 0 }).detail is 0
</span><span class="cx"> PASS new UIEvent('eventType', { detail: 2147483647 }).detail is 2147483647
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/ChangeLog 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2016-10-18 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ [Web IDL] Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor]
+ https://bugs.webkit.org/show_bug.cgi?id=163630
+
+ Reviewed by Darin Adler.
+
+ Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor] in our
+ IDL now that all our events use proper constructors instead.
+
+ * bindings/scripts/CodeGenerator.pm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateHeader):
+ (GenerateConstructorDefinition):
+ (GenerateConstructorHelperMethods):
+ (IsConstructable):
+ * bindings/scripts/IDLAttributes.txt:
+ * dom/Event.h:
+ (WebCore::Event::create):
+ * dom/Event.idl:
+ * dom/UIEvent.h:
+ (WebCore::UIEvent::create):
+ * dom/UIEvent.idl:
+
+2016-10-18 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Changing details.open should cause a toggle event to be fired asynchronously
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=163568
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -1750,6 +1750,8 @@
</span><span class="cx"> 4634592C1AC2271000ECB71C /* PowerObserverMac.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4634592B1AC2271000ECB71C /* PowerObserverMac.cpp */; };
</span><span class="cx"> 463EB6221B8789E00096ED51 /* TagCollection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 463EB6201B8789CB0096ED51 /* TagCollection.cpp */; };
</span><span class="cx"> 463EB6231B8789E00096ED51 /* TagCollection.h in Headers */ = {isa = PBXBuildFile; fileRef = 463EB6211B8789CB0096ED51 /* TagCollection.h */; };
</span><ins>+ 465307D01DB6EE4800E4137C /* JSUIEventInit.h in Headers */ = {isa = PBXBuildFile; fileRef = 83E045EF1DAA104F00B0D8B9 /* JSUIEventInit.h */; };
+ 465307D11DB6EE4A00E4137C /* JSUIEventInit.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 83E045EE1DAA104F00B0D8B9 /* JSUIEventInit.cpp */; };
</ins><span class="cx"> 465A8E791C8A24CE00E7D3E4 /* RuntimeApplicationChecks.mm in Sources */ = {isa = PBXBuildFile; fileRef = 465A8E781C8A24CE00E7D3E4 /* RuntimeApplicationChecks.mm */; };
</span><span class="cx"> 4669B2871B852A0B000F905F /* JSDOMNamedFlowCollectionCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 46F2768E1B85297F005C2556 /* JSDOMNamedFlowCollectionCustom.cpp */; };
</span><span class="cx"> 4671E0651D67A59600C6B497 /* CanvasPath.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4671E0631D67A57B00C6B497 /* CanvasPath.cpp */; };
</span><span class="lines">@@ -5976,7 +5978,6 @@
</span><span class="cx"> E125F83A1824104800D84CD9 /* CryptoAlgorithmAesCbcParamsDeprecated.h in Headers */ = {isa = PBXBuildFile; fileRef = E125F8391824104800D84CD9 /* CryptoAlgorithmAesCbcParamsDeprecated.h */; };
</span><span class="cx"> E125F83D182411E700D84CD9 /* JSCryptoOperationData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E125F83B182411E700D84CD9 /* JSCryptoOperationData.cpp */; };
</span><span class="cx"> E125F83E182411E700D84CD9 /* JSCryptoOperationData.h in Headers */ = {isa = PBXBuildFile; fileRef = E125F83C182411E700D84CD9 /* JSCryptoOperationData.h */; };
</span><del>-
</del><span class="cx"> E125F8411824253A00D84CD9 /* CryptoAlgorithmAES_CBC.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E125F83F1824253A00D84CD9 /* CryptoAlgorithmAES_CBC.cpp */; };
</span><span class="cx"> E125F8421824253A00D84CD9 /* CryptoAlgorithmAES_CBC.h in Headers */ = {isa = PBXBuildFile; fileRef = E125F8401824253A00D84CD9 /* CryptoAlgorithmAES_CBC.h */; };
</span><span class="cx"> E125F845182425C900D84CD9 /* CryptoAlgorithmAES_CBCMac.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E125F843182425C900D84CD9 /* CryptoAlgorithmAES_CBCMac.cpp */; };
</span><span class="lines">@@ -7327,12 +7328,12 @@
</span><span class="cx"> 0F4710AC1DB56AFC002DCEC3 /* DOMRectInit.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMRectInit.idl; sourceTree = "<group>"; };
</span><span class="cx"> 0F4710AD1DB56AFC002DCEC3 /* DOMRectReadOnly.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMRectReadOnly.h; sourceTree = "<group>"; };
</span><span class="cx"> 0F4710AE1DB56AFC002DCEC3 /* DOMRectReadOnly.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMRectReadOnly.idl; sourceTree = "<group>"; };
</span><del>- 0F4710B51DB56BE8002DCEC3 /* JSDOMRect.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSDOMRect.cpp; path = JSDOMRect.cpp; sourceTree = "<group>"; };
- 0F4710B61DB56BE8002DCEC3 /* JSDOMRect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSDOMRect.h; path = JSDOMRect.h; sourceTree = "<group>"; };
- 0F4710B71DB56BE8002DCEC3 /* JSDOMRectInit.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSDOMRectInit.cpp; path = JSDOMRectInit.cpp; sourceTree = "<group>"; };
- 0F4710B81DB56BE8002DCEC3 /* JSDOMRectInit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSDOMRectInit.h; path = JSDOMRectInit.h; sourceTree = "<group>"; };
- 0F4710B91DB56BE8002DCEC3 /* JSDOMRectReadOnly.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSDOMRectReadOnly.cpp; path = JSDOMRectReadOnly.cpp; sourceTree = "<group>"; };
- 0F4710BA1DB56BE8002DCEC3 /* JSDOMRectReadOnly.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSDOMRectReadOnly.h; path = JSDOMRectReadOnly.h; sourceTree = "<group>"; };
</del><ins>+ 0F4710B51DB56BE8002DCEC3 /* JSDOMRect.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMRect.cpp; sourceTree = "<group>"; };
+ 0F4710B61DB56BE8002DCEC3 /* JSDOMRect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMRect.h; sourceTree = "<group>"; };
+ 0F4710B71DB56BE8002DCEC3 /* JSDOMRectInit.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMRectInit.cpp; sourceTree = "<group>"; };
+ 0F4710B81DB56BE8002DCEC3 /* JSDOMRectInit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMRectInit.h; sourceTree = "<group>"; };
+ 0F4710B91DB56BE8002DCEC3 /* JSDOMRectReadOnly.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMRectReadOnly.cpp; sourceTree = "<group>"; };
+ 0F4710BA1DB56BE8002DCEC3 /* JSDOMRectReadOnly.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMRectReadOnly.h; sourceTree = "<group>"; };
</ins><span class="cx"> 0F4966991DB408C100A274BB /* DOMPoint.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMPoint.h; sourceTree = "<group>"; };
</span><span class="cx"> 0F49669A1DB408C100A274BB /* DOMPoint.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMPoint.idl; sourceTree = "<group>"; };
</span><span class="cx"> 0F49669B1DB408C100A274BB /* DOMPointReadOnly.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMPointReadOnly.h; sourceTree = "<group>"; };
</span><span class="lines">@@ -14696,8 +14697,8 @@
</span><span class="cx"> 5EA725CD1ACABCD900EAD17B /* MediaDevices.cpp */,
</span><span class="cx"> 5EA725CE1ACABCD900EAD17B /* MediaDevices.h */,
</span><span class="cx"> 5EA725CF1ACABCD900EAD17B /* MediaDevices.idl */,
</span><del>- 07ABEF6B1D8A1C5800F21972 /* MediaDevicesEnumerationRequest.cpp */,
- 07ABEF6D1D8A1C7600F21972 /* MediaDevicesEnumerationRequest.h */,
</del><ins>+ 07ABEF6B1D8A1C5800F21972 /* MediaDevicesEnumerationRequest.cpp */,
+ 07ABEF6D1D8A1C7600F21972 /* MediaDevicesEnumerationRequest.h */,
</ins><span class="cx"> 07394EC71BAB2CCD00BE99CD /* MediaDevicesRequest.cpp */,
</span><span class="cx"> 07394EC91BAB2CD700BE99CD /* MediaDevicesRequest.h */,
</span><span class="cx"> 5E16A2E21BFA64FB0029A21E /* MediaEndpointPeerConnection.cpp */,
</span><span class="lines">@@ -24214,6 +24215,7 @@
</span><span class="cx"> 29D7BCFA1444AF7D0070619C /* AccessibilitySpinButton.h in Headers */,
</span><span class="cx"> 69A6CBAD1C6BE42C00B836E9 /* AccessibilitySVGElement.h in Headers */,
</span><span class="cx"> AAC08CF315F941FD00F1E188 /* AccessibilitySVGRoot.h in Headers */,
</span><ins>+ 465307D01DB6EE4800E4137C /* JSUIEventInit.h in Headers */,
</ins><span class="cx"> 29A8122B0FBB9C1D00510293 /* AccessibilityTable.h in Headers */,
</span><span class="cx"> 29A812320FBB9C1D00510293 /* AccessibilityTableCell.h in Headers */,
</span><span class="cx"> 29A812410FBB9C1D00510293 /* AccessibilityTableColumn.h in Headers */,
</span><span class="lines">@@ -28161,6 +28163,7 @@
</span><span class="cx"> A89943290B42338800D7C802 /* BitmapImage.cpp in Sources */,
</span><span class="cx"> 1AFFC4541D5E81CB00267A66 /* BlacklistUpdater.mm in Sources */,
</span><span class="cx"> 976D6C78122B8A3D001FD1F7 /* Blob.cpp in Sources */,
</span><ins>+ 465307D11DB6EE4A00E4137C /* JSUIEventInit.cpp in Sources */,
</ins><span class="cx"> 2EDEF1F3121B0EFC00726DB2 /* BlobData.cpp in Sources */,
</span><span class="cx"> E1D31CDC19196020001005A3 /* BlobDataFileReference.cpp in Sources */,
</span><span class="cx"> E164A2ED191AE6350010737D /* BlobDataFileReferenceMac.mm in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -380,15 +380,6 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-sub IsConstructorTemplate
-{
- my $object = shift;
- my $interface = shift;
- my $template = shift;
-
- return $interface->extendedAttributes->{"LegacyConstructorTemplate"} && $interface->extendedAttributes->{"LegacyConstructorTemplate"} eq $template;
-}
-
</del><span class="cx"> sub IsNumericType
</span><span class="cx"> {
</span><span class="cx"> my ($object, $type) = @_;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -1272,7 +1272,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> AddClassForwardIfNeeded("JSDOMWindowShell") if $interfaceName eq "DOMWindow";
</span><del>- AddClassForwardIfNeeded("JSDictionary") if $codeGenerator->IsConstructorTemplate($interface, "Event");
</del><span class="cx">
</span><span class="cx"> my $exportMacro = GetExportMacroForJSClass($interface);
</span><span class="cx">
</span><span class="lines">@@ -1725,10 +1724,6 @@
</span><span class="cx"> push(@headerContent, "JSC::EncodedJSValue JSC_HOST_CALL construct${className}(JSC::ExecState&);\n\n");
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ($codeGenerator->IsConstructorTemplate($interface, "Event")) {
- push(@headerContent, "bool fill${interfaceName}Init(${interfaceName}Init&, JSDictionary&);\n\n");
- }
-
</del><span class="cx"> if (NeedsImplementationClass($interface)) {
</span><span class="cx"> push(@headerContent, "template<> struct JSDOMWrapperConverterTraits<${implType}> {\n");
</span><span class="cx"> push(@headerContent, " using WrapperClass = ${className};\n");
</span><span class="lines">@@ -5703,84 +5698,7 @@
</span><span class="cx"> my $constructorClassName = $generatingNamedConstructor ? "${className}NamedConstructor" : "${className}Constructor";
</span><span class="cx">
</span><span class="cx"> if (IsConstructable($interface)) {
</span><del>- if ($codeGenerator->IsConstructorTemplate($interface, "Event")) {
- $implIncludes{"JSDictionary.h"} = 1;
- $implIncludes{"<runtime/Error.h>"} = 1;
-
- push(@$outputArray, <<END);
-template<> EncodedJSValue JSC_HOST_CALL ${constructorClassName}::construct(ExecState* state)
-{
- VM& vm = state->vm();
- auto throwScope = DECLARE_THROW_SCOPE(vm);
- auto* jsConstructor = jsCast<${constructorClassName}*>(state->callee());
- ASSERT(jsConstructor);
-
- if (!jsConstructor->scriptExecutionContext())
- return throwConstructorScriptExecutionContextUnavailableError(*state, throwScope, \"${visibleInterfaceName}\");
-
- if (UNLIKELY(state->argumentCount() < 1))
- return throwVMError(state, throwScope, createNotEnoughArgumentsError(state));
-
- AtomicString eventType = state->uncheckedArgument(0).toString(state)->toAtomicString(state);
- RETURN_IF_EXCEPTION(throwScope, encodedJSValue());
-
- ${interfaceName}Init eventInit;
-
- JSValue initializerValue = state->argument(1);
- if (!initializerValue.isUndefinedOrNull()) {
- // Given the above test, this will always yield an object.
- JSObject* initializerObject = initializerValue.toObject(state);
- ASSERT(!throwScope.exception());
-
- // Create the dictionary wrapper from the initializer object.
- JSDictionary dictionary(state, initializerObject);
-
- // Attempt to fill in the EventInit.
- if (!fill${interfaceName}Init(eventInit, dictionary))
- return JSValue::encode(jsUndefined());
- }
-
- Ref<${interfaceName}> event = ${interfaceName}::createForBindings(eventType, eventInit);
- return JSValue::encode(createWrapper<${interfaceName}>(jsConstructor->globalObject(), WTFMove(event)));
-}
-
-bool fill${interfaceName}Init(${interfaceName}Init& eventInit, JSDictionary& dictionary)
-{
-END
-
- if ($interface->parent) {
- my $interfaceBase = $interface->parent;
- push(@implContent, <<END);
- if (!fill${interfaceBase}Init(eventInit, dictionary))
- return false;
-
-END
- }
-
- for (my $index = 0; $index < @{$interface->attributes}; $index++) {
- my $attribute = @{$interface->attributes}[$index];
- if ($attribute->signature->extendedAttributes->{LegacyInitializedByEventConstructor}) {
- my $attributeName = $attribute->signature->name;
- my $attributeImplName = $attribute->signature->extendedAttributes->{ImplementedAs} || $attributeName;
- my $conditionalString = $codeGenerator->GenerateConditionalString($attribute->signature);
-
- push(@implContent, "#if ${conditionalString}\n") if $conditionalString;
-
- push(@implContent, <<END);
- if (!dictionary.tryGetProperty("${attributeName}", eventInit.${attributeImplName}))
- return false;
-END
- push(@implContent, "#endif\n") if $conditionalString;
-
- }
- }
-
- push(@$outputArray, <<END);
- return true;
-}
-
-END
- } elsif ($interface->extendedAttributes->{CustomConstructor}) {
</del><ins>+ if ($interface->extendedAttributes->{CustomConstructor}) {
</ins><span class="cx"> push(@$outputArray, "template<> JSC::EncodedJSValue JSC_HOST_CALL ${constructorClassName}::construct(JSC::ExecState* exec)\n");
</span><span class="cx"> push(@$outputArray, "{\n");
</span><span class="cx"> push(@$outputArray, " ASSERT(exec);\n");
</span><span class="lines">@@ -5904,9 +5822,7 @@
</span><span class="cx">
</span><span class="cx"> my $constructorClassName = $generatingNamedConstructor ? "${className}NamedConstructor" : "${className}Constructor";
</span><span class="cx"> my $leastConstructorLength = 0;
</span><del>- if ($codeGenerator->IsConstructorTemplate($interface, "Event")) {
- $leastConstructorLength = 1;
- } elsif ($interface->extendedAttributes->{Constructor} || $interface->extendedAttributes->{CustomConstructor}) {
</del><ins>+ if ($interface->extendedAttributes->{Constructor} || $interface->extendedAttributes->{CustomConstructor}) {
</ins><span class="cx"> my @constructors = @{$interface->constructors};
</span><span class="cx"> my @customConstructors = @{$interface->customConstructors};
</span><span class="cx"> $leastConstructorLength = 255;
</span><span class="lines">@@ -6014,7 +5930,6 @@
</span><span class="cx"> return HasCustomConstructor($interface)
</span><span class="cx"> || $interface->extendedAttributes->{Constructor}
</span><span class="cx"> || $interface->extendedAttributes->{NamedConstructor}
</span><del>- || $interface->extendedAttributes->{LegacyConstructorTemplate}
</del><span class="cx"> || $interface->extendedAttributes->{JSBuiltinConstructor};
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLAttributestxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -92,8 +92,6 @@
</span><span class="cx"> JSGenerateToJSObject
</span><span class="cx"> JSGenerateToNativeObject
</span><span class="cx"> JSLegacyParent=*
</span><del>-LegacyConstructorTemplate=Event
-LegacyInitializedByEventConstructor
</del><span class="cx"> LenientThis
</span><span class="cx"> MasqueradesAsUndefined
</span><span class="cx"> MayThrowException
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.h (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.h 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/dom/Event.h 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -87,9 +87,9 @@
</span><span class="cx"> return adoptRef(*new Event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static Ref<Event> createForBindings(const AtomicString& type, const EventInit& initializer)
</del><ins>+ static Ref<Event> create(const AtomicString& type, const EventInit& initializer, IsTrusted isTrusted = IsTrusted::No)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new Event(type, initializer));
</del><ins>+ return adoptRef(*new Event(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> virtual ~Event();
</span><span class="lines">@@ -193,7 +193,7 @@
</span><span class="cx"> Event(IsTrusted = IsTrusted::No);
</span><span class="cx"> WEBCORE_EXPORT Event(const AtomicString& type, bool canBubble, bool cancelable);
</span><span class="cx"> Event(const AtomicString& type, bool canBubble, bool cancelable, double timestamp);
</span><del>- Event(const AtomicString& type, const EventInit&, IsTrusted = IsTrusted::No);
</del><ins>+ Event(const AtomicString& type, const EventInit&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> virtual void receivedTarget();
</span><span class="cx"> bool dispatched() const { return m_target; }
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.idl (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.idl 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/dom/Event.idl 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -19,7 +19,7 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- LegacyConstructorTemplate=Event,
</del><ins>+ Constructor(DOMString type, optional EventInit eventInitDict),
</ins><span class="cx"> CustomToJSObject,
</span><span class="cx"> ExportToWrappedFunction,
</span><span class="cx"> Exposed=(Window,Worker),
</span><span class="lines">@@ -51,9 +51,9 @@
</span><span class="cx"> readonly attribute EventTarget target;
</span><span class="cx"> readonly attribute EventTarget currentTarget;
</span><span class="cx"> readonly attribute unsigned short eventPhase;
</span><del>- [LegacyInitializedByEventConstructor] readonly attribute boolean bubbles;
- [LegacyInitializedByEventConstructor] readonly attribute boolean cancelable;
- [LegacyInitializedByEventConstructor, EnabledAtRuntime=ShadowDOM] readonly attribute boolean composed;
</del><ins>+ readonly attribute boolean bubbles;
+ readonly attribute boolean cancelable;
+ [EnabledAtRuntime=ShadowDOM] readonly attribute boolean composed;
</ins><span class="cx"> readonly attribute DOMTimeStamp timeStamp;
</span><span class="cx">
</span><span class="cx"> [EnabledAtRuntime=ShadowDOM] sequence<Node> composedPath();
</span></span></pre></div>
<a id="trunkSourceWebCoredomUIEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/UIEvent.h (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/UIEvent.h 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/dom/UIEvent.h 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -42,9 +42,9 @@
</span><span class="cx"> {
</span><span class="cx"> return adoptRef(*new UIEvent);
</span><span class="cx"> }
</span><del>- static Ref<UIEvent> createForBindings(const AtomicString& type, const UIEventInit& initializer)
</del><ins>+ static Ref<UIEvent> create(const AtomicString& type, const UIEventInit& initializer, IsTrusted isTrusted = IsTrusted::No)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new UIEvent(type, initializer));
</del><ins>+ return adoptRef(*new UIEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx"> virtual ~UIEvent();
</span><span class="cx">
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> UIEvent();
</span><span class="cx"> UIEvent(const AtomicString& type, bool canBubble, bool cancelable, DOMWindow*, int detail);
</span><span class="cx"> UIEvent(const AtomicString& type, bool canBubble, bool cancelable, double timestamp, DOMWindow*, int detail);
</span><del>- UIEvent(const AtomicString&, const UIEventInit&, IsTrusted = IsTrusted::No);
</del><ins>+ UIEvent(const AtomicString&, const UIEventInit&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> bool isUIEvent() const final;
</span></span></pre></div>
<a id="trunkSourceWebCoredomUIEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/UIEvent.idl (207514 => 207515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/UIEvent.idl 2016-10-19 02:03:07 UTC (rev 207514)
+++ trunk/Source/WebCore/dom/UIEvent.idl 2016-10-19 02:26:50 UTC (rev 207515)
</span><span class="lines">@@ -18,10 +18,10 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- LegacyConstructorTemplate=Event,
</del><ins>+ Constructor(DOMString type, optional UIEventInit eventInitDict)
</ins><span class="cx"> ] interface UIEvent : Event {
</span><del>- [LegacyInitializedByEventConstructor] readonly attribute DOMWindow view;
- [LegacyInitializedByEventConstructor] readonly attribute long detail;
</del><ins>+ readonly attribute DOMWindow view;
+ readonly attribute long detail;
</ins><span class="cx">
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> void initUIEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false, optional DOMWindow? view = null, optional long detail = 0);
</span></span></pre>
</div>
</div>
</body>
</html>