<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207519] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207519">207519</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-18 21:46:39 -0700 (Tue, 18 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Web IDL] Drop webkit-specific extended attributes that are no longer useful
https://bugs.webkit.org/show_bug.cgi?id=163643
Reviewed by Ryosuke Niwa.
Source/WebCore:
Drop webkit-specific IDL extended attributes that are no longer useful:
- [CustomReturn]: I believe this used to be for ObjC bindings. It has
no impact in JS bindings.
- [Deletable]: It only had an impact on static attributes and was only
used on HTMLAllCollection.all, which is not static. I updated the
bindings generator to so that static attributes are now configurable
by default (unless marked as [Unforgeable], as per Web IDL [1]. This
causes Notification.permission (This only static attribute we have)
to become deletable. This behavior is consistent with the specification
and with Chrome. I added test coverage for this.
- [ImplementationNamespace]: Implemented but unused.
- [PassContext]: Not implemented and unused.
- [TypedArray=*]: Not implemented and unused.
[1] https://heycam.github.io/webidl/#es-attributes
Test: fast/notifications/notification-permisssion-deletable.html
* bindings/scripts/CodeGeneratorJS.pm:
(GetNamespaceForInterface):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* dom/Node.idl:
* html/HTMLDocument.idl:
LayoutTests:
Add layout test to check that Notification.permission is now deletable.
* fast/notifications/notification-permisssion-deletable-expected.txt: Added.
* fast/notifications/notification-permisssion-deletable.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeidl">trunk/Source/WebCore/dom/Node.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumentidl">trunk/Source/WebCore/html/HTMLDocument.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastnotificationsnotificationpermisssiondeletableexpectedtxt">trunk/LayoutTests/fast/notifications/notification-permisssion-deletable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastnotificationsnotificationpermisssiondeletablehtml">trunk/LayoutTests/fast/notifications/notification-permisssion-deletable.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/LayoutTests/ChangeLog 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-10-18 Chris Dumez <cdumez@apple.com>
+
+ [Web IDL] Drop webkit-specific extended attributes that are no longer useful
+ https://bugs.webkit.org/show_bug.cgi?id=163643
+
+ Reviewed by Ryosuke Niwa.
+
+ Add layout test to check that Notification.permission is now deletable.
+
+ * fast/notifications/notification-permisssion-deletable-expected.txt: Added.
+ * fast/notifications/notification-permisssion-deletable.html: Added.
+
</ins><span class="cx"> 2016-10-18 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Invoking Object.prototype.__proto__ accessors directly should throw a TypeError.
</span></span></pre></div>
<a id="trunkLayoutTestsfastnotificationsnotificationpermisssiondeletableexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/notifications/notification-permisssion-deletable-expected.txt (0 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/notifications/notification-permisssion-deletable-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/notifications/notification-permisssion-deletable-expected.txt 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+Tests that Notification.permission is deletable.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Notification.permission is "default"
+PASS delete Notification.permission is true
+PASS Notification.permission is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastnotificationsnotificationpermisssiondeletablehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/notifications/notification-permisssion-deletable.html (0 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/notifications/notification-permisssion-deletable.html (rev 0)
+++ trunk/LayoutTests/fast/notifications/notification-permisssion-deletable.html 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that Notification.permission is deletable.");
+
+shouldBeEqualToString("Notification.permission", "default");
+shouldBeTrue("delete Notification.permission");
+shouldBeUndefined("Notification.permission");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/ChangeLog 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2016-10-18 Chris Dumez <cdumez@apple.com>
+
+ [Web IDL] Drop webkit-specific extended attributes that are no longer useful
+ https://bugs.webkit.org/show_bug.cgi?id=163643
+
+ Reviewed by Ryosuke Niwa.
+
+ Drop webkit-specific IDL extended attributes that are no longer useful:
+ - [CustomReturn]: I believe this used to be for ObjC bindings. It has
+ no impact in JS bindings.
+ - [Deletable]: It only had an impact on static attributes and was only
+ used on HTMLAllCollection.all, which is not static. I updated the
+ bindings generator to so that static attributes are now configurable
+ by default (unless marked as [Unforgeable], as per Web IDL [1]. This
+ causes Notification.permission (This only static attribute we have)
+ to become deletable. This behavior is consistent with the specification
+ and with Chrome. I added test coverage for this.
+ - [ImplementationNamespace]: Implemented but unused.
+ - [PassContext]: Not implemented and unused.
+ - [TypedArray=*]: Not implemented and unused.
+
+ [1] https://heycam.github.io/webidl/#es-attributes
+
+ Test: fast/notifications/notification-permisssion-deletable.html
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GetNamespaceForInterface):
+ (GenerateImplementation):
+ * bindings/scripts/IDLAttributes.txt:
+ * bindings/scripts/test/JS/JSTestInterface.cpp:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+ * dom/Node.idl:
+ * html/HTMLDocument.idl:
+
</ins><span class="cx"> 2016-10-18 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Replace std::experimental::variant with WTF::Variant (or similar)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -2343,7 +2343,7 @@
</span><span class="cx"> sub GetNamespaceForInterface
</span><span class="cx"> {
</span><span class="cx"> my $interface = shift;
</span><del>- return $interface->extendedAttributes->{ImplementationNamespace} || "WebCore";
</del><ins>+ return "WebCore";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GetImplementationLacksVTableForInterface
</span><span class="lines">@@ -2592,7 +2592,7 @@
</span><span class="cx"> push(@hashKeys, $name);
</span><span class="cx">
</span><span class="cx"> my @specials = ();
</span><del>- push(@specials, "DontDelete") unless $attribute->signature->extendedAttributes->{Deletable};
</del><ins>+ push(@specials, "DontDelete") if IsUnforgeable($interface, $attribute);
</ins><span class="cx"> push(@specials, "ReadOnly") if IsReadonly($attribute);
</span><span class="cx"> push(@specials, "DOMJITAttribute") if $attribute->signature->extendedAttributes->{"DOMJIT"};
</span><span class="cx"> my $special = (@specials > 0) ? join(" | ", @specials) : "0";
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLAttributestxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -49,12 +49,10 @@
</span><span class="cx"> CustomPreventExtensions
</span><span class="cx"> CustomProxyToJSObject
</span><span class="cx"> CustomPutFunction
</span><del>-CustomReturn
</del><span class="cx"> CustomSetPrototype
</span><span class="cx"> CustomSetter
</span><span class="cx"> CustomToJSObject
</span><span class="cx"> DOMJIT
</span><del>-Deletable
</del><span class="cx"> DoNotCheckConstants
</span><span class="cx"> DoNotCheckSecurity
</span><span class="cx"> DoNotCheckSecurityOnGetter
</span><span class="lines">@@ -73,7 +71,6 @@
</span><span class="cx"> Immutable
</span><span class="cx"> ImplementedAs=*
</span><span class="cx"> ImplementationLacksVTable
</span><del>-ImplementationNamespace=*
</del><span class="cx"> ImplementationReturnType=*
</span><span class="cx"> ImplicitThis
</span><span class="cx"> InterfaceName=*
</span><span class="lines">@@ -103,7 +100,6 @@
</span><span class="cx"> Nondeterministic
</span><span class="cx"> NotEnumerable
</span><span class="cx"> OverrideBuiltins
</span><del>-PassContext
</del><span class="cx"> PrivateIdentifier
</span><span class="cx"> PublicIdentifier
</span><span class="cx"> PutForwards=*
</span><span class="lines">@@ -118,7 +114,6 @@
</span><span class="cx"> SkipVTableValidation
</span><span class="cx"> SuppressToJSObject
</span><span class="cx"> TreatNullAs=EmptyString
</span><del>-TypedArray=*
</del><span class="cx"> URL
</span><span class="cx"> Unforgeable
</span><span class="cx"> Unscopable
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -176,22 +176,22 @@
</span><span class="cx"> { 0, 0, NoIntrinsic, { 0, 0 } },
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(Condition22) || ENABLE(Condition23)
</span><del>- { "implementsStaticReadOnlyAttr", DontDelete | ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorImplementsStaticReadOnlyAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</del><ins>+ { "implementsStaticReadOnlyAttr", ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorImplementsStaticReadOnlyAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</ins><span class="cx"> #else
</span><span class="cx"> { 0, 0, NoIntrinsic, { 0, 0 } },
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(Condition22) || ENABLE(Condition23)
</span><del>- { "implementsStaticAttr", DontDelete, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorImplementsStaticAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestInterfaceConstructorImplementsStaticAttr) } },
</del><ins>+ { "implementsStaticAttr", 0, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorImplementsStaticAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestInterfaceConstructorImplementsStaticAttr) } },
</ins><span class="cx"> #else
</span><span class="cx"> { 0, 0, NoIntrinsic, { 0, 0 } },
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(Condition11) || ENABLE(Condition12)
</span><del>- { "supplementalStaticReadOnlyAttr", DontDelete | ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</del><ins>+ { "supplementalStaticReadOnlyAttr", ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</ins><span class="cx"> #else
</span><span class="cx"> { 0, 0, NoIntrinsic, { 0, 0 } },
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(Condition11) || ENABLE(Condition12)
</span><del>- { "supplementalStaticAttr", DontDelete, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestInterfaceConstructorSupplementalStaticAttr) } },
</del><ins>+ { "supplementalStaticAttr", 0, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestInterfaceConstructorSupplementalStaticAttr) } },
</ins><span class="cx"> #else
</span><span class="cx"> { 0, 0, NoIntrinsic, { 0, 0 } },
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -1276,9 +1276,9 @@
</span><span class="cx"> { "CONST_VALUE_14", DontDelete | ReadOnly | ConstantInteger, NoIntrinsic, { (long long)(0x1abc) } },
</span><span class="cx"> { "CONST_JAVASCRIPT", DontDelete | ReadOnly | ConstantInteger, NoIntrinsic, { (long long)(15) } },
</span><span class="cx"> { "readonly", DontDelete | ReadOnly | ConstantInteger, NoIntrinsic, { (long long)(0) } },
</span><del>- { "staticReadOnlyLongAttr", DontDelete | ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorStaticReadOnlyLongAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
- { "staticStringAttr", DontDelete, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorStaticStringAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestObjConstructorStaticStringAttr) } },
- { "TestSubObj", DontDelete | ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorTestSubObj), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</del><ins>+ { "staticReadOnlyLongAttr", ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorStaticReadOnlyLongAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
+ { "staticStringAttr", 0, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorStaticStringAttr), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestObjConstructorStaticStringAttr) } },
+ { "TestSubObj", ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorTestSubObj), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</ins><span class="cx"> { "nullableStringStaticMethod", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionNullableStringStaticMethod), (intptr_t) (0) } },
</span><span class="cx"> { "staticMethodWithCallbackAndOptionalArg", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg), (intptr_t) (0) } },
</span><span class="cx"> { "staticMethodWithCallbackArg", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionStaticMethodWithCallbackArg), (intptr_t) (1) } },
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx">
</span><span class="cx"> static const HashTableValue JSTestTypedefsConstructorTableValues[] =
</span><span class="cx"> {
</span><del>- { "TestSubObj", DontDelete | ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestTypedefsConstructorTestSubObj), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</del><ins>+ { "TestSubObj", ReadOnly, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestTypedefsConstructorTestSubObj), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(0) } },
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> template<> EncodedJSValue JSC_HOST_CALL JSTestTypedefsConstructor::construct(ExecState* state)
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.idl (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.idl 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/dom/Node.idl 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -55,10 +55,10 @@
</span><span class="cx"> [DOMJIT] readonly attribute Node? nextSibling;
</span><span class="cx"> readonly attribute Document? ownerDocument;
</span><span class="cx">
</span><del>- [CEReactions, Custom, MayThrowLegacyException] Node insertBefore([CustomReturn] Node newChild, Node? refChild);
- [CEReactions, Custom, MayThrowLegacyException] Node replaceChild(Node newChild, [CustomReturn] Node oldChild);
- [CEReactions, Custom, MayThrowLegacyException] Node removeChild([CustomReturn] Node oldChild);
- [CEReactions, Custom, MayThrowLegacyException] Node appendChild([CustomReturn] Node newChild);
</del><ins>+ [CEReactions, Custom, MayThrowLegacyException] Node insertBefore(Node newChild, Node? refChild);
+ [CEReactions, Custom, MayThrowLegacyException] Node replaceChild(Node newChild, Node oldChild);
+ [CEReactions, Custom, MayThrowLegacyException] Node removeChild(Node oldChild);
+ [CEReactions, Custom, MayThrowLegacyException] Node appendChild(Node newChild);
</ins><span class="cx">
</span><span class="cx"> boolean hasChildNodes();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.idl (207518 => 207519)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.idl 2016-10-19 03:52:29 UTC (rev 207518)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2016-10-19 04:46:39 UTC (rev 207519)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx"> [Custom] void write(optional DOMString text);
</span><span class="cx"> [Custom] void writeln(optional DOMString text);
</span><span class="cx">
</span><del>- [Custom, Replaceable, Deletable] readonly attribute HTMLAllCollection all;
</del><ins>+ [Custom, Replaceable] readonly attribute HTMLAllCollection all;
</ins><span class="cx">
</span><span class="cx"> void clear();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>