<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207426] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207426">207426</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-17 13:38:46 -0700 (Mon, 17 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move form.reportValidity() behind InteractiveFormValidation setting
https://bugs.webkit.org/show_bug.cgi?id=163550
Reviewed by Darin Adler.
Source/WebCore:
Move form.reportValidity() behind InteractiveFormValidation setting for consistency
given that the two features are strongly related.
Also enable the setting by default so we can get feedback on the implementation.
Demos:
- Interactive form validation: http://jsfiddle.net/tj_vantoll/HdSqt/
- Report validity: https://googlechrome.github.io/samples/report-validity/
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled):
(WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled):
* html/HTMLButtonElement.idl:
* html/HTMLFieldSetElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLKeygenElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOutputElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTextAreaElement.idl:
Source/WebKit/mac:
Enable InteractiveFormValidation setting by default and link it to
RuntimeEnabledFeatures so we can use it in the IDL.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
* WebView/WebViewData.mm:
(-[WebViewPrivate init]):
Source/WebKit2:
Enable InteractiveFormValidation setting by default and link it to
RuntimeEnabledFeatures so we can use it in the IDL.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLButtonElementidl">trunk/Source/WebCore/html/HTMLButtonElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFieldSetElementidl">trunk/Source/WebCore/html/HTMLFieldSetElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementidl">trunk/Source/WebCore/html/HTMLFormElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementidl">trunk/Source/WebCore/html/HTMLInputElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLKeygenElementidl">trunk/Source/WebCore/html/HTMLKeygenElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementidl">trunk/Source/WebCore/html/HTMLObjectElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOutputElementidl">trunk/Source/WebCore/html/HTMLOutputElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementidl">trunk/Source/WebCore/html/HTMLSelectElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementidl">trunk/Source/WebCore/html/HTMLTextAreaElement.idl</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewDatamm">trunk/Source/WebKit/mac/WebView/WebViewData.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/ChangeLog 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -1,3 +1,32 @@
</span><ins>+2016-10-17 Chris Dumez <cdumez@apple.com>
+
+ Move form.reportValidity() behind InteractiveFormValidation setting
+ https://bugs.webkit.org/show_bug.cgi?id=163550
+
+ Reviewed by Darin Adler.
+
+ Move form.reportValidity() behind InteractiveFormValidation setting for consistency
+ given that the two features are strongly related.
+
+ Also enable the setting by default so we can get feedback on the implementation.
+
+ Demos:
+ - Interactive form validation: http://jsfiddle.net/tj_vantoll/HdSqt/
+ - Report validity: https://googlechrome.github.io/samples/report-validity/
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled):
+ (WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled):
+ * html/HTMLButtonElement.idl:
+ * html/HTMLFieldSetElement.idl:
+ * html/HTMLFormElement.idl:
+ * html/HTMLInputElement.idl:
+ * html/HTMLKeygenElement.idl:
+ * html/HTMLObjectElement.idl:
+ * html/HTMLOutputElement.idl:
+ * html/HTMLSelectElement.idl:
+ * html/HTMLTextAreaElement.idl:
+
</ins><span class="cx"> 2016-10-17 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> [Modern Media Controls] Add a MediaControlsHost API to retrieve images as base64
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -198,6 +198,9 @@
</span><span class="cx"> void setShadowDOMEnabled(bool isEnabled) { m_isShadowDOMEnabled = isEnabled; }
</span><span class="cx"> bool shadowDOMEnabled() const { return m_isShadowDOMEnabled; }
</span><span class="cx">
</span><ins>+ void setInteractiveFormValidationEnabled(bool isEnabled) { m_isInteractiveFormValidationEnabled = isEnabled; }
+ bool interactiveFormValidationEnabled() const { return m_isInteractiveFormValidationEnabled; }
+
</ins><span class="cx"> #if ENABLE(CUSTOM_ELEMENTS)
</span><span class="cx"> void setCustomElementsEnabled(bool areEnabled) { m_areCustomElementsEnabled = areEnabled; }
</span><span class="cx"> bool customElementsEnabled() const { return m_areCustomElementsEnabled; }
</span><span class="lines">@@ -318,6 +321,8 @@
</span><span class="cx">
</span><span class="cx"> bool m_isShadowDOMEnabled;
</span><span class="cx">
</span><ins>+ bool m_isInteractiveFormValidationEnabled { false };
+
</ins><span class="cx"> #if ENABLE(CUSTOM_ELEMENTS)
</span><span class="cx"> bool m_areCustomElementsEnabled;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLButtonElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLButtonElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLButtonElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLButtonElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx">
</span><span class="cx"> readonly attribute NodeList labels;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFieldSetElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFieldSetElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -30,6 +30,6 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLFormElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> [ImplementedAs=submitFromJavaScript] void submit();
</span><span class="cx"> void reset();
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx">
</span><span class="cx"> [Conditional=REQUEST_AUTOCOMPLETE] void requestAutocomplete();
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx">
</span><span class="cx"> readonly attribute NodeList labels;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLKeygenElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLKeygenElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLKeygenElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx">
</span><span class="cx"> readonly attribute NodeList labels;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx">
</span><span class="cx"> // Introduced in DOM Level 2:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOutputElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOutputElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOutputElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLOutputElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx">
</span><span class="cx"> readonly attribute NodeList labels;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLSelectElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error); // FIXME: Argument should not be nullable.
</span><span class="cx">
</span><span class="cx"> readonly attribute NodeList labels;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.idl (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.idl 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.idl 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> readonly attribute ValidityState validity;
</span><span class="cx"> readonly attribute DOMString validationMessage;
</span><span class="cx"> boolean checkValidity();
</span><del>- boolean reportValidity();
</del><ins>+ [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity();
</ins><span class="cx"> void setCustomValidity(DOMString? error);
</span><span class="cx">
</span><span class="cx"> readonly attribute NodeList labels;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-10-17 Chris Dumez <cdumez@apple.com>
+
+ Move form.reportValidity() behind InteractiveFormValidation setting
+ https://bugs.webkit.org/show_bug.cgi?id=163550
+
+ Reviewed by Darin Adler.
+
+ Enable InteractiveFormValidation setting by default and link it to
+ RuntimeEnabledFeatures so we can use it in the IDL.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+ * WebView/WebViewData.mm:
+ (-[WebViewPrivate init]):
+
</ins><span class="cx"> 2016-10-17 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix iOS build.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -2537,6 +2537,8 @@
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled([preferences shadowDOMEnabled]);
</span><span class="cx">
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled([self interactiveFormValidationEnabled]);
+
</ins><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled([preferences DOMIteratorEnabled]);
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setModernMediaControlsEnabled([preferences modernMediaControlsEnabled]);
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewDatamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebViewData.mm (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebViewData.mm 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit/mac/WebView/WebViewData.mm 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -143,7 +143,7 @@
</span><span class="cx"> zoomMultiplier = 1;
</span><span class="cx"> zoomsTextOnly = NO;
</span><span class="cx">
</span><del>- interactiveFormValidationEnabled = NO;
</del><ins>+ interactiveFormValidationEnabled = YES;
</ins><span class="cx"> // The default value should be synchronized with WebCore/page/Settings.cpp.
</span><span class="cx"> validationMessageTimerMagnification = 50;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit2/ChangeLog 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-10-17 Chris Dumez <cdumez@apple.com>
+
+ Move form.reportValidity() behind InteractiveFormValidation setting
+ https://bugs.webkit.org/show_bug.cgi?id=163550
+
+ Reviewed by Darin Adler.
+
+ Enable InteractiveFormValidation setting by default and link it to
+ RuntimeEnabledFeatures so we can use it in the IDL.
+
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2016-10-17 Gavin Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> UIProcess should determine throttle state for WebContent process
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -179,7 +179,7 @@
</span><span class="cx"> macro(AsynchronousPluginInitializationEnabledForAllPlugins, asynchronousPluginInitializationEnabledForAllPlugins, Bool, bool, false, "", "") \
</span><span class="cx"> macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false, "", "") \
</span><del>- macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false, "", "") \
</del><ins>+ macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, true, "", "") \
</ins><span class="cx"> macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(ScrollAnimatorEnabled, scrollAnimatorEnabled, Bool, bool, DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED, "", "") \
</span><span class="cx"> macro(ForceUpdateScrollbarsOnMainThreadForPerformanceTesting, forceUpdateScrollbarsOnMainThreadForPerformanceTesting, Bool, bool, false, "", "") \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -243,7 +243,7 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetTabToLinksEnabled(WKPreferencesRef preferencesRef, bool enabled);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetTabToLinksEnabled(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span><del>-// Defaults to false
</del><ins>+// Defaults to true
</ins><span class="cx"> WK_EXPORT void WKPreferencesSetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef, bool enabled);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (207425 => 207426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-10-17 20:34:15 UTC (rev 207425)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-10-17 20:38:46 UTC (rev 207426)
</span><span class="lines">@@ -3197,6 +3197,8 @@
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey()));
</span><span class="cx">
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
+
</ins><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(store.getBoolValueForKey(WebPreferencesKey::domIteratorEnabledKey()));
</span><span class="cx">
</span><span class="cx"> // Experimental Features.
</span></span></pre>
</div>
</div>
</body>
</html>