<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207395] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207395">207395</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-16 15:11:41 -0700 (Sun, 16 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Modern Media Controls] Styles for StartButton are missing
https://bugs.webkit.org/show_bug.cgi?id=163499
<rdar://problem/28792009>
Patch by Antoine Quint <graouts@apple.com> on 2016-10-16
Reviewed by Darin Adler.
Source/WebCore:
Add styling for StartButton so that instances are always displayed in the center of their container.
Test: media/modern-media-controls/start-button/start-button-styles.html
* Modules/modern-media-controls/controls/start-button.css: Added.
(button.start):
(button.start > *):
(button.start > div):
(button.start > img):
(button.start:active > img):
LayoutTests:
New test checking StartButton instances have the right CSS styles applied to their DOM structure.
* media/modern-media-controls/start-button/start-button-styles-expected.txt: Added.
* media/modern-media-controls/start-button/start-button-styles.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsstartbuttonstartbuttonstylesexpectedtxt">trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsstartbuttonstartbuttonstyleshtml">trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles.html</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsstartbuttoncss">trunk/Source/WebCore/Modules/modern-media-controls/controls/start-button.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207394 => 207395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-16 18:59:31 UTC (rev 207394)
+++ trunk/LayoutTests/ChangeLog 2016-10-16 22:11:41 UTC (rev 207395)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-10-16 Antoine Quint <graouts@apple.com>
+
+ [Modern Media Controls] Styles for StartButton are missing
+ https://bugs.webkit.org/show_bug.cgi?id=163499
+ <rdar://problem/28792009>
+
+ Reviewed by Darin Adler.
+
+ New test checking StartButton instances have the right CSS styles applied to their DOM structure.
+
+ * media/modern-media-controls/start-button/start-button-styles-expected.txt: Added.
+ * media/modern-media-controls/start-button/start-button-styles.html: Added.
+
</ins><span class="cx"> 2016-10-16 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> [EFL] Meter tests have been failed since r207280
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsstartbuttonstartbuttonstylesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles-expected.txt (0 => 207395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles-expected.txt 2016-10-16 22:11:41 UTC (rev 207395)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+Testing the StartButton class.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS startButtonStyle.position is "absolute"
+PASS startButtonStyle.left is "50%"
+PASS startButtonStyle.top is "50%"
+PASS startButtonStyle.width is "70px"
+PASS startButtonStyle.height is "70px"
+PASS startButtonStyle.transform is "matrix(1, 0, 0, 1, -35, -35)"
+PASS startButtonBounds.left is 115
+PASS startButtonBounds.top is 65
+
+PASS startButtonBackgroundStyle.position is "absolute"
+PASS startButtonBackgroundStyle.left is "0px"
+PASS startButtonBackgroundStyle.top is "0px"
+PASS startButtonBackgroundStyle.width is "70px"
+PASS startButtonBackgroundStyle.height is "70px"
+PASS startButtonBackgroundStyle.webkitAppearance is "media-controls-light-bar-background"
+PASS startButtonBackgroundStyle.webkitClipPath is "circle(50% at 50% 50%)"
+PASS startButtonBackgroundStyle.willChange is "transform"
+
+PASS startButtonImageStyle.position is "absolute"
+PASS startButtonImageStyle.left is "0px"
+PASS startButtonImageStyle.top is "0px"
+PASS startButtonImageStyle.width is "70px"
+PASS startButtonImageStyle.height is "70px"
+PASS 0.6000000238418579 is within 0.001 of 0.6
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsstartbuttonstartbuttonstyleshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles.html (0 => 207395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/start-button/start-button-styles.html 2016-10-16 22:11:41 UTC (rev 207395)
</span><span class="lines">@@ -0,0 +1,69 @@
</span><ins>+<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.css" type="text/css" media="screen">
+<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/start-button.css" type="text/css" media="screen">
+<script src="../../../resources/js-test-pre.js"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/scheduler.js" type="text/javascript"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-node.js" type="text/javascript"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-item.js" type="text/javascript"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.js" type="text/javascript"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-service.js" type="text/javascript"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.js" type="text/javascript"></script>
+<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/start-button.js" type="text/javascript"></script>
+<style type="text/css" media="screen">
+
+#container {
+ position: absolute;
+ left: 0;
+ top: 0;
+ width: 300px;
+ height: 200px;
+}
+
+</style>
+<body>
+<div id="container"></div>
+<script type="text/javascript">
+
+description("Testing the <code>StartButton</code> class.");
+
+iconService.directoryPath = "../../../../Source/WebCore/Modules/modern-media-controls/images";
+
+const startButton = new StartButton({ layoutTraits: LayoutTraits.macOS });
+document.getElementById("container").appendChild(startButton.element);
+
+const startButtonStyle = window.getComputedStyle(startButton.element);
+const startButtonBounds = startButton.element.getBoundingClientRect();
+shouldBeEqualToString("startButtonStyle.position", "absolute");
+shouldBeEqualToString("startButtonStyle.left", "50%");
+shouldBeEqualToString("startButtonStyle.top", "50%");
+shouldBeEqualToString("startButtonStyle.width", "70px");
+shouldBeEqualToString("startButtonStyle.height", "70px");
+shouldBeEqualToString("startButtonStyle.transform", "matrix(1, 0, 0, 1, -35, -35)");
+shouldBe("startButtonBounds.left", "115");
+shouldBe("startButtonBounds.top", "65");
+
+debug("");
+const startButtonBackgroundStyle = window.getComputedStyle(startButton.element.firstElementChild);
+shouldBeEqualToString("startButtonBackgroundStyle.position", "absolute");
+shouldBeEqualToString("startButtonBackgroundStyle.left", "0px");
+shouldBeEqualToString("startButtonBackgroundStyle.top", "0px");
+shouldBeEqualToString("startButtonBackgroundStyle.width", "70px");
+shouldBeEqualToString("startButtonBackgroundStyle.height", "70px");
+shouldBeEqualToString("startButtonBackgroundStyle.webkitAppearance", "media-controls-light-bar-background");
+shouldBeEqualToString("startButtonBackgroundStyle.webkitClipPath", "circle(50% at 50% 50%)");
+shouldBeEqualToString("startButtonBackgroundStyle.willChange", "transform");
+
+debug("");
+const startButtonImageStyle = window.getComputedStyle(startButton.element.lastElementChild);
+shouldBeEqualToString("startButtonImageStyle.position", "absolute");
+shouldBeEqualToString("startButtonImageStyle.left", "0px");
+shouldBeEqualToString("startButtonImageStyle.top", "0px");
+shouldBeEqualToString("startButtonImageStyle.width", "70px");
+shouldBeEqualToString("startButtonImageStyle.height", "70px");
+shouldBeCloseTo(startButtonImageStyle.opacity, 0.6, 0.001);
+
+startButton.element.remove();
+debug("");
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207394 => 207395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-16 18:59:31 UTC (rev 207394)
+++ trunk/Source/WebCore/ChangeLog 2016-10-16 22:11:41 UTC (rev 207395)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-10-16 Antoine Quint <graouts@apple.com>
+
+ [Modern Media Controls] Styles for StartButton are missing
+ https://bugs.webkit.org/show_bug.cgi?id=163499
+ <rdar://problem/28792009>
+
+ Reviewed by Darin Adler.
+
+ Add styling for StartButton so that instances are always displayed in the center of their container.
+
+ Test: media/modern-media-controls/start-button/start-button-styles.html
+
+ * Modules/modern-media-controls/controls/start-button.css: Added.
+ (button.start):
+ (button.start > *):
+ (button.start > div):
+ (button.start > img):
+ (button.start:active > img):
+
</ins><span class="cx"> 2016-10-16 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Implement serializer = { attribute }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsstartbuttoncss"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/Modules/modern-media-controls/controls/start-button.css (0 => 207395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/start-button.css (rev 0)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/start-button.css 2016-10-16 22:11:41 UTC (rev 207395)
</span><span class="lines">@@ -0,0 +1,58 @@
</span><ins>+/*
+ * Copyright (C) 2016 Apple Inc. All Rights Reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+button.start {
+ position: absolute;
+ left: 50%;
+ top: 50%;
+ width: 70px;
+ height: 70px;
+
+ background: transparent !important;
+
+ transform: translate3d(-50%, -50%, 0);
+}
+
+button.start > * {
+ position: absolute;
+ left: 0;
+ top: 0;
+ width: 100%;
+ height: 100%;
+}
+
+button.start > div {
+ -webkit-appearance: media-controls-light-bar-background;
+ -webkit-clip-path: circle(50%);
+ will-change: transform;
+}
+
+button.start > img {
+ opacity: 0.6;
+}
+
+button.start:active > img {
+ opacity: 1;
+}
</ins></span></pre>
</div>
</div>
</body>
</html>