<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207334] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207334">207334</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-14 03:04:42 -0700 (Fri, 14 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>test262: Failure with RegExp.prototype.compile when pattern is undefined
https://bugs.webkit.org/show_bug.cgi?id=163431
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-10-14
Reviewed by Yusuke Suzuki.
JSTests:
* test262.yaml:
Source/JavaScriptCore:
If pattern is undefined let P be the empty String.
https://tc39.github.io/ecma262/#sec-regexpinitialize
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
LayoutTests:
* js/regexp-compile-expected.txt:
* js/script-tests/regexp-compile.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTeststest262yaml">trunk/JSTests/test262.yaml</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsregexpcompileexpectedtxt">trunk/LayoutTests/js/regexp-compile-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsregexpcompilejs">trunk/LayoutTests/js/script-tests/regexp-compile.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeRegExpPrototypecpp">trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/JSTests/ChangeLog 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-10-14 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: Failure with RegExp.prototype.compile when pattern is undefined
+ https://bugs.webkit.org/show_bug.cgi?id=163431
+
+ Reviewed by Yusuke Suzuki.
+
+ * test262.yaml:
+
</ins><span class="cx"> 2016-10-13 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Exception message for expressions with multiple bracket accesses is inconsistent / incorrect
</span></span></pre></div>
<a id="trunkJSTeststest262yaml"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/test262.yaml (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/test262.yaml 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/JSTests/test262.yaml 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -448,9 +448,9 @@
</span><span class="cx"> - path: test262/test/annexB/built-ins/RegExp/prototype/compile/pattern-to-string-err.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
</span><span class="cx"> - path: test262/test/annexB/built-ins/RegExp/prototype/compile/pattern-undefined.js
</span><del>- cmd: runTest262 :fail, "NoException", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
</del><ins>+ cmd: runTest262 :normal, "NoException", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
</ins><span class="cx"> - path: test262/test/annexB/built-ins/RegExp/prototype/compile/pattern-undefined.js
</span><del>- cmd: runTest262 :fail, "NoException", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
</del><ins>+ cmd: runTest262 :normal, "NoException", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], [:strict]
</ins><span class="cx"> - path: test262/test/annexB/built-ins/RegExp/prototype/compile/this-not-object.js
</span><span class="cx"> cmd: runTest262 :normal, "NoException", ["../../../../../../harness/assert.js", "../../../../../../harness/sta.js"], []
</span><span class="cx"> - path: test262/test/annexB/built-ins/RegExp/prototype/compile/this-not-object.js
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/LayoutTests/ChangeLog 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-10-14 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: Failure with RegExp.prototype.compile when pattern is undefined
+ https://bugs.webkit.org/show_bug.cgi?id=163431
+
+ Reviewed by Yusuke Suzuki.
+
+ * js/regexp-compile-expected.txt:
+ * js/script-tests/regexp-compile.js:
+
</ins><span class="cx"> 2016-10-14 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r207299): media/modern-media-controls/pip-button/pip-button.html and media/modern-media-controls/skip-back-button/skip-back-button.html are flaky
</span></span></pre></div>
<a id="trunkLayoutTestsjsregexpcompileexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/regexp-compile-expected.txt (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regexp-compile-expected.txt 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/LayoutTests/js/regexp-compile-expected.txt 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -17,9 +17,10 @@
</span><span class="cx"> PASS re.compile(new RegExp('c'), 'i'); threw exception TypeError: Cannot supply flags when constructing one RegExp from another..
</span><span class="cx"> PASS re.toString() is '/c/i'
</span><span class="cx"> PASS re.compile(new RegExp('+')); threw exception SyntaxError: Invalid regular expression: nothing to repeat.
</span><del>-PASS re.toString() is '/undefined/'
</del><ins>+PASS re.toString() is '/(?:)/'
+PASS re.toString() is '/(?:)/'
+PASS re.toString() is '/(?:)/'
</ins><span class="cx"> PASS re.toString() is '/null/'
</span><del>-PASS re.toString() is '/(?:)/'
</del><span class="cx"> PASS re.toString() is '/z/'
</span><span class="cx"> PASS re.lastIndex is 0
</span><span class="cx"> PASS re.lastIndex is 1
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsregexpcompilejs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/regexp-compile.js (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/regexp-compile.js 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/LayoutTests/js/script-tests/regexp-compile.js 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -31,15 +31,16 @@
</span><span class="cx">
</span><span class="cx"> shouldThrow("re.compile(new RegExp('+'));");
</span><span class="cx">
</span><ins>+re.compile();
+shouldBe("re.toString()", "'/(?:)/'");
</ins><span class="cx"> re.compile(undefined);
</span><del>-shouldBe("re.toString()", "'/undefined/'");
</del><ins>+shouldBe("re.toString()", "'/(?:)/'");
+re.compile("");
+shouldBe("re.toString()", "'/(?:)/'");
</ins><span class="cx">
</span><span class="cx"> re.compile(null);
</span><span class="cx"> shouldBe("re.toString()", "'/null/'");
</span><span class="cx">
</span><del>-re.compile();
-shouldBe("re.toString()", "'/(?:)/'");
-
</del><span class="cx"> re.compile("z", undefined);
</span><span class="cx"> shouldBe("re.toString()", "'/z/'");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-10-14 Joseph Pecoraro <pecoraro@apple.com>
+
+ test262: Failure with RegExp.prototype.compile when pattern is undefined
+ https://bugs.webkit.org/show_bug.cgi?id=163431
+
+ Reviewed by Yusuke Suzuki.
+
+ If pattern is undefined let P be the empty String.
+ https://tc39.github.io/ecma262/#sec-regexpinitialize
+
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+
</ins><span class="cx"> 2016-10-13 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Exception message for expressions with multiple bracket accesses is inconsistent / incorrect
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeRegExpPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp (207333 => 207334)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp 2016-10-14 09:49:47 UTC (rev 207333)
+++ trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp 2016-10-14 10:04:42 UTC (rev 207334)
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx"> return throwVMTypeError(exec, scope, ASCIILiteral("Cannot supply flags when constructing one RegExp from another."));
</span><span class="cx"> regExp = asRegExpObject(arg0)->regExp();
</span><span class="cx"> } else {
</span><del>- String pattern = !exec->argumentCount() ? emptyString() : arg0.toString(exec)->value(exec);
</del><ins>+ String pattern = arg0.isUndefined() ? emptyString() : arg0.toString(exec)->value(exec);
</ins><span class="cx"> RETURN_IF_EXCEPTION(scope, encodedJSValue());
</span><span class="cx">
</span><span class="cx"> RegExpFlags flags = NoFlags;
</span></span></pre>
</div>
</div>
</body>
</html>