<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207268] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207268">207268</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2016-10-12 19:14:30 -0700 (Wed, 12 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Mail needs nonspecial URLs to keep case in host and not have slash after host
https://bugs.webkit.org/show_bug.cgi?id=163373
Reviewed by Saam Barati.
Mail uses urls like scheme://HoSt which were not changed when canonicalized
before enabling the URLParser but now are canonicalized to scheme://host/
I manually verified this fixes the issue.
This should be reverted once Mail will accept modern canonicalized URLs.
* platform/URLParser.cpp:
(WebCore::URLParser::parse):
(WebCore::URLParser::parseHostAndPort):
* platform/URLParser.h:
If the application is mail and the scheme is nonspecial, don't make the host lower case and don't add a slash after the host.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformURLParsercpp">trunk/Source/WebCore/platform/URLParser.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformURLParserh">trunk/Source/WebCore/platform/URLParser.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207267 => 207268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-13 02:05:44 UTC (rev 207267)
+++ trunk/Source/WebCore/ChangeLog 2016-10-13 02:14:30 UTC (rev 207268)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-10-12 Alex Christensen <achristensen@webkit.org>
+
+ Mail needs nonspecial URLs to keep case in host and not have slash after host
+ https://bugs.webkit.org/show_bug.cgi?id=163373
+
+ Reviewed by Saam Barati.
+
+ Mail uses urls like scheme://HoSt which were not changed when canonicalized
+ before enabling the URLParser but now are canonicalized to scheme://host/
+ I manually verified this fixes the issue.
+ This should be reverted once Mail will accept modern canonicalized URLs.
+
+ * platform/URLParser.cpp:
+ (WebCore::URLParser::parse):
+ (WebCore::URLParser::parseHostAndPort):
+ * platform/URLParser.h:
+ If the application is mail and the scheme is nonspecial, don't make the host lower case and don't add a slash after the host.
+
</ins><span class="cx"> 2016-10-11 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Add preliminary support for extended colors to WebCore::Color
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformURLParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/URLParser.cpp (207267 => 207268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/URLParser.cpp 2016-10-13 02:05:44 UTC (rev 207267)
+++ trunk/Source/WebCore/platform/URLParser.cpp 2016-10-13 02:14:30 UTC (rev 207268)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> #include "URLParser.h"
</span><span class="cx">
</span><span class="cx"> #include "Logging.h"
</span><ins>+#include "RuntimeApplicationChecks.h"
</ins><span class="cx"> #include <array>
</span><span class="cx"> #include <unicode/uidna.h>
</span><span class="cx"> #include <unicode/utypes.h>
</span><span class="lines">@@ -1127,6 +1128,12 @@
</span><span class="cx"> template<typename CharacterType>
</span><span class="cx"> void URLParser::parse(const CharacterType* input, const unsigned length, const URL& base, const TextEncoding& encoding)
</span><span class="cx"> {
</span><ins>+#if PLATFORM(MAC)
+ static bool isMail = MacApplication::isAppleMail();
+#else
+ static bool isMail = false;
+#endif
+
</ins><span class="cx"> URL_PARSER_LOG("Parsing URL <%s> base <%s> encoding <%s>", String(input, length).utf8().data(), base.string().utf8().data(), encoding.name());
</span><span class="cx"> m_url = { };
</span><span class="cx"> ASSERT(m_asciiBuffer.isEmpty());
</span><span class="lines">@@ -1453,7 +1460,7 @@
</span><span class="cx"> } else {
</span><span class="cx"> m_url.m_userEnd = currentPosition(authorityOrHostBegin);
</span><span class="cx"> m_url.m_passwordEnd = m_url.m_userEnd;
</span><del>- if (!parseHostAndPort(iterator)) {
</del><ins>+ if (!parseHostAndPort(iterator, isMail)) {
</ins><span class="cx"> failure();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1475,7 +1482,7 @@
</span><span class="cx"> do {
</span><span class="cx"> LOG_STATE("Host");
</span><span class="cx"> if (*c == '/' || *c == '?' || *c == '#') {
</span><del>- if (!parseHostAndPort(CodePointIterator<CharacterType>(authorityOrHostBegin, c))) {
</del><ins>+ if (!parseHostAndPort(CodePointIterator<CharacterType>(authorityOrHostBegin, c), isMail)) {
</ins><span class="cx"> failure();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1646,7 +1653,7 @@
</span><span class="cx"> state = State::Path;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- if (!parseHostAndPort(CodePointIterator<CharacterType>(authorityOrHostBegin, c))) {
</del><ins>+ if (!parseHostAndPort(CodePointIterator<CharacterType>(authorityOrHostBegin, c), isMail)) {
</ins><span class="cx"> failure();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -1866,13 +1873,16 @@
</span><span class="cx"> m_url.m_hostEnd = m_url.m_userStart;
</span><span class="cx"> m_url.m_portEnd = m_url.m_userStart;
</span><span class="cx"> m_url.m_pathEnd = m_url.m_userStart + 2;
</span><del>- } else if (!parseHostAndPort(authorityOrHostBegin)) {
</del><ins>+ } else if (!parseHostAndPort(authorityOrHostBegin, isMail)) {
</ins><span class="cx"> failure();
</span><span class="cx"> return;
</span><span class="cx"> } else {
</span><del>- syntaxViolation(c);
- appendToASCIIBuffer('/');
- m_url.m_pathEnd = m_url.m_portEnd + 1;
</del><ins>+ if (LIKELY(!isMail || m_urlIsSpecial)) {
+ syntaxViolation(c);
+ appendToASCIIBuffer('/');
+ m_url.m_pathEnd = m_url.m_portEnd + 1;
+ } else
+ m_url.m_pathEnd = m_url.m_portEnd;
</ins><span class="cx"> }
</span><span class="cx"> m_url.m_pathAfterLastSlash = m_url.m_pathEnd;
</span><span class="cx"> m_url.m_queryEnd = m_url.m_pathEnd;
</span><span class="lines">@@ -1880,13 +1890,16 @@
</span><span class="cx"> break;
</span><span class="cx"> case State::Host:
</span><span class="cx"> LOG_FINAL_STATE("Host");
</span><del>- if (!parseHostAndPort(authorityOrHostBegin)) {
</del><ins>+ if (!parseHostAndPort(authorityOrHostBegin, isMail)) {
</ins><span class="cx"> failure();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- syntaxViolation(c);
- appendToASCIIBuffer('/');
- m_url.m_pathEnd = m_url.m_portEnd + 1;
</del><ins>+ if (LIKELY(!isMail || m_urlIsSpecial)) {
+ syntaxViolation(c);
+ appendToASCIIBuffer('/');
+ m_url.m_pathEnd = m_url.m_portEnd + 1;
+ } else
+ m_url.m_pathEnd = m_url.m_portEnd;
</ins><span class="cx"> m_url.m_pathAfterLastSlash = m_url.m_pathEnd;
</span><span class="cx"> m_url.m_queryEnd = m_url.m_pathEnd;
</span><span class="cx"> m_url.m_fragmentEnd = m_url.m_pathEnd;
</span><span class="lines">@@ -1940,7 +1953,7 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (!parseHostAndPort(CodePointIterator<CharacterType>(authorityOrHostBegin, c))) {
</del><ins>+ if (!parseHostAndPort(CodePointIterator<CharacterType>(authorityOrHostBegin, c), isMail)) {
</ins><span class="cx"> failure();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -2555,7 +2568,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-bool URLParser::parseHostAndPort(CodePointIterator<CharacterType> iterator)
</del><ins>+bool URLParser::parseHostAndPort(CodePointIterator<CharacterType> iterator, const bool& isMail)
</ins><span class="cx"> {
</span><span class="cx"> if (iterator.atEnd())
</span><span class="cx"> return false;
</span><span class="lines">@@ -2605,9 +2618,13 @@
</span><span class="cx"> }
</span><span class="cx"> for (; hostIterator != iterator; ++hostIterator) {
</span><span class="cx"> if (LIKELY(!isTabOrNewline(*hostIterator))) {
</span><del>- if (UNLIKELY(isASCIIUpper(*hostIterator)))
- syntaxViolation(hostIterator);
- appendToASCIIBuffer(toASCIILower(*hostIterator));
</del><ins>+ if (UNLIKELY(isMail && !m_urlIsSpecial))
+ appendToASCIIBuffer(*hostIterator);
+ else {
+ if (UNLIKELY(isASCIIUpper(*hostIterator)))
+ syntaxViolation(hostIterator);
+ appendToASCIIBuffer(toASCIILower(*hostIterator));
+ }
</ins><span class="cx"> } else
</span><span class="cx"> syntaxViolation(hostIterator);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformURLParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/URLParser.h (207267 => 207268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/URLParser.h 2016-10-13 02:05:44 UTC (rev 207267)
+++ trunk/Source/WebCore/platform/URLParser.h 2016-10-13 02:14:30 UTC (rev 207268)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType> void parse(const CharacterType*, const unsigned length, const URL&, const TextEncoding&);
</span><span class="cx"> template<typename CharacterType> void parseAuthority(CodePointIterator<CharacterType>);
</span><del>- template<typename CharacterType> bool parseHostAndPort(CodePointIterator<CharacterType>);
</del><ins>+ template<typename CharacterType> bool parseHostAndPort(CodePointIterator<CharacterType>, const bool& isMail);
</ins><span class="cx"> template<typename CharacterType> bool parsePort(CodePointIterator<CharacterType>&);
</span><span class="cx">
</span><span class="cx"> void failure();
</span></span></pre>
</div>
</div>
</body>
</html>