<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207256] branches/safari-602.2.14.0-branch/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207256">207256</a></dd>
<dt>Author</dt> <dd>matthew_hanson@apple.com</dd>
<dt>Date</dt> <dd>2016-10-12 16:02:05 -0700 (Wed, 12 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/204631">r204631</a>. rdar://problem/28481427</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari6022140branchSourceWebCoreChangeLog">branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari6022140branchSourceWebCorepageDOMWindowcpp">branches/safari-602.2.14.0-branch/Source/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#branchessafari6022140branchSourceWebCorepageFramecpp">branches/safari-602.2.14.0-branch/Source/WebCore/page/Frame.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari6022140branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog (207255 => 207256)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog 2016-10-12 23:02:01 UTC (rev 207255)
+++ branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog 2016-10-12 23:02:05 UTC (rev 207256)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2016-10-12 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><ins>+ Merge r204631. rdar://problem/28481427
+
+ 2016-08-19 Chris Dumez <cdumez@apple.com>
+
+ DumpRenderTree crashed in com.apple.WebCore: WebCore::DOMWindow::resetDOMWindowProperties + 607
+ https://bugs.webkit.org/show_bug.cgi?id=160983
+ <rdar://problem/26768524>
+
+ Reviewed by Brent Fulgham.
+
+ Update DOMWindow::frameDestroyed() to ref the window object as the crash
+ traces seem to indicate it can get destroyed during the execution of this
+ method. Also update the code in the ~Frame destructor to not iterate over
+ the list of FrameDestructionObservers because observers remove themselves
+ from the list when they get destroyed.
+
+ No new tests, do not know how to reproduce.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::frameDestroyed):
+ * page/Frame.cpp:
+ (WebCore::Frame::~Frame):
+
+2016-10-12 Matthew Hanson <matthew_hanson@apple.com>
+
</ins><span class="cx"> Merge r204266. rdar://problem/28216261
</span><span class="cx">
</span><span class="cx"> 2016-08-08 John Wilander <wilander@apple.com>
</span></span></pre></div>
<a id="branchessafari6022140branchSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602.2.14.0-branch/Source/WebCore/page/DOMWindow.cpp (207255 => 207256)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602.2.14.0-branch/Source/WebCore/page/DOMWindow.cpp 2016-10-12 23:02:01 UTC (rev 207255)
+++ branches/safari-602.2.14.0-branch/Source/WebCore/page/DOMWindow.cpp 2016-10-12 23:02:05 UTC (rev 207256)
</span><span class="lines">@@ -480,6 +480,8 @@
</span><span class="cx">
</span><span class="cx"> void DOMWindow::frameDestroyed()
</span><span class="cx"> {
</span><ins>+ Ref<DOMWindow> protectedThis(*this);
+
</ins><span class="cx"> willDestroyDocumentInFrame();
</span><span class="cx"> FrameDestructionObserver::frameDestroyed();
</span><span class="cx"> resetDOMWindowProperties();
</span></span></pre></div>
<a id="branchessafari6022140branchSourceWebCorepageFramecpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602.2.14.0-branch/Source/WebCore/page/Frame.cpp (207255 => 207256)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602.2.14.0-branch/Source/WebCore/page/Frame.cpp 2016-10-12 23:02:01 UTC (rev 207255)
+++ branches/safari-602.2.14.0-branch/Source/WebCore/page/Frame.cpp 2016-10-12 23:02:05 UTC (rev 207256)
</span><span class="lines">@@ -217,8 +217,8 @@
</span><span class="cx">
</span><span class="cx"> disconnectOwnerElement();
</span><span class="cx">
</span><del>- for (auto& observer : m_destructionObservers)
- observer->frameDestroyed();
</del><ins>+ while (auto* destructionObserver = m_destructionObservers.takeAny())
+ destructionObserver->frameDestroyed();
</ins><span class="cx">
</span><span class="cx"> if (!isMainFrame())
</span><span class="cx"> m_mainFrame.selfOnlyDeref();
</span></span></pre>
</div>
</div>
</body>
</html>