<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207238] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207238">207238</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-12 13:41:49 -0700 (Wed, 12 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update more events to stop using legacy [ConstructorTemplate=Event]
https://bugs.webkit.org/show_bug.cgi?id=163339
Reviewed by Ryosuke Niwa.
Source/WebCore:
Update more events to stop using legacy [ConstructorTemplate=Event]
and use regular constructors instead.
No new tests, updated existing tests.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::convertDictionary<TestEventConstructor::Init>):
(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::JSTestEventConstructorConstructor::prototypeForStructure):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::createPrototype):
(WebCore::JSTestEventConstructorPrototype::create): Deleted.
(WebCore::JSTestEventConstructorPrototype::createStructure): Deleted.
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype): Deleted.
(WebCore::setJSTestEventConstructorConstructor): Deleted.
(WebCore::JSTestEventConstructor::getConstructor): Deleted.
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::wrapped):
(WebCore::JSTestEventConstructor::create): Deleted.
(WebCore::toJS): Deleted.
(WebCore::toJSNewlyCreated): Deleted.
* bindings/scripts/test/TestEventConstructor.idl:
* css/CSSFontFaceLoadEvent.cpp:
(WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
* css/CSSFontFaceLoadEvent.h:
* css/CSSFontFaceLoadEvent.idl:
* html/canvas/WebGLContextEvent.cpp:
(WebCore::WebGLContextEvent::WebGLContextEvent):
* html/canvas/WebGLContextEvent.h:
* html/canvas/WebGLContextEvent.idl:
* storage/StorageEvent.cpp:
(WebCore::StorageEvent::create):
(WebCore::StorageEvent::StorageEvent):
* storage/StorageEvent.h:
* storage/StorageEvent.idl:
LayoutTests:
Update existing tests to reflect minor behavior changes.
* fast/events/constructors/storage-event-constructor-expected.txt:
* fast/events/constructors/storage-event-constructor.html:
* fast/events/constructors/webgl-context-event-constructor-expected.txt:
* fast/events/constructors/webgl-context-event-constructor.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsstorageeventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/storage-event-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsstorageeventconstructorhtml">trunk/LayoutTests/fast/events/constructors/storage-event-constructor.html</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorswebglcontexteventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorswebglcontexteventconstructorhtml">trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor.html</a></li>
<li><a href="#trunkLayoutTestsstoragedomstorageeventsbasicexpectedtxt">trunk/LayoutTests/storage/domstorage/events/basic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragedomstorageeventsbasicsetattributeexpectedtxt">trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragedomstorageeventsscripttestsbasicsetattributejs">trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js</a></li>
<li><a href="#trunkLayoutTestsstoragedomstorageeventsscripttestsbasicjs">trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorh">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestEventConstructoridl">trunk/Source/WebCore/bindings/scripts/test/TestEventConstructor.idl</a></li>
<li><a href="#trunkSourceWebCorecssCSSFontFaceLoadEventcpp">trunk/Source/WebCore/css/CSSFontFaceLoadEvent.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSFontFaceLoadEventh">trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSFontFaceLoadEventidl">trunk/Source/WebCore/css/CSSFontFaceLoadEvent.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLContextEventcpp">trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLContextEventh">trunk/Source/WebCore/html/canvas/WebGLContextEvent.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLContextEventidl">trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl</a></li>
<li><a href="#trunkSourceWebCorestorageStorageEventcpp">trunk/Source/WebCore/storage/StorageEvent.cpp</a></li>
<li><a href="#trunkSourceWebCorestorageStorageEventh">trunk/Source/WebCore/storage/StorageEvent.h</a></li>
<li><a href="#trunkSourceWebCorestorageStorageEventidl">trunk/Source/WebCore/storage/StorageEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/ChangeLog 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-10-12 Chris Dumez <cdumez@apple.com>
+
+ Update more events to stop using legacy [ConstructorTemplate=Event]
+ https://bugs.webkit.org/show_bug.cgi?id=163339
+
+ Reviewed by Ryosuke Niwa.
+
+ Update existing tests to reflect minor behavior changes.
+
+ * fast/events/constructors/storage-event-constructor-expected.txt:
+ * fast/events/constructors/storage-event-constructor.html:
+ * fast/events/constructors/webgl-context-event-constructor-expected.txt:
+ * fast/events/constructors/webgl-context-event-constructor.html:
+
</ins><span class="cx"> 2016-10-12 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Improve support for logging Proxy objects in console
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsstorageeventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/storage-event-constructor-expected.txt (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/storage-event-constructor-expected.txt 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/fast/events/constructors/storage-event-constructor-expected.txt 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx">
</span><span class="cx"> PASS new StorageEvent('eventType').bubbles is false
</span><span class="cx"> PASS new StorageEvent('eventType').cancelable is false
</span><del>-PASS new StorageEvent('eventType').key is ""
</del><ins>+PASS new StorageEvent('eventType').key is null
</ins><span class="cx"> PASS new StorageEvent('eventType').oldValue is null
</span><span class="cx"> PASS new StorageEvent('eventType').newValue is null
</span><span class="cx"> PASS new StorageEvent('eventType').url is ""
</span><span class="lines">@@ -16,8 +16,8 @@
</span><span class="cx"> PASS new StorageEvent('eventType', { cancelable: true }).cancelable is true
</span><span class="cx"> PASS new StorageEvent('eventType', { key: 'abcde' }).key is "abcde"
</span><span class="cx"> PASS new StorageEvent('eventType', { key: '' }).key is ""
</span><del>-PASS new StorageEvent('eventType', { key: undefined }).key is "undefined"
-PASS new StorageEvent('eventType', { key: null }).key is "null"
</del><ins>+PASS new StorageEvent('eventType', { key: undefined }).key is null
+PASS new StorageEvent('eventType', { key: null }).key is null
</ins><span class="cx"> PASS new StorageEvent('eventType', { key: false }).key is "false"
</span><span class="cx"> PASS new StorageEvent('eventType', { key: true }).key is "true"
</span><span class="cx"> PASS new StorageEvent('eventType', { key: 12345 }).key is "12345"
</span><span class="lines">@@ -29,8 +29,8 @@
</span><span class="cx"> PASS new StorageEvent('eventType', { key: {valueOf: function () { return 'abcde'; } } }).key is "[object Object]"
</span><span class="cx"> PASS new StorageEvent('eventType', { oldValue: 'abcde' }).oldValue is "abcde"
</span><span class="cx"> PASS new StorageEvent('eventType', { oldValue: '' }).oldValue is ""
</span><del>-PASS new StorageEvent('eventType', { oldValue: undefined }).oldValue is "undefined"
-PASS new StorageEvent('eventType', { oldValue: null }).oldValue is "null"
</del><ins>+PASS new StorageEvent('eventType', { oldValue: undefined }).oldValue is null
+PASS new StorageEvent('eventType', { oldValue: null }).oldValue is null
</ins><span class="cx"> PASS new StorageEvent('eventType', { oldValue: false }).oldValue is "false"
</span><span class="cx"> PASS new StorageEvent('eventType', { oldValue: true }).oldValue is "true"
</span><span class="cx"> PASS new StorageEvent('eventType', { oldValue: 12345 }).oldValue is "12345"
</span><span class="lines">@@ -42,8 +42,8 @@
</span><span class="cx"> PASS new StorageEvent('eventType', { oldValue: {valueOf: function () { return 'abcde'; } } }).oldValue is "[object Object]"
</span><span class="cx"> PASS new StorageEvent('eventType', { newValue: 'abcde' }).newValue is "abcde"
</span><span class="cx"> PASS new StorageEvent('eventType', { newValue: '' }).newValue is ""
</span><del>-PASS new StorageEvent('eventType', { newValue: undefined }).newValue is "undefined"
-PASS new StorageEvent('eventType', { newValue: null }).newValue is "null"
</del><ins>+PASS new StorageEvent('eventType', { newValue: undefined }).newValue is null
+PASS new StorageEvent('eventType', { newValue: null }).newValue is null
</ins><span class="cx"> PASS new StorageEvent('eventType', { newValue: false }).newValue is "false"
</span><span class="cx"> PASS new StorageEvent('eventType', { newValue: true }).newValue is "true"
</span><span class="cx"> PASS new StorageEvent('eventType', { newValue: 12345 }).newValue is "12345"
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> PASS new StorageEvent('eventType', { newValue: {valueOf: function () { return 'abcde'; } } }).newValue is "[object Object]"
</span><span class="cx"> PASS new StorageEvent('eventType', { url: 'abcde' }).url is "abcde"
</span><span class="cx"> PASS new StorageEvent('eventType', { url: '' }).url is ""
</span><del>-PASS new StorageEvent('eventType', { url: undefined }).url is "undefined"
</del><ins>+PASS new StorageEvent('eventType', { url: undefined }).url is ""
</ins><span class="cx"> PASS new StorageEvent('eventType', { url: null }).url is "null"
</span><span class="cx"> PASS new StorageEvent('eventType', { url: false }).url is "false"
</span><span class="cx"> PASS new StorageEvent('eventType', { url: true }).url is "true"
</span><span class="lines">@@ -68,20 +68,20 @@
</span><span class="cx"> PASS new StorageEvent('eventType', { url: {valueOf: function () { return 'abcde'; } } }).url is "[object Object]"
</span><span class="cx"> PASS new StorageEvent('eventType', { storageArea: localStorage }).storageArea is localStorage
</span><span class="cx"> PASS new StorageEvent('eventType', { storageArea: sessionStorage }).storageArea is sessionStorage
</span><del>-PASS new StorageEvent('eventType', { storageArea: test_object }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: window }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: document }).storageArea is null
</del><ins>+PASS new StorageEvent('eventType', { storageArea: test_object }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: window }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: document }) threw exception TypeError: Type error.
</ins><span class="cx"> PASS new StorageEvent('eventType', { storageArea: undefined }).storageArea is null
</span><span class="cx"> PASS new StorageEvent('eventType', { storageArea: null }).storageArea is null
</span><del>-PASS new StorageEvent('eventType', { storageArea: false }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: true }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: '' }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: 'chocolate' }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: 12345 }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: 18446744073709551615 }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: NaN }).storageArea is null
-PASS new StorageEvent('eventType', { storageArea: {valueOf: function () { return window; } } }).storageArea == window is false
-PASS new StorageEvent('eventType', { get storageArea() { return 123; } }).storageArea is null
</del><ins>+PASS new StorageEvent('eventType', { storageArea: false }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: true }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: '' }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: 'chocolate' }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: 12345 }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: 18446744073709551615 }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: NaN }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { storageArea: {valueOf: function () { return window; } } }) threw exception TypeError: Type error.
+PASS new StorageEvent('eventType', { get storageArea() { return 123; } }).storageArea threw exception TypeError: Type error.
</ins><span class="cx"> PASS new StorageEvent('eventType', { get storageArea() { throw 'StorageEvent Error'; } }) threw exception StorageEvent Error.
</span><span class="cx"> PASS new StorageEvent('eventType', { bubbles: true, cancelable: false, key: 'abc', oldValue: 'def', newValue: 'ghi', url: 'jkl', storageArea: localStorage }).bubbles is true
</span><span class="cx"> PASS new StorageEvent('eventType', { bubbles: false, cancelable: true, key: 'abc', oldValue: 'def', newValue: 'ghi', url: 'jkl', storageArea: localStorage }).cancelable is true
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsstorageeventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/storage-event-constructor.html (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/storage-event-constructor.html 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/fast/events/constructors/storage-event-constructor.html 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx"> // No initializer is passed.
</span><span class="cx"> shouldBe("new StorageEvent('eventType').bubbles", "false");
</span><span class="cx"> shouldBe("new StorageEvent('eventType').cancelable", "false");
</span><del>-shouldBeEqualToString("new StorageEvent('eventType').key", "");
</del><ins>+shouldBe("new StorageEvent('eventType').key", "null");
</ins><span class="cx"> // Note: oldValue is nullable.
</span><span class="cx"> shouldBe("new StorageEvent('eventType').oldValue", "null");
</span><span class="cx"> // Note: newValue is nullable.
</span><span class="lines">@@ -36,8 +36,14 @@
</span><span class="cx"> shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": '' })." + attr, "");
</span><span class="cx">
</span><span class="cx"> // Non-strings.
</span><del>- shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": undefined })." + attr, "undefined");
- shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": null })." + attr, "null");
</del><ins>+ if (attr == "key" || attr == "oldValue" || attr == "newValue") {
+ // Those members are nullable.
+ shouldBe("new StorageEvent('eventType', { " + attr + ": undefined })." + attr, "null");
+ shouldBe("new StorageEvent('eventType', { " + attr + ": null })." + attr, "null");
+ } else {
+ shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": undefined })." + attr, "");
+ shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": null })." + attr, "null");
+ }
</ins><span class="cx"> shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": false })." + attr, "false");
</span><span class="cx"> shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": true })." + attr, "true");
</span><span class="cx"> shouldBeEqualToString("new StorageEvent('eventType', { " + attr + ": 12345 })." + attr, "12345");
</span><span class="lines">@@ -56,21 +62,21 @@
</span><span class="cx">
</span><span class="cx"> // Non-Storage objects.
</span><span class="cx"> var test_object = {abc: 123};
</span><del>-shouldBe("new StorageEvent('eventType', { storageArea: test_object }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: window }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: document }).storageArea", "null");
</del><ins>+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: test_object })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: window })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: document })", "TypeError");
</ins><span class="cx"> shouldBe("new StorageEvent('eventType', { storageArea: undefined }).storageArea", "null");
</span><span class="cx"> shouldBe("new StorageEvent('eventType', { storageArea: null }).storageArea", "null");
</span><del>-shouldBe("new StorageEvent('eventType', { storageArea: false }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: true }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: '' }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: 'chocolate' }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: 12345 }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: 18446744073709551615 }).storageArea", "null");
-shouldBe("new StorageEvent('eventType', { storageArea: NaN }).storageArea", "null");
</del><ins>+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: false })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: true })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: '' })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: 'chocolate' })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: 12345 })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: 18446744073709551615 })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: NaN })", "TypeError");
</ins><span class="cx"> // Note that valueOf() is not called, when the left hand side is evaluated.
</span><del>-shouldBeFalse("new StorageEvent('eventType', { storageArea: {valueOf: function () { return window; } } }).storageArea == window");
-shouldBe("new StorageEvent('eventType', { get storageArea() { return 123; } }).storageArea", "null");
</del><ins>+shouldThrowErrorName("new StorageEvent('eventType', { storageArea: {valueOf: function () { return window; } } })", "TypeError");
+shouldThrowErrorName("new StorageEvent('eventType', { get storageArea() { return 123; } }).storageArea", "TypeError");
</ins><span class="cx"> shouldThrow("new StorageEvent('eventType', { get storageArea() { throw 'StorageEvent Error'; } })");
</span><span class="cx">
</span><span class="cx"> // All initializers are passed.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorswebglcontexteventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor-expected.txt (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor-expected.txt 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor-expected.txt 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx"> PASS new WebGLContextEvent('eventType', { cancelable: true }).cancelable is true
</span><span class="cx"> PASS new WebGLContextEvent('eventType', { statusMessage: 'abcde' }).statusMessage is "abcde"
</span><span class="cx"> PASS new WebGLContextEvent('eventType', { statusMessage: '' }).statusMessage is ""
</span><del>-PASS new WebGLContextEvent('eventType', { statusMessage: undefined }).statusMessage is "undefined"
</del><ins>+PASS new WebGLContextEvent('eventType', { statusMessage: undefined }).statusMessage is ""
</ins><span class="cx"> PASS new WebGLContextEvent('eventType', { statusMessage: null }).statusMessage is "null"
</span><span class="cx"> PASS new WebGLContextEvent('eventType', { statusMessage: false }).statusMessage is "false"
</span><span class="cx"> PASS new WebGLContextEvent('eventType', { statusMessage: true }).statusMessage is "true"
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorswebglcontexteventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor.html (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor.html 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/fast/events/constructors/webgl-context-event-constructor.html 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -29,7 +29,7 @@
</span><span class="cx"> shouldBeEqualToString("new WebGLContextEvent('eventType', { statusMessage: '' }).statusMessage", "");
</span><span class="cx">
</span><span class="cx"> // Non-strings.
</span><del>-shouldBeEqualToString("new WebGLContextEvent('eventType', { statusMessage: undefined }).statusMessage", "undefined");
</del><ins>+shouldBeEqualToString("new WebGLContextEvent('eventType', { statusMessage: undefined }).statusMessage", "");
</ins><span class="cx"> shouldBeEqualToString("new WebGLContextEvent('eventType', { statusMessage: null }).statusMessage", "null");
</span><span class="cx"> shouldBeEqualToString("new WebGLContextEvent('eventType', { statusMessage: false }).statusMessage", "false");
</span><span class="cx"> shouldBeEqualToString("new WebGLContextEvent('eventType', { statusMessage: true }).statusMessage", "true");
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstorageeventsbasicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/events/basic-expected.txt (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/events/basic-expected.txt 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/storage/domstorage/events/basic-expected.txt 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> PASS storageEventList[6].newValue is null
</span><span class="cx"> storage.clear()
</span><span class="cx"> PASS storageEventList.length is 8
</span><del>-PASS storageEventList[7].key is ""
</del><ins>+PASS storageEventList[7].key is null
</ins><span class="cx"> PASS storageEventList[7].oldValue is null
</span><span class="cx"> PASS storageEventList[7].newValue is null
</span><span class="cx">
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> PASS storageEventList[6].newValue is null
</span><span class="cx"> storage.clear()
</span><span class="cx"> PASS storageEventList.length is 8
</span><del>-PASS storageEventList[7].key is ""
</del><ins>+PASS storageEventList[7].key is null
</ins><span class="cx"> PASS storageEventList[7].oldValue is null
</span><span class="cx"> PASS storageEventList[7].newValue is null
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstorageeventsbasicsetattributeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> PASS storageEventList[6].newValue is null
</span><span class="cx"> storage.clear()
</span><span class="cx"> PASS storageEventList.length is 8
</span><del>-PASS storageEventList[7].key is ""
</del><ins>+PASS storageEventList[7].key is null
</ins><span class="cx"> PASS storageEventList[7].oldValue is null
</span><span class="cx"> PASS storageEventList[7].newValue is null
</span><span class="cx">
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> PASS storageEventList[6].newValue is null
</span><span class="cx"> storage.clear()
</span><span class="cx"> PASS storageEventList.length is 8
</span><del>-PASS storageEventList[7].key is ""
</del><ins>+PASS storageEventList[7].key is null
</ins><span class="cx"> PASS storageEventList[7].oldValue is null
</span><span class="cx"> PASS storageEventList[7].newValue is null
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstorageeventsscripttestsbasicsetattributejs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> function step6()
</span><span class="cx"> {
</span><span class="cx"> shouldBe("storageEventList.length", "8");
</span><del>- shouldBeEqualToString("storageEventList[7].key", "");
</del><ins>+ shouldBeNull("storageEventList[7].key");
</ins><span class="cx"> shouldBeNull("storageEventList[7].oldValue");
</span><span class="cx"> shouldBeNull("storageEventList[7].newValue");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstoragedomstorageeventsscripttestsbasicjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> function step6()
</span><span class="cx"> {
</span><span class="cx"> shouldBe("storageEventList.length", "8");
</span><del>- shouldBeEqualToString("storageEventList[7].key", "");
</del><ins>+ shouldBeNull("storageEventList[7].key");
</ins><span class="cx"> shouldBeNull("storageEventList[7].oldValue");
</span><span class="cx"> shouldBeNull("storageEventList[7].newValue");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/ChangeLog 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -1,3 +1,46 @@
</span><ins>+2016-10-12 Chris Dumez <cdumez@apple.com>
+
+ Update more events to stop using legacy [ConstructorTemplate=Event]
+ https://bugs.webkit.org/show_bug.cgi?id=163339
+
+ Reviewed by Ryosuke Niwa.
+
+ Update more events to stop using legacy [ConstructorTemplate=Event]
+ and use regular constructors instead.
+
+ No new tests, updated existing tests.
+
+ * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+ (WebCore::convertDictionary<TestEventConstructor::Init>):
+ (WebCore::JSTestEventConstructorConstructor::construct):
+ (WebCore::JSTestEventConstructorConstructor::prototypeForStructure):
+ (WebCore::JSTestEventConstructor::JSTestEventConstructor):
+ (WebCore::JSTestEventConstructor::createPrototype):
+ (WebCore::JSTestEventConstructorPrototype::create): Deleted.
+ (WebCore::JSTestEventConstructorPrototype::createStructure): Deleted.
+ (WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype): Deleted.
+ (WebCore::setJSTestEventConstructorConstructor): Deleted.
+ (WebCore::JSTestEventConstructor::getConstructor): Deleted.
+ * bindings/scripts/test/JS/JSTestEventConstructor.h:
+ (WebCore::JSTestEventConstructor::wrapped):
+ (WebCore::JSTestEventConstructor::create): Deleted.
+ (WebCore::toJS): Deleted.
+ (WebCore::toJSNewlyCreated): Deleted.
+ * bindings/scripts/test/TestEventConstructor.idl:
+ * css/CSSFontFaceLoadEvent.cpp:
+ (WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
+ * css/CSSFontFaceLoadEvent.h:
+ * css/CSSFontFaceLoadEvent.idl:
+ * html/canvas/WebGLContextEvent.cpp:
+ (WebCore::WebGLContextEvent::WebGLContextEvent):
+ * html/canvas/WebGLContextEvent.h:
+ * html/canvas/WebGLContextEvent.idl:
+ * storage/StorageEvent.cpp:
+ (WebCore::StorageEvent::create):
+ (WebCore::StorageEvent::StorageEvent):
+ * storage/StorageEvent.h:
+ * storage/StorageEvent.idl:
+
</ins><span class="cx"> 2016-10-12 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Make Document::existingAXObjectCache() fast with accessibility disabled.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -21,12 +21,11 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestEventConstructor.h"
</span><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><del>-#include "JSDictionary.h"
</del><span class="cx"> #include "URL.h"
</span><span class="cx"> #include <runtime/Error.h>
</span><del>-#include <runtime/FunctionPrototype.h>
</del><span class="cx"> #include <runtime/JSString.h>
</span><span class="cx"> #include <wtf/GetPtr.h>
</span><span class="cx">
</span><span class="lines">@@ -34,6 +33,54 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><ins>+template<> Optional<TestEventConstructor::Init> convertDictionary<TestEventConstructor::Init>(ExecState& state, JSValue value)
+{
+ VM& vm = state.vm();
+ auto throwScope = DECLARE_THROW_SCOPE(vm);
+ bool isNullOrUndefined = value.isUndefinedOrNull();
+ auto* object = isNullOrUndefined ? nullptr : value.getObject();
+ if (UNLIKELY(!isNullOrUndefined && !object)) {
+ throwTypeError(&state, throwScope);
+ return Nullopt;
+ }
+ if (UNLIKELY(object && object->type() == RegExpObjectType)) {
+ throwTypeError(&state, throwScope);
+ return Nullopt;
+ }
+ TestEventConstructor::Init result;
+ JSValue bubblesValue = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "bubbles"));
+ if (!bubblesValue.isUndefined()) {
+ result.bubbles = convert<IDLBoolean>(state, bubblesValue);
+ RETURN_IF_EXCEPTION(throwScope, Nullopt);
+ } else
+ result.bubbles = false;
+ JSValue cancelableValue = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "cancelable"));
+ if (!cancelableValue.isUndefined()) {
+ result.cancelable = convert<IDLBoolean>(state, cancelableValue);
+ RETURN_IF_EXCEPTION(throwScope, Nullopt);
+ } else
+ result.cancelable = false;
+ JSValue composedValue = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "composed"));
+ if (!composedValue.isUndefined()) {
+ result.composed = convert<IDLBoolean>(state, composedValue);
+ RETURN_IF_EXCEPTION(throwScope, Nullopt);
+ } else
+ result.composed = false;
+ JSValue attr2Value = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "attr2"));
+ if (!attr2Value.isUndefined()) {
+ result.attr2 = convert<IDLDOMString>(state, attr2Value);
+ RETURN_IF_EXCEPTION(throwScope, Nullopt);
+ } else
+ result.attr2 = "";
+ JSValue attr3Value = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "attr3"));
+ if (!attr3Value.isUndefined()) {
+ result.attr3 = convert<IDLDOMString>(state, attr3Value);
+ RETURN_IF_EXCEPTION(throwScope, Nullopt);
+ } else
+ result.attr3 = "";
+ return WTFMove(result);
+}
+
</ins><span class="cx"> // Attributes
</span><span class="cx">
</span><span class="cx"> JSC::EncodedJSValue jsTestEventConstructorAttr1(JSC::ExecState*, JSC::EncodedJSValue, JSC::PropertyName);
</span><span class="lines">@@ -75,53 +122,22 @@
</span><span class="cx"> {
</span><span class="cx"> VM& vm = state->vm();
</span><span class="cx"> auto throwScope = DECLARE_THROW_SCOPE(vm);
</span><del>- auto* jsConstructor = jsCast<JSTestEventConstructorConstructor*>(state->callee());
- ASSERT(jsConstructor);
-
- if (!jsConstructor->scriptExecutionContext())
- return throwConstructorScriptExecutionContextUnavailableError(*state, throwScope, "TestEventConstructor");
-
</del><ins>+ UNUSED_PARAM(throwScope);
+ auto* castedThis = jsCast<JSTestEventConstructorConstructor*>(state->callee());
+ ASSERT(castedThis);
</ins><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, throwScope, createNotEnoughArgumentsError(state));
</span><del>-
- AtomicString eventType = state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</del><ins>+ auto type = state->uncheckedArgument(0).toWTFString(state);
</ins><span class="cx"> RETURN_IF_EXCEPTION(throwScope, encodedJSValue());
</span><del>-
- TestEventConstructorInit eventInit;
-
- JSValue initializerValue = state->argument(1);
- if (!initializerValue.isUndefinedOrNull()) {
- // Given the above test, this will always yield an object.
- JSObject* initializerObject = initializerValue.toObject(state);
- ASSERT(!throwScope.exception());
-
- // Create the dictionary wrapper from the initializer object.
- JSDictionary dictionary(state, initializerObject);
-
- // Attempt to fill in the EventInit.
- if (!fillTestEventConstructorInit(eventInit, dictionary))
- return JSValue::encode(jsUndefined());
- }
-
- Ref<TestEventConstructor> event = TestEventConstructor::createForBindings(eventType, eventInit);
- return JSValue::encode(createWrapper<TestEventConstructor>(jsConstructor->globalObject(), WTFMove(event)));
</del><ins>+ auto eventInitDict = convert<IDLDictionary<TestEventConstructor::Init>>(*state, state->argument(1));
+ RETURN_IF_EXCEPTION(throwScope, encodedJSValue());
+ auto object = TestEventConstructor::create(WTFMove(type), eventInitDict.value());
+ return JSValue::encode(toJSNewlyCreated(state, castedThis->globalObject(), WTFMove(object)));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-bool fillTestEventConstructorInit(TestEventConstructorInit& eventInit, JSDictionary& dictionary)
-{
- if (!dictionary.tryGetProperty("attr2", eventInit.attr2))
- return false;
-#if ENABLE(SPECIAL_EVENT)
- if (!dictionary.tryGetProperty("attr3", eventInit.attr3))
- return false;
-#endif
- return true;
-}
-
</del><span class="cx"> template<> JSValue JSTestEventConstructorConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
</span><span class="cx"> {
</span><del>- UNUSED_PARAM(vm);
- return globalObject.functionPrototype();
</del><ins>+ return JSEvent::getConstructor(vm, &globalObject);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<> void JSTestEventConstructorConstructor::initializeProperties(VM& vm, JSDOMGlobalObject& globalObject)
</span><span class="lines">@@ -158,13 +174,13 @@
</span><span class="cx"> const ClassInfo JSTestEventConstructor::s_info = { "TestEventConstructor", &Base::s_info, 0, CREATE_METHOD_TABLE(JSTestEventConstructor) };
</span><span class="cx">
</span><span class="cx"> JSTestEventConstructor::JSTestEventConstructor(Structure* structure, JSDOMGlobalObject& globalObject, Ref<TestEventConstructor>&& impl)
</span><del>- : JSDOMWrapper<TestEventConstructor>(structure, globalObject, WTFMove(impl))
</del><ins>+ : JSEvent(structure, globalObject, WTFMove(impl))
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSObject* JSTestEventConstructor::createPrototype(VM& vm, JSGlobalObject* globalObject)
</span><span class="cx"> {
</span><del>- return JSTestEventConstructorPrototype::create(vm, globalObject, JSTestEventConstructorPrototype::createStructure(vm, globalObject, globalObject->objectPrototype()));
</del><ins>+ return JSTestEventConstructorPrototype::create(vm, globalObject, JSTestEventConstructorPrototype::createStructure(vm, globalObject, JSEvent::prototype(vm, globalObject)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSObject* JSTestEventConstructor::prototype(VM& vm, JSGlobalObject* globalObject)
</span><span class="lines">@@ -172,12 +188,6 @@
</span><span class="cx"> return getDOMPrototype<JSTestEventConstructor>(vm, globalObject);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void JSTestEventConstructor::destroy(JSC::JSCell* cell)
-{
- JSTestEventConstructor* thisObject = static_cast<JSTestEventConstructor*>(cell);
- thisObject->JSTestEventConstructor::~JSTestEventConstructor();
-}
-
</del><span class="cx"> template<> inline JSTestEventConstructor* BindingCaller<JSTestEventConstructor>::castForAttribute(ExecState&, EncodedJSValue thisValue)
</span><span class="cx"> {
</span><span class="cx"> return jsDynamicCast<JSTestEventConstructor*>(JSValue::decode(thisValue));
</span><span class="lines">@@ -263,20 +273,6 @@
</span><span class="cx"> return getDOMConstructor<JSTestEventConstructorConstructor>(vm, *jsCast<const JSDOMGlobalObject*>(globalObject));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool JSTestEventConstructorOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
-{
- UNUSED_PARAM(handle);
- UNUSED_PARAM(visitor);
- return false;
-}
-
-void JSTestEventConstructorOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
-{
- auto* jsTestEventConstructor = jsCast<JSTestEventConstructor*>(handle.slot()->asCell());
- auto& world = *static_cast<DOMWrapperWorld*>(context);
- uncacheWrapper(world, &jsTestEventConstructor->wrapped(), jsTestEventConstructor);
-}
-
</del><span class="cx"> #if ENABLE(BINDING_INTEGRITY)
</span><span class="cx"> #if PLATFORM(WIN)
</span><span class="cx"> #pragma warning(disable: 4483)
</span><span class="lines">@@ -315,11 +311,5 @@
</span><span class="cx"> return wrap(state, globalObject, impl);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-TestEventConstructor* JSTestEventConstructor::toWrapped(JSC::JSValue value)
-{
- if (auto* wrapper = jsDynamicCast<JSTestEventConstructor*>(value))
- return &wrapper->wrapped();
- return nullptr;
-}
</del><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -20,17 +20,16 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "JSDOMWrapper.h"
</del><ins>+#include "JSDOMConvert.h"
+#include "JSEvent.h"
</ins><span class="cx"> #include "TestEventConstructor.h"
</span><del>-#include <wtf/NeverDestroyed.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class JSDictionary;
-
-class JSTestEventConstructor : public JSDOMWrapper<TestEventConstructor> {
</del><ins>+class JSTestEventConstructor : public JSEvent {
</ins><span class="cx"> public:
</span><del>- using Base = JSDOMWrapper<TestEventConstructor>;
</del><ins>+ using Base = JSEvent;
+ using DOMWrapped = TestEventConstructor;
</ins><span class="cx"> static JSTestEventConstructor* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref<TestEventConstructor>&& impl)
</span><span class="cx"> {
</span><span class="cx"> JSTestEventConstructor* ptr = new (NotNull, JSC::allocateCell<JSTestEventConstructor>(globalObject->vm().heap)) JSTestEventConstructor(structure, *globalObject, WTFMove(impl));
</span><span class="lines">@@ -40,8 +39,6 @@
</span><span class="cx">
</span><span class="cx"> static JSC::JSObject* createPrototype(JSC::VM&, JSC::JSGlobalObject*);
</span><span class="cx"> static JSC::JSObject* prototype(JSC::VM&, JSC::JSGlobalObject*);
</span><del>- static TestEventConstructor* toWrapped(JSC::JSValue);
- static void destroy(JSC::JSCell*);
</del><span class="cx">
</span><span class="cx"> DECLARE_INFO;
</span><span class="cx">
</span><span class="lines">@@ -51,6 +48,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
</span><ins>+ TestEventConstructor& wrapped() const
+ {
+ return static_cast<TestEventConstructor&>(Base::wrapped());
+ }
</ins><span class="cx"> protected:
</span><span class="cx"> JSTestEventConstructor(JSC::Structure*, JSDOMGlobalObject&, Ref<TestEventConstructor>&&);
</span><span class="cx">
</span><span class="lines">@@ -62,32 +63,15 @@
</span><span class="cx">
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class JSTestEventConstructorOwner : public JSC::WeakHandleOwner {
-public:
- virtual bool isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void* context, JSC::SlotVisitor&);
- virtual void finalize(JSC::Handle<JSC::Unknown>, void* context);
-};
-
-inline JSC::WeakHandleOwner* wrapperOwner(DOMWrapperWorld&, TestEventConstructor*)
-{
- static NeverDestroyed<JSTestEventConstructorOwner> owner;
- return &owner.get();
-}
-
-inline void* wrapperKey(TestEventConstructor* wrappableObject)
-{
- return wrappableObject;
-}
-
</del><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, TestEventConstructor&);
</span><span class="cx"> inline JSC::JSValue toJS(JSC::ExecState* state, JSDOMGlobalObject* globalObject, TestEventConstructor* impl) { return impl ? toJS(state, globalObject, *impl) : JSC::jsNull(); }
</span><span class="cx"> JSC::JSValue toJSNewlyCreated(JSC::ExecState*, JSDOMGlobalObject*, Ref<TestEventConstructor>&&);
</span><span class="cx"> inline JSC::JSValue toJSNewlyCreated(JSC::ExecState* state, JSDOMGlobalObject* globalObject, RefPtr<TestEventConstructor>&& impl) { return impl ? toJSNewlyCreated(state, globalObject, impl.releaseNonNull()) : JSC::jsNull(); }
</span><span class="cx">
</span><del>-bool fillTestEventConstructorInit(TestEventConstructorInit&, JSDictionary&);
-
</del><span class="cx"> template<> struct JSDOMWrapperConverterTraits<TestEventConstructor> {
</span><span class="cx"> using WrapperClass = JSTestEventConstructor;
</span><span class="cx"> };
</span><ins>+template<> Optional<TestEventConstructor::Init> convertDictionary<TestEventConstructor::Init>(JSC::ExecState&, JSC::JSValue);
</ins><span class="cx">
</span><ins>+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestEventConstructoridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestEventConstructor.idl (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestEventConstructor.idl 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/bindings/scripts/test/TestEventConstructor.idl 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -29,10 +29,15 @@
</span><span class="cx"> // This IDL file is for testing the bindings code generator and for tracking
</span><span class="cx"> // changes in its ouput.
</span><span class="cx"> [
</span><del>- ConstructorTemplate=Event
-] interface TestEventConstructor {
</del><ins>+ Constructor(DOMString type, optional TestEventConstructorInit eventInitDict),
+] interface TestEventConstructor : Event {
</ins><span class="cx"> // Attributes
</span><span class="cx"> readonly attribute DOMString attr1;
</span><del>- [InitializedByEventConstructor] readonly attribute DOMString attr2;
- [InitializedByEventConstructor, Conditional=SPECIAL_EVENT] readonly attribute DOMString attr3;
</del><ins>+ readonly attribute DOMString attr2;
+ [Conditional=SPECIAL_EVENT] readonly attribute DOMString attr3;
</ins><span class="cx"> };
</span><ins>+
+dictionary TestEventConstructorInit : EventInit {
+ DOMString attr2 = "";
+ [Conditional=SPECIAL_EVENT] DOMString attr3 = "";
+};
</ins></span></pre></div>
<a id="trunkSourceWebCorecssCSSFontFaceLoadEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFontFaceLoadEvent.cpp (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFontFaceLoadEvent.cpp 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/css/CSSFontFaceLoadEvent.cpp 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -46,8 +46,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-CSSFontFaceLoadEvent::CSSFontFaceLoadEvent(const AtomicString& type, const CSSFontFaceLoadEventInit& initializer)
- : Event(type, initializer)
</del><ins>+CSSFontFaceLoadEvent::CSSFontFaceLoadEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_fontface(initializer.fontface)
</span><span class="cx"> , m_error(initializer.error)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFontFaceLoadEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -42,11 +42,6 @@
</span><span class="cx">
</span><span class="cx"> class DOMError;
</span><span class="cx">
</span><del>-struct CSSFontFaceLoadEventInit : public EventInit {
- RefPtr<CSSFontFaceRule> fontface;
- RefPtr<DOMError> error;
-};
-
</del><span class="cx"> class CSSFontFaceLoadEvent final : public Event {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<CSSFontFaceLoadEvent> create()
</span><span class="lines">@@ -54,9 +49,14 @@
</span><span class="cx"> return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static Ref<CSSFontFaceLoadEvent> create(const AtomicString& type, const CSSFontFaceLoadEventInit& initializer)
</del><ins>+ struct Init : EventInit {
+ RefPtr<CSSFontFaceRule> fontface;
+ RefPtr<DOMError> error;
+ };
+
+ static Ref<CSSFontFaceLoadEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
</ins><span class="cx"> {
</span><del>- return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent(type, initializer));
</del><ins>+ return adoptRef<CSSFontFaceLoadEvent>(*new CSSFontFaceLoadEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<CSSFontFaceLoadEvent> createForFontFaceRule(const AtomicString& type, RefPtr<CSSFontFaceRule>&& rule)
</span><span class="lines">@@ -79,7 +79,7 @@
</span><span class="cx"> private:
</span><span class="cx"> CSSFontFaceLoadEvent();
</span><span class="cx"> CSSFontFaceLoadEvent(const AtomicString&, RefPtr<CSSFontFaceRule>&&, RefPtr<DOMError>&&);
</span><del>- CSSFontFaceLoadEvent(const AtomicString&, const CSSFontFaceLoadEventInit&);
</del><ins>+ CSSFontFaceLoadEvent(const AtomicString&, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> RefPtr<CSSFontFaceRule> m_fontface;
</span><span class="cx"> RefPtr<DOMError> m_error;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFontFaceLoadEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFontFaceLoadEvent.idl (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFontFaceLoadEvent.idl 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/css/CSSFontFaceLoadEvent.idl 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -29,10 +29,14 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> Conditional=FONT_LOAD_EVENTS,
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, optional CSSFontFaceLoadEventInit eventInit),
</ins><span class="cx"> ] interface CSSFontFaceLoadEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute CSSFontFaceRule fontface;
- [InitializedByEventConstructor] readonly attribute DOMError error;
</del><ins>+ readonly attribute CSSFontFaceRule? fontface;
+ readonly attribute DOMError? error;
</ins><span class="cx"> };
</span><ins>+
+dictionary CSSFontFaceLoadEventInit : EventInit {
+ CSSFontFaceRule? fontface = null;
+ DOMError? error = null;
+};
</ins></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLContextEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -38,8 +38,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-WebGLContextEvent::WebGLContextEvent(const AtomicString& type, const WebGLContextEventInit& initializer)
- : Event(type, initializer)
</del><ins>+WebGLContextEvent::WebGLContextEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_statusMessage(initializer.statusMessage)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLContextEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLContextEvent.h (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLContextEvent.h 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/html/canvas/WebGLContextEvent.h 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -30,10 +30,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-struct WebGLContextEventInit : public EventInit {
- String statusMessage;
-};
-
</del><span class="cx"> class WebGLContextEvent final : public Event {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<WebGLContextEvent> create(const AtomicString& type, bool canBubble, bool cancelable, const String& statusMessage)
</span><span class="lines">@@ -40,9 +36,14 @@
</span><span class="cx"> {
</span><span class="cx"> return adoptRef(*new WebGLContextEvent(type, canBubble, cancelable, statusMessage));
</span><span class="cx"> }
</span><del>- static Ref<WebGLContextEvent> createForBindings(const AtomicString& type, const WebGLContextEventInit& initializer)
</del><ins>+
+ struct Init : EventInit {
+ String statusMessage;
+ };
+
+ static Ref<WebGLContextEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new WebGLContextEvent(type, initializer));
</del><ins>+ return adoptRef(*new WebGLContextEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx"> virtual ~WebGLContextEvent();
</span><span class="cx">
</span><span class="lines">@@ -52,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> WebGLContextEvent(const AtomicString& type, bool canBubble, bool cancelable, const String& statusMessage);
</span><del>- WebGLContextEvent(const AtomicString&, const WebGLContextEventInit&);
</del><ins>+ WebGLContextEvent(const AtomicString&, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> String m_statusMessage;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLContextEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -25,8 +25,11 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=WEBGL,
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, optional WebGLContextEventInit eventInit),
</ins><span class="cx"> ] interface WebGLContextEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute DOMString statusMessage;
</del><ins>+ readonly attribute DOMString statusMessage;
</ins><span class="cx"> };
</span><span class="cx">
</span><ins>+dictionary WebGLContextEventInit : EventInit {
+ DOMString statusMessage = "";
+};
</ins></span></pre></div>
<a id="trunkSourceWebCorestorageStorageEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageEvent.cpp (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageEvent.cpp 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/storage/StorageEvent.cpp 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -49,9 +49,9 @@
</span><span class="cx"> return adoptRef(*new StorageEvent(type, key, oldValue, newValue, url, storageArea));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<StorageEvent> StorageEvent::createForBindings(const AtomicString& type, const StorageEventInit& initializer)
</del><ins>+Ref<StorageEvent> StorageEvent::create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new StorageEvent(type, initializer));
</del><ins>+ return adoptRef(*new StorageEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> StorageEvent::StorageEvent(const AtomicString& type, const String& key, const String& oldValue, const String& newValue, const String& url, Storage* storageArea)
</span><span class="lines">@@ -64,8 +64,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-StorageEvent::StorageEvent(const AtomicString& type, const StorageEventInit& initializer)
- : Event(type, initializer)
</del><ins>+StorageEvent::StorageEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_key(initializer.key)
</span><span class="cx"> , m_oldValue(initializer.oldValue)
</span><span class="cx"> , m_newValue(initializer.newValue)
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageEvent.h (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageEvent.h 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/storage/StorageEvent.h 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -33,19 +33,20 @@
</span><span class="cx">
</span><span class="cx"> class Storage;
</span><span class="cx">
</span><del>-struct StorageEventInit : public EventInit {
- String key;
- String oldValue;
- String newValue;
- String url;
- RefPtr<Storage> storageArea;
-};
-
</del><span class="cx"> class StorageEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<StorageEvent> create(const AtomicString& type, const String& key, const String& oldValue, const String& newValue, const String& url, Storage* storageArea);
</span><span class="cx"> static Ref<StorageEvent> createForBindings();
</span><del>- static Ref<StorageEvent> createForBindings(const AtomicString&, const StorageEventInit&);
</del><ins>+
+ struct Init : EventInit {
+ String key;
+ String oldValue;
+ String newValue;
+ String url;
+ RefPtr<Storage> storageArea;
+ };
+
+ static Ref<StorageEvent> create(const AtomicString&, const Init&, IsTrusted = IsTrusted::No);
</ins><span class="cx"> virtual ~StorageEvent();
</span><span class="cx">
</span><span class="cx"> const String& key() const { return m_key; }
</span><span class="lines">@@ -64,7 +65,7 @@
</span><span class="cx"> private:
</span><span class="cx"> StorageEvent();
</span><span class="cx"> StorageEvent(const AtomicString& type, const String& key, const String& oldValue, const String& newValue, const String& url, Storage* storageArea);
</span><del>- StorageEvent(const AtomicString&, const StorageEventInit&);
</del><ins>+ StorageEvent(const AtomicString&, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> String m_key;
</span><span class="cx"> String m_oldValue;
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageEvent.idl (207237 => 207238)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageEvent.idl 2016-10-12 20:38:37 UTC (rev 207237)
+++ trunk/Source/WebCore/storage/StorageEvent.idl 2016-10-12 20:41:49 UTC (rev 207238)
</span><span class="lines">@@ -24,13 +24,13 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- ConstructorTemplate=Event,
</del><ins>+ Constructor(DOMString type, optional StorageEventInit eventInitDict)
</ins><span class="cx"> ] interface StorageEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute DOMString key;
- [InitializedByEventConstructor] readonly attribute DOMString? oldValue;
- [InitializedByEventConstructor] readonly attribute DOMString? newValue;
- [InitializedByEventConstructor] readonly attribute USVString url;
- [InitializedByEventConstructor] readonly attribute Storage storageArea;
</del><ins>+ readonly attribute DOMString? key;
+ readonly attribute DOMString? oldValue;
+ readonly attribute DOMString? newValue;
+ readonly attribute USVString url;
+ readonly attribute Storage? storageArea;
</ins><span class="cx">
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> void initStorageEvent(optional DOMString typeArg = "undefined",
</span><span class="lines">@@ -46,3 +46,10 @@
</span><span class="cx"> // void initStorageEventNS(DOMString namespaceURI, DOMString typeArg, boolean canBubbleArg, boolean cancelableArg, DOMString keyArg, DOMString oldValueArg, DOMString newValueArg, USVString urlArg, Storage? storageAreaArg);
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+dictionary StorageEventInit : EventInit {
+ DOMString? key = null;
+ DOMString? oldValue = null;
+ DOMString? newValue = null;
+ USVString url = "";
+ Storage? storageArea = null;
+};
</ins></span></pre>
</div>
</div>
</body>
</html>