<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207169] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207169">207169</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-11 15:03:04 -0700 (Tue, 11 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update CloseEvent to stop using legacy [ConstructorTemplate=Event]
https://bugs.webkit.org/show_bug.cgi?id=163293
Reviewed by Darin Adler.
Source/WebCore:
Update CloseEvent to stop using legacy [ConstructorTemplate=Event] and
use a regular constructor as in the specification:
- https://html.spec.whatwg.org/multipage/comms.html#the-closeevent-interfaces
No new tests, updated existing test.
* Modules/websockets/CloseEvent.h:
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
* Modules/websockets/CloseEvent.idl:
LayoutTests:
Update existing test to reflect a small behavior change. Passing an explicit
undefined as 'reason' members now initializes the attribute to the empty
string (the member's default value) instead of the string "undefined". This
new behavior matches Chrome and Firefox.
* fast/events/constructors/close-event-constructor-expected.txt:
* fast/events/constructors/close-event-constructor.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorscloseeventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/close-event-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorscloseeventconstructorhtml">trunk/LayoutTests/fast/events/constructors/close-event-constructor.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsCloseEventh">trunk/Source/WebCore/Modules/websockets/CloseEvent.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsCloseEventidl">trunk/Source/WebCore/Modules/websockets/CloseEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207168 => 207169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-10-11 22:01:45 UTC (rev 207168)
+++ trunk/LayoutTests/ChangeLog        2016-10-11 22:03:04 UTC (rev 207169)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-10-11 Chris Dumez <cdumez@apple.com>
+
+ Update CloseEvent to stop using legacy [ConstructorTemplate=Event]
+ https://bugs.webkit.org/show_bug.cgi?id=163293
+
+ Reviewed by Darin Adler.
+
+ Update existing test to reflect a small behavior change. Passing an explicit
+ undefined as 'reason' members now initializes the attribute to the empty
+ string (the member's default value) instead of the string "undefined". This
+ new behavior matches Chrome and Firefox.
+
+ * fast/events/constructors/close-event-constructor-expected.txt:
+ * fast/events/constructors/close-event-constructor.html:
+
</ins><span class="cx"> 2016-10-11 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Enable URLParser by default
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorscloseeventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/close-event-constructor-expected.txt (207168 => 207169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/close-event-constructor-expected.txt        2016-10-11 22:01:45 UTC (rev 207168)
+++ trunk/LayoutTests/fast/events/constructors/close-event-constructor-expected.txt        2016-10-11 22:03:04 UTC (rev 207169)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> PASS new CloseEvent('eventType', { wasClean: true }).wasClean is true
</span><span class="cx"> PASS new CloseEvent('eventType', { reason: 'koakuma' }).reason is "koakuma"
</span><span class="cx"> PASS new CloseEvent('eventType', { reason: '' }).reason is ""
</span><del>-PASS new CloseEvent('eventType', { reason: undefined }).reason is "undefined"
</del><ins>+PASS new CloseEvent('eventType', { reason: undefined }).reason is ""
</ins><span class="cx"> PASS new CloseEvent('eventType', { reason: null }).reason is "null"
</span><span class="cx"> PASS new CloseEvent('eventType', { reason: false }).reason is "false"
</span><span class="cx"> PASS new CloseEvent('eventType', { reason: true }).reason is "true"
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorscloseeventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/close-event-constructor.html (207168 => 207169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/close-event-constructor.html        2016-10-11 22:01:45 UTC (rev 207168)
+++ trunk/LayoutTests/fast/events/constructors/close-event-constructor.html        2016-10-11 22:03:04 UTC (rev 207169)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> shouldBeEqualToString("new CloseEvent('eventType', { reason: '' }).reason", "");
</span><span class="cx">
</span><span class="cx"> // Non-strings.
</span><del>-shouldBeEqualToString("new CloseEvent('eventType', { reason: undefined }).reason", "undefined");
</del><ins>+shouldBeEqualToString("new CloseEvent('eventType', { reason: undefined }).reason", "");
</ins><span class="cx"> shouldBeEqualToString("new CloseEvent('eventType', { reason: null }).reason", "null");
</span><span class="cx"> shouldBeEqualToString("new CloseEvent('eventType', { reason: false }).reason", "false");
</span><span class="cx"> shouldBeEqualToString("new CloseEvent('eventType', { reason: true }).reason", "true");
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207168 => 207169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-10-11 22:01:45 UTC (rev 207168)
+++ trunk/Source/WebCore/ChangeLog        2016-10-11 22:03:04 UTC (rev 207169)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-10-11 Chris Dumez <cdumez@apple.com>
+
+ Update CloseEvent to stop using legacy [ConstructorTemplate=Event]
+ https://bugs.webkit.org/show_bug.cgi?id=163293
+
+ Reviewed by Darin Adler.
+
+ Update CloseEvent to stop using legacy [ConstructorTemplate=Event] and
+ use a regular constructor as in the specification:
+ - https://html.spec.whatwg.org/multipage/comms.html#the-closeevent-interfaces
+
+ No new tests, updated existing test.
+
+ * Modules/websockets/CloseEvent.h:
+ (WebCore::CloseEvent::create):
+ (WebCore::CloseEvent::CloseEvent):
+ * Modules/websockets/CloseEvent.idl:
+
</ins><span class="cx"> 2016-10-11 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [DOMJIT] DOMJIT::Patchpoint should have a way to receive constant folded arguments
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsCloseEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/CloseEvent.h (207168 => 207169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/CloseEvent.h        2016-10-11 22:01:45 UTC (rev 207168)
+++ trunk/Source/WebCore/Modules/websockets/CloseEvent.h        2016-10-11 22:03:04 UTC (rev 207169)
</span><span class="lines">@@ -36,12 +36,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-struct CloseEventInit : public EventInit {
- bool wasClean { false };
- unsigned short code { 0 };
- String reason;
-};
-
</del><span class="cx"> class CloseEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<CloseEvent> create(bool wasClean, unsigned short code, const String& reason)
</span><span class="lines">@@ -49,9 +43,15 @@
</span><span class="cx"> return adoptRef(*new CloseEvent(wasClean, code, reason));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static Ref<CloseEvent> createForBindings(const AtomicString& type, const CloseEventInit& initializer)
</del><ins>+ struct Init : EventInit {
+ bool wasClean { false };
+ unsigned short code { 0 };
+ String reason;
+ };
+
+ static Ref<CloseEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new CloseEvent(type, initializer));
</del><ins>+ return adoptRef(*new CloseEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool wasClean() const { return m_wasClean; }
</span><span class="lines">@@ -70,8 +70,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- CloseEvent(const AtomicString& type, const CloseEventInit& initializer)
- : Event(type, initializer)
</del><ins>+ CloseEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_wasClean(initializer.wasClean)
</span><span class="cx"> , m_code(initializer.code)
</span><span class="cx"> , m_reason(initializer.reason)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsCloseEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/CloseEvent.idl (207168 => 207169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/CloseEvent.idl        2016-10-11 22:01:45 UTC (rev 207168)
+++ trunk/Source/WebCore/Modules/websockets/CloseEvent.idl        2016-10-11 22:03:04 UTC (rev 207169)
</span><span class="lines">@@ -28,11 +28,17 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+// FIXME: This should be exposed to workers as well.
</ins><span class="cx"> [
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, optional CloseEventInit eventInitDict),
</ins><span class="cx"> ] interface CloseEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute boolean wasClean;
- [InitializedByEventConstructor] readonly attribute unsigned short code;
- [InitializedByEventConstructor] readonly attribute USVString reason;
</del><ins>+ readonly attribute boolean wasClean;
+ readonly attribute unsigned short code;
+ readonly attribute USVString reason;
</ins><span class="cx"> };
</span><span class="cx">
</span><ins>+dictionary CloseEventInit : EventInit {
+ boolean wasClean = false;
+ unsigned short code = 0;
+ USVString reason = "";
+};
</ins></span></pre>
</div>
</div>
</body>
</html>