<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207175] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207175">207175</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-11 16:11:49 -0700 (Tue, 11 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update MediaStream events to stop using legacy [ConstructorTemplate=Event]
https://bugs.webkit.org/show_bug.cgi?id=163289
Reviewed by Sam Weinig.
Source/WebCore:
Update MediaStream events to stop using legacy [ConstructorTemplate=Event]
and use regular constructors instead.
* Modules/mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
* Modules/mediastream/MediaStreamEvent.h:
* Modules/mediastream/MediaStreamEvent.idl:
* Modules/mediastream/MediaStreamTrackEvent.cpp:
(WebCore::MediaStreamTrackEvent::create):
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):
* Modules/mediastream/MediaStreamTrackEvent.h:
* Modules/mediastream/MediaStreamTrackEvent.idl:
* Modules/mediastream/OverconstrainedErrorEvent.h:
(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):
(WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent): Deleted.
* Modules/mediastream/OverconstrainedErrorEvent.idl:
* Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
(WebCore::RTCDTMFToneChangeEvent::create):
(WebCore::RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent):
* Modules/mediastream/RTCDTMFToneChangeEvent.h:
* Modules/mediastream/RTCDTMFToneChangeEvent.idl:
* Modules/mediastream/RTCTrackEvent.cpp:
(WebCore::RTCTrackEvent::create):
(WebCore::RTCTrackEvent::RTCTrackEvent):
* Modules/mediastream/RTCTrackEvent.h:
* Modules/mediastream/RTCTrackEvent.idl:
LayoutTests:
Update existing test cases now that we throw more exceptions on bad input.
* fast/events/constructors/overconstrained-error-event-constructor-expected.txt:
* fast/events/constructors/overconstrained-error-event-constructor.html:
* fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
* fast/mediastream/MediaStreamTrackEvent-constructor.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsoverconstrainederroreventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsoverconstrainederroreventconstructorhtml">trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor.html</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamMediaStreamTrackEventconstructorexpectedtxt">trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamMediaStreamTrackEventconstructorhtml">trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamEventcpp">trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamEventh">trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamEventidl">trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackEventcpp">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackEventh">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackEventidl">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamOverconstrainedErrorEventh">trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamOverconstrainedErrorEventidl">trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventcpp">trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventh">trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventidl">trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCTrackEventcpp">trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCTrackEventh">trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCTrackEventidl">trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/LayoutTests/ChangeLog 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-10-11 Chris Dumez <cdumez@apple.com>
+
+ Update MediaStream events to stop using legacy [ConstructorTemplate=Event]
+ https://bugs.webkit.org/show_bug.cgi?id=163289
+
+ Reviewed by Sam Weinig.
+
+ Update existing test cases now that we throw more exceptions on bad input.
+
+ * fast/events/constructors/overconstrained-error-event-constructor-expected.txt:
+ * fast/events/constructors/overconstrained-error-event-constructor.html:
+ * fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
+ * fast/mediastream/MediaStreamTrackEvent-constructor.html:
+
</ins><span class="cx"> 2016-10-11 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Implement prefers-reduced-motion media query
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsoverconstrainederroreventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor-expected.txt 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -15,8 +15,8 @@
</span><span class="cx"> PASS new OverconstrainedErrorEvent('eventType', { error: new OverconstrainedError('width') }).error.constraint is "width"
</span><span class="cx"> PASS new OverconstrainedErrorEvent('eventType', { error: new OverconstrainedError('fred', 'unsupported constraint') }).error.message is "unsupported constraint"
</span><span class="cx"> PASS new OverconstrainedErrorEvent('eventType', { error: null }).reason is undefined.
</span><del>-PASS new OverconstrainedErrorEvent('eventType', { error: 'fake error' }).error is null
-PASS new OverconstrainedErrorEvent('eventType', { error: [] }).error is null
</del><ins>+PASS new OverconstrainedErrorEvent('eventType', { error: 'fake error' }) threw exception TypeError: Type error.
+PASS new OverconstrainedErrorEvent('eventType', { error: [] }) threw exception TypeError: Type error.
</ins><span class="cx"> PASS new OverconstrainedErrorEvent('eventType', { bubbles: true, cancelable: true, error: new OverconstrainedError() }).bubbles is true
</span><span class="cx"> PASS new OverconstrainedErrorEvent('eventType', { bubbles: true, cancelable: true, error: new OverconstrainedError() }).cancelable is true
</span><span class="cx"> PASS new OverconstrainedErrorEvent('eventType', { bubbles: true, cancelable: true, error: new OverconstrainedError('bogus') }).error.constraint is "bogus"
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsoverconstrainederroreventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor.html (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor.html 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/LayoutTests/fast/events/constructors/overconstrained-error-event-constructor.html 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -35,8 +35,8 @@
</span><span class="cx"> shouldBeEqualToString("new OverconstrainedErrorEvent('eventType', { error: new OverconstrainedError('fred', 'unsupported constraint') }).error.message", "unsupported constraint");
</span><span class="cx">
</span><span class="cx"> shouldBeUndefined("new OverconstrainedErrorEvent('eventType', { error: null }).reason");
</span><del>- shouldBeNull("new OverconstrainedErrorEvent('eventType', { error: 'fake error' }).error", null);
- shouldBeNull("new OverconstrainedErrorEvent('eventType', { error: [] }).error", null);
</del><ins>+ shouldThrowErrorName("new OverconstrainedErrorEvent('eventType', { error: 'fake error' })", "TypeError");
+ shouldThrowErrorName("new OverconstrainedErrorEvent('eventType', { error: [] })", "TypeError");
</ins><span class="cx">
</span><span class="cx"> // All initializers are passed.
</span><span class="cx"> shouldBe("new OverconstrainedErrorEvent('eventType', { bubbles: true, cancelable: true, error: new OverconstrainedError() }).bubbles", "true");
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamMediaStreamTrackEventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -19,15 +19,13 @@
</span><span class="cx"> PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).track is null
</span><span class="cx">
</span><span class="cx"> *** Bubbles and cancelable true, invalid track ***
</span><del>-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }).bubbles is true
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }).cancelable is true
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }).track is null
</del><ins>+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }) threw exception TypeError: Type error.
</ins><span class="cx">
</span><span class="cx"> *** Initialize 'track' with a invalid values ***
</span><del>-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: 10 }).track is null
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: 'string' }).track is null
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: emptyObject }).track is null
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: document }).track is null
</del><ins>+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: 10 }) threw exception TypeError: Type error.
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: 'string' }) threw exception TypeError: Type error.
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: emptyObject }) threw exception TypeError: Type error.
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: document }) threw exception TypeError: Type error.
</ins><span class="cx">
</span><span class="cx"> *** Bubbles and cancelable true, valid track ***
</span><span class="cx"> PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: mediaStreamTrack }).bubbles is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamMediaStreamTrackEventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -33,16 +33,14 @@
</span><span class="cx"> shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).track");
</span><span class="cx">
</span><span class="cx"> debug("<br>*** Bubbles and cancelable true, invalid track ***");
</span><del>- shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }).bubbles", "true");
- shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }).cancelable", "true");
- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack }).track");
</del><ins>+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack })", "TypeError");
</ins><span class="cx">
</span><span class="cx"> debug("<br>*** Initialize 'track' with a invalid values ***");
</span><del>- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: 10 }).track");
- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: \'string\' }).track");
</del><ins>+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: 10 })", "TypeError");
+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: \'string\' })", "TypeError");
</ins><span class="cx"> emptyObject = { };
</span><del>- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: emptyObject }).track");
- shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: document }).track");
</del><ins>+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: emptyObject })", "TypeError");
+ shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { track: document })", "TypeError");
</ins><span class="cx">
</span><span class="cx"> debug("<br>*** Bubbles and cancelable true, valid track ***");
</span><span class="cx"> shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: mediaStreamTrack }).bubbles", "true");
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/ChangeLog 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -1,5 +1,41 @@
</span><span class="cx"> 2016-10-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Update MediaStream events to stop using legacy [ConstructorTemplate=Event]
+ https://bugs.webkit.org/show_bug.cgi?id=163289
+
+ Reviewed by Sam Weinig.
+
+ Update MediaStream events to stop using legacy [ConstructorTemplate=Event]
+ and use regular constructors instead.
+
+ * Modules/mediastream/MediaStreamEvent.cpp:
+ (WebCore::MediaStreamEvent::create):
+ (WebCore::MediaStreamEvent::MediaStreamEvent):
+ * Modules/mediastream/MediaStreamEvent.h:
+ * Modules/mediastream/MediaStreamEvent.idl:
+ * Modules/mediastream/MediaStreamTrackEvent.cpp:
+ (WebCore::MediaStreamTrackEvent::create):
+ (WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):
+ * Modules/mediastream/MediaStreamTrackEvent.h:
+ * Modules/mediastream/MediaStreamTrackEvent.idl:
+ * Modules/mediastream/OverconstrainedErrorEvent.h:
+ (WebCore::OverconstrainedErrorEvent::create):
+ (WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):
+ (WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent): Deleted.
+ * Modules/mediastream/OverconstrainedErrorEvent.idl:
+ * Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
+ (WebCore::RTCDTMFToneChangeEvent::create):
+ (WebCore::RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent):
+ * Modules/mediastream/RTCDTMFToneChangeEvent.h:
+ * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
+ * Modules/mediastream/RTCTrackEvent.cpp:
+ (WebCore::RTCTrackEvent::create):
+ (WebCore::RTCTrackEvent::RTCTrackEvent):
+ * Modules/mediastream/RTCTrackEvent.h:
+ * Modules/mediastream/RTCTrackEvent.idl:
+
+2016-10-11 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Update UIRequestEvent to stop using legacy [ConstructorTemplate=Event]
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=163288
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx"> return adoptRef(*new MediaStreamEvent(type, canBubble, cancelable, WTFMove(stream)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<MediaStreamEvent> MediaStreamEvent::createForBindings(const AtomicString& type, const MediaStreamEventInit& initializer)
</del><ins>+Ref<MediaStreamEvent> MediaStreamEvent::create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new MediaStreamEvent(type, initializer));
</del><ins>+ return adoptRef(*new MediaStreamEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MediaStreamEvent::MediaStreamEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&& stream)
</span><span class="lines">@@ -48,8 +48,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-MediaStreamEvent::MediaStreamEvent(const AtomicString& type, const MediaStreamEventInit& initializer)
- : Event(type, initializer)
</del><ins>+MediaStreamEvent::MediaStreamEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_stream(initializer.stream)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.h 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -33,17 +33,17 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-struct MediaStreamEventInit : public EventInit {
- RefPtr<MediaStream> stream;
-};
-
</del><span class="cx"> class MediaStreamEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> virtual ~MediaStreamEvent();
</span><span class="cx">
</span><span class="cx"> static Ref<MediaStreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&&);
</span><del>- static Ref<MediaStreamEvent> createForBindings(const AtomicString& type, const MediaStreamEventInit& initializer);
</del><span class="cx">
</span><ins>+ struct Init : EventInit {
+ RefPtr<MediaStream> stream;
+ };
+ static Ref<MediaStreamEvent> create(const AtomicString& type, const Init& initializer, IsTrusted = IsTrusted::No);
+
</ins><span class="cx"> MediaStream* stream() const;
</span><span class="cx">
</span><span class="cx"> virtual EventInterface eventInterface() const;
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> MediaStreamEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&&);
</span><del>- MediaStreamEvent(const AtomicString& type, const MediaStreamEventInit&);
</del><ins>+ MediaStreamEvent(const AtomicString& type, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> RefPtr<MediaStream> m_stream;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -24,8 +24,11 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=WEB_RTC,
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, MediaStreamEventInit eventInitDict),
</ins><span class="cx"> ] interface MediaStreamEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute MediaStream stream;
</del><ins>+ readonly attribute MediaStream? stream;
</ins><span class="cx"> };
</span><span class="cx">
</span><ins>+dictionary MediaStreamEventInit : EventInit {
+ MediaStream? stream = null;
+};
</ins></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx"> return adoptRef(*new MediaStreamTrackEvent(type, canBubble, cancelable, WTFMove(track)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<MediaStreamTrackEvent> MediaStreamTrackEvent::createForBindings(const AtomicString& type, const MediaStreamTrackEventInit& initializer)
</del><ins>+Ref<MediaStreamTrackEvent> MediaStreamTrackEvent::create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new MediaStreamTrackEvent(type, initializer));
</del><ins>+ return adoptRef(*new MediaStreamTrackEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MediaStreamTrackEvent::MediaStreamTrackEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStreamTrack>&& track)
</span><span class="lines">@@ -48,8 +48,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-MediaStreamTrackEvent::MediaStreamTrackEvent(const AtomicString& type, const MediaStreamTrackEventInit& initializer)
- : Event(type, initializer)
</del><ins>+MediaStreamTrackEvent::MediaStreamTrackEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_track(initializer.track)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -34,17 +34,17 @@
</span><span class="cx">
</span><span class="cx"> class MediaStreamTrack;
</span><span class="cx">
</span><del>-struct MediaStreamTrackEventInit : public EventInit {
- RefPtr<MediaStreamTrack> track;
-};
-
</del><span class="cx"> class MediaStreamTrackEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> virtual ~MediaStreamTrackEvent();
</span><span class="cx">
</span><span class="cx"> static Ref<MediaStreamTrackEvent> create(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStreamTrack>&&);
</span><del>- static Ref<MediaStreamTrackEvent> createForBindings(const AtomicString& type, const MediaStreamTrackEventInit& initializer);
</del><span class="cx">
</span><ins>+ struct Init : EventInit {
+ RefPtr<MediaStreamTrack> track;
+ };
+ static Ref<MediaStreamTrackEvent> create(const AtomicString& type, const Init&, IsTrusted = IsTrusted::No);
+
</ins><span class="cx"> MediaStreamTrack* track() const;
</span><span class="cx">
</span><span class="cx"> // Event
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> MediaStreamTrackEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStreamTrack>&&);
</span><del>- MediaStreamTrackEvent(const AtomicString& type, const MediaStreamTrackEventInit&);
</del><ins>+ MediaStreamTrackEvent(const AtomicString& type, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> RefPtr<MediaStreamTrack> m_track;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -24,8 +24,12 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=MEDIA_STREAM,
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, optional MediaStreamTrackEventInit eventInitDict),
</ins><span class="cx"> ] interface MediaStreamTrackEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute MediaStreamTrack track;
</del><ins>+ readonly attribute MediaStreamTrack? track;
</ins><span class="cx"> };
</span><span class="cx">
</span><ins>+dictionary MediaStreamTrackEventInit : EventInit {
+ // FIXME: The specification says that this member should be required and non-nullable.
+ MediaStreamTrack? track = null;
+};
</ins></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamOverconstrainedErrorEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -36,10 +36,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-struct OverconstrainedErrorEventInit : public EventInit {
- RefPtr<OverconstrainedError> error;
-};
-
</del><span class="cx"> class OverconstrainedErrorEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> virtual ~OverconstrainedErrorEvent() { }
</span><span class="lines">@@ -49,9 +45,13 @@
</span><span class="cx"> return adoptRef(*new OverconstrainedErrorEvent(type, canBubble, cancelable, error));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static Ref<OverconstrainedErrorEvent> createForBindings(const AtomicString& type, const OverconstrainedErrorEventInit& initializer)
</del><ins>+ struct Init : EventInit {
+ RefPtr<OverconstrainedError> error;
+ };
+
+ static Ref<OverconstrainedErrorEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new OverconstrainedErrorEvent(type, initializer));
</del><ins>+ return adoptRef(*new OverconstrainedErrorEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> OverconstrainedError* error() const { return m_error.get(); }
</span><span class="lines">@@ -63,8 +63,8 @@
</span><span class="cx"> , m_error(error)
</span><span class="cx"> {
</span><span class="cx"> }
</span><del>- OverconstrainedErrorEvent(const AtomicString& type, const OverconstrainedErrorEventInit& initializer)
- : Event(type, initializer)
</del><ins>+ OverconstrainedErrorEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_error(initializer.error)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamOverconstrainedErrorEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -28,8 +28,11 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=MEDIA_STREAM,
</span><del>- ConstructorTemplate=Event,
</del><ins>+ Constructor(DOMString type, optional OverconstrainedErrorEventInit eventInitDict),
</ins><span class="cx"> ] interface OverconstrainedErrorEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute OverconstrainedError? error;
</del><ins>+ readonly attribute OverconstrainedError? error;
</ins><span class="cx"> };
</span><span class="cx">
</span><ins>+dictionary OverconstrainedErrorEventInit : EventInit {
+ OverconstrainedError? error = null;
+};
</ins></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -37,10 +37,9 @@
</span><span class="cx"> return adoptRef(*new RTCDTMFToneChangeEvent(tone));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<RTCDTMFToneChangeEvent> RTCDTMFToneChangeEvent::createForBindings(const AtomicString& type, const RTCDTMFToneChangeEventInit& initializer)
</del><ins>+Ref<RTCDTMFToneChangeEvent> RTCDTMFToneChangeEvent::create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
</ins><span class="cx"> {
</span><del>- ASSERT_UNUSED(type, type == eventNames().tonechangeEvent);
- return adoptRef(*new RTCDTMFToneChangeEvent(initializer));
</del><ins>+ return adoptRef(*new RTCDTMFToneChangeEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent(const String& tone)
</span><span class="lines">@@ -49,8 +48,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent(const RTCDTMFToneChangeEventInit& initializer)
- : Event(eventNames().tonechangeEvent, initializer)
</del><ins>+RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_tone(initializer.tone)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -33,17 +33,18 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-struct RTCDTMFToneChangeEventInit : public EventInit {
- String tone;
-};
-
</del><span class="cx"> class RTCDTMFToneChangeEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> virtual ~RTCDTMFToneChangeEvent();
</span><span class="cx">
</span><span class="cx"> static Ref<RTCDTMFToneChangeEvent> create(const String& tone);
</span><del>- static Ref<RTCDTMFToneChangeEvent> createForBindings(const AtomicString& type, const RTCDTMFToneChangeEventInit& initializer);
</del><span class="cx">
</span><ins>+ struct Init : EventInit {
+ String tone;
+ };
+
+ static Ref<RTCDTMFToneChangeEvent> create(const AtomicString& type, const Init&, IsTrusted = IsTrusted::No);
+
</ins><span class="cx"> const String& tone() const;
</span><span class="cx">
</span><span class="cx"> virtual EventInterface eventInterface() const;
</span><span class="lines">@@ -50,7 +51,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit RTCDTMFToneChangeEvent(const String& tone);
</span><del>- explicit RTCDTMFToneChangeEvent(const RTCDTMFToneChangeEventInit&);
</del><ins>+ RTCDTMFToneChangeEvent(const AtomicString& type, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> String m_tone;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCDTMFToneChangeEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -24,9 +24,12 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> Conditional=WEB_RTC,
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, optional RTCDTMFToneChangeEventInit eventInitDict),
</ins><span class="cx"> ] interface RTCDTMFToneChangeEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute DOMString tone;
</del><ins>+ readonly attribute DOMString tone;
</ins><span class="cx"> };
</span><ins>+
+dictionary RTCDTMFToneChangeEventInit : EventInit {
+ DOMString tone = "";
+};
</ins></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCTrackEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -45,9 +45,9 @@
</span><span class="cx"> return adoptRef(*new RTCTrackEvent(type, canBubble, cancelable, WTFMove(receiver), WTFMove(track), WTFMove(streams), WTFMove(transceiver)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<RTCTrackEvent> RTCTrackEvent::createForBindings(const AtomicString& type, const RTCTrackEventInit& initializer)
</del><ins>+Ref<RTCTrackEvent> RTCTrackEvent::create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
</ins><span class="cx"> {
</span><del>- return adoptRef(*new RTCTrackEvent(type, initializer));
</del><ins>+ return adoptRef(*new RTCTrackEvent(type, initializer, isTrusted));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RTCTrackEvent::RTCTrackEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<RTCRtpReceiver>&& receiver, RefPtr<MediaStreamTrack>&& track, Vector<RefPtr<MediaStream>>&& streams, RefPtr<RTCRtpTransceiver>&& transceiver)
</span><span class="lines">@@ -59,8 +59,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RTCTrackEvent::RTCTrackEvent(const AtomicString& type, const RTCTrackEventInit& initializer)
- : Event(type, initializer)
</del><ins>+RTCTrackEvent::RTCTrackEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+ : Event(type, initializer, isTrusted)
</ins><span class="cx"> , m_receiver(initializer.receiver)
</span><span class="cx"> , m_track(initializer.track)
</span><span class="cx"> , m_streams(initializer.streams)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCTrackEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.h (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.h 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.h 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -45,18 +45,18 @@
</span><span class="cx">
</span><span class="cx"> typedef Vector<RefPtr<MediaStream>> MediaStreamArray;
</span><span class="cx">
</span><del>-struct RTCTrackEventInit : public EventInit {
- RefPtr<RTCRtpReceiver> receiver;
- RefPtr<MediaStreamTrack> track;
- MediaStreamArray streams;
- RefPtr<RTCRtpTransceiver> transceiver;
-};
-
</del><span class="cx"> class RTCTrackEvent : public Event {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<RTCTrackEvent> create(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<RTCRtpReceiver>&&, RefPtr<MediaStreamTrack>&&, MediaStreamArray&&, RefPtr<RTCRtpTransceiver>&&);
</span><del>- static Ref<RTCTrackEvent> createForBindings(const AtomicString& type, const RTCTrackEventInit&);
</del><span class="cx">
</span><ins>+ struct Init : EventInit {
+ RefPtr<RTCRtpReceiver> receiver;
+ RefPtr<MediaStreamTrack> track;
+ MediaStreamArray streams;
+ RefPtr<RTCRtpTransceiver> transceiver;
+ };
+ static Ref<RTCTrackEvent> create(const AtomicString& type, const Init&, IsTrusted = IsTrusted::No);
+
</ins><span class="cx"> RTCRtpReceiver* receiver() const { return m_receiver.get(); }
</span><span class="cx"> MediaStreamTrack* track() const { return m_track.get(); }
</span><span class="cx"> const MediaStreamArray& streams() const { return m_streams; }
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RTCTrackEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<RTCRtpReceiver>&&, RefPtr<MediaStreamTrack>&&, MediaStreamArray&&, RefPtr<RTCRtpTransceiver>&&);
</span><del>- RTCTrackEvent(const AtomicString& type, const RTCTrackEventInit&);
</del><ins>+ RTCTrackEvent(const AtomicString& type, const Init&, IsTrusted);
</ins><span class="cx">
</span><span class="cx"> RefPtr<RTCRtpReceiver> m_receiver;
</span><span class="cx"> RefPtr<MediaStreamTrack> m_track;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCTrackEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl (207174 => 207175)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl 2016-10-11 23:07:35 UTC (rev 207174)
+++ trunk/Source/WebCore/Modules/mediastream/RTCTrackEvent.idl 2016-10-11 23:11:49 UTC (rev 207175)
</span><span class="lines">@@ -30,10 +30,19 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=WEB_RTC,
</span><del>- ConstructorTemplate=Event
</del><ins>+ Constructor(DOMString type, optional RTCTrackEventInit eventInitDict),
</ins><span class="cx"> ] interface RTCTrackEvent : Event {
</span><del>- [InitializedByEventConstructor] readonly attribute RTCRtpReceiver receiver;
- [InitializedByEventConstructor] readonly attribute MediaStreamTrack track;
</del><ins>+ [InitializedByEventConstructor] readonly attribute RTCRtpReceiver? receiver;
+ [InitializedByEventConstructor] readonly attribute MediaStreamTrack? track;
</ins><span class="cx"> [InitializedByEventConstructor] readonly attribute sequence<MediaStream> streams;
</span><del>- [InitializedByEventConstructor] readonly attribute RTCRtpTransceiver transceiver;
</del><ins>+ [InitializedByEventConstructor] readonly attribute RTCRtpTransceiver? transceiver;
</ins><span class="cx"> };
</span><ins>+
+dictionary RTCTrackEventInit : EventInit {
+ sequence<MediaStream> streams = [];
+
+ // FIXME: The specification says that these members should be required and non-nullable.
+ RTCRtpReceiver? receiver = null;
+ MediaStreamTrack? track = null;
+ RTCRtpTransceiver? transceiver = null;
+};
</ins></span></pre>
</div>
</div>
</body>
</html>