<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[207035] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/207035">207035</a></dd>
<dt>Author</dt> <dd>n_wang@apple.com</dd>
<dt>Date</dt> <dd>2016-10-10 17:11:40 -0700 (Mon, 10 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Expose invalid status for input types with that information
https://bugs.webkit.org/show_bug.cgi?id=163252
<rdar://problem/28704409>
Reviewed by Chris Fleizach.
Source/WebCore:
For input types with invalid input value, we should expose the invalid
status to the assitive technology.
Test: accessibility/mac/invalid-status-for-input-types.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus):
LayoutTests:
* accessibility/mac/invalid-status-for-input-types-expected.txt: Added.
* accessibility/mac/invalid-status-for-input-types.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilitymacinvalidstatusforinputtypesexpectedtxt">trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitymacinvalidstatusforinputtypeshtml">trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (207034 => 207035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-10 23:59:46 UTC (rev 207034)
+++ trunk/LayoutTests/ChangeLog 2016-10-11 00:11:40 UTC (rev 207035)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-10-10 Nan Wang <n_wang@apple.com>
+
+ AX: Expose invalid status for input types with that information
+ https://bugs.webkit.org/show_bug.cgi?id=163252
+ <rdar://problem/28704409>
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/invalid-status-for-input-types-expected.txt: Added.
+ * accessibility/mac/invalid-status-for-input-types.html: Added.
+
</ins><span class="cx"> 2016-10-10 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking two media/modern-media-controls tests as failing.
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitymacinvalidstatusforinputtypesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types-expected.txt (0 => 207035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types-expected.txt 2016-10-11 00:11:40 UTC (rev 207035)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+
+This tests that we are exposing correct invalid status for different types.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS: AXInvalid is true.
+PASS: AXInvalid is false.
+PASS: AXInvalid is true.
+PASS: AXInvalid is false.
+PASS: AXInvalid is true.
+PASS: AXInvalid is false.
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilitymacinvalidstatusforinputtypeshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types.html (0 => 207035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types.html (rev 0)
+++ trunk/LayoutTests/accessibility/mac/invalid-status-for-input-types.html 2016-10-11 00:11:40 UTC (rev 207035)
</span><span class="lines">@@ -0,0 +1,56 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="examples">
+ <input class="ex" data-expected="true" type="number" value="abc">
+ <input class="ex" data-expected="false" type="number" value="10">
+
+ <input class="ex" data-expected="true" type="url" value="abc">
+ <input class="ex" data-expected="false" type="url" value="http://abc.com">
+
+ <input class="ex" data-expected="true" type="email" value="abc">
+ <input class="ex" data-expected="false" type="email" value="abc@abc.com">
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that we are exposing correct invalid status for different types.");
+
+ function $(id){
+ return document.getElementById(id);
+ }
+
+ var result = $('console');
+ function verify(value, expectation, element) {
+ if (value === expectation)
+ result.innerText += "PASS: AXInvalid is " + value + ".\n";
+ else
+ result.innerText += "FAIL: AXInvalid is " + value + ". Expected: " + expectation + ". " + (element ? element.outerHTML : "") + "\n";
+ }
+
+ if (window.accessibilityController) {
+
+ var examples = document.querySelectorAll(".ex");
+ for (var i = 0, c = examples.length; i < c; i++) {
+ var el = examples[i];
+ el.focus();
+ if (i == 0)
+ eventSender.keyDown('a');
+ var expectation = el.getAttribute("data-expected");
+ var value = accessibilityController.focusedElement.stringAttributeValue('AXInvalid');
+ verify(value, expectation, el);
+ }
+ }
+
+</script>
+
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (207034 => 207035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-10 23:59:46 UTC (rev 207034)
+++ trunk/Source/WebCore/ChangeLog 2016-10-11 00:11:40 UTC (rev 207035)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-10-10 Nan Wang <n_wang@apple.com>
+
+ AX: Expose invalid status for input types with that information
+ https://bugs.webkit.org/show_bug.cgi?id=163252
+ <rdar://problem/28704409>
+
+ Reviewed by Chris Fleizach.
+
+ For input types with invalid input value, we should expose the invalid
+ status to the assitive technology.
+
+ Test: accessibility/mac/invalid-status-for-input-types.html
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::invalidStatus):
+
</ins><span class="cx"> 2016-10-10 Konstantin Tokarev <annulen@yandex.ru>
</span><span class="cx">
</span><span class="cx"> Added override specifier to PluginViewBase::isPluginViewBase()
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (207034 => 207035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2016-10-10 23:59:46 UTC (rev 207034)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2016-10-11 00:11:40 UTC (rev 207035)
</span><span class="lines">@@ -1909,8 +1909,19 @@
</span><span class="cx"> // aria-invalid can return false (default), grammar, spelling, or true.
</span><span class="cx"> String ariaInvalid = stripLeadingAndTrailingHTMLSpaces(getAttribute(aria_invalidAttr));
</span><span class="cx">
</span><ins>+ if (ariaInvalid.isEmpty()) {
+ // We should expose invalid status for input types.
+ Node* node = this->node();
+ if (node && is<HTMLInputElement>(*node)) {
+ HTMLInputElement& input = downcast<HTMLInputElement>(*node);
+ if (input.hasBadInput() || input.typeMismatch())
+ return trueValue;
+ }
+ return falseValue;
+ }
+
</ins><span class="cx"> // If "false", "undefined" [sic, string value], empty, or missing, return "false".
</span><del>- if (ariaInvalid.isEmpty() || ariaInvalid == falseValue || ariaInvalid == undefinedValue)
</del><ins>+ if (ariaInvalid == falseValue || ariaInvalid == undefinedValue)
</ins><span class="cx"> return falseValue;
</span><span class="cx"> // Besides true/false/undefined, the only tokens defined by WAI-ARIA 1.0...
</span><span class="cx"> // ...for @aria-invalid are "grammar" and "spelling".
</span></span></pre>
</div>
</div>
</body>
</html>