<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[206796] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206796">206796</a></dd>

<dt>Author</dt> <dd>cdumez@apple.com</dd>

<dt>Date</dt> <dd>2016-10-04 17:02:48 -0700 (Tue, 04 Oct 2016)</dd>

</dl>

<h3>Log Message</h3>

<pre>Add support for KeyboardEvent.isComposing attribute

https://bugs.webkit.org/show_bug.cgi?id=162921

Reviewed by Darin Adler.

Source/WebCore:

Add support for KeyboardEvent.isComposing attribute:

- https://www.w3.org/TR/uievents/#dom-keyboardevent-iscomposing

- https://www.w3.org/TR/uievents/#ref-for-dom-keyboardevent-iscomposing-3

Manual test: https://jsfiddle.net/ay92sr08/9/

No new tests, extended existing tests.

* dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):

* dom/KeyboardEvent.h:

* dom/KeyboardEvent.idl:

LayoutTests:

Extend layout test coverage to test KeyboardEvent.isComposing.

* editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt:

* editing/mac/input/kotoeri-enter-to-confirm-and-newline.html:

* fast/events/constructors/keyboard-event-constructor-expected.txt:

* fast/events/constructors/keyboard-event-constructor.html:</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestseditingmacinputkotoerientertoconfirmandnewlineexpectedtxt">trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt</a></li>

<li><a href="#trunkLayoutTestseditingmacinputkotoerientertoconfirmandnewlinehtml">trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline.html</a></li>

<li><a href="#trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorhtml">trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html</a></li>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoredomKeyboardEventcpp">trunk/Source/WebCore/dom/KeyboardEvent.cpp</a></li>

<li><a href="#trunkSourceWebCoredomKeyboardEventh">trunk/Source/WebCore/dom/KeyboardEvent.h</a></li>

<li><a href="#trunkSourceWebCoredomKeyboardEventidl">trunk/Source/WebCore/dom/KeyboardEvent.idl</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/LayoutTests/ChangeLog        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -1,3 +1,17 @@

</span><ins>+2016-10-04  Chris Dumez  &lt;cdumez@apple.com&gt;

+

+        Add support for KeyboardEvent.isComposing attribute

+        https://bugs.webkit.org/show_bug.cgi?id=162921

+

+        Reviewed by Darin Adler.

+

+        Extend layout test coverage to test KeyboardEvent.isComposing.

+

+        * editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt:

+        * editing/mac/input/kotoeri-enter-to-confirm-and-newline.html:

+        * fast/events/constructors/keyboard-event-constructor-expected.txt:

+        * fast/events/constructors/keyboard-event-constructor.html:

+

</ins><span class="cx"> 2016-10-03  Ryosuke Niwa  &lt;rniwa@webkit.org&gt;

</span><span class="cx"> 

</span><span class="cx">         ShadowRoot interface should have elementFromPoint

</span></span></pre></div>

<a id="trunkLayoutTestseditingmacinputkotoerientertoconfirmandnewlineexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -4,14 +4,41 @@

<span class="cx"> To test this manually switch to the Kotoeri/Hiragana input method, and type 'toukyou'&lt;enter&gt;&lt;enter&gt;.

<span class="cx"> You should see only a single keypress event, as the very last reported event.

</span><span class="cx"> 

</span><ins>+compositionstart

+compositionupdate

+keydown : keyCode == 229, key: t, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 84, key: t, isComposing: true

+compositionupdate

+keydown : keyCode == 229, key: o, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 79, key: o, isComposing: true

+compositionupdate

+keydown : keyCode == 229, key: u, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 85, key: u, isComposing: true

+compositionupdate

+keydown : keyCode == 229, key: k, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 75, key: k, isComposing: true

+compositionupdate

+keydown : keyCode == 229, key: y, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 89, key: y, isComposing: true

+compositionupdate

+keydown : keyCode == 229, key: o, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 79, key: o, isComposing: true

+compositionupdate

+keydown : keyCode == 229, key: u, isComposing: true

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 85, key: u, isComposing: true

+compositionend

+keydown : keyCode == 229, key: Enter, isComposing: false

</ins><span class="cx"> Received valid keydown event

</span><ins>+keyup : keyCode == 13, key: Enter, isComposing: false

+keydown : keyCode == 13, key: Enter, isComposing: false

</ins><span class="cx"> Received valid keydown event

</span><span class="cx"> Received valid keypress event

</span><ins>+keyup : keyCode == 13, key: Enter, isComposing: false

</ins><span class="cx"> PASSED: Successfully typed 'toukyou'

</span></span></pre></div>

<a id="trunkLayoutTestseditingmacinputkotoerientertoconfirmandnewlinehtml"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline.html (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline.html        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/LayoutTests/editing/mac/input/kotoeri-enter-to-confirm-and-newline.html        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -7,7 +7,7 @@

</span><span class="cx">     To test this manually switch to the Kotoeri/Hiragana input method, and type 'toukyou'&amp;lt;enter&amp;gt;&amp;lt;enter&amp;gt;.&lt;br /&gt;

<span class="cx">     You should see only a single keypress event, as the very last reported event.

</span><span class="cx"> &lt;/div&gt;

</span><del>-&lt;input id=&quot;targetInput&quot; onkeydown=&quot;keyDown()&quot; onkeypress=&quot;keyPress()&quot;&gt;

</del><ins>+&lt;input id=&quot;targetInput&quot; onkeydown=&quot;keyDown()&quot; onkeyup=&quot;keyUp()&quot; onkeypress=&quot;keyPress()&quot;&gt;

</ins><span class="cx"> &lt;ul id=&quot;console&quot;&gt;&lt;/console&gt;

</span><span class="cx"> 

</span><span class="cx"> &lt;script src=&quot;resources/logger.js&quot;&gt;&lt;/script&gt;

</span><span class="lines">@@ -15,10 +15,10 @@

</span><span class="cx"> &lt;script&gt;

</span><span class="cx">     var shouldBeCompositionEvent = false;

</span><span class="cx">     function keyDown() {

</span><del>-        if (!window.testRunner) {

-            log(&quot;keydown : keyCode == &quot; + event.keyCode);

</del><ins>+        log(&quot;keydown : keyCode == &quot; + event.keyCode + &quot;, key: &quot; + event.key + &quot;, isComposing: &quot; + event.isComposing);

+        if (!window.testRunner)

</ins><span class="cx">             return;

</span><del>-        }

</del><ins>+

</ins><span class="cx">         if (shouldBeCompositionEvent &amp;&amp; event.keyCode != 229)

</span><span class="cx">             log(&quot;FAILURE: received keyCode &quot; + event.keyCode + &quot; in a keydown when VK_PROCESSKEY is expected&quot;);

</span><span class="cx">         else if (!shouldBeCompositionEvent &amp;&amp; event.keyCode == 229)

</span><span class="lines">@@ -26,6 +26,10 @@

</span><span class="cx">         else

</span><span class="cx">             log(&quot;Received valid keydown event&quot;);

</span><span class="cx">     }

</span><ins>+

+    function keyUp() {

+        log(&quot;keyup : keyCode == &quot; + event.keyCode + &quot;, key: &quot; + event.key + &quot;, isComposing: &quot; + event.isComposing);

+    }

</ins><span class="cx">     

</span><span class="cx">     function keyPress() {

</span><span class="cx">         if (!window.testRunner) {

</span><span class="lines">@@ -39,6 +43,9 @@

</span><span class="cx">     }

</span><span class="cx">     

</span><span class="cx">     var targetInput = document.getElementById('targetInput');

</span><ins>+    targetInput.addEventListener(&quot;compositionstart&quot;, function() { log(&quot;compositionstart&quot;); });

+    targetInput.addEventListener(&quot;compositionupdate&quot;, function() { log(&quot;compositionupdate&quot;); });

+    targetInput.addEventListener(&quot;compositionend&quot;, function() { log(&quot;compositionend&quot;); });

</ins><span class="cx">     targetInput.focus();

</span><span class="cx">     if (window.testRunner) {

</span><span class="cx">         testRunner.dumpAsText();

</span></span></pre></div>

<a id="trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -22,6 +22,9 @@

</span><span class="cx"> PASS new KeyboardEvent('eventType', { }).repeat is false

</span><span class="cx"> PASS new KeyboardEvent('eventType', { repeat: false }).repeat is false

</span><span class="cx"> PASS new KeyboardEvent('eventType', { repeat: true }).repeat is true

</span><ins>+PASS new KeyboardEvent('eventType', { }).isComposing is false

+PASS new KeyboardEvent('eventType', { isComposing: false }).isComposing is false

+PASS new KeyboardEvent('eventType', { isComposing: true }).isComposing is true

</ins><span class="cx"> PASS new KeyboardEvent('eventType', { view: testObject }).view threw exception TypeError: Dictionary member is not of type Window.

<span class="cx"> PASS new KeyboardEvent('eventType', { view: document }).view threw exception TypeError: Dictionary member is not of type Window.

</span><span class="cx"> PASS new KeyboardEvent('eventType', { view: undefined }).view is null

</span></span></pre></div>

<a id="trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorhtml"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -40,6 +40,11 @@

</span><span class="cx"> shouldBe(&quot;new KeyboardEvent('eventType', { repeat: false }).repeat&quot;, &quot;false&quot;);

</span><span class="cx"> shouldBe(&quot;new KeyboardEvent('eventType', { repeat: true }).repeat&quot;, &quot;true&quot;);

</span><span class="cx"> 

<ins>+// isCompositing is passed.

+shouldBe(&quot;new KeyboardEvent('eventType', { }).isComposing&quot;, &quot;false&quot;);

+shouldBe(&quot;new KeyboardEvent('eventType', { isComposing: false }).isComposing&quot;, &quot;false&quot;);

+shouldBe(&quot;new KeyboardEvent('eventType', { isComposing: true }).isComposing&quot;, &quot;true&quot;);

+

</ins><span class="cx"> // Non-window objects.

</span><span class="cx"> shouldThrowErrorName(&quot;new KeyboardEvent('eventType', { view: testObject }).view&quot;, &quot;TypeError&quot;);

</span><span class="cx"> shouldThrowErrorName(&quot;new KeyboardEvent('eventType', { view: document }).view&quot;, &quot;TypeError&quot;);

</span></span></pre></div>

<a id="trunkSourceWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/Source/WebCore/ChangeLog        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -1,3 +1,23 @@

</span><ins>+2016-10-04  Chris Dumez  &lt;cdumez@apple.com&gt;

+

+        Add support for KeyboardEvent.isComposing attribute

+        https://bugs.webkit.org/show_bug.cgi?id=162921

+

+        Reviewed by Darin Adler.

+

+        Add support for KeyboardEvent.isComposing attribute:

+        - https://www.w3.org/TR/uievents/#dom-keyboardevent-iscomposing

+        - https://www.w3.org/TR/uievents/#ref-for-dom-keyboardevent-iscomposing-3

+

+        Manual test: https://jsfiddle.net/ay92sr08/9/

+

+        No new tests, extended existing tests.

+

+        * dom/KeyboardEvent.cpp:

+        (WebCore::KeyboardEvent::KeyboardEvent):

+        * dom/KeyboardEvent.h:

+        * dom/KeyboardEvent.idl:

+

</ins><span class="cx"> 2016-10-03  Ryosuke Niwa  &lt;rniwa@webkit.org&gt;

</span><span class="cx"> 

</span><span class="cx">         ShadowRoot interface should have elementFromPoint

</span></span></pre></div>

<a id="trunkSourceWebCoredomKeyboardEventcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.cpp (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.cpp        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/Source/WebCore/dom/KeyboardEvent.cpp        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -24,6 +24,7 @@

</span><span class="cx"> #include &quot;KeyboardEvent.h&quot;

</span><span class="cx"> 

</span><span class="cx"> #include &quot;Document.h&quot;

</span><ins>+#include &quot;Editor.h&quot;

</ins><span class="cx"> #include &quot;EventDispatcher.h&quot;

</span><span class="cx"> #include &quot;EventHandler.h&quot;

</span><span class="cx"> #include &quot;EventNames.h&quot;

</span><span class="lines">@@ -91,14 +92,7 @@

</span><span class="cx">     }

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-KeyboardEvent::KeyboardEvent()

-    : m_location(DOM_KEY_LOCATION_STANDARD)

-    , m_altGraphKey(false)

-#if PLATFORM(COCOA)

-    , m_handledByInputMethod(false)

-#endif

-{

-}

</del><ins>+KeyboardEvent::KeyboardEvent() = default;

</ins><span class="cx"> 

</span><span class="cx"> KeyboardEvent::KeyboardEvent(const PlatformKeyboardEvent&amp; key, DOMWindow* view)

</span><span class="cx">     : UIEventWithKeyState(eventTypeForKeyboardEventType(key.type()),

</span><span class="lines">@@ -111,6 +105,7 @@

</span><span class="cx">     , m_location(keyLocationCode(key))

</span><span class="cx">     , m_repeat(key.isAutoRepeat())

</span><span class="cx">     , m_altGraphKey(false)

</span><ins>+    , m_isComposing(view &amp;&amp; view-&gt;frame() &amp;&amp; view-&gt;frame()-&gt;editor().hasComposition())

</ins><span class="cx"> #if PLATFORM(COCOA)

</span><span class="cx"> #if USE(APPKIT)

</span><span class="cx">     , m_handledByInputMethod(key.handledByInputMethod())

</span><span class="lines">@@ -137,6 +132,7 @@

</span><span class="cx">     , m_location(initializer.location)

</span><span class="cx">     , m_repeat(initializer.repeat)

</span><span class="cx">     , m_altGraphKey(false)

</span><ins>+    , m_isComposing(initializer.isComposing)

</ins><span class="cx"> #if PLATFORM(COCOA)

</span><span class="cx">     , m_handledByInputMethod(false)

</span><span class="cx"> #endif

</span></span></pre></div>

<a id="trunkSourceWebCoredomKeyboardEventh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.h (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.h        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/Source/WebCore/dom/KeyboardEvent.h        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -40,6 +40,7 @@

</span><span class="cx">     String keyIdentifier;

</span><span class="cx">     unsigned location { 0 };

</span><span class="cx">     bool repeat { false };

</span><ins>+    bool isComposing { false };

</ins><span class="cx"> };

</span><span class="cx"> 

</span><span class="cx"> class KeyboardEvent final : public UIEventWithKeyState {

</span><span class="lines">@@ -100,6 +101,8 @@

</span><span class="cx">     bool isKeyboardEvent() const final;

</span><span class="cx">     int which() const final;

</span><span class="cx"> 

</span><ins>+    bool isComposing() const { return m_isComposing; }

+

</ins><span class="cx"> #if PLATFORM(COCOA)

</span><span class="cx">     bool handledByInputMethod() const { return m_handledByInputMethod; }

</span><span class="cx">     const Vector&lt;KeypressCommand&gt;&amp; keypressCommands() const { return m_keypressCommands; }

</span><span class="lines">@@ -121,13 +124,14 @@

</span><span class="cx">     String m_key;

</span><span class="cx"> #endif

</span><span class="cx">     String m_keyIdentifier;

</span><del>-    unsigned m_location;

-    bool m_repeat : 1;

-    bool m_altGraphKey : 1;

</del><ins>+    unsigned m_location { DOM_KEY_LOCATION_STANDARD };

+    bool m_repeat { false };

+    bool m_altGraphKey { false };

+    bool m_isComposing { false };

</ins><span class="cx"> 

</span><span class="cx"> #if PLATFORM(COCOA)

<span class="cx">     // Commands that were sent by AppKit when interpreting the event. Doesn't include input method commands.

</span><del>-    bool m_handledByInputMethod;

</del><ins>+    bool m_handledByInputMethod { false };

</ins><span class="cx">     Vector&lt;KeypressCommand&gt; m_keypressCommands;

</span><span class="cx"> #endif

</span><span class="cx"> };

</span></span></pre></div>

<a id="trunkSourceWebCoredomKeyboardEventidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.idl (206795 => 206796)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.idl        2016-10-04 23:42:18 UTC (rev 206795)

+++ trunk/Source/WebCore/dom/KeyboardEvent.idl        2016-10-05 00:02:48 UTC (rev 206796)

</span><span class="lines">@@ -41,8 +41,7 @@

</span><span class="cx">     [InitializedByEventConstructor] readonly attribute boolean metaKey;

</span><span class="cx">     [InitializedByEventConstructor] readonly attribute boolean repeat;

</span><span class="cx"> 

<del>-    // FIXME: We should support this.

-    // readonly attribute boolean isComposing;

</del><ins>+    [InitializedByEventConstructor] readonly attribute boolean isComposing;

</ins><span class="cx"> 

</span><span class="cx">     boolean getModifierState(DOMString keyArg);

</span><span class="cx"> 

</span></span></pre>

</div>

</div>

</body>

</html>