<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206777] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206777">206777</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-04 12:00:06 -0700 (Tue, 04 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Return null when window.open() is popup blocked
https://bugs.webkit.org/show_bug.cgi?id=162897
Reviewed by Michael Catanzaro.
Source/WebCore:
The return value of window.open() when the popup is blocked should be null:
- https://github.com/whatwg/html/pull/1854
- https://github.com/whatwg/html/issues/1851
Firefox / Edge return null.
No new tests, rebaselined existing tests.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open):
LayoutTests:
Rebaseline existing tests to reflect behavior change.
* fast/events/popup-blocked-from-fake-button-click-expected.txt:
* fast/events/popup-blocked-from-fake-button-click.html:
* fast/events/popup-blocked-from-fake-focus-expected.txt:
* fast/events/popup-blocked-from-fake-focus.html:
* fast/events/popup-blocked-from-fake-user-gesture-expected.txt:
* fast/events/popup-blocked-from-fake-user-gesture.html:
* fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt:
* fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html:
* fast/events/popup-blocking-timers3-expected.txt:
* fast/events/popup-blocking-timers3.html:
* fast/events/popup-blocking-timers4-expected.txt:
* fast/events/popup-blocking-timers4.html:
* fast/events/popup-blocking-timers6-expected.txt:
* fast/events/popup-blocking-timers6.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromfakebuttonclickexpectedtxt">trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromfakebuttonclickhtml">trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click.html</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromfakefocusexpectedtxt">trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromfakefocushtml">trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus.html</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromfakeusergestureexpectedtxt">trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromfakeusergesturehtml">trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture.html</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromuntrustedclickeventonanchorexpectedtxt">trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockedfromuntrustedclickeventonanchorhtml">trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockingtimers3expectedtxt">trunk/LayoutTests/fast/events/popup-blocking-timers3-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockingtimers3html">trunk/LayoutTests/fast/events/popup-blocking-timers3.html</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockingtimers4expectedtxt">trunk/LayoutTests/fast/events/popup-blocking-timers4-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockingtimers4html">trunk/LayoutTests/fast/events/popup-blocking-timers4.html</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockingtimers6expectedtxt">trunk/LayoutTests/fast/events/popup-blocking-timers6-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventspopupblockingtimers6html">trunk/LayoutTests/fast/events/popup-blocking-timers6.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/ChangeLog 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-10-04 Chris Dumez <cdumez@apple.com>
+
+ Return null when window.open() is popup blocked
+ https://bugs.webkit.org/show_bug.cgi?id=162897
+
+ Reviewed by Michael Catanzaro.
+
+ Rebaseline existing tests to reflect behavior change.
+
+ * fast/events/popup-blocked-from-fake-button-click-expected.txt:
+ * fast/events/popup-blocked-from-fake-button-click.html:
+ * fast/events/popup-blocked-from-fake-focus-expected.txt:
+ * fast/events/popup-blocked-from-fake-focus.html:
+ * fast/events/popup-blocked-from-fake-user-gesture-expected.txt:
+ * fast/events/popup-blocked-from-fake-user-gesture.html:
+ * fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt:
+ * fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html:
+ * fast/events/popup-blocking-timers3-expected.txt:
+ * fast/events/popup-blocking-timers3.html:
+ * fast/events/popup-blocking-timers4-expected.txt:
+ * fast/events/popup-blocking-timers4.html:
+ * fast/events/popup-blocking-timers6-expected.txt:
+ * fast/events/popup-blocking-timers6.html:
+
</ins><span class="cx"> 2016-10-04 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking http/tests/cache/disk-cache/disk-cache-204-status-code.html as flaky on mac-wk2.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromfakebuttonclickexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,2 +1,2 @@
</span><del>-PASS win is undefined.
</del><ins>+PASS win is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromfakebuttonclickhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-fake-button-click.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx"> var win;
</span><span class="cx"> function popup() {
</span><span class="cx"> win = window.open("about:blank", "blank");
</span><del>- shouldBeUndefined("win");
</del><ins>+ shouldBeNull("win");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (window.testRunner) {
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromfakefocusexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx">
</span><del>-PASS win is undefined.
-PASS win is undefined.
</del><ins>+PASS win is null
+PASS win is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromfakefocushtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-fake-focus.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -10,7 +10,7 @@
</span><span class="cx"> var win;
</span><span class="cx"> function popup() {
</span><span class="cx"> win = window.open("about:blank", "blank");
</span><del>- shouldBeUndefined("win");
</del><ins>+ shouldBeNull("win");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (window.testRunner) {
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromfakeusergestureexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> Click Here
</span><span class="cx"> PASS win is non-null.
</span><del>-PASS win is undefined.
</del><ins>+PASS win is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromfakeusergesturehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-fake-user-gesture.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> {
</span><span class="cx"> window.event = stolenEvent;
</span><span class="cx"> win = window.open("about:blank", "blank");
</span><del>- shouldBeUndefined("win");
</del><ins>+ shouldBeNull("win");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> clickHandler = clickHandler1;
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromuntrustedclickeventonanchorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,3 +1,3 @@
</span><span class="cx"> test
</span><del>-PASS win is undefined.
</del><ins>+PASS win is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockedfromuntrustedclickeventonanchorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx"> var win;
</span><span class="cx"> function popup() {
</span><span class="cx"> win = window.open('about:blank','blank','height=200,width=200');
</span><del>- shouldBeUndefined("win");
</del><ins>+ shouldBeNull("win");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (window.testRunner) {
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockingtimers3expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocking-timers3-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocking-timers3-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers3-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -2,5 +2,5 @@
</span><span class="cx"> Test calling window.open() in a 100 ms interval. A popup should only be allowed on the first execution of the interval.
</span><span class="cx"> PASS newWindow is non-null.
</span><span class="cx"> Test calling window.open() in a 100 ms interval. A popup should only be allowed on the first execution of the interval.
</span><del>-PASS newWindow is undefined.
</del><ins>+PASS newWindow is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockingtimers3html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocking-timers3.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocking-timers3.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers3.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -22,7 +22,7 @@
</span><span class="cx"> shouldBeNonNull("newWindow");
</span><span class="cx"> firstIntervalExecution = false;
</span><span class="cx"> } else {
</span><del>- shouldBeUndefined("newWindow");
</del><ins>+ shouldBeNull("newWindow");
</ins><span class="cx"> clearInterval(intervalId);
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockingtimers4expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocking-timers4-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocking-timers4-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers4-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> Click Here
</span><span class="cx"> Test calling window.open() in a nested call to setTimeout(). A popup should not be allowed.
</span><del>-PASS newWindow is undefined.
</del><ins>+PASS newWindow is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockingtimers4html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocking-timers4.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocking-timers4.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers4.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -17,7 +17,7 @@
</span><span class="cx"> newWindow = window.open("about:blank");
</span><span class="cx"> self.focus();
</span><span class="cx"> debug("Test calling window.open() in a nested call to setTimeout(). A popup should not be allowed.")
</span><del>- shouldBeUndefined("newWindow");
</del><ins>+ shouldBeNull("newWindow");
</ins><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> }, 0);
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockingtimers6expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocking-timers6-expected.txt (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocking-timers6-expected.txt 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers6-expected.txt 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx"> Click Here
</span><span class="cx"> Test calling window.open() with a 1001 ms delay. A popup should not be allowed.
</span><del>-PASS newWindow is undefined.
</del><ins>+PASS newWindow is null
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventspopupblockingtimers6html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/popup-blocking-timers6.html (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/popup-blocking-timers6.html 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/LayoutTests/fast/events/popup-blocking-timers6.html 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx"> newWindow = window.open("about:blank");
</span><span class="cx"> self.focus();
</span><span class="cx"> debug("Test calling window.open() with a 1001 ms delay. A popup should not be allowed.")
</span><del>- shouldBeUndefined("newWindow");
</del><ins>+ shouldBeNull("newWindow");
</ins><span class="cx">
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/Source/WebCore/ChangeLog 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2016-10-04 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Return null when window.open() is popup blocked
+ https://bugs.webkit.org/show_bug.cgi?id=162897
+
+ Reviewed by Michael Catanzaro.
+
+ The return value of window.open() when the popup is blocked should be null:
+ - https://github.com/whatwg/html/pull/1854
+ - https://github.com/whatwg/html/issues/1851
+
+ Firefox / Edge return null.
+
+ No new tests, rebaselined existing tests.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::open):
+
+2016-10-04 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> [Web IDL] Add support for dictionary inheritance
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=162907
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (206776 => 206777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2016-10-04 18:51:44 UTC (rev 206776)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2016-10-04 19:00:06 UTC (rev 206777)
</span><span class="lines">@@ -433,7 +433,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<DOMWindow> openedWindow = wrapped().open(urlString, target, windowFeaturesString, activeDOMWindow(&state), firstDOMWindow(&state));
</span><span class="cx"> if (!openedWindow)
</span><del>- return jsUndefined();
</del><ins>+ return jsNull();
</ins><span class="cx"> return toJS(&state, openedWindow.get());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>