<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206740] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206740">206740</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-10-03 12:13:20 -0700 (Mon, 03 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[SOUP] Remove unused methods toSoupMessage from ResourceRequest/Response
https://bugs.webkit.org/show_bug.cgi?id=162867
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2016-10-03
Reviewed by Sergio Villar Senin.
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::updateFromSoupMessage): Deleted.
* platform/network/soup/ResourceResponse.h:
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworksoupResourceRequesth">trunk/Source/WebCore/platform/network/soup/ResourceRequest.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworksoupResourceRequestSoupcpp">trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworksoupResourceResponseh">trunk/Source/WebCore/platform/network/soup/ResourceResponse.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworksoupResourceResponseSoupcpp">trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206739 => 206740)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/ChangeLog 2016-10-03 19:13:20 UTC (rev 206740)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-10-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [SOUP] Remove unused methods toSoupMessage from ResourceRequest/Response
+ https://bugs.webkit.org/show_bug.cgi?id=162867
+
+ Reviewed by Sergio Villar Senin.
+
+ * platform/network/soup/ResourceRequest.h:
+ * platform/network/soup/ResourceRequestSoup.cpp:
+ (WebCore::ResourceRequest::updateSoupMessage):
+ (WebCore::ResourceRequest::updateFromSoupMessage): Deleted.
+ * platform/network/soup/ResourceResponse.h:
+ * platform/network/soup/ResourceResponseSoup.cpp:
+ (WebCore::ResourceResponse::updateFromSoupMessage): Deleted.
+
</ins><span class="cx"> 2016-10-03 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove FetchBody::m_isEmpty
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworksoupResourceRequesth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequest.h (206739 => 206740)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2016-10-03 19:13:20 UTC (rev 206740)
</span><span class="lines">@@ -94,7 +94,6 @@
</span><span class="cx"> void updateSoupMessageHeaders(SoupMessageHeaders*) const;
</span><span class="cx"> void updateFromSoupMessageHeaders(SoupMessageHeaders*);
</span><span class="cx"> void updateSoupMessage(SoupMessage*) const;
</span><del>- SoupMessage* toSoupMessage() const;
</del><span class="cx"> void updateFromSoupMessage(SoupMessage*);
</span><span class="cx"> void updateSoupRequest(SoupRequest*) const;
</span><span class="cx"> void updateFromSoupRequest(SoupRequest*);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworksoupResourceRequestSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp (206739 => 206740)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2016-10-03 19:13:20 UTC (rev 206740)
</span><span class="lines">@@ -79,20 +79,6 @@
</span><span class="cx"> updateSoupMessageMembers(soupMessage);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-SoupMessage* ResourceRequest::toSoupMessage() const
-{
- SoupMessage* soupMessage = soup_message_new(httpMethod().ascii().data(), url().string().utf8().data());
- if (!soupMessage)
- return 0;
-
- updateSoupMessageMembers(soupMessage);
-
- // Body data is only handled at ResourceHandleSoup::startHttp for
- // now; this is because this may not be a good place to go
- // openning and mmapping files. We should maybe revisit this.
- return soupMessage;
-}
-
</del><span class="cx"> void ResourceRequest::updateFromSoupMessage(SoupMessage* soupMessage)
</span><span class="cx"> {
</span><span class="cx"> bool shouldPortBeResetToZero = m_url.hasPort() && !m_url.port();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworksoupResourceResponseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponse.h (206739 => 206740)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2016-10-03 19:13:20 UTC (rev 206740)
</span><span class="lines">@@ -56,7 +56,6 @@
</span><span class="cx"> updateFromSoupMessage(soupMessage);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- SoupMessage* toSoupMessage() const;
</del><span class="cx"> void updateSoupMessageHeaders(SoupMessageHeaders*) const;
</span><span class="cx"> void updateFromSoupMessage(SoupMessage*);
</span><span class="cx"> void updateFromSoupMessageHeaders(const SoupMessageHeaders*);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworksoupResourceResponseSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (206739 => 206740)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2016-10-03 19:13:20 UTC (rev 206740)
</span><span class="lines">@@ -38,25 +38,6 @@
</span><span class="cx"> soup_message_headers_append(soupHeaders, header.key.utf8().data(), header.value.utf8().data());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-SoupMessage* ResourceResponse::toSoupMessage() const
-{
- // This GET here is just because SoupMessage wants it, we dn't really know.
- SoupMessage* soupMessage = soup_message_new("GET", url().string().utf8().data());
- if (!soupMessage)
- return 0;
-
- soupMessage->status_code = httpStatusCode();
-
- updateSoupMessageHeaders(soupMessage->response_headers);
-
- soup_message_set_flags(soupMessage, m_soupFlags);
-
- g_object_set(G_OBJECT(soupMessage), "tls-certificate", m_certificate.get(), "tls-errors", m_tlsErrors, NULL);
-
- // Body data is not in the message.
- return soupMessage;
-}
-
</del><span class="cx"> void ResourceResponse::updateFromSoupMessage(SoupMessage* soupMessage)
</span><span class="cx"> {
</span><span class="cx"> m_url = URL(soup_message_get_uri(soupMessage));
</span></span></pre>
</div>
</div>
</body>
</html>