<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206724] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206724">206724</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-10-02 14:33:28 -0700 (Sun, 02 Oct 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add support for KeyboardEvent.repeat attribute
https://bugs.webkit.org/show_bug.cgi?id=162854
Reviewed by Darin Adler.
Source/WebCore:
Add support for KeyboardEvent.repeat attribute:
- https://w3c.github.io/uievents/#dom-keyboardevent-repeat
No new tests, extended existing test.
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
* dom/KeyboardEvent.h:
* dom/KeyboardEvent.idl:
LayoutTests:
Extend layout test coverage.
* fast/events/constructors/keyboard-event-constructor-expected.txt:
* fast/events/constructors/keyboard-event-constructor.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorhtml">trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomKeyboardEventcpp">trunk/Source/WebCore/dom/KeyboardEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomKeyboardEventh">trunk/Source/WebCore/dom/KeyboardEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomKeyboardEventidl">trunk/Source/WebCore/dom/KeyboardEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/LayoutTests/ChangeLog 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-10-02 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Add support for KeyboardEvent.repeat attribute
+ https://bugs.webkit.org/show_bug.cgi?id=162854
+
+ Reviewed by Darin Adler.
+
+ Extend layout test coverage.
+
+ * fast/events/constructors/keyboard-event-constructor-expected.txt:
+ * fast/events/constructors/keyboard-event-constructor.html:
+
+2016-10-02 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Unreviewed, rolling out r206692 and r206718.
</span><span class="cx">
</span><span class="cx"> Seems to have caused >200 failures on Sierra
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -19,6 +19,9 @@
</span><span class="cx"> PASS new KeyboardEvent('eventType', { cancelable: true }).cancelable is true
</span><span class="cx"> PASS new KeyboardEvent('eventType', { view: window }).view is window
</span><span class="cx"> PASS new KeyboardEvent('eventType', { view: this }).view is this
</span><ins>+PASS new KeyboardEvent('eventType', { }).repeat is false
+PASS new KeyboardEvent('eventType', { repeat: false }).repeat is false
+PASS new KeyboardEvent('eventType', { repeat: true }).repeat is true
</ins><span class="cx"> PASS new KeyboardEvent('eventType', { view: testObject }).view threw exception TypeError: Dictionary member is not of type Window.
</span><span class="cx"> PASS new KeyboardEvent('eventType', { view: document }).view threw exception TypeError: Dictionary member is not of type Window.
</span><span class="cx"> PASS new KeyboardEvent('eventType', { view: undefined }).view is null
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorskeyboardeventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/LayoutTests/fast/events/constructors/keyboard-event-constructor.html 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -35,6 +35,11 @@
</span><span class="cx"> shouldBe("new KeyboardEvent('eventType', { view: window }).view", "window");
</span><span class="cx"> shouldBe("new KeyboardEvent('eventType', { view: this }).view", "this");
</span><span class="cx">
</span><ins>+// repeat is passed.
+shouldBe("new KeyboardEvent('eventType', { }).repeat", "false");
+shouldBe("new KeyboardEvent('eventType', { repeat: false }).repeat", "false");
+shouldBe("new KeyboardEvent('eventType', { repeat: true }).repeat", "true");
+
</ins><span class="cx"> // Non-window objects.
</span><span class="cx"> shouldThrowErrorName("new KeyboardEvent('eventType', { view: testObject }).view", "TypeError");
</span><span class="cx"> shouldThrowErrorName("new KeyboardEvent('eventType', { view: document }).view", "TypeError");
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/Source/WebCore/ChangeLog 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-10-02 Chris Dumez <cdumez@apple.com>
+
+ Add support for KeyboardEvent.repeat attribute
+ https://bugs.webkit.org/show_bug.cgi?id=162854
+
+ Reviewed by Darin Adler.
+
+ Add support for KeyboardEvent.repeat attribute:
+ - https://w3c.github.io/uievents/#dom-keyboardevent-repeat
+
+ No new tests, extended existing test.
+
+ * dom/KeyboardEvent.cpp:
+ (WebCore::KeyboardEvent::KeyboardEvent):
+ * dom/KeyboardEvent.h:
+ * dom/KeyboardEvent.idl:
+
</ins><span class="cx"> 2016-10-02 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename ExceptionCode-based exception handling to "legacy"
</span></span></pre></div>
<a id="trunkSourceWebCoredomKeyboardEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.cpp (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.cpp 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/Source/WebCore/dom/KeyboardEvent.cpp 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -106,6 +106,7 @@
</span><span class="cx"> , m_keyEvent(std::make_unique<PlatformKeyboardEvent>(key))
</span><span class="cx"> , m_keyIdentifier(key.keyIdentifier())
</span><span class="cx"> , m_location(keyLocationCode(key))
</span><ins>+ , m_repeat(key.isAutoRepeat())
</ins><span class="cx"> , m_altGraphKey(false)
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> #if USE(APPKIT)
</span><span class="lines">@@ -128,6 +129,7 @@
</span><span class="cx"> : UIEventWithKeyState(eventType, initializer)
</span><span class="cx"> , m_keyIdentifier(initializer.keyIdentifier)
</span><span class="cx"> , m_location(initializer.location)
</span><ins>+ , m_repeat(initializer.repeat)
</ins><span class="cx"> , m_altGraphKey(false)
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> , m_handledByInputMethod(false)
</span></span></pre></div>
<a id="trunkSourceWebCoredomKeyboardEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.h (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.h 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/Source/WebCore/dom/KeyboardEvent.h 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -36,6 +36,7 @@
</span><span class="cx"> struct KeyboardEventInit : public UIEventWithKeyStateInit {
</span><span class="cx"> String keyIdentifier;
</span><span class="cx"> unsigned location { 0 };
</span><ins>+ bool repeat { false };
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> class KeyboardEvent final : public UIEventWithKeyState {
</span><span class="lines">@@ -80,6 +81,7 @@
</span><span class="cx">
</span><span class="cx"> const String& keyIdentifier() const { return m_keyIdentifier; }
</span><span class="cx"> unsigned location() const { return m_location; }
</span><ins>+ bool repeat() const { return m_repeat; }
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT bool getModifierState(const String& keyIdentifier) const;
</span><span class="cx">
</span><span class="lines">@@ -113,6 +115,7 @@
</span><span class="cx"> std::unique_ptr<PlatformKeyboardEvent> m_keyEvent;
</span><span class="cx"> String m_keyIdentifier;
</span><span class="cx"> unsigned m_location;
</span><ins>+ bool m_repeat : 1;
</ins><span class="cx"> bool m_altGraphKey : 1;
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span></span></pre></div>
<a id="trunkSourceWebCoredomKeyboardEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/KeyboardEvent.idl (206723 => 206724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/KeyboardEvent.idl 2016-10-02 21:28:31 UTC (rev 206723)
+++ trunk/Source/WebCore/dom/KeyboardEvent.idl 2016-10-02 21:33:28 UTC (rev 206724)
</span><span class="lines">@@ -37,6 +37,8 @@
</span><span class="cx"> [InitializedByEventConstructor] readonly attribute boolean metaKey;
</span><span class="cx"> readonly attribute boolean altGraphKey;
</span><span class="cx">
</span><ins>+ [InitializedByEventConstructor] readonly attribute boolean repeat;
+
</ins><span class="cx"> // FIXME: this does not match the version in the DOM spec.
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> void initKeyboardEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
</span></span></pre>
</div>
</div>
</body>
</html>