<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206618] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206618">206618</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-29 15:15:57 -0700 (Thu, 29 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
https://bugs.webkit.org/show_bug.cgi?id=130600
<rdar://problem/16391333>
Patch by Aaron Chu <aaron_chu@apple.com> on 2016-09-29
Reviewed by Brian Burg.
.:
Added a manual test to test the node links in the Accessibility Inspector
https://bugs.webkit.org/show_bug.cgi?id=130600
* ManualTests/accessibility/delinkified-non-navigable-links.html: Added.
Source/WebInspectorUI:
Removing link style for non-navigable nodes by first
checking nodeType of the node.
* UserInterface/Base/DOMUtilities.js:
(WebInspector.linkifyNodeReference):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseDOMUtilitiesjs">trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkManualTestsaccessibilitydelinkifiednonnavigablelinkshtml">trunk/ManualTests/accessibility/delinkified-non-navigable-links.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (206617 => 206618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2016-09-29 22:02:04 UTC (rev 206617)
+++ trunk/ChangeLog 2016-09-29 22:15:57 UTC (rev 206618)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-09-29 Aaron Chu <aaron_chu@apple.com>
+
+ Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
+ https://bugs.webkit.org/show_bug.cgi?id=130600
+ <rdar://problem/16391333>
+
+ Reviewed by Brian Burg.
+
+ Added a manual test to test the node links in the Accessibility Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=130600
+
+ * ManualTests/accessibility/delinkified-non-navigable-links.html: Added.
+
</ins><span class="cx"> 2016-09-28 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Remove obsolete comment from OptionsGTK.cmake
</span></span></pre></div>
<a id="trunkManualTestsaccessibilitydelinkifiednonnavigablelinkshtml"></a>
<div class="addfile"><h4>Added: trunk/ManualTests/accessibility/delinkified-non-navigable-links.html (0 => 206618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ManualTests/accessibility/delinkified-non-navigable-links.html (rev 0)
+++ trunk/ManualTests/accessibility/delinkified-non-navigable-links.html 2016-09-29 22:15:57 UTC (rev 206618)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<html>
+<body>
+
+
+<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=130600">Bug 130600: Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them</a>.</p>
+<ol>
+<li>Open Accessibility Inspector.</li>
+<li>In DOM tree in the Web Inspector, click on the first &lt;html&gt;.</li>
+<li>In the Accessibility Inspector, you should be able to see "#document" as parent, but it should not look like a link.</li>
+<li>In DOM tree in the Web Inspector, click on a &lt;p&gt;.</li>
+<li>In the Accessibility Inspector, you should be able to see "#document" as parent, but it should not look like a link.</li>
+<li>In the Accessibility Inspector, you should be able to see a ":role(text)" under "Children", but it should not look like a link.</li>
+<li>In DOM tree in the Web Inspector, click on the &lt;iframe&gt;.</li>
+<li>In the Accessibility Inspector, you should be able to see a "#document" under "Children", and it <b>should</b> not look like a link.</li>
+
+</ol>
+
+<p>A paragraph</p>
+
+<iframe></iframe>
+
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (206617 => 206618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-29 22:02:04 UTC (rev 206617)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-29 22:15:57 UTC (rev 206618)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-09-29 Aaron Chu <aaron_chu@apple.com>
+
+ Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
+ https://bugs.webkit.org/show_bug.cgi?id=130600
+ <rdar://problem/16391333>
+
+ Reviewed by Brian Burg.
+
+ Removing link style for non-navigable nodes by first
+ checking nodeType of the node.
+
+ * UserInterface/Base/DOMUtilities.js:
+ (WebInspector.linkifyNodeReference):
+
</ins><span class="cx"> 2016-09-27 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Refreshing while in Timelines-tab causes negative timestamps in Network-tab
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseDOMUtilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js (206617 => 206618)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js 2016-09-29 22:02:04 UTC (rev 206617)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js 2016-09-29 22:15:57 UTC (rev 206618)
</span><span class="lines">@@ -66,8 +66,12 @@
</span><span class="cx"> let link = document.createElement("span");
</span><span class="cx"> link.append(displayName);
</span><span class="cx"> link.setAttribute("role", "link");
</span><del>- link.className = "node-link";
</del><ins>+
</ins><span class="cx"> link.title = displayName;
</span><ins>+
+ let nodeType = node.nodeType();
+ if ((nodeType !== Node.DOCUMENT_NODE || node.parentNode) && nodeType !== Node.TEXT_NODE)
+ link.className = "node-link";
</ins><span class="cx">
</span><span class="cx"> link.addEventListener("click", WebInspector.domTreeManager.inspectElement.bind(WebInspector.domTreeManager, node.id));
</span><span class="cx"> link.addEventListener("mouseover", WebInspector.domTreeManager.highlightDOMNode.bind(WebInspector.domTreeManager, node.id, "all"));
</span></span></pre>
</div>
</div>
</body>
</html>