<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206621] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206621">206621</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-29 16:05:35 -0700 (Thu, 29 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Mark NetworkLoad as final
https://bugs.webkit.org/show_bug.cgi?id=162681
Reviewed by Alex Christensen.
Mark class NetworkLoad as final as we do not have any derived classes at the moment and it
is unclear if it would make sense to subclass it. We can always unmark the class if it turns
out that it makes sense to subclass it.
* NetworkProcess/NetworkLoad.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkLoadh">trunk/Source/WebKit2/NetworkProcess/NetworkLoad.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (206620 => 206621)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-09-29 22:23:31 UTC (rev 206620)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-29 23:05:35 UTC (rev 206621)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-09-29 Daniel Bates <dabates@apple.com>
+
+ Mark NetworkLoad as final
+ https://bugs.webkit.org/show_bug.cgi?id=162681
+
+ Reviewed by Alex Christensen.
+
+ Mark class NetworkLoad as final as we do not have any derived classes at the moment and it
+ is unclear if it would make sense to subclass it. We can always unmark the class if it turns
+ out that it makes sense to subclass it.
+
+ * NetworkProcess/NetworkLoad.h:
+
</ins><span class="cx"> 2016-09-29 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Allow overriding some NSURLSessionConfiguration properties on a per-NetworkProcess basis
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkLoadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkLoad.h (206620 => 206621)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkLoad.h 2016-09-29 22:23:31 UTC (rev 206620)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkLoad.h 2016-09-29 23:05:35 UTC (rev 206621)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><del>-class NetworkLoad : private WebCore::ResourceHandleClient
</del><ins>+class NetworkLoad final : private WebCore::ResourceHandleClient
</ins><span class="cx"> #if USE(NETWORK_SESSION)
</span><span class="cx"> , private NetworkDataTaskClient
</span><span class="cx"> #endif
</span><span class="lines">@@ -97,20 +97,20 @@
</span><span class="cx"> void sharedWillSendRedirectedRequest(WebCore::ResourceRequest&&, WebCore::ResourceResponse&&);
</span><span class="cx">
</span><span class="cx"> // ResourceHandleClient
</span><del>- void willSendRequestAsync(WebCore::ResourceHandle*, WebCore::ResourceRequest&&, WebCore::ResourceResponse&& redirectResponse) override;
- void didSendData(WebCore::ResourceHandle*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
- void didReceiveResponseAsync(WebCore::ResourceHandle*, WebCore::ResourceResponse&&) override;
- void didReceiveData(WebCore::ResourceHandle*, const char*, unsigned, int encodedDataLength) override;
- void didReceiveBuffer(WebCore::ResourceHandle*, Ref<WebCore::SharedBuffer>&&, int reportedEncodedDataLength) override;
- void didFinishLoading(WebCore::ResourceHandle*, double finishTime) override;
- void didFail(WebCore::ResourceHandle*, const WebCore::ResourceError&) override;
- void wasBlocked(WebCore::ResourceHandle*) override;
- void cannotShowURL(WebCore::ResourceHandle*) override;
- bool shouldUseCredentialStorage(WebCore::ResourceHandle*) override;
- void didReceiveAuthenticationChallenge(WebCore::ResourceHandle*, const WebCore::AuthenticationChallenge&) override;
- void receivedCancellation(WebCore::ResourceHandle*, const WebCore::AuthenticationChallenge&) override;
- bool usesAsyncCallbacks() override { return true; }
- bool loadingSynchronousXHR() override { return m_client.isSynchronous(); }
</del><ins>+ void willSendRequestAsync(WebCore::ResourceHandle*, WebCore::ResourceRequest&&, WebCore::ResourceResponse&& redirectResponse) final;
+ void didSendData(WebCore::ResourceHandle*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) final;
+ void didReceiveResponseAsync(WebCore::ResourceHandle*, WebCore::ResourceResponse&&) final;
+ void didReceiveData(WebCore::ResourceHandle*, const char*, unsigned, int encodedDataLength) final;
+ void didReceiveBuffer(WebCore::ResourceHandle*, Ref<WebCore::SharedBuffer>&&, int reportedEncodedDataLength) final;
+ void didFinishLoading(WebCore::ResourceHandle*, double finishTime) final;
+ void didFail(WebCore::ResourceHandle*, const WebCore::ResourceError&) final;
+ void wasBlocked(WebCore::ResourceHandle*) final;
+ void cannotShowURL(WebCore::ResourceHandle*) final;
+ bool shouldUseCredentialStorage(WebCore::ResourceHandle*) final;
+ void didReceiveAuthenticationChallenge(WebCore::ResourceHandle*, const WebCore::AuthenticationChallenge&) final;
+ void receivedCancellation(WebCore::ResourceHandle*, const WebCore::AuthenticationChallenge&) final;
+ bool usesAsyncCallbacks() final { return true; }
+ bool loadingSynchronousXHR() final { return m_client.isSynchronous(); }
</ins><span class="cx">
</span><span class="cx"> #if USE(NETWORK_SESSION)
</span><span class="cx"> // NetworkDataTaskClient
</span><span class="lines">@@ -120,9 +120,9 @@
</span><span class="cx"> void didReceiveData(Ref<WebCore::SharedBuffer>&&) final;
</span><span class="cx"> void didCompleteWithError(const WebCore::ResourceError&) final;
</span><span class="cx"> void didBecomeDownload() final;
</span><del>- void didSendData(uint64_t totalBytesSent, uint64_t totalBytesExpectedToSend) override;
- void wasBlocked() override;
- void cannotShowURL() override;
</del><ins>+ void didSendData(uint64_t totalBytesSent, uint64_t totalBytesExpectedToSend) final;
+ void wasBlocked() final;
+ void cannotShowURL() final;
</ins><span class="cx">
</span><span class="cx"> void completeAuthenticationChallenge(ChallengeCompletionHandler&&);
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>