<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206541] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206541">206541</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-09-28 13:36:46 -0700 (Wed, 28 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>It should be possible to dispatch events on template documents
https://bugs.webkit.org/show_bug.cgi?id=162687
Reviewed by Ryosuke Niwa.
Source/WebCore:
It should be possible to dispatch events on template documents. Firefox
supports this. Chrome does not but this is likely not intentional as
Chrome generally supports dispatching events on frameless documents.
Test: fast/dom/template-document-dispatchEvent.html
* dom/Document.cpp:
(WebCore::Document::ensureTemplateDocument):
LayoutTests:
Add layout test coverage.
* fast/dom/template-document-dispatchEvent-expected.txt: Added.
* fast/dom/template-document-dispatchEvent.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomtemplatedocumentdispatchEventexpectedtxt">trunk/LayoutTests/fast/dom/template-document-dispatchEvent-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomtemplatedocumentdispatchEventhtml">trunk/LayoutTests/fast/dom/template-document-dispatchEvent.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (206540 => 206541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-09-28 20:35:52 UTC (rev 206540)
+++ trunk/LayoutTests/ChangeLog 2016-09-28 20:36:46 UTC (rev 206541)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-09-28 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to dispatch events on template documents
+ https://bugs.webkit.org/show_bug.cgi?id=162687
+
+ Reviewed by Ryosuke Niwa.
+
+ Add layout test coverage.
+
+ * fast/dom/template-document-dispatchEvent-expected.txt: Added.
+ * fast/dom/template-document-dispatchEvent.html: Added.
+
</ins><span class="cx"> 2016-09-28 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Update TestExpectations for crashing fast/images tests.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomtemplatedocumentdispatchEventexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/template-document-dispatchEvent-expected.txt (0 => 206541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/template-document-dispatchEvent-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/template-document-dispatchEvent-expected.txt 2016-09-28 20:36:46 UTC (rev 206541)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+Test that it is possible to dispatchEvent() works on template documents.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS wasEventDispatched is false
+PASS wasEventDispatched is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomtemplatedocumentdispatchEventhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/template-document-dispatchEvent.html (0 => 206541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/template-document-dispatchEvent.html (rev 0)
+++ trunk/LayoutTests/fast/dom/template-document-dispatchEvent.html 2016-09-28 20:36:46 UTC (rev 206541)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<template id="t"></template>
+<script>
+description("Test that it is possible to dispatchEvent() works on template documents.");
+
+var wasEventDispatched = false;
+let doc = document.implementation.createDocument('', '');
+let tXml = doc.importNode(t);
+
+tXml.content.ownerDocument.addEventListener("click", function(evt) {
+ shouldBeFalse("wasEventDispatched");
+ wasEventDispatched = true;
+}, true);
+var clickEvent = tXml.content.ownerDocument.createEvent("Event");
+clickEvent.initEvent("click", true, true);
+tXml.content.ownerDocument.dispatchEvent(clickEvent);
+shouldBeTrue("wasEventDispatched");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206540 => 206541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-28 20:35:52 UTC (rev 206540)
+++ trunk/Source/WebCore/ChangeLog 2016-09-28 20:36:46 UTC (rev 206541)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-09-28 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to dispatch events on template documents
+ https://bugs.webkit.org/show_bug.cgi?id=162687
+
+ Reviewed by Ryosuke Niwa.
+
+ It should be possible to dispatch events on template documents. Firefox
+ supports this. Chrome does not but this is likely not intentional as
+ Chrome generally supports dispatching events on frameless documents.
+
+ Test: fast/dom/template-document-dispatchEvent.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::ensureTemplateDocument):
+
</ins><span class="cx"> 2016-09-27 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Use Color references where possible
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (206540 => 206541)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-09-28 20:35:52 UTC (rev 206540)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-09-28 20:36:46 UTC (rev 206541)
</span><span class="lines">@@ -6758,6 +6758,7 @@
</span><span class="cx"> else
</span><span class="cx"> m_templateDocument = Document::create(nullptr, blankURL());
</span><span class="cx">
</span><ins>+ m_templateDocument->setContextDocument(contextDocument());
</ins><span class="cx"> m_templateDocument->setTemplateDocumentHost(this); // balanced in dtor.
</span><span class="cx">
</span><span class="cx"> return *m_templateDocument;
</span></span></pre>
</div>
</div>
</body>
</html>