<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206538] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206538">206538</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2016-09-28 13:19:47 -0700 (Wed, 28 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use Color references where possible
https://bugs.webkit.org/show_bug.cgi?id=162643
<rdar://problem/28506550>
Reviewed by Simon Fraser.
There were a bunch of places where we pass or use
Colors by value. As the Color class gets a bit more
complicated, it would be nice to avoid copying, so
use references where possible.
* css/CSSGradientValue.cpp:
(WebCore::interpolate):
* css/StyleColor.h:
(WebCore::StyleColor::getColor):
(WebCore::StyleColor::resolve):
* css/StyleResolver.h:
(WebCore::StyleResolver::State::backgroundColor):
* dom/Document.h:
(WebCore::Document::textColor):
* editing/FrameSelection.cpp:
(WebCore::disappearsIntoBackground):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):
* html/canvas/CanvasRenderingContext2D.h:
* html/track/TextTrackCueGeneric.h:
* page/PageOverlay.cpp:
(WebCore::PageOverlay::setBackgroundColor):
* page/PageOverlay.h:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRectWithRoundedHole):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::strokeColor):
(WebCore::GraphicsContext::fillColor):
* platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::foregroundColor):
(WebCore::GenericCueData::setForegroundColor):
(WebCore::GenericCueData::backgroundColor):
(WebCore::GenericCueData::setBackgroundColor):
(WebCore::GenericCueData::highlightColor):
(WebCore::GenericCueData::setHighlightColor):
* platform/graphics/ca/TileController.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
* platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawFocusRingPath::color):
(WebCore::DisplayList::DrawFocusRingRects::color):
(WebCore::DisplayList::FillRectWithColor::color):
(WebCore::DisplayList::FillCompositedRect::color):
(WebCore::DisplayList::FillRoundedRect::color):
(WebCore::DisplayList::FillRectWithRoundedHole::color):
* platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::lightingColor):
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDropShadow.h:
(WebCore::FEDropShadow::shadowColor):
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::floodColor):
(WebCore::FEFlood::platformApplySoftware):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::lightingColor):
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FilterOperation.h:
* rendering/BorderEdge.h:
(WebCore::BorderEdge::color):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection):
* rendering/InlineTextBox.h:
* rendering/RenderFrameSet.cpp:
(WebCore::borderStartEdgeColor):
(WebCore::borderEndEdgeColor):
(WebCore::borderFillColor):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderInline.h:
* rendering/RenderLayerCompositor.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
* rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintTextDecoration):
* rendering/TextPainter.cpp:
(WebCore::TextPainter::paintTextWithShadows):
* rendering/style/BorderValue.h:
(WebCore::BorderValue::color):
* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::color):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::color):
(WebCore::RenderStyle::visitedLinkColor):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::borderLeftColor):
(WebCore::RenderStyle::borderRightColor):
(WebCore::RenderStyle::borderTopColor):
(WebCore::RenderStyle::borderBottomColor):
(WebCore::RenderStyle::backgroundColor):
(WebCore::RenderStyle::columnRuleColor):
(WebCore::RenderStyle::outlineColor):
(WebCore::RenderStyle::textEmphasisColor):
(WebCore::RenderStyle::textFillColor):
(WebCore::RenderStyle::textStrokeColor):
(WebCore::RenderStyle::visitedLinkBackgroundColor):
(WebCore::RenderStyle::visitedLinkBorderLeftColor):
(WebCore::RenderStyle::visitedLinkBorderRightColor):
(WebCore::RenderStyle::visitedLinkBorderBottomColor):
(WebCore::RenderStyle::visitedLinkBorderTopColor):
(WebCore::RenderStyle::visitedLinkOutlineColor):
(WebCore::RenderStyle::visitedLinkColumnRuleColor):
(WebCore::RenderStyle::textDecorationColor):
(WebCore::RenderStyle::visitedLinkTextDecorationColor):
(WebCore::RenderStyle::visitedLinkTextEmphasisColor):
(WebCore::RenderStyle::visitedLinkTextFillColor):
(WebCore::RenderStyle::visitedLinkTextStrokeColor):
(WebCore::RenderStyle::stopColor):
(WebCore::RenderStyle::floodColor):
(WebCore::RenderStyle::lightingColor):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::build):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::build):
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::buildStops):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSGradientValuecpp">trunk/Source/WebCore/css/CSSGradientValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleColorh">trunk/Source/WebCore/css/StyleColor.h</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolverh">trunk/Source/WebCore/css/StyleResolver.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectioncpp">trunk/Source/WebCore/editing/FrameSelection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dcpp">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dh">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackCueGenerich">trunk/Source/WebCore/html/track/TextTrackCueGeneric.h</a></li>
<li><a href="#trunkSourceWebCorepagePageOverlaycpp">trunk/Source/WebCore/page/PageOverlay.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageOverlayh">trunk/Source/WebCore/page/PageOverlay.h</a></li>
<li><a href="#trunkSourceWebCorepageanimationCSSPropertyAnimationcpp">trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsContexth">trunk/Source/WebCore/platform/graphics/GraphicsContext.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsInbandTextTrackPrivateClienth">trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaTileControllerh">trunk/Source/WebCore/platform/graphics/ca/TileController.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscgGraphicsContextCGcpp">trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsdisplaylistsDisplayListItemsh">trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEDiffuseLightingcpp">trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEDiffuseLightingh">trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEDropShadowh">trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEFloodcpp">trunk/Source/WebCore/platform/graphics/filters/FEFlood.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEFloodh">trunk/Source/WebCore/platform/graphics/filters/FEFlood.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFESpecularLightingcpp">trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFESpecularLightingh">trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFilterOperationh">trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h</a></li>
<li><a href="#trunkSourceWebCorerenderingBorderEdgeh">trunk/Source/WebCore/rendering/BorderEdge.h</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineFlowBoxcpp">trunk/Source/WebCore/rendering/InlineFlowBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineTextBoxcpp">trunk/Source/WebCore/rendering/InlineTextBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineTextBoxh">trunk/Source/WebCore/rendering/InlineTextBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFrameSetcpp">trunk/Source/WebCore/rendering/RenderFrameSet.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderInlinecpp">trunk/Source/WebCore/rendering/RenderInline.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderInlineh">trunk/Source/WebCore/rendering/RenderInline.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorh">trunk/Source/WebCore/rendering/RenderLayerCompositor.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewcpp">trunk/Source/WebCore/rendering/RenderView.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingTextDecorationPaintercpp">trunk/Source/WebCore/rendering/TextDecorationPainter.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleBorderValueh">trunk/Source/WebCore/rendering/style/BorderValue.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleCollapsedBorderValueh">trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStyleh">trunk/Source/WebCore/rendering/style/RenderStyle.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFEDiffuseLightingElementcpp">trunk/Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFEDropShadowElementcpp">trunk/Source/WebCore/svg/SVGFEDropShadowElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFEFloodElementcpp">trunk/Source/WebCore/svg/SVGFEFloodElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFESpecularLightingElementcpp">trunk/Source/WebCore/svg/SVGFESpecularLightingElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGGradientElementcpp">trunk/Source/WebCore/svg/SVGGradientElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/ChangeLog 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -1,3 +1,143 @@
</span><ins>+2016-09-27 Dean Jackson <dino@apple.com>
+
+ Use Color references where possible
+ https://bugs.webkit.org/show_bug.cgi?id=162643
+ <rdar://problem/28506550>
+
+ Reviewed by Simon Fraser.
+
+ There were a bunch of places where we pass or use
+ Colors by value. As the Color class gets a bit more
+ complicated, it would be nice to avoid copying, so
+ use references where possible.
+
+ * css/CSSGradientValue.cpp:
+ (WebCore::interpolate):
+ * css/StyleColor.h:
+ (WebCore::StyleColor::getColor):
+ (WebCore::StyleColor::resolve):
+ * css/StyleResolver.h:
+ (WebCore::StyleResolver::State::backgroundColor):
+ * dom/Document.h:
+ (WebCore::Document::textColor):
+ * editing/FrameSelection.cpp:
+ (WebCore::disappearsIntoBackground):
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::setShadow):
+ * html/canvas/CanvasRenderingContext2D.h:
+ * html/track/TextTrackCueGeneric.h:
+ * page/PageOverlay.cpp:
+ (WebCore::PageOverlay::setBackgroundColor):
+ * page/PageOverlay.h:
+ * page/animation/CSSPropertyAnimation.cpp:
+ (WebCore::PropertyWrapperColor::PropertyWrapperColor):
+ (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
+ (WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::fillRectWithRoundedHole):
+ * platform/graphics/GraphicsContext.h:
+ (WebCore::GraphicsContext::strokeColor):
+ (WebCore::GraphicsContext::fillColor):
+ * platform/graphics/InbandTextTrackPrivateClient.h:
+ (WebCore::GenericCueData::foregroundColor):
+ (WebCore::GenericCueData::setForegroundColor):
+ (WebCore::GenericCueData::backgroundColor):
+ (WebCore::GenericCueData::setBackgroundColor):
+ (WebCore::GenericCueData::highlightColor):
+ (WebCore::GenericCueData::setHighlightColor):
+ * platform/graphics/ca/TileController.h:
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::drawRect):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::platformFillRoundedRect):
+ (WebCore::GraphicsContext::fillRectWithRoundedHole):
+ * platform/graphics/displaylists/DisplayListItems.h:
+ (WebCore::DisplayList::DrawFocusRingPath::color):
+ (WebCore::DisplayList::DrawFocusRingRects::color):
+ (WebCore::DisplayList::FillRectWithColor::color):
+ (WebCore::DisplayList::FillCompositedRect::color):
+ (WebCore::DisplayList::FillRoundedRect::color):
+ (WebCore::DisplayList::FillRectWithRoundedHole::color):
+ * platform/graphics/filters/FEDiffuseLighting.cpp:
+ (WebCore::FEDiffuseLighting::lightingColor):
+ * platform/graphics/filters/FEDiffuseLighting.h:
+ * platform/graphics/filters/FEDropShadow.h:
+ (WebCore::FEDropShadow::shadowColor):
+ * platform/graphics/filters/FEFlood.cpp:
+ (WebCore::FEFlood::floodColor):
+ (WebCore::FEFlood::platformApplySoftware):
+ * platform/graphics/filters/FEFlood.h:
+ * platform/graphics/filters/FESpecularLighting.cpp:
+ (WebCore::FESpecularLighting::lightingColor):
+ * platform/graphics/filters/FESpecularLighting.h:
+ * platform/graphics/filters/FilterOperation.h:
+ * rendering/BorderEdge.h:
+ (WebCore::BorderEdge::color):
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::paintBoxDecorations):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintSelection):
+ * rendering/InlineTextBox.h:
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::borderStartEdgeColor):
+ (WebCore::borderEndEdgeColor):
+ (WebCore::borderFillColor):
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::paintOutlineForLine):
+ * rendering/RenderInline.h:
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::paintBoxDecorations):
+ * rendering/TextDecorationPainter.cpp:
+ (WebCore::TextDecorationPainter::paintTextDecoration):
+ * rendering/TextPainter.cpp:
+ (WebCore::TextPainter::paintTextWithShadows):
+ * rendering/style/BorderValue.h:
+ (WebCore::BorderValue::color):
+ * rendering/style/CollapsedBorderValue.h:
+ (WebCore::CollapsedBorderValue::color):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::color):
+ (WebCore::RenderStyle::visitedLinkColor):
+ (WebCore::RenderStyle::setColor):
+ (WebCore::RenderStyle::setVisitedLinkColor):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::borderLeftColor):
+ (WebCore::RenderStyle::borderRightColor):
+ (WebCore::RenderStyle::borderTopColor):
+ (WebCore::RenderStyle::borderBottomColor):
+ (WebCore::RenderStyle::backgroundColor):
+ (WebCore::RenderStyle::columnRuleColor):
+ (WebCore::RenderStyle::outlineColor):
+ (WebCore::RenderStyle::textEmphasisColor):
+ (WebCore::RenderStyle::textFillColor):
+ (WebCore::RenderStyle::textStrokeColor):
+ (WebCore::RenderStyle::visitedLinkBackgroundColor):
+ (WebCore::RenderStyle::visitedLinkBorderLeftColor):
+ (WebCore::RenderStyle::visitedLinkBorderRightColor):
+ (WebCore::RenderStyle::visitedLinkBorderBottomColor):
+ (WebCore::RenderStyle::visitedLinkBorderTopColor):
+ (WebCore::RenderStyle::visitedLinkOutlineColor):
+ (WebCore::RenderStyle::visitedLinkColumnRuleColor):
+ (WebCore::RenderStyle::textDecorationColor):
+ (WebCore::RenderStyle::visitedLinkTextDecorationColor):
+ (WebCore::RenderStyle::visitedLinkTextEmphasisColor):
+ (WebCore::RenderStyle::visitedLinkTextFillColor):
+ (WebCore::RenderStyle::visitedLinkTextStrokeColor):
+ (WebCore::RenderStyle::stopColor):
+ (WebCore::RenderStyle::floodColor):
+ (WebCore::RenderStyle::lightingColor):
+ * svg/SVGFEDiffuseLightingElement.cpp:
+ (WebCore::SVGFEDiffuseLightingElement::build):
+ * svg/SVGFEDropShadowElement.cpp:
+ (WebCore::SVGFEDropShadowElement::build):
+ * svg/SVGFEFloodElement.cpp:
+ (WebCore::SVGFEFloodElement::build):
+ * svg/SVGFESpecularLightingElement.cpp:
+ (WebCore::SVGFESpecularLightingElement::build):
+ * svg/SVGGradientElement.cpp:
+ (WebCore::SVGGradientElement::buildStops):
+
</ins><span class="cx"> 2016-09-28 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> assignedNodes should include fallback contents when flattened option is set
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGradientValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGradientValue.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGradientValue.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/css/CSSGradientValue.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> return min + static_cast<int>(position * (max - min));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline Color interpolate(Color color1, Color color2, float position)
</del><ins>+static inline Color interpolate(const Color& color1, const Color& color2, float position)
</ins><span class="cx"> {
</span><span class="cx"> int red = interpolate(color1.red(), color2.red(), position);
</span><span class="cx"> int green = interpolate(color1.green(), color2.green(), position);
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleColorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleColor.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleColor.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/css/StyleColor.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -46,9 +46,9 @@
</span><span class="cx"> static StyleColor currentColor() { return StyleColor(); }
</span><span class="cx">
</span><span class="cx"> bool isCurrentColor() const { return m_currentColor; }
</span><del>- Color getColor() const { ASSERT(!isCurrentColor()); return m_color; }
</del><ins>+ const Color& getColor() const { ASSERT(!isCurrentColor()); return m_color; }
</ins><span class="cx">
</span><del>- Color resolve(Color currentColor) const { return m_currentColor ? currentColor : m_color; }
</del><ins>+ const Color& resolve(const Color& currentColor) const { return m_currentColor ? currentColor : m_color; }
</ins><span class="cx">
</span><span class="cx"> static Color colorFromKeyword(CSSValueID);
</span><span class="cx"> static bool isColorKeyword(CSSValueID);
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/css/StyleResolver.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -391,7 +391,7 @@
</span><span class="cx"> bool hasUAAppearance() const { return m_hasUAAppearance; }
</span><span class="cx"> BorderData borderData() const { return m_borderData; }
</span><span class="cx"> FillLayer backgroundData() const { return m_backgroundData; }
</span><del>- Color backgroundColor() const { return m_backgroundColor; }
</del><ins>+ const Color& backgroundColor() const { return m_backgroundColor; }
</ins><span class="cx">
</span><span class="cx"> const FontCascadeDescription& fontDescription() { return m_style->fontDescription(); }
</span><span class="cx"> const FontCascadeDescription& parentFontDescription() { return m_parentStyle->fontDescription(); }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/dom/Document.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -688,7 +688,7 @@
</span><span class="cx"> std::chrono::milliseconds elapsedTime() const;
</span><span class="cx">
</span><span class="cx"> void setTextColor(const Color& color) { m_textColor = color; }
</span><del>- Color textColor() const { return m_textColor; }
</del><ins>+ const Color& textColor() const { return m_textColor; }
</ins><span class="cx">
</span><span class="cx"> const Color& linkColor() const { return m_linkColor; }
</span><span class="cx"> const Color& visitedLinkColor() const { return m_visitedLinkColor; }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -1693,7 +1693,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TEXT_CARET)
</span><del>-static inline bool disappearsIntoBackground(Color foreground, Color background)
</del><ins>+static inline bool disappearsIntoBackground(const Color& foreground, const Color& background)
</ins><span class="cx"> {
</span><span class="cx"> return background.blend(foreground) == background;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -1276,7 +1276,7 @@
</span><span class="cx"> setShadow(FloatSize(), 0, Color::transparent);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CanvasRenderingContext2D::setShadow(const FloatSize& offset, float blur, Color color)
</del><ins>+void CanvasRenderingContext2D::setShadow(const FloatSize& offset, float blur, const Color& color)
</ins><span class="cx"> {
</span><span class="cx"> if (state().shadowOffset == offset && state().shadowBlur == blur && state().shadowColor == color)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -316,7 +316,7 @@
</span><span class="cx"> const State& state() const { return m_stateStack.last(); }
</span><span class="cx">
</span><span class="cx"> void applyLineDash() const;
</span><del>- void setShadow(const FloatSize& offset, float blur, Color);
</del><ins>+ void setShadow(const FloatSize& offset, float blur, const Color&);
</ins><span class="cx"> void applyShadow();
</span><span class="cx"> bool shouldDrawShadows() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackCueGenerich"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrackCueGeneric.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrackCueGeneric.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/html/track/TextTrackCueGeneric.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -61,13 +61,13 @@
</span><span class="cx"> String fontName() const { return m_fontName; }
</span><span class="cx"> void setFontName(String name) { m_fontName = name; }
</span><span class="cx">
</span><del>- Color foregroundColor() const { return m_foregroundColor; }
</del><ins>+ const Color& foregroundColor() const { return m_foregroundColor; }
</ins><span class="cx"> void setForegroundColor(Color color) { m_foregroundColor = color; }
</span><span class="cx">
</span><del>- Color backgroundColor() const { return m_backgroundColor; }
</del><ins>+ const Color& backgroundColor() const { return m_backgroundColor; }
</ins><span class="cx"> void setBackgroundColor(Color color) { m_backgroundColor = color; }
</span><span class="cx">
</span><del>- Color highlightColor() const { return m_highlightColor; }
</del><ins>+ const Color& highlightColor() const { return m_highlightColor; }
</ins><span class="cx"> void setHighlightColor(Color color) { m_highlightColor = color; }
</span><span class="cx">
</span><span class="cx"> void setFontSize(int, const IntSize&, bool important) override;
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageOverlaycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageOverlay.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageOverlay.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/page/PageOverlay.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> return IntSize();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageOverlay::setBackgroundColor(Color backgroundColor)
</del><ins>+void PageOverlay::setBackgroundColor(const Color& backgroundColor)
</ins><span class="cx"> {
</span><span class="cx"> if (m_backgroundColor == backgroundColor)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageOverlayh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageOverlay.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageOverlay.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/page/PageOverlay.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -106,8 +106,8 @@
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT IntSize viewToOverlayOffset() const;
</span><span class="cx">
</span><del>- Color backgroundColor() const { return m_backgroundColor; }
- void setBackgroundColor(Color);
</del><ins>+ const Color& backgroundColor() const { return m_backgroundColor; }
+ void setBackgroundColor(const Color&);
</ins><span class="cx">
</span><span class="cx"> void setShouldIgnoreMouseEventsOutsideBounds(bool flag) { m_shouldIgnoreMouseEventsOutsideBounds = flag; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationCSSPropertyAnimationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -567,11 +567,11 @@
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class PropertyWrapperColor : public PropertyWrapperGetter<Color> {
</del><ins>+class PropertyWrapperColor : public PropertyWrapperGetter<const Color&> {
</ins><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- PropertyWrapperColor(CSSPropertyID prop, Color (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&))
- : PropertyWrapperGetter<Color>(prop, getter)
</del><ins>+ PropertyWrapperColor(CSSPropertyID prop, const Color& (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&))
+ : PropertyWrapperGetter<const Color&>(prop, getter)
</ins><span class="cx"> , m_setter(setter)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -578,7 +578,7 @@
</span><span class="cx">
</span><span class="cx"> void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
</span><span class="cx"> {
</span><del>- (dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<Color>::m_getter)(), (b->*PropertyWrapperGetter<Color>::m_getter)(), progress));
</del><ins>+ (dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<const Color&>::m_getter)(), (b->*PropertyWrapperGetter<const Color&>::m_getter)(), progress));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> protected:
</span><span class="lines">@@ -585,7 +585,6 @@
</span><span class="cx"> void (RenderStyle::*m_setter)(const Color&);
</span><span class="cx"> };
</span><span class="cx">
</span><del>-
</del><span class="cx"> class PropertyWrapperAcceleratedOpacity : public PropertyWrapper<float> {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="lines">@@ -811,7 +810,7 @@
</span><span class="cx"> class PropertyWrapperMaybeInvalidColor : public AnimationPropertyWrapperBase {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- PropertyWrapperMaybeInvalidColor(CSSPropertyID prop, Color (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&))
</del><ins>+ PropertyWrapperMaybeInvalidColor(CSSPropertyID prop, const Color& (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&))
</ins><span class="cx"> : AnimationPropertyWrapperBase(prop)
</span><span class="cx"> , m_getter(getter)
</span><span class="cx"> , m_setter(setter)
</span><span class="lines">@@ -868,7 +867,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- Color (RenderStyle::*m_getter)() const;
</del><ins>+ const Color& (RenderStyle::*m_getter)() const;
</ins><span class="cx"> void (RenderStyle::*m_setter)(const Color&);
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -877,15 +876,15 @@
</span><span class="cx"> class PropertyWrapperVisitedAffectedColor : public AnimationPropertyWrapperBase {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- PropertyWrapperVisitedAffectedColor(CSSPropertyID prop, Color (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&),
- Color (RenderStyle::*visitedGetter)() const, void (RenderStyle::*visitedSetter)(const Color&))
</del><ins>+ PropertyWrapperVisitedAffectedColor(CSSPropertyID prop, const Color& (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&),
+ const Color& (RenderStyle::*visitedGetter)() const, void (RenderStyle::*visitedSetter)(const Color&))
</ins><span class="cx"> : AnimationPropertyWrapperBase(prop)
</span><span class="cx"> , m_wrapper(std::make_unique<PropertyWrapperColor>(prop, getter, setter))
</span><span class="cx"> , m_visitedWrapper(std::make_unique<PropertyWrapperColor>(prop, visitedGetter, visitedSetter))
</span><span class="cx"> {
</span><span class="cx"> }
</span><del>- PropertyWrapperVisitedAffectedColor(CSSPropertyID prop, MaybeInvalidColorTag, Color (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&),
- Color (RenderStyle::*visitedGetter)() const, void (RenderStyle::*visitedSetter)(const Color&))
</del><ins>+ PropertyWrapperVisitedAffectedColor(CSSPropertyID prop, MaybeInvalidColorTag, const Color& (RenderStyle::*getter)() const, void (RenderStyle::*setter)(const Color&),
+ const Color& (RenderStyle::*visitedGetter)() const, void (RenderStyle::*visitedSetter)(const Color&))
</ins><span class="cx"> : AnimationPropertyWrapperBase(prop)
</span><span class="cx"> , m_wrapper(std::make_unique<PropertyWrapperMaybeInvalidColor>(prop, getter, setter))
</span><span class="cx"> , m_visitedWrapper(std::make_unique<PropertyWrapperMaybeInvalidColor>(prop, visitedGetter, visitedSetter))
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> StrokeStyle strokeStyle() const { return m_state.strokeStyle; }
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void setStrokeColor(const Color&);
</span><del>- Color strokeColor() const { return m_state.strokeColor; }
</del><ins>+ const Color& strokeColor() const { return m_state.strokeColor; }
</ins><span class="cx">
</span><span class="cx"> void setStrokePattern(Ref<Pattern>&&);
</span><span class="cx"> Pattern* strokePattern() const { return m_state.strokePattern.get(); }
</span><span class="lines">@@ -276,7 +276,7 @@
</span><span class="cx"> WindRule fillRule() const { return m_state.fillRule; }
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void setFillColor(const Color&);
</span><del>- Color fillColor() const { return m_state.fillColor; }
</del><ins>+ const Color& fillColor() const { return m_state.fillColor; }
</ins><span class="cx">
</span><span class="cx"> void setFillPattern(Ref<Pattern>&&);
</span><span class="cx"> Pattern* fillPattern() const { return m_state.fillPattern.get(); }
</span><span class="lines">@@ -592,7 +592,7 @@
</span><span class="cx">
</span><span class="cx"> void platformFillRoundedRect(const FloatRoundedRect&, const Color&);
</span><span class="cx">
</span><del>- FloatRect computeLineBoundsAndAntialiasingModeForText(const FloatPoint&, float width, bool printing, Color&);
</del><ins>+ FloatRect computeLineBoundsAndAntialiasingModeForText(const FloatPoint&, float width, bool printing, Color&);
</ins><span class="cx">
</span><span class="cx"> GraphicsContextPlatformPrivate* m_data { nullptr };
</span><span class="cx"> DisplayList::Recorder* m_displayListRecorder { nullptr };
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsInbandTextTrackPrivateClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -86,15 +86,15 @@
</span><span class="cx"> double relativeFontSize() const { return m_relativeFontSize; }
</span><span class="cx"> void setRelativeFontSize(double relativeFontSize) { m_relativeFontSize = relativeFontSize; }
</span><span class="cx">
</span><del>- Color foregroundColor() const { return m_foregroundColor; }
- void setForegroundColor(Color color) { m_foregroundColor = color; }
</del><ins>+ const Color& foregroundColor() const { return m_foregroundColor; }
+ void setForegroundColor(const Color& color) { m_foregroundColor = color; }
</ins><span class="cx">
</span><del>- Color backgroundColor() const { return m_backgroundColor; }
- void setBackgroundColor(Color color) { m_backgroundColor = color; }
-
- Color highlightColor() const { return m_highlightColor; }
- void setHighlightColor(Color color) { m_highlightColor = color; }
-
</del><ins>+ const Color& backgroundColor() const { return m_backgroundColor; }
+ void setBackgroundColor(const Color& color) { m_backgroundColor = color; }
+
+ const Color& highlightColor() const { return m_highlightColor; }
+ void setHighlightColor(const Color& color) { m_highlightColor = color; }
+
</ins><span class="cx"> enum Status {
</span><span class="cx"> Uninitialized,
</span><span class="cx"> Partial,
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaTileControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/TileController.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/TileController.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/ca/TileController.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx">
</span><span class="cx"> float deviceScaleFactor() const { return m_deviceScaleFactor; }
</span><span class="cx">
</span><del>- Color tileDebugBorderColor() const { return m_tileDebugBorderColor; }
</del><ins>+ const Color& tileDebugBorderColor() const { return m_tileDebugBorderColor; }
</ins><span class="cx"> float tileDebugBorderWidth() const { return m_tileDebugBorderWidth; }
</span><span class="cx"> ScrollingModeIndication indicatorMode() const { return m_indicatorMode; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscgGraphicsContextCGcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -935,7 +935,7 @@
</span><span class="cx">
</span><span class="cx"> WindRule oldFillRule = fillRule();
</span><span class="cx"> Color oldFillColor = fillColor();
</span><del>-
</del><ins>+
</ins><span class="cx"> setFillRule(RULE_EVENODD);
</span><span class="cx"> setFillColor(color);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsdisplaylistsDisplayListItemsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -909,7 +909,7 @@
</span><span class="cx"> const Path& path() const { return m_path; }
</span><span class="cx"> int width() const { return m_width; }
</span><span class="cx"> int offset() const { return m_offset; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> DrawFocusRingPath(const Path& path, int width, int offset, const Color& color)
</span><span class="lines">@@ -941,7 +941,7 @@
</span><span class="cx"> const Vector<FloatRect> rects() const { return m_rects; }
</span><span class="cx"> int width() const { return m_width; }
</span><span class="cx"> int offset() const { return m_offset; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> DrawFocusRingRects(const Vector<FloatRect>& rects, int width, int offset, const Color& color)
</span><span class="lines">@@ -994,7 +994,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FloatRect rect() const { return m_rect; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> FillRectWithColor(const FloatRect& rect, const Color& color)
</span><span class="lines">@@ -1043,7 +1043,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FloatRect rect() const { return m_rect; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx"> CompositeOperator compositeOperator() const { return m_op; }
</span><span class="cx"> BlendMode blendMode() const { return m_blendMode; }
</span><span class="cx">
</span><span class="lines">@@ -1074,7 +1074,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const FloatRoundedRect& roundedRect() const { return m_rect; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx"> BlendMode blendMode() const { return m_blendMode; }
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="lines">@@ -1103,7 +1103,7 @@
</span><span class="cx">
</span><span class="cx"> const FloatRect& rect() const { return m_rect; }
</span><span class="cx"> const FloatRoundedRect& roundedHoleRect() const { return m_roundedHoleRect; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> FillRectWithRoundedHole(const FloatRect& rect, const FloatRoundedRect& roundedHoleRect, const Color& color)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEDiffuseLightingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Color FEDiffuseLighting::lightingColor() const
</del><ins>+const Color& FEDiffuseLighting::lightingColor() const
</ins><span class="cx"> {
</span><span class="cx"> return m_lightingColor;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEDiffuseLightingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> float, float, PassRefPtr<LightSource>);
</span><span class="cx"> virtual ~FEDiffuseLighting();
</span><span class="cx">
</span><del>- Color lightingColor() const;
</del><ins>+ const Color& lightingColor() const;
</ins><span class="cx"> bool setLightingColor(const Color&);
</span><span class="cx">
</span><span class="cx"> float surfaceScale() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEDropShadowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> float dy() const { return m_dy; }
</span><span class="cx"> void setDy(float dy) { m_dy = dy; }
</span><span class="cx">
</span><del>- Color shadowColor() const { return m_shadowColor; }
</del><ins>+ const Color& shadowColor() const { return m_shadowColor; }
</ins><span class="cx"> void setShadowColor(const Color& shadowColor) { m_shadowColor = shadowColor; }
</span><span class="cx">
</span><span class="cx"> float shadowOpacity() const { return m_shadowOpacity; }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEFloodcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEFlood.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEFlood.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FEFlood.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> return adoptRef(*new FEFlood(filter, floodColor, floodOpacity));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Color FEFlood::floodColor() const
</del><ins>+const Color& FEFlood::floodColor() const
</ins><span class="cx"> {
</span><span class="cx"> return m_floodColor;
</span><span class="cx"> }
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> if (!resultImage)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Color color = colorWithOverrideAlpha(floodColor().rgb(), floodOpacity());
</del><ins>+ const Color& color = colorWithOverrideAlpha(floodColor().rgb(), floodOpacity());
</ins><span class="cx"> resultImage->context().fillRect(FloatRect(FloatPoint(), absolutePaintRect().size()), color);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEFloodh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEFlood.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEFlood.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FEFlood.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static Ref<FEFlood> create(Filter&, const Color&, float);
</span><span class="cx">
</span><del>- Color floodColor() const;
</del><ins>+ const Color& floodColor() const;
</ins><span class="cx"> bool setFloodColor(const Color&);
</span><span class="cx">
</span><span class="cx"> float floodOpacity() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFESpecularLightingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Color FESpecularLighting::lightingColor() const
</del><ins>+const Color& FESpecularLighting::lightingColor() const
</ins><span class="cx"> {
</span><span class="cx"> return m_lightingColor;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFESpecularLightingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> float, float, float, PassRefPtr<LightSource>);
</span><span class="cx"> virtual ~FESpecularLighting();
</span><span class="cx">
</span><del>- Color lightingColor() const;
</del><ins>+ const Color& lightingColor() const;
</ins><span class="cx"> bool setLightingColor(const Color&);
</span><span class="cx">
</span><span class="cx"> float surfaceScale() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFilterOperationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -302,7 +302,7 @@
</span><span class="cx">
</span><span class="cx"> class WEBCORE_EXPORT DropShadowFilterOperation : public FilterOperation {
</span><span class="cx"> public:
</span><del>- static PassRefPtr<DropShadowFilterOperation> create(const IntPoint& location, int stdDeviation, Color color)
</del><ins>+ static PassRefPtr<DropShadowFilterOperation> create(const IntPoint& location, int stdDeviation, const Color& color)
</ins><span class="cx"> {
</span><span class="cx"> return adoptRef(new DropShadowFilterOperation(location, stdDeviation, color));
</span><span class="cx"> }
</span><span class="lines">@@ -316,7 +316,7 @@
</span><span class="cx"> int y() const { return m_location.y(); }
</span><span class="cx"> IntPoint location() const { return m_location; }
</span><span class="cx"> int stdDeviation() const { return m_stdDeviation; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx">
</span><span class="cx"> bool affectsOpacity() const override { return true; }
</span><span class="cx"> bool movesPixels() const override { return true; }
</span><span class="lines">@@ -326,7 +326,7 @@
</span><span class="cx"> private:
</span><span class="cx"> bool operator==(const FilterOperation&) const override;
</span><span class="cx">
</span><del>- DropShadowFilterOperation(const IntPoint& location, int stdDeviation, Color color)
</del><ins>+ DropShadowFilterOperation(const IntPoint& location, int stdDeviation, const Color& color)
</ins><span class="cx"> : FilterOperation(DROP_SHADOW)
</span><span class="cx"> , m_location(location)
</span><span class="cx"> , m_stdDeviation(stdDeviation)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingBorderEdgeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/BorderEdge.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/BorderEdge.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/BorderEdge.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> static void getBorderEdgeInfo(BorderEdge edges[], const RenderStyle&, float deviceScaleFactor, bool includeLogicalLeftEdge = true, bool includeLogicalRightEdge = true);
</span><span class="cx">
</span><span class="cx"> EBorderStyle style() const { return m_style; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx"> bool isTransparent() const { return m_isTransparent; }
</span><span class="cx"> bool isPresent() const { return m_isPresent; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineFlowBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -1379,8 +1379,8 @@
</span><span class="cx"> if (!renderer().boxShadowShouldBeAppliedToBackground(adjustedPaintoffset, BackgroundBleedNone, this))
</span><span class="cx"> paintBoxShadow(paintInfo, lineStyle, Normal, paintRect);
</span><span class="cx">
</span><del>- Color c = lineStyle.visitedDependentColor(CSSPropertyBackgroundColor);
- paintFillLayers(paintInfo, c, lineStyle.backgroundLayers(), paintRect);
</del><ins>+ const Color& color = lineStyle.visitedDependentColor(CSSPropertyBackgroundColor);
+ paintFillLayers(paintInfo, color, lineStyle.backgroundLayers(), paintRect);
</ins><span class="cx"> paintBoxShadow(paintInfo, lineStyle, Inset, paintRect);
</span><span class="cx">
</span><span class="cx"> // :first-line cannot be used to put borders on a line. Always paint borders with our
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineTextBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -617,7 +617,7 @@
</span><span class="cx"> return { clampedOffset(start), clampedOffset(end) };
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InlineTextBox::paintSelection(GraphicsContext& context, const FloatPoint& boxOrigin, const RenderStyle& style, const FontCascade& font, Color textColor)
</del><ins>+void InlineTextBox::paintSelection(GraphicsContext& context, const FloatPoint& boxOrigin, const RenderStyle& style, const FontCascade& font, const Color& textColor)
</ins><span class="cx"> {
</span><span class="cx"> #if ENABLE(TEXT_SELECTION)
</span><span class="cx"> if (context.paintingDisabled())
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineTextBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineTextBox.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineTextBox.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/InlineTextBox.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -161,7 +161,7 @@
</span><span class="cx"> private:
</span><span class="cx"> void paintDecoration(GraphicsContext&, const FontCascade&, RenderCombineText*, const TextRun&, const FloatPoint& textOrigin, const FloatRect& boxRect,
</span><span class="cx"> TextDecoration, TextPaintStyle, const ShadowData*);
</span><del>- void paintSelection(GraphicsContext&, const FloatPoint& boxOrigin, const RenderStyle&, const FontCascade&, Color textColor);
</del><ins>+ void paintSelection(GraphicsContext&, const FloatPoint& boxOrigin, const RenderStyle&, const FontCascade&, const Color& textColor);
</ins><span class="cx"> void paintDocumentMarker(GraphicsContext&, const FloatPoint& boxOrigin, RenderedDocumentMarker&, const RenderStyle&, const FontCascade&, bool grammar);
</span><span class="cx"> void paintTextMatchMarker(GraphicsContext&, const FloatPoint& boxOrigin, RenderedDocumentMarker&, const RenderStyle&, const FontCascade&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFrameSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFrameSet.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFrameSet.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -67,19 +67,22 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static Color borderStartEdgeColor()
</del><ins>+static const Color& borderStartEdgeColor()
</ins><span class="cx"> {
</span><del>- return Color(170, 170, 170);
</del><ins>+ static const Color color(170, 170, 170);
+ return color;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-static Color borderEndEdgeColor()
</del><ins>+static const Color& borderEndEdgeColor()
</ins><span class="cx"> {
</span><del>- return Color::black;
</del><ins>+ static const Color color = Color::black;
+ return color;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-static Color borderFillColor()
</del><ins>+static const Color& borderFillColor()
</ins><span class="cx"> {
</span><del>- return Color(208, 208, 208);
</del><ins>+ static const Color color(208, 208, 208);
+ return color;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderInlinecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderInline.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -1644,7 +1644,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderInline::paintOutlineForLine(GraphicsContext& graphicsContext, const LayoutPoint& paintOffset,
</span><del>- const LayoutRect& previousLine, const LayoutRect& thisLine, const LayoutRect& nextLine, const Color outlineColor)
</del><ins>+ const LayoutRect& previousLine, const LayoutRect& thisLine, const LayoutRect& nextLine, const Color& outlineColor)
</ins><span class="cx"> {
</span><span class="cx"> const auto& styleToUse = style();
</span><span class="cx"> float outlineOffset = styleToUse.outlineOffset();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderInlineh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderInline.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderInline.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/RenderInline.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -173,8 +173,7 @@
</span><span class="cx">
</span><span class="cx"> RenderPtr<RenderInline> clone() const;
</span><span class="cx">
</span><del>- void paintOutlineForLine(GraphicsContext&, const LayoutPoint&, const LayoutRect& prevLine, const LayoutRect& thisLine,
- const LayoutRect& nextLine, const Color);
</del><ins>+ void paintOutlineForLine(GraphicsContext&, const LayoutPoint&, const LayoutRect& prevLine, const LayoutRect& thisLine, const LayoutRect& nextLine, const Color&);
</ins><span class="cx"> RenderBoxModelObject* continuationBefore(RenderObject* beforeChild);
</span><span class="cx">
</span><span class="cx"> bool willChangeCreatesStackingContext() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -312,7 +312,7 @@
</span><span class="cx"> void didPaintBacking(RenderLayerBacking*);
</span><span class="cx">
</span><span class="cx"> void setRootExtendedBackgroundColor(const Color&);
</span><del>- Color rootExtendedBackgroundColor() const { return m_rootExtendedBackgroundColor; }
</del><ins>+ const Color& rootExtendedBackgroundColor() const { return m_rootExtendedBackgroundColor; }
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_SCROLL_SNAP)
</span><span class="cx"> void updateScrollSnapPropertiesWithFrameView(const FrameView&);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -578,8 +578,8 @@
</span><span class="cx"> if (frameView().isTransparent()) // FIXME: This needs to be dynamic. We should be able to go back to blitting if we ever stop being transparent.
</span><span class="cx"> frameView().setCannotBlitToWindow(); // The parent must show behind the child.
</span><span class="cx"> else {
</span><del>- Color documentBackgroundColor = frameView().documentBackgroundColor();
- Color backgroundColor = (backgroundShouldExtendBeyondPage && documentBackgroundColor.isValid()) ? documentBackgroundColor : frameView().baseBackgroundColor();
</del><ins>+ const Color& documentBackgroundColor = frameView().documentBackgroundColor();
+ const Color& backgroundColor = (backgroundShouldExtendBeyondPage && documentBackgroundColor.isValid()) ? documentBackgroundColor : frameView().baseBackgroundColor();
</ins><span class="cx"> if (backgroundColor.alpha()) {
</span><span class="cx"> CompositeOperator previousOperator = paintInfo.context().compositeOperation();
</span><span class="cx"> paintInfo.context().setCompositeOperation(CompositeCopy);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingTextDecorationPaintercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/TextDecorationPainter.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/TextDecorationPainter.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/TextDecorationPainter.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -262,7 +262,7 @@
</span><span class="cx"> m_context.setStrokeThickness(textDecorationThickness);
</span><span class="cx"> FloatPoint localOrigin = boxOrigin;
</span><span class="cx">
</span><del>- auto paintDecoration = [&](TextDecoration decoration, TextDecorationStyle style, Color color, const FloatPoint& start, const FloatPoint& end, int offset) {
</del><ins>+ auto paintDecoration = [&](TextDecoration decoration, TextDecorationStyle style, const Color& color, const FloatPoint& start, const FloatPoint& end, int offset) {
</ins><span class="cx"> m_context.setStrokeColor(color);
</span><span class="cx">
</span><span class="cx"> auto strokeStyle = textDecorationStyleToStrokeStyle(style);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleBorderValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/BorderValue.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/BorderValue.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/style/BorderValue.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> m_color = color;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx">
</span><span class="cx"> float width() const { return m_width; }
</span><span class="cx"> EBorderStyle style() const { return static_cast<EBorderStyle>(m_style); }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleCollapsedBorderValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/style/CollapsedBorderValue.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> LayoutUnit width() const { return m_style > BHIDDEN ? m_width : LayoutUnit::fromPixel(0); }
</span><span class="cx"> EBorderStyle style() const { return static_cast<EBorderStyle>(m_style); }
</span><span class="cx"> bool exists() const { return m_precedence != BOFF; }
</span><del>- Color color() const { return m_color; }
</del><ins>+ const Color& color() const { return m_color; }
</ins><span class="cx"> bool isTransparent() const { return m_transparent; }
</span><span class="cx"> EBorderPrecedence precedence() const { return static_cast<EBorderPrecedence>(m_precedence); }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -1189,11 +1189,26 @@
</span><span class="cx"> rareInheritedData.access()->listStyleImage = v;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Color RenderStyle::color() const { return inherited->color; }
-Color RenderStyle::visitedLinkColor() const { return inherited->visitedLinkColor; }
-void RenderStyle::setColor(const Color& v) { SET_VAR(inherited, color, v); }
-void RenderStyle::setVisitedLinkColor(const Color& v) { SET_VAR(inherited, visitedLinkColor, v); }
</del><ins>+const Color& RenderStyle::color() const
+{
+ return inherited->color;
+}
</ins><span class="cx">
</span><ins>+const Color& RenderStyle::visitedLinkColor() const
+{
+ return inherited->visitedLinkColor;
+}
+
+void RenderStyle::setColor(const Color& v)
+{
+ SET_VAR(inherited, color, v);
+}
+
+void RenderStyle::setVisitedLinkColor(const Color& v)
+{
+ SET_VAR(inherited, visitedLinkColor, v);
+}
+
</ins><span class="cx"> float RenderStyle::horizontalBorderSpacing() const { return inherited->horizontal_border_spacing; }
</span><span class="cx"> float RenderStyle::verticalBorderSpacing() const { return inherited->vertical_border_spacing; }
</span><span class="cx"> void RenderStyle::setHorizontalBorderSpacing(float v) { SET_VAR(inherited, horizontal_border_spacing, v); }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStyleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -2238,36 +2238,36 @@
</span><span class="cx">
</span><span class="cx"> // Color accessors are all private to make sure callers use visitedDependentColor instead to access them.
</span><span class="cx"> static Color invalidColor() { return Color(); }
</span><del>- Color borderLeftColor() const { return surround->border.left().color(); }
- Color borderRightColor() const { return surround->border.right().color(); }
- Color borderTopColor() const { return surround->border.top().color(); }
- Color borderBottomColor() const { return surround->border.bottom().color(); }
- Color backgroundColor() const { return m_background->color(); }
- Color color() const;
- Color columnRuleColor() const { return rareNonInheritedData->m_multiCol->m_rule.color(); }
- Color outlineColor() const { return m_background->outline().color(); }
- Color textEmphasisColor() const { return rareInheritedData->textEmphasisColor; }
- Color textFillColor() const { return rareInheritedData->textFillColor; }
- Color textStrokeColor() const { return rareInheritedData->textStrokeColor; }
- Color visitedLinkColor() const;
- Color visitedLinkBackgroundColor() const { return rareNonInheritedData->m_visitedLinkBackgroundColor; }
- Color visitedLinkBorderLeftColor() const { return rareNonInheritedData->m_visitedLinkBorderLeftColor; }
- Color visitedLinkBorderRightColor() const { return rareNonInheritedData->m_visitedLinkBorderRightColor; }
- Color visitedLinkBorderBottomColor() const { return rareNonInheritedData->m_visitedLinkBorderBottomColor; }
- Color visitedLinkBorderTopColor() const { return rareNonInheritedData->m_visitedLinkBorderTopColor; }
- Color visitedLinkOutlineColor() const { return rareNonInheritedData->m_visitedLinkOutlineColor; }
- Color visitedLinkColumnRuleColor() const { return rareNonInheritedData->m_multiCol->m_visitedLinkColumnRuleColor; }
- Color textDecorationColor() const { return rareNonInheritedData->m_textDecorationColor; }
- Color visitedLinkTextDecorationColor() const { return rareNonInheritedData->m_visitedLinkTextDecorationColor; }
- Color visitedLinkTextEmphasisColor() const { return rareInheritedData->visitedLinkTextEmphasisColor; }
- Color visitedLinkTextFillColor() const { return rareInheritedData->visitedLinkTextFillColor; }
- Color visitedLinkTextStrokeColor() const { return rareInheritedData->visitedLinkTextStrokeColor; }
</del><ins>+ const Color& borderLeftColor() const { return surround->border.left().color(); }
+ const Color& borderRightColor() const { return surround->border.right().color(); }
+ const Color& borderTopColor() const { return surround->border.top().color(); }
+ const Color& borderBottomColor() const { return surround->border.bottom().color(); }
+ const Color& backgroundColor() const { return m_background->color(); }
+ const Color& color() const;
+ const Color& columnRuleColor() const { return rareNonInheritedData->m_multiCol->m_rule.color(); }
+ const Color& outlineColor() const { return m_background->outline().color(); }
+ const Color& textEmphasisColor() const { return rareInheritedData->textEmphasisColor; }
+ const Color& textFillColor() const { return rareInheritedData->textFillColor; }
+ const Color& textStrokeColor() const { return rareInheritedData->textStrokeColor; }
+ const Color& visitedLinkColor() const;
+ const Color& visitedLinkBackgroundColor() const { return rareNonInheritedData->m_visitedLinkBackgroundColor; }
+ const Color& visitedLinkBorderLeftColor() const { return rareNonInheritedData->m_visitedLinkBorderLeftColor; }
+ const Color& visitedLinkBorderRightColor() const { return rareNonInheritedData->m_visitedLinkBorderRightColor; }
+ const Color& visitedLinkBorderBottomColor() const { return rareNonInheritedData->m_visitedLinkBorderBottomColor; }
+ const Color& visitedLinkBorderTopColor() const { return rareNonInheritedData->m_visitedLinkBorderTopColor; }
+ const Color& visitedLinkOutlineColor() const { return rareNonInheritedData->m_visitedLinkOutlineColor; }
+ const Color& visitedLinkColumnRuleColor() const { return rareNonInheritedData->m_multiCol->m_visitedLinkColumnRuleColor; }
+ const Color& textDecorationColor() const { return rareNonInheritedData->m_textDecorationColor; }
+ const Color& visitedLinkTextDecorationColor() const { return rareNonInheritedData->m_visitedLinkTextDecorationColor; }
+ const Color& visitedLinkTextEmphasisColor() const { return rareInheritedData->visitedLinkTextEmphasisColor; }
+ const Color& visitedLinkTextFillColor() const { return rareInheritedData->visitedLinkTextFillColor; }
+ const Color& visitedLinkTextStrokeColor() const { return rareInheritedData->visitedLinkTextStrokeColor; }
</ins><span class="cx">
</span><span class="cx"> Color colorIncludingFallback(int colorProperty, bool visitedLink) const;
</span><span class="cx">
</span><del>- Color stopColor() const { return svgStyle().stopColor(); }
- Color floodColor() const { return svgStyle().floodColor(); }
- Color lightingColor() const { return svgStyle().lightingColor(); }
</del><ins>+ const Color& stopColor() const { return svgStyle().stopColor(); }
+ const Color& floodColor() const { return svgStyle().floodColor(); }
+ const Color& lightingColor() const { return svgStyle().lightingColor(); }
</ins><span class="cx">
</span><span class="cx"> void appendContent(std::unique_ptr<ContentData>);
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFEDiffuseLightingElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -186,9 +186,9 @@
</span><span class="cx"> RenderObject* renderer = this->renderer();
</span><span class="cx"> if (!renderer)
</span><span class="cx"> return nullptr;
</span><del>-
- Color color = renderer->style().svgStyle().lightingColor();
</del><span class="cx">
</span><ins>+ const Color& color = renderer->style().svgStyle().lightingColor();
+
</ins><span class="cx"> RefPtr<FilterEffect> effect = FEDiffuseLighting::create(filter, color, surfaceScale(), diffuseConstant(),
</span><span class="cx"> kernelUnitLengthX(), kernelUnitLengthY(), WTFMove(lightSource));
</span><span class="cx"> effect->inputEffects().append(input1);
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFEDropShadowElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFEDropShadowElement.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFEDropShadowElement.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/svg/SVGFEDropShadowElement.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -130,7 +130,7 @@
</span><span class="cx">
</span><span class="cx"> const SVGRenderStyle& svgStyle = renderer->style().svgStyle();
</span><span class="cx">
</span><del>- Color color = svgStyle.floodColor();
</del><ins>+ const Color& color = svgStyle.floodColor();
</ins><span class="cx"> float opacity = svgStyle.floodOpacity();
</span><span class="cx">
</span><span class="cx"> FilterEffect* input1 = filterBuilder->getEffectById(in1());
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFEFloodElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFEFloodElement.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFEFloodElement.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/svg/SVGFEFloodElement.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx">
</span><span class="cx"> const SVGRenderStyle& svgStyle = renderer->style().svgStyle();
</span><span class="cx">
</span><del>- Color color = svgStyle.floodColor();
</del><ins>+ const Color& color = svgStyle.floodColor();
</ins><span class="cx"> float opacity = svgStyle.floodOpacity();
</span><span class="cx">
</span><span class="cx"> return FEFlood::create(filter, color, opacity);
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFESpecularLightingElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFESpecularLightingElement.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFESpecularLightingElement.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/svg/SVGFESpecularLightingElement.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -198,7 +198,7 @@
</span><span class="cx"> if (!renderer)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- Color color = renderer->style().svgStyle().lightingColor();
</del><ins>+ const Color& color = renderer->style().svgStyle().lightingColor();
</ins><span class="cx">
</span><span class="cx"> RefPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, surfaceScale(), specularConstant(),
</span><span class="cx"> specularExponent(), kernelUnitLengthX(), kernelUnitLengthY(), WTFMove(lightSource));
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGGradientElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGGradientElement.cpp (206537 => 206538)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGGradientElement.cpp 2016-09-28 19:56:30 UTC (rev 206537)
+++ trunk/Source/WebCore/svg/SVGGradientElement.cpp 2016-09-28 20:19:47 UTC (rev 206538)
</span><span class="lines">@@ -133,7 +133,7 @@
</span><span class="cx"> float previousOffset = 0.0f;
</span><span class="cx">
</span><span class="cx"> for (auto& stop : childrenOfType<SVGStopElement>(*this)) {
</span><del>- Color color = stop.stopColorIncludingOpacity();
</del><ins>+ const Color& color = stop.stopColorIncludingOpacity();
</ins><span class="cx">
</span><span class="cx"> // Figure out right monotonic offset
</span><span class="cx"> float offset = stop.offset();
</span></span></pre>
</div>
</div>
</body>
</html>