<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206465] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206465">206465</a></dd>
<dt>Author</dt> <dd>dewei_zhu@apple.com</dd>
<dt>Date</dt> <dd>2016-09-27 14:54:38 -0700 (Tue, 27 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Extend perf dashboard to support multiple summary pages.
https://bugs.webkit.org/show_bug.cgi?id=162594
Reviewed by Ryosuke Niwa.
Start support multiple summary pages instead of one.
Specify 'summaryPages' as key that map to a list of summaries which follows
current 'summary' format in 'config.json' but with 2 more properties:
'name': specifying the name shows on perf dashboard,
'route': specifying the path to this page.
* public/include/manifest.php:
* public/v3/main.js:
(main):
(main.): Deleted.
* public/v3/models/manifest.js:
(Manifest._didFetchManifest):
(Manifest):
* public/v3/pages/summary-page.js:
(SummaryPage):
(SummaryPage.prototype.routeName):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludemanifestphp">trunk/Websites/perf.webkit.org/public/include/manifest.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3mainjs">trunk/Websites/perf.webkit.org/public/v3/main.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmanifestjs">trunk/Websites/perf.webkit.org/public/v3/models/manifest.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagessummarypagejs">trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (206464 => 206465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-09-27 21:05:50 UTC (rev 206464)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-09-27 21:54:38 UTC (rev 206465)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-09-27 Dewei Zhu <dewei_zhu@apple.com>
+
+ Extend perf dashboard to support multiple summary pages.
+ https://bugs.webkit.org/show_bug.cgi?id=162594
+
+ Reviewed by Ryosuke Niwa.
+
+ Start support multiple summary pages instead of one.
+ Specify 'summaryPages' as key that map to a list of summaries which follows
+ current 'summary' format in 'config.json' but with 2 more properties:
+ 'name': specifying the name shows on perf dashboard,
+ 'route': specifying the path to this page.
+
+ * public/include/manifest.php:
+ * public/v3/main.js:
+ (main):
+ (main.): Deleted.
+ * public/v3/models/manifest.js:
+ (Manifest._didFetchManifest):
+ (Manifest):
+ * public/v3/pages/summary-page.js:
+ (SummaryPage):
+ (SummaryPage.prototype.routeName):
+
</ins><span class="cx"> 2016-08-09 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Don't filter out the latest data point in chart data sampling
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludemanifestphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/manifest.php (206464 => 206465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/manifest.php 2016-09-27 21:05:50 UTC (rev 206464)
+++ trunk/Websites/perf.webkit.org/public/include/manifest.php 2016-09-27 21:54:38 UTC (rev 206465)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 'builders' => (object)$this->builders(),
</span><span class="cx"> 'bugTrackers' => (object)$this->bug_trackers($repositories_table),
</span><span class="cx"> 'dashboards' => (object)config('dashboards'),
</span><del>- 'summary' => (object)config('summary'),
</del><ins>+ 'summaryPages' => (object)config('summaryPages'),
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $this->manifest['elapsedTime'] = (microtime(true) - $start_time) * 1000;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3mainjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/main.js (206464 => 206465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/main.js 2016-09-27 21:05:50 UTC (rev 206464)
+++ trunk/Websites/perf.webkit.org/public/v3/main.js 2016-09-27 21:54:38 UTC (rev 206465)
</span><span class="lines">@@ -20,7 +20,12 @@
</span><span class="cx"> var router = new PageRouter();
</span><span class="cx"> var chartsToolbar = new ChartsToolbar;
</span><span class="cx">
</span><del>- var summaryPage = manifest.summary ? new SummaryPage(manifest.summary) : null;
</del><ins>+ var summaryPages = [];
+ if (manifest.summaryPages) {
+ for (var summaryPage of manifest.summaryPages)
+ summaryPages.push(new SummaryPage(summaryPage));
+ }
+
</ins><span class="cx"> var chartsPage = new ChartsPage(chartsToolbar);
</span><span class="cx"> var analysisCategoryPage = new AnalysisCategoryPage();
</span><span class="cx">
</span><span class="lines">@@ -34,13 +39,13 @@
</span><span class="cx"> buildRequestQueuePage.setParentPage(analysisCategoryPage);
</span><span class="cx">
</span><span class="cx"> var heading = new Heading(manifest.siteTitle);
</span><del>- heading.addPageGroup([summaryPage, chartsPage, analysisCategoryPage].filter(function (page) { return page; }));
</del><ins>+ heading.addPageGroup(summaryPages.concat([chartsPage, analysisCategoryPage]));
</ins><span class="cx">
</span><span class="cx"> heading.setTitle(manifest.siteTitle);
</span><span class="cx"> heading.addPageGroup(dashboardPages);
</span><span class="cx">
</span><span class="cx"> var router = new PageRouter();
</span><del>- if(summaryPage)
</del><ins>+ for (var summaryPage of summaryPages)
</ins><span class="cx"> router.addPage(summaryPage);
</span><span class="cx"> router.addPage(chartsPage);
</span><span class="cx"> router.addPage(createAnalysisTaskPage);
</span><span class="lines">@@ -50,9 +55,9 @@
</span><span class="cx"> for (var page of dashboardPages)
</span><span class="cx"> router.addPage(page);
</span><span class="cx">
</span><del>- if (summaryPage)
- router.setDefaultPage(summaryPage);
- else if (dashboardPages)
</del><ins>+ if (summaryPages.length)
+ router.setDefaultPage(summaryPages[0]);
+ else if (dashboardPages.length)
</ins><span class="cx"> router.setDefaultPage(dashboardPages[0]);
</span><span class="cx"> else
</span><span class="cx"> router.setDefaultPage(chartsPage);
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmanifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/manifest.js (206464 => 206465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/manifest.js 2016-09-27 21:05:50 UTC (rev 206464)
+++ trunk/Websites/perf.webkit.org/public/v3/models/manifest.js 2016-09-27 21:54:38 UTC (rev 206465)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> return {
</span><span class="cx"> siteTitle: rawResponse.siteTitle,
</span><span class="cx"> dashboards: rawResponse.dashboards, // FIXME: Add an abstraction around dashboards.
</span><del>- summary: rawResponse.summary,
</del><ins>+ summaryPages: rawResponse.summaryPages,
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagessummarypagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js (206464 => 206465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2016-09-27 21:05:50 UTC (rev 206464)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2016-09-27 21:54:38 UTC (rev 206465)
</span><span class="lines">@@ -3,8 +3,9 @@
</span><span class="cx">
</span><span class="cx"> constructor(summarySettings)
</span><span class="cx"> {
</span><del>- super('Summary', null);
</del><ins>+ super(summarySettings.name, null);
</ins><span class="cx">
</span><ins>+ this._route = summarySettings.route;
</ins><span class="cx"> this._table = {
</span><span class="cx"> heading: summarySettings.platformGroups,
</span><span class="cx"> groups: [],
</span><span class="lines">@@ -26,7 +27,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- routeName() { return 'summary'; }
</del><ins>+ routeName() { return `summary/${this._route}`; }
</ins><span class="cx">
</span><span class="cx"> open(state)
</span><span class="cx"> {
</span><span class="lines">@@ -37,7 +38,7 @@
</span><span class="cx"> for (var group of this._configGroups)
</span><span class="cx"> group.fetchAndComputeSummary(timeRange).then(this.render.bind(this));
</span><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> render()
</span><span class="cx"> {
</span><span class="cx"> Instrumentation.startMeasuringTime('SummaryPage', 'render');
</span></span></pre>
</div>
</div>
</body>
</html>