<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206469] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206469">206469</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-09-27 16:33:08 -0700 (Tue, 27 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>It should be possible to dispatch events on documents created using DOMParser
https://bugs.webkit.org/show_bug.cgi?id=26147
Reviewed by Ryosuke Niwa.
Source/WebCore:
It should be possible to dispatch events on documents created using
DOMParser. It did not work because we were not setting the context
document on the newly created document in DOMParser::parseFromString().
Firefox and Chrome both already support this.
Test: fast/dom/parsed-document-dispatchEvent.html
* xml/DOMParser.cpp:
(WebCore::DOMParser::DOMParser):
(WebCore::DOMParser::parseFromString):
* xml/DOMParser.h:
(WebCore::DOMParser::create):
* xml/DOMParser.idl:
LayoutTests:
Add layout test coverage.
* fast/dom/parsed-document-dispatchEvent-expected.txt: Added.
* fast/dom/parsed-document-dispatchEvent.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorexmlDOMParsercpp">trunk/Source/WebCore/xml/DOMParser.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlDOMParserh">trunk/Source/WebCore/xml/DOMParser.h</a></li>
<li><a href="#trunkSourceWebCorexmlDOMParseridl">trunk/Source/WebCore/xml/DOMParser.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomparseddocumentdispatchEventexpectedtxt">trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomparseddocumentdispatchEventhtml">trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (206468 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-09-27 23:20:56 UTC (rev 206468)
+++ trunk/LayoutTests/ChangeLog 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-09-27 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to dispatch events on documents created using DOMParser
+ https://bugs.webkit.org/show_bug.cgi?id=26147
+
+ Reviewed by Ryosuke Niwa.
+
+ Add layout test coverage.
+
+ * fast/dom/parsed-document-dispatchEvent-expected.txt: Added.
+ * fast/dom/parsed-document-dispatchEvent.html: Added.
+
</ins><span class="cx"> 2016-09-27 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html as flaky on Sierra.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomparseddocumentdispatchEventexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent-expected.txt (0 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent-expected.txt 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+Test that it is possible to dispatchEvent() works on documents created using DOMParser.parseFromString().
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS wasEventDispatched is false
+PASS wasEventDispatched is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomparseddocumentdispatchEventhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent.html (0 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent.html (rev 0)
+++ trunk/LayoutTests/fast/dom/parsed-document-dispatchEvent.html 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Test that it is possible to dispatchEvent() works on documents created using DOMParser.parseFromString().");
+
+var wasEventDispatched = false;
+var documentString = '<?xml version="1.0" encoding="UTF-8"?>\
+<root>\
+ <foo>bar</foo>\
+</root>';
+var parser = new DOMParser();
+var parsedDocument = parser.parseFromString(documentString, 'text/xml');
+parsedDocument.addEventListener("click", function(evt) {
+ shouldBeFalse("wasEventDispatched");
+ wasEventDispatched = true;
+}, true);
+var clickEvent = parsedDocument.createEvent("Event");
+clickEvent.initEvent("click", true, true);
+parsedDocument.getElementsByTagName("foo")[0].dispatchEvent(clickEvent);
+shouldBeTrue("wasEventDispatched");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206468 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-27 23:20:56 UTC (rev 206468)
+++ trunk/Source/WebCore/ChangeLog 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-09-27 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to dispatch events on documents created using DOMParser
+ https://bugs.webkit.org/show_bug.cgi?id=26147
+
+ Reviewed by Ryosuke Niwa.
+
+ It should be possible to dispatch events on documents created using
+ DOMParser. It did not work because we were not setting the context
+ document on the newly created document in DOMParser::parseFromString().
+
+ Firefox and Chrome both already support this.
+
+ Test: fast/dom/parsed-document-dispatchEvent.html
+
+ * xml/DOMParser.cpp:
+ (WebCore::DOMParser::DOMParser):
+ (WebCore::DOMParser::parseFromString):
+ * xml/DOMParser.h:
+ (WebCore::DOMParser::create):
+ * xml/DOMParser.idl:
+
</ins><span class="cx"> 2016-09-26 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Improve performance of complex text codepath
</span></span></pre></div>
<a id="trunkSourceWebCorexmlDOMParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/DOMParser.cpp (206468 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/DOMParser.cpp 2016-09-27 23:20:56 UTC (rev 206468)
+++ trunk/Source/WebCore/xml/DOMParser.cpp 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -25,8 +25,13 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-RefPtr<Document> DOMParser::parseFromString(const String& str, const String& contentType, ExceptionCode& ec)
</del><ins>+DOMParser::DOMParser(Document& contextDocument)
+ : m_contextDocument(contextDocument.createWeakPtr())
</ins><span class="cx"> {
</span><ins>+}
+
+RefPtr<Document> DOMParser::parseFromString(const String& string, const String& contentType, ExceptionCode& ec)
+{
</ins><span class="cx"> if (contentType != "text/html"
</span><span class="cx"> && contentType != "text/xml"
</span><span class="cx"> && contentType != "application/xml"
</span><span class="lines">@@ -36,9 +41,11 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Ref<Document> doc = DOMImplementation::createDocument(contentType, nullptr, URL());
- doc->setContent(str);
- return WTFMove(doc);
</del><ins>+ Ref<Document> document = DOMImplementation::createDocument(contentType, nullptr, URL());
+ if (m_contextDocument)
+ document->setContextDocument(*m_contextDocument.get());
+ document->setContent(string);
+ return WTFMove(document);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorexmlDOMParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/DOMParser.h (206468 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/DOMParser.h 2016-09-27 23:20:56 UTC (rev 206468)
+++ trunk/Source/WebCore/xml/DOMParser.h 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -22,6 +22,7 @@
</span><span class="cx"> #include <wtf/Forward.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><ins>+#include <wtf/WeakPtr.h>
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> typedef int ExceptionCode;
</span><span class="lines">@@ -30,12 +31,17 @@
</span><span class="cx">
</span><span class="cx"> class DOMParser : public RefCounted<DOMParser> {
</span><span class="cx"> public:
</span><del>- static Ref<DOMParser> create() { return adoptRef(*new DOMParser); }
</del><ins>+ static Ref<DOMParser> create(Document& contextDocument)
+ {
+ return adoptRef(*new DOMParser(contextDocument));
+ }
</ins><span class="cx">
</span><span class="cx"> RefPtr<Document> parseFromString(const String&, const String& contentType, ExceptionCode&);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- DOMParser() { }
</del><ins>+ explicit DOMParser(Document& contextDocument);
+
+ WeakPtr<Document> m_contextDocument;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorexmlDOMParseridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/DOMParser.idl (206468 => 206469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/DOMParser.idl 2016-09-27 23:20:56 UTC (rev 206468)
+++ trunk/Source/WebCore/xml/DOMParser.idl 2016-09-27 23:33:08 UTC (rev 206469)
</span><span class="lines">@@ -19,6 +19,7 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Constructor,
</span><ins>+ ConstructorCallWith=Document,
</ins><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface DOMParser {
</span><span class="cx"> [RaisesException, NewObject] Document parseFromString(DOMString str, DOMString contentType);
</span></span></pre>
</div>
</div>
</body>
</html>