<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206296] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206296">206296</a></dd>
<dt>Author</dt> <dd>graouts@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-23 02:32:09 -0700 (Fri, 23 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Adding a new runtime flag for modern media controls.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeCommonIdentifiersh">trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferenceKeysPrivateh">trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencescpp">trunk/Source/WebKit/win/WebPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencesh">trunk/Source/WebKit/win/WebPreferences.h</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreewinDumpRenderTreecpp">trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp</a></li>
<li><a href="#trunkToolsScriptswebkitperlFeatureListpm">trunk/Tools/Scripts/webkitperl/FeatureList.pm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp">trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-09-23 Antoine Quint <graouts@apple.com>
+
+ Add a new runtime flag for work on modern media controls (off by default)
+ https://bugs.webkit.org/show_bug.cgi?id=162420
+ <rdar://problem/27989489>
+
+ Reviewed by Eric Carlson.
+
+ * runtime/CommonIdentifiers.h:
+
</ins><span class="cx"> 2016-09-23 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeCommonIdentifiersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -70,6 +70,7 @@
</span><span class="cx"> macro(Map)\
</span><span class="cx"> macro(MapIterator)\
</span><span class="cx"> macro(Math) \
</span><ins>+ macro(ModernMediaControls) \
</ins><span class="cx"> macro(NaN) \
</span><span class="cx"> macro(Number) \
</span><span class="cx"> macro(NumberFormat) \
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebCore/ChangeLog 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-09-23 Antoine Quint <graouts@apple.com>
+
+ Add a new runtime flag for work on modern media controls (off by default)
+ https://bugs.webkit.org/show_bug.cgi?id=162420
+ <rdar://problem/27989489>
+
+ Reviewed by Eric Carlson.
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setModernMediaControlsEnabled):
+ (WebCore::RuntimeEnabledFeatures::modernMediaControlsEnabled):
+
</ins><span class="cx"> 2016-09-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [ShadowDOM] Add support for Node.getRootNode(options)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -223,6 +223,9 @@
</span><span class="cx"> bool isCSSGridLayoutEnabled() const { return m_cssGridLayoutEnabled; }
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ void setModernMediaControlsEnabled(bool areEnabled) { m_areModernMediaControlsEnabled = areEnabled; }
+ bool modernMediaControlsEnabled() const { return m_areModernMediaControlsEnabled; }
+
</ins><span class="cx"> WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void reset();
</span><span class="lines">@@ -231,6 +234,7 @@
</span><span class="cx"> // Never instantiate.
</span><span class="cx"> RuntimeEnabledFeatures();
</span><span class="cx">
</span><ins>+ bool m_areModernMediaControlsEnabled;
</ins><span class="cx"> bool m_isLocalStorageEnabled;
</span><span class="cx"> bool m_isSessionStorageEnabled;
</span><span class="cx"> bool m_isWebkitNotificationsEnabled;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-09-23 Antoine Quint <graouts@apple.com>
+
+ Add a new runtime flag for work on modern media controls (off by default)
+ https://bugs.webkit.org/show_bug.cgi?id=162420
+ <rdar://problem/27989489>
+
+ Reviewed by Eric Carlson.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (-[WebPreferences modernMediaControlsEnabled]):
+ (-[WebPreferences setModernMediaControlsEnabled:]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2016-09-21 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Support openPaymentSetup API on ApplePaySession object
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -167,6 +167,7 @@
</span><span class="cx"> #define WebKitDownloadAttributeEnabledPreferenceKey @"WebKitDownloadAttributeEnabled"
</span><span class="cx"> #define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
</span><span class="cx"> #define WebKitVisualViewportEnabledPreferenceKey @"WebKitVisualViewportEnabled"
</span><ins>+#define WebKitModernMediaControlsEnabledPreferenceKey @"WebKitModernMediaControlsEnabled"
</ins><span class="cx">
</span><span class="cx"> #if !TARGET_OS_IPHONE
</span><span class="cx"> // These are private both because callers should be using the cover methods and because the
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -2786,6 +2786,16 @@
</span><span class="cx"> [self _setBoolValue:flag forKey:WebKitWebAnimationsEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)modernMediaControlsEnabled
+{
+ return [self _boolValueForKey:WebKitModernMediaControlsEnabledPreferenceKey];
+}
+
+- (void)setModernMediaControlsEnabled:(BOOL)flag
+{
+ [self _setBoolValue:flag forKey:WebKitModernMediaControlsEnabledPreferenceKey];
+}
+
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> @implementation WebPreferences (WebInternal)
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -496,6 +496,9 @@
</span><span class="cx"> - (void)setWebAnimationsEnabled:(BOOL)flag;
</span><span class="cx"> - (BOOL)webAnimationsEnabled;
</span><span class="cx">
</span><ins>+- (void)setModernMediaControlsEnabled:(BOOL)flag;
+- (BOOL)modernMediaControlsEnabled;
+
</ins><span class="cx"> @property (nonatomic) BOOL visualViewportEnabled;
</span><span class="cx"> @property (nonatomic) BOOL javaScriptMarkupEnabled;
</span><span class="cx"> @property (nonatomic) BOOL mediaDataLoadsAutomatically;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -2525,6 +2525,8 @@
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled([preferences DOMIteratorEnabled]);
</span><span class="cx">
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setModernMediaControlsEnabled([preferences modernMediaControlsEnabled]);
+
</ins><span class="cx"> #if ENABLE(CUSTOM_ELEMENTS)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled([preferences customElementsEnabled]);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/win/ChangeLog 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-09-23 Antoine Quint <graouts@apple.com>
+
+ Add a new runtime flag for work on modern media controls (off by default)
+ https://bugs.webkit.org/show_bug.cgi?id=162420
+ <rdar://problem/27989489>
+
+ Reviewed by Eric Carlson.
+
+ * Interfaces/IWebPreferencesPrivate.idl:
+ * WebPreferenceKeysPrivate.h:
+ * WebPreferences.cpp:
+ (WebPreferences::setModernMediaControlsEnabled):
+ (WebPreferences::modernMediaControlsEnabled):
+ (WebPreferences::setCustomElementsEnabled): Deleted.
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
</ins><span class="cx"> 2016-09-15 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -183,5 +183,7 @@
</span><span class="cx"> HRESULT setShadowDOMEnabled([in] BOOL enabled);
</span><span class="cx"> HRESULT customElementsEnabled([out, retval] BOOL* enabled);
</span><span class="cx"> HRESULT setCustomElementsEnabled([in] BOOL enabled);
</span><ins>+ HRESULT modernMediaControlsEnabled([out, retval] BOOL* enabled);
+ HRESULT setModernMediaControlsEnabled([in] BOOL enabled);
</ins><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -175,3 +175,5 @@
</span><span class="cx"> #define WebKitShadowDOMEnabledPreferenceKey "WebKitShadowDOMEnabled"
</span><span class="cx">
</span><span class="cx"> #define WebKitCustomElementsEnabledPreferenceKey "WebKitCustomElementsEnabled"
</span><ins>+
+#define WebKitModernMediaControlsEnabledPreferenceKey "WebKitModernMediaControlsEnabled"
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/win/WebPreferences.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1979,3 +1979,17 @@
</span><span class="cx"> setBoolValue(WebKitCustomElementsEnabledPreferenceKey, enabled);
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><ins>+
+HRESULT WebPreferences::setModernMediaControlsEnabled(BOOL enabled)
+{
+ setBoolValue(WebKitModernMediaControlsEnabledPreferenceKey, enabled);
+ return S_OK;
+}
+
+HRESULT WebPreferences::modernMediaControlsEnabled(_Out_ BOOL* enabled)
+{
+ if (!enabled)
+ return E_POINTER;
+ *enabled = boolValueForKey(WebKitModernMediaControlsEnabledPreferenceKey);
+ return S_OK;
+}
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/win/WebPreferences.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -241,6 +241,8 @@
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setShadowDOMEnabled(BOOL);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE customElementsEnabled(_Out_ BOOL*);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setCustomElementsEnabled(BOOL);
</span><ins>+ virtual HRESULT STDMETHODCALLTYPE modernMediaControlsEnabled(_Out_ BOOL*);
+ virtual HRESULT STDMETHODCALLTYPE setModernMediaControlsEnabled(BOOL);
</ins><span class="cx">
</span><span class="cx"> // WebPreferences
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -5082,6 +5082,11 @@
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(!!enabled);
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ hr = prefsPrivate->modernMediaControlsEnabled(&enabled);
+ if (FAILED(hr))
+ return hr;
+ RuntimeEnabledFeatures::sharedFeatures().setModernMediaControlsEnabled(!!enabled);
+
</ins><span class="cx"> hr = preferences->privateBrowsingEnabled(&enabled);
</span><span class="cx"> if (FAILED(hr))
</span><span class="cx"> return hr;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-09-23 Antoine Quint <graouts@apple.com>
+
+ Add a new runtime flag for work on modern media controls (off by default)
+ https://bugs.webkit.org/show_bug.cgi?id=162420
+ <rdar://problem/27989489>
+
+ Reviewed by Eric Carlson.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2016-09-23 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -289,6 +289,7 @@
</span><span class="cx"> macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true, "CSS Grid", "CSS Grid Layout Module support") \
</span><span class="cx"> macro(CustomElementsEnabled, customElementsEnabled, Bool, bool, true, "Custom Elements", "HTML Custom Elements prototype") \
</span><span class="cx"> macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, false, "Gamepads", "Web Gamepad API support") \
</span><ins>+ macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, false, "Modern Media Controls", "Use modern media controls look") \
</ins><span class="cx"> macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, true, "CSS Spring Animations", "CSS Spring Animation prototype") \
</span><span class="cx"> macro(WebGL2Enabled, webGL2Enabled, Bool, bool, true, "WebGL 2.0", "WebGL 2 prototype") \
</span><span class="cx"> macro(VisualViewportEnabled, visualViewportEnabled, Bool, bool, false, "Visual Viewport", "Use Visual Viewport for fixed elements when zooming") \
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -212,6 +212,9 @@
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(enabled);
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ if (preference == "WebKitModernMediaControlsEnabled")
+ RuntimeEnabledFeatures::sharedFeatures().setModernMediaControlsEnabled(enabled);
+
</ins><span class="cx"> // Map the names used in LayoutTests with the names used in WebCore::Settings and WebPreferencesStore.
</span><span class="cx"> #define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
</span><span class="cx"> macro(WebKitAcceleratedCompositingEnabled, AcceleratedCompositingEnabled, acceleratedCompositingEnabled) \
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -3224,6 +3224,8 @@
</span><span class="cx">
</span><span class="cx"> settings.setVisualViewportEnabled(store.getBoolValueForKey(WebPreferencesKey::visualViewportEnabledKey()));
</span><span class="cx">
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setModernMediaControlsEnabled(store.getBoolValueForKey(WebPreferencesKey::modernMediaControlsEnabledKey()));
+
</ins><span class="cx"> bool processSuppressionEnabled = store.getBoolValueForKey(WebPreferencesKey::pageVisibilityBasedProcessSuppressionEnabledKey());
</span><span class="cx"> if (m_processSuppressionEnabled != processSuppressionEnabled) {
</span><span class="cx"> m_processSuppressionEnabled = processSuppressionEnabled;
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/ChangeLog 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-09-23 Antoine Quint <graouts@apple.com>
+
+ Add a new runtime flag for work on modern media controls (off by default)
+ https://bugs.webkit.org/show_bug.cgi?id=162420
+ <rdar://problem/27989489>
+
+ Reviewed by Eric Carlson.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (resetWebPreferencesToConsistentValues):
+ * Scripts/webkitperl/FeatureList.pm:
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::beginTesting):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setModernMediaControlsEnabled):
+ * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
</ins><span class="cx"> 2016-09-23 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -989,6 +989,8 @@
</span><span class="cx">
</span><span class="cx"> [preferences setDownloadAttributeEnabled:YES];
</span><span class="cx">
</span><ins>+ [preferences setModernMediaControlsEnabled:NO];
+
</ins><span class="cx"> [preferences setHiddenPageDOMTimerThrottlingEnabled:NO];
</span><span class="cx"> [preferences setHiddenPageCSSAnimationSuspensionEnabled:NO];
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinDumpRenderTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -854,6 +854,7 @@
</span><span class="cx"> prefsPrivate3->setCustomElementsEnabled(TRUE);
</span><span class="cx">
</span><span class="cx"> prefsPrivate3->setDOMIteratorEnabled(TRUE);
</span><ins>+ prefsPrivate3->setModernMediaControlsEnabled(FALSE);
</ins><span class="cx">
</span><span class="cx"> setAlwaysAcceptCookies(false);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsScriptswebkitperlFeatureListpm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -113,6 +113,7 @@
</span><span class="cx"> $mediaStreamSupport,
</span><span class="cx"> $meterElementSupport,
</span><span class="cx"> $mhtmlSupport,
</span><ins>+ $modernMediaControls,
</ins><span class="cx"> $modulesSupport,
</span><span class="cx"> $mouseCursorScaleSupport,
</span><span class="cx"> $netscapePluginAPISupport,
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -319,6 +319,8 @@
</span><span class="cx">
</span><span class="cx"> m_testRunner->setWebGL2Enabled(true);
</span><span class="cx">
</span><ins>+ m_testRunner->setModernMediaControlsEnabled(false);
+
</ins><span class="cx"> m_testRunner->setFetchAPIEnabled(true);
</span><span class="cx">
</span><span class="cx"> m_testRunner->setDownloadAttributeEnabled(true);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -361,6 +361,13 @@
</span><span class="cx"> WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void TestRunner::setModernMediaControlsEnabled(bool enabled)
+{
+ WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitModernMediaControlsEnabled"));
+ auto& injectedBundle = InjectedBundle::singleton();
+ WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
+}
+
</ins><span class="cx"> void TestRunner::setWebGL2Enabled(bool enabled)
</span><span class="cx"> {
</span><span class="cx"> WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitWebGL2Enabled"));
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (206295 => 206296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2016-09-23 08:20:06 UTC (rev 206295)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2016-09-23 09:32:09 UTC (rev 206296)
</span><span class="lines">@@ -103,6 +103,7 @@
</span><span class="cx"> void setShadowDOMEnabled(bool);
</span><span class="cx"> void setCustomElementsEnabled(bool);
</span><span class="cx"> void setDOMIteratorEnabled(bool);
</span><ins>+ void setModernMediaControlsEnabled(bool);
</ins><span class="cx"> void setWebGL2Enabled(bool);
</span><span class="cx"> void setFetchAPIEnabled(bool);
</span><span class="cx"> void setAllowUniversalAccessFromFileURLs(bool);
</span></span></pre>
</div>
</div>
</body>
</html>