<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206284] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206284">206284</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2016-09-22 18:15:53 -0700 (Thu, 22 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Removed unused hasErrorInfo().
https://bugs.webkit.org/show_bug.cgi?id=162473
Reviewed by Saam Barati.
* JavaScriptCore.order:
* runtime/Error.cpp:
(JSC::hasErrorInfo): Deleted.
* runtime/Error.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreJavaScriptCoreorder">trunk/Source/JavaScriptCore/JavaScriptCore.order</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeErrorcpp">trunk/Source/JavaScriptCore/runtime/Error.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeErrorh">trunk/Source/JavaScriptCore/runtime/Error.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (206283 => 206284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-09-23 01:15:53 UTC (rev 206284)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-09-22 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><ins>+ Removed unused hasErrorInfo().
+ https://bugs.webkit.org/show_bug.cgi?id=162473
+
+ Reviewed by Saam Barati.
+
+ * JavaScriptCore.order:
+ * runtime/Error.cpp:
+ (JSC::hasErrorInfo): Deleted.
+ * runtime/Error.h:
+
+2016-09-22 Mark Lam <mark.lam@apple.com>
+
</ins><span class="cx"> Array.prototype.join should do overflow checks on string joins.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=162459
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreJavaScriptCoreorder"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/JavaScriptCore.order (206283 => 206284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/JavaScriptCore.order 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/JavaScriptCore/JavaScriptCore.order 2016-09-23 01:15:53 UTC (rev 206284)
</span><span class="lines">@@ -1761,7 +1761,6 @@
</span><span class="cx"> _cti_vm_throw
</span><span class="cx"> __ZN3JSC8jitThrowEPNS_2VMEPNS_9ExecStateENS_7JSValueENS_16ReturnAddressPtrE
</span><span class="cx"> __ZN3JSC11Interpreter14throwExceptionERPNS_9ExecStateERNS_7JSValueEj
</span><del>-__ZN3JSC12hasErrorInfoEPNS_9ExecStateEPNS_8JSObjectE
</del><span class="cx"> __ZN3JSC9CodeBlock27lineNumberForBytecodeOffsetEj
</span><span class="cx"> __ZN3JSC17UnlinkedCodeBlock27lineNumberForBytecodeOffsetEj
</span><span class="cx"> __ZN3JSC12addErrorInfoEPNS_9ExecStateEPNS_8JSObjectEiRKNS_10SourceCodeE
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeErrorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Error.cpp (206283 => 206284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Error.cpp 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/JavaScriptCore/runtime/Error.cpp 2016-09-23 01:15:53 UTC (rev 206284)
</span><span class="lines">@@ -193,13 +193,6 @@
</span><span class="cx"> return error;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
-bool hasErrorInfo(ExecState* exec, JSObject* error)
-{
- return error->hasProperty(exec, Identifier::fromString(exec, linePropertyName))
- || error->hasProperty(exec, Identifier::fromString(exec, sourceURLPropertyName));
-}
-
</del><span class="cx"> JSObject* throwConstructorCannotBeCalledAsFunctionTypeError(ExecState* exec, ThrowScope& scope, const char* constructorName)
</span><span class="cx"> {
</span><span class="cx"> return throwTypeError(exec, scope, makeString("calling ", constructorName, " constructor without new is invalid"));
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeErrorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Error.h (206283 => 206284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Error.h 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/JavaScriptCore/runtime/Error.h 2016-09-23 01:15:53 UTC (rev 206284)
</span><span class="lines">@@ -64,7 +64,6 @@
</span><span class="cx">
</span><span class="cx"> bool addErrorInfoAndGetBytecodeOffset(ExecState*, VM&, JSObject*, bool, CallFrame*&, unsigned* = nullptr);
</span><span class="cx">
</span><del>-bool hasErrorInfo(ExecState*, JSObject* error);
</del><span class="cx"> JS_EXPORT_PRIVATE void addErrorInfo(ExecState*, JSObject*, bool);
</span><span class="cx"> JSObject* addErrorInfo(ExecState*, JSObject* error, int line, const SourceCode&);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>