<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206247] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206247">206247</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2016-09-21 22:03:01 -0700 (Wed, 21 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
https://bugs.webkit.org/show_bug.cgi?id=162359
<rdar://problem/27776454>
Reviewed by Tim Horton.
Source/WebKit2:
Test: added to TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Fixed a bug where
m_pendingNewlyReachedLayoutMilestones was never initialized.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Added
m_pendingNewlyReachedLayoutMilestones member variable to this derived class as well.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): If we have pending milestones, notify
the WebPageProxy now, after any content size changes have been sent.
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): New override that
accumulates the milestones into m_pendingNewlyReachedLayoutMilestones and returns true,
so that the caller won’t notify the WebPageProxy immediately.
Tools:
* TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
(TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreah">trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacTiledCoreAnimationDrawingAreah">trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacTiledCoreAnimationDrawingAreamm">trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaAutoLayoutIntegrationmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (206246 => 206247)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-22 05:03:01 UTC (rev 206247)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-09-21 Dan Bernstein <mitz@apple.com>
+
+ [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
+ https://bugs.webkit.org/show_bug.cgi?id=162359
+ <rdar://problem/27776454>
+
+ Reviewed by Tim Horton.
+
+ Test: added to TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm
+
+ * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Fixed a bug where
+ m_pendingNewlyReachedLayoutMilestones was never initialized.
+
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Added
+ m_pendingNewlyReachedLayoutMilestones member variable to this derived class as well.
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+ (WebKit::TiledCoreAnimationDrawingArea::flushLayers): If we have pending milestones, notify
+ the WebPageProxy now, after any content size changes have been sent.
+ (WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): New override that
+ accumulates the milestones into m_pendingNewlyReachedLayoutMilestones and returns true,
+ so that the caller won’t notify the WebPageProxy immediately.
+
</ins><span class="cx"> 2016-09-21 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> support openPaymentSetup API on ApplePaySession object
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (206246 => 206247)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2016-09-22 05:03:01 UTC (rev 206247)
</span><span class="lines">@@ -163,7 +163,7 @@
</span><span class="cx"> uint64_t m_currentTransactionID;
</span><span class="cx"> Vector<RemoteLayerTreeTransaction::TransactionCallbackID> m_pendingCallbackIDs;
</span><span class="cx">
</span><del>- WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones;
</del><ins>+ WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones { 0 };
</ins><span class="cx">
</span><span class="cx"> WebCore::GraphicsLayer* m_contentLayer;
</span><span class="cx"> WebCore::GraphicsLayer* m_viewOverlayRootLayer;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacTiledCoreAnimationDrawingAreah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h (206246 => 206247)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h 2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h 2016-09-22 05:03:01 UTC (rev 206247)
</span><span class="lines">@@ -86,6 +86,8 @@
</span><span class="cx">
</span><span class="cx"> void attachViewOverlayGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*) override;
</span><span class="cx">
</span><ins>+ bool dispatchDidReachLayoutMilestone(WebCore::LayoutMilestones) override;
+
</ins><span class="cx"> // WebCore::LayerFlushSchedulerClient
</span><span class="cx"> bool flushLayers() override;
</span><span class="cx">
</span><span class="lines">@@ -154,6 +156,8 @@
</span><span class="cx"> bool m_isScalingViewToFitDocument { false };
</span><span class="cx"> WebCore::IntSize m_lastViewSizeForScaleToFit;
</span><span class="cx"> WebCore::IntSize m_lastDocumentSizeForScaleToFit;
</span><ins>+
+ WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones { 0 };
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacTiledCoreAnimationDrawingAreamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (206246 => 206247)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2016-09-22 05:03:01 UTC (rev 206247)
</span><span class="lines">@@ -439,6 +439,10 @@
</span><span class="cx"> if (m_transientZoomScale != 1)
</span><span class="cx"> applyTransientZoomToLayers(m_transientZoomScale, m_transientZoomOrigin);
</span><span class="cx">
</span><ins>+ if (m_pendingNewlyReachedLayoutMilestones)
+ m_webPage.send(Messages::WebPageProxy::DidReachLayoutMilestone(m_pendingNewlyReachedLayoutMilestones));
+ m_pendingNewlyReachedLayoutMilestones = 0;
+
</ins><span class="cx"> return returnValue;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -864,6 +868,12 @@
</span><span class="cx"> m_layerHostingContext->setFencePort(fencePort.sendRight());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone(WebCore::LayoutMilestones layoutMilestones)
+{
+ m_pendingNewlyReachedLayoutMilestones |= layoutMilestones;
+ return true;
+}
+
</ins><span class="cx"> } // namespace WebKit
</span><span class="cx">
</span><span class="cx"> #endif // !PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (206246 => 206247)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Tools/ChangeLog 2016-09-22 05:03:01 UTC (rev 206247)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-09-21 Dan Bernstein <mitz@apple.com>
+
+ [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
+ https://bugs.webkit.org/show_bug.cgi?id=162359
+ <rdar://problem/27776454>
+
+ Reviewed by Tim Horton.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
+ (TEST):
+
</ins><span class="cx"> 2016-09-21 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix build for future versions of Clang.
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaAutoLayoutIntegrationmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm (206246 => 206247)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm 2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm 2016-09-22 05:03:01 UTC (rev 206247)
</span><span class="lines">@@ -36,12 +36,11 @@
</span><span class="cx"> static bool didEvaluateJavaScript;
</span><span class="cx">
</span><span class="cx"> @interface AutoLayoutWKWebView : WKWebView
</span><ins>+@property (nonatomic) BOOL expectingIntrinsicContentSizeChange;
+@property (nonatomic) NSSize expectedIntrinsicContentSize;
</ins><span class="cx"> @end
</span><span class="cx">
</span><del>-@implementation AutoLayoutWKWebView {
- BOOL _expectingIntrinsicContentSizeChange;
- NSSize _expectedIntrinsicContentSize;
-}
</del><ins>+@implementation AutoLayoutWKWebView
</ins><span class="cx">
</span><span class="cx"> - (instancetype)initWithFrame:(NSRect)frame configuration:(WKWebViewConfiguration *)configuration
</span><span class="cx"> {
</span><span class="lines">@@ -156,6 +155,33 @@
</span><span class="cx"> }];
</span><span class="cx"> TestWebKitAPI::Util::run(&didEvaluateJavaScript);
</span><span class="cx"> didEvaluateJavaScript = false;
</span><ins>+ [webView _setShouldExpandContentToViewHeightForAutoLayout:NO];
+
+ auto navigationDelegate = adoptNS([[TestNavigationDelegate alloc] init]);
+
+ __block bool didFinishNavigation = false;
+ [navigationDelegate setDidFinishNavigation:^(WKWebView *, WKNavigation *) {
+ didFinishNavigation = true;
+ }];
+ __block bool didFirstLayout = false;
+ [navigationDelegate setRenderingProgressDidChange:^(WKWebView *, _WKRenderingProgressEvents progressEvents) {
+ if (progressEvents & _WKRenderingProgressEventFirstLayout) {
+ didFirstLayout = true;
+ EXPECT_TRUE(didInvalidateIntrinsicContentSize);
+ }
+ }];
+ [webView setNavigationDelegate:navigationDelegate.get()];
+
+ [webView _setMinimumLayoutWidth:100];
+ didInvalidateIntrinsicContentSize = false;
+ [webView setExpectingIntrinsicContentSizeChange:YES];
+ [webView setExpectedIntrinsicContentSize:NSMakeSize(100, 400)];
+ [webView loadHTMLString:@"<body style='margin: 0; height: 400px;'></body>" baseURL:nil];
+ TestWebKitAPI::Util::run(&didInvalidateIntrinsicContentSize);
+ EXPECT_FALSE(didFirstLayout);
+ TestWebKitAPI::Util::run(&didFirstLayout);
+ TestWebKitAPI::Util::run(&didFinishNavigation);
+ [webView setNavigationDelegate:nil];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>