<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206222] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206222">206222</a></dd>
<dt>Author</dt> <dd>keith_miller@apple.com</dd>
<dt>Date</dt> <dd>2016-09-21 11:24:43 -0700 (Wed, 21 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix build for future versions of Clang.
https://bugs.webkit.org/show_bug.cgi?id=162346
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
* runtime/VM.h:
(JSC::VM::setGlobalConstRedeclarationShouldThrow):
Source/WebCore:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
* Configurations/WebCore.unexp:
* dom/Exception.h:
* page/Frame.h:
* platform/cocoa/WebPlaybackSessionModelMediaElement.h:
* platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::videoElement):
* platform/graphics/Color.h:
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::rotate):
* platform/mac/WebVideoFullscreenInterfaceMac.h:
* platform/network/ParsedContentRange.h:
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::certificateInfo):
* platform/text/TextStream.h:
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):
Source/WTF:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
* wtf/text/StringImpl.h:
Tools:
* TestWebKitAPI/Counters.cpp:
* TestWebKitAPI/Counters.h:
(DeleterCounter::deleterCount):
(DeleterCounter::TestingScope::TestingScope):
(DeleterCounter::operator()):
* TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeVMh">trunk/Source/JavaScriptCore/runtime/VM.h</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextStringImplh">trunk/Source/WTF/wtf/text/StringImpl.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreConfigurationsWebCoreunexp">trunk/Source/WebCore/Configurations/WebCore.unexp</a></li>
<li><a href="#trunkSourceWebCoredomExceptionh">trunk/Source/WebCore/dom/Exception.h</a></li>
<li><a href="#trunkSourceWebCorepageFrameh">trunk/Source/WebCore/page/Frame.h</a></li>
<li><a href="#trunkSourceWebCoreplatformcocoaWebPlaybackSessionModelMediaElementh">trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h</a></li>
<li><a href="#trunkSourceWebCoreplatformcocoaWebVideoFullscreenModelVideoElementh">trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsColorh">trunk/Source/WebCore/platform/graphics/Color.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicstransformsTransformationMatrixh">trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmacWebVideoFullscreenInterfaceMach">trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkParsedContentRangeh">trunk/Source/WebCore/platform/network/ParsedContentRange.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkResourceResponseBaseh">trunk/Source/WebCore/platform/network/ResourceResponseBase.h</a></li>
<li><a href="#trunkSourceWebCoreplatformtextTextStreamh">trunk/Source/WebCore/platform/text/TextStream.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPICounterscpp">trunk/Tools/TestWebKitAPI/Counters.cpp</a></li>
<li><a href="#trunkToolsTestWebKitAPICountersh">trunk/Tools/TestWebKitAPI/Counters.h</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFHashCountedSetcpp">trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFHashMapcpp">trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-09-21 Keith Miller <keith_miller@apple.com>
+
+ Fix build for future versions of Clang.
+ https://bugs.webkit.org/show_bug.cgi?id=162346
+
+ Reviewed by Filip Pizlo.
+
+ This fixes issues with the WebCore build where inline
+ template-class function definitions are marked as exported. This
+ genereates a weak external symobl that our build does not like.
+
+
+ * runtime/VM.h:
+ (JSC::VM::setGlobalConstRedeclarationShouldThrow):
+
</ins><span class="cx"> 2016-09-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Object.getOwnPropertyDescriptor() does not work correctly cross origin
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeVMh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/VM.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/VM.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/JavaScriptCore/runtime/VM.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -616,7 +616,7 @@
</span><span class="cx">
</span><span class="cx"> JS_EXPORT_PRIVATE void queueMicrotask(JSGlobalObject*, PassRefPtr<Microtask>);
</span><span class="cx"> JS_EXPORT_PRIVATE void drainMicrotasks();
</span><del>- JS_EXPORT_PRIVATE void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
</del><ins>+ void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
</ins><span class="cx"> ALWAYS_INLINE bool globalConstRedeclarationShouldThrow() const { return m_globalConstRedeclarationShouldThrow; }
</span><span class="cx">
</span><span class="cx"> inline bool shouldTriggerTermination(ExecState*);
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WTF/ChangeLog 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-09-21 Keith Miller <keith_miller@apple.com>
+
+ Fix build for future versions of Clang.
+ https://bugs.webkit.org/show_bug.cgi?id=162346
+
+ Reviewed by Filip Pizlo.
+
+ This fixes issues with the WebCore build where inline
+ template-class function definitions are marked as exported. This
+ genereates a weak external symobl that our build does not like.
+
+ * wtf/text/StringImpl.h:
+
</ins><span class="cx"> 2016-09-20 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Require WTFMove for String::adopt
</span></span></pre></div>
<a id="trunkSourceWTFwtftextStringImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/StringImpl.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/StringImpl.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -948,8 +948,8 @@
</span><span class="cx">
</span><span class="cx"> bool equalIgnoringASCIICase(const StringImpl&, const StringImpl&);
</span><span class="cx"> WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const StringImpl*);
</span><del>-WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl&, const char*);
-WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const char*);
</del><ins>+bool equalIgnoringASCIICase(const StringImpl&, const char*);
+bool equalIgnoringASCIICase(const StringImpl*, const char*);
</ins><span class="cx">
</span><span class="cx"> WTF_EXPORT_STRING_API bool equalIgnoringASCIICaseNonNull(const StringImpl*, const StringImpl*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/ChangeLog 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -1,3 +1,33 @@
</span><ins>+2016-09-21 Keith Miller <keith_miller@apple.com>
+
+ Fix build for future versions of Clang.
+ https://bugs.webkit.org/show_bug.cgi?id=162346
+
+ Reviewed by Filip Pizlo.
+
+ This fixes issues with the WebCore build where inline
+ template-class function definitions are marked as exported. This
+ genereates a weak external symobl that our build does not like.
+
+ * Configurations/WebCore.unexp:
+ * dom/Exception.h:
+ * page/Frame.h:
+ * platform/cocoa/WebPlaybackSessionModelMediaElement.h:
+ * platform/cocoa/WebVideoFullscreenModelVideoElement.h:
+ (WebCore::WebVideoFullscreenModelVideoElement::videoElement):
+ * platform/graphics/Color.h:
+ * platform/graphics/transforms/TransformationMatrix.h:
+ (WebCore::TransformationMatrix::rotate):
+ * platform/mac/WebVideoFullscreenInterfaceMac.h:
+ * platform/network/ParsedContentRange.h:
+ (WebCore::ParsedContentRange::ParsedContentRange):
+ (WebCore::ParsedContentRange::isValid):
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::certificateInfo):
+ * platform/text/TextStream.h:
+ (WebCore::TextStream::increaseIndent):
+ (WebCore::TextStream::decreaseIndent):
+
</ins><span class="cx"> 2016-09-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Object.getOwnPropertyDescriptor() does not work correctly cross origin
</span></span></pre></div>
<a id="trunkSourceWebCoreConfigurationsWebCoreunexp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Configurations/WebCore.unexp (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Configurations/WebCore.unexp 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/Configurations/WebCore.unexp 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -47,9 +47,12 @@
</span><span class="cx"> _DDDFAScannerCreateFromCache
</span><span class="cx"> _DDDFAScannerFirstResultInUnicharArray
</span><span class="cx"> # Source/WebCore/page/mac/ServicesOverlayController.mm
</span><ins>+_DDHighlightGetLayerWithContext
+_DDHighlightGetBoundingRect
</ins><span class="cx"> _DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection
</span><span class="cx"> _DDHighlightPointIsOnHighlight
</span><span class="cx">
</span><ins>+
</ins><span class="cx"> # Subclasses of an exported C++ class in JavaScriptCore.
</span><span class="cx">
</span><span class="cx"> # Source/JavaScriptCore/inspector/ScriptDebugServer.h
</span></span></pre></div>
<a id="trunkSourceWebCoredomExceptionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Exception.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Exception.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/dom/Exception.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> public:
</span><span class="cx"> explicit Exception(ExceptionCode);
</span><span class="cx">
</span><del>- WEBCORE_EXPORT ExceptionCode code() const;
</del><ins>+ ExceptionCode code() const;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> ExceptionCode m_code;
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Frame.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Frame.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/page/Frame.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -135,7 +135,7 @@
</span><span class="cx"> void disconnectOwnerElement();
</span><span class="cx">
</span><span class="cx"> MainFrame& mainFrame() const;
</span><del>- WEBCORE_EXPORT bool isMainFrame() const;
</del><ins>+ bool isMainFrame() const;
</ins><span class="cx">
</span><span class="cx"> Page* page() const;
</span><span class="cx"> HTMLFrameOwnerElement* ownerElement() const;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformcocoaWebPlaybackSessionModelMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> }
</span><span class="cx"> WEBCORE_EXPORT virtual ~WebPlaybackSessionModelMediaElement();
</span><span class="cx"> WEBCORE_EXPORT void setMediaElement(HTMLMediaElement*);
</span><del>- WEBCORE_EXPORT HTMLMediaElement* mediaElement() const { return m_mediaElement.get(); }
</del><ins>+ HTMLMediaElement* mediaElement() const { return m_mediaElement.get(); }
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) final;
</span><span class="cx"> void updateForEventName(const WTF::AtomicString&);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformcocoaWebVideoFullscreenModelVideoElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> }
</span><span class="cx"> WEBCORE_EXPORT virtual ~WebVideoFullscreenModelVideoElement();
</span><span class="cx"> WEBCORE_EXPORT void setVideoElement(HTMLVideoElement*);
</span><del>- WEBCORE_EXPORT HTMLVideoElement* videoElement() const { return m_videoElement.get(); }
</del><ins>+ HTMLVideoElement* videoElement() const { return m_videoElement.get(); }
</ins><span class="cx"> WEBCORE_EXPORT void setVideoFullscreenLayer(PlatformLayer*, std::function<void()> completionHandler = [] { });
</span><span class="cx"> WEBCORE_EXPORT void waitForPreparedForInlineThen(std::function<void()> completionHandler = [] { });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsColorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/Color.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/Color.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/graphics/Color.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx"> RGBA32 makeUnPremultipliedRGBA(int r, int g, int b, int a);
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT RGBA32 colorWithOverrideAlpha(RGBA32 color, float overrideAlpha);
</span><del>-WEBCORE_EXPORT RGBA32 colorWithOverrideAlpha(RGBA32 color, Optional<float> overrideAlpha);
</del><ins>+RGBA32 colorWithOverrideAlpha(RGBA32 color, Optional<float> overrideAlpha);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT RGBA32 makeRGBA32FromFloats(float r, float g, float b, float a);
</span><span class="cx"> RGBA32 makeRGBAFromHSLA(double h, double s, double l, double a);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicstransformsTransformationMatrixh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -231,7 +231,7 @@
</span><span class="cx"> TransformationMatrix& scale3d(double sx, double sy, double sz);
</span><span class="cx">
</span><span class="cx"> // Angle is in degrees.
</span><del>- WEBCORE_EXPORT TransformationMatrix& rotate(double d) { return rotate3d(0, 0, d); }
</del><ins>+ TransformationMatrix& rotate(double d) { return rotate3d(0, 0, d); }
</ins><span class="cx"> TransformationMatrix& rotateFromVector(double x, double y);
</span><span class="cx"> WEBCORE_EXPORT TransformationMatrix& rotate3d(double rx, double ry, double rz);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacWebVideoFullscreenInterfaceMach"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> WEBCORE_EXPORT void exitFullscreenWithoutAnimationToMode(HTMLMediaElementEnums::VideoFullscreenMode);
</span><span class="cx"> WEBCORE_EXPORT void cleanupFullscreen();
</span><span class="cx"> WEBCORE_EXPORT void invalidate();
</span><del>- WEBCORE_EXPORT void requestHideAndExitFullscreen() { }
</del><ins>+ void requestHideAndExitFullscreen() { }
</ins><span class="cx"> WEBCORE_EXPORT void preparedToReturnToInline(bool visible, const IntRect& inlineRect, NSWindow *parentWindow);
</span><span class="cx"> WEBCORE_EXPORT void ensureControlsManager();
</span><span class="cx">
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx">
</span><span class="cx"> bool isPlayingVideoInEnhancedFullscreen() const;
</span><span class="cx">
</span><del>- WEBCORE_EXPORT bool mayAutomaticallyShowVideoPictureInPicture() const { return false; }
</del><ins>+ bool mayAutomaticallyShowVideoPictureInPicture() const { return false; }
</ins><span class="cx"> void applicationDidBecomeActive() { }
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT WebVideoFullscreenInterfaceMacObjC *videoFullscreenInterfaceObjC();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkParsedContentRangeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ParsedContentRange.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ParsedContentRange.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/network/ParsedContentRange.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -33,10 +33,10 @@
</span><span class="cx"> class ParsedContentRange {
</span><span class="cx"> public:
</span><span class="cx"> WEBCORE_EXPORT explicit ParsedContentRange(const String&);
</span><del>- WEBCORE_EXPORT ParsedContentRange() { }
</del><ins>+ ParsedContentRange() { }
</ins><span class="cx"> WEBCORE_EXPORT ParsedContentRange(int64_t firstBytePosition, int64_t lastBytePosition, int64_t instanceLength);
</span><span class="cx">
</span><del>- WEBCORE_EXPORT bool isValid() const { return m_isValid; }
</del><ins>+ bool isValid() const { return m_isValid; }
</ins><span class="cx"> int64_t firstBytePosition() const { return m_firstBytePosition; }
</span><span class="cx"> int64_t lastBytePosition() const { return m_lastBytePosition; }
</span><span class="cx"> int64_t instanceLength() const { return m_instanceLength; }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkResourceResponseBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ResourceResponseBase.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> WEBCORE_EXPORT String suggestedFilename() const;
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void includeCertificateInfo() const;
</span><del>- WEBCORE_EXPORT const Optional<CertificateInfo>& certificateInfo() const { return m_certificateInfo; };
</del><ins>+ const Optional<CertificateInfo>& certificateInfo() const { return m_certificateInfo; };
</ins><span class="cx">
</span><span class="cx"> // These functions return parsed values of the corresponding response headers.
</span><span class="cx"> // NaN means that the header was not present or had invalid value.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextTextStreamh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/TextStream.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/TextStream.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WebCore/platform/text/TextStream.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -77,8 +77,8 @@
</span><span class="cx"> WEBCORE_EXPORT void endGroup();
</span><span class="cx"> WEBCORE_EXPORT void nextLine(); // Output newline and indent.
</span><span class="cx">
</span><del>- WEBCORE_EXPORT void increaseIndent() { ++m_indent; }
- WEBCORE_EXPORT void decreaseIndent() { --m_indent; ASSERT(m_indent >= 0); }
</del><ins>+ void increaseIndent() { ++m_indent; }
+ void decreaseIndent() { --m_indent; ASSERT(m_indent >= 0); }
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void writeIndent();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Tools/ChangeLog 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-09-21 Keith Miller <keith_miller@apple.com>
+
+ Fix build for future versions of Clang.
+ https://bugs.webkit.org/show_bug.cgi?id=162346
+
+ Reviewed by Filip Pizlo.
+
+ * TestWebKitAPI/Counters.cpp:
+ * TestWebKitAPI/Counters.h:
+ (DeleterCounter::deleterCount):
+ (DeleterCounter::TestingScope::TestingScope):
+ (DeleterCounter::operator()):
+ * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WTF/HashMap.cpp:
+ (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2016-09-21 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Prepare API tests for enabling URLParser by default
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPICounterscpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Counters.cpp (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Counters.cpp 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Tools/TestWebKitAPI/Counters.cpp 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -33,4 +33,4 @@
</span><span class="cx"> unsigned ConstructorDestructorCounter::constructionCount = 0;
</span><span class="cx"> unsigned ConstructorDestructorCounter::destructionCount = 0;
</span><span class="cx">
</span><del>-template<> unsigned DeleterCounter<ConstructorDestructorCounter>::deleterCount = 0;
</del><ins>+template<> unsigned DeleterCounter<ConstructorDestructorCounter>::m_deleterCount = 0;
</ins></span></pre></div>
<a id="trunkToolsTestWebKitAPICountersh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Counters.h (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Counters.h 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Tools/TestWebKitAPI/Counters.h 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -65,22 +65,35 @@
</span><span class="cx"> ~ConstructorDestructorCounter() { destructionCount++; }
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+#if COMPILER(CLANG)
+#if __has_warning("-Wundefined-var-template")
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wundefined-var-template"
+#endif
+#endif
</ins><span class="cx"> template<typename T>
</span><span class="cx"> struct DeleterCounter {
</span><del>- static unsigned deleterCount;
</del><ins>+ static unsigned m_deleterCount;
</ins><span class="cx">
</span><ins>+ static unsigned deleterCount() { return m_deleterCount; }
+
</ins><span class="cx"> struct TestingScope {
</span><span class="cx"> TestingScope()
</span><span class="cx"> {
</span><del>- deleterCount = 0;
</del><ins>+ m_deleterCount = 0;
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> void operator()(T* p) const
</span><span class="cx"> {
</span><del>- deleterCount++;
</del><ins>+ m_deleterCount++;
</ins><span class="cx"> delete p;
</span><span class="cx"> }
</span><span class="cx"> };
</span><ins>+#if COMPILER(CLANG)
+#if __has_warning("-Wundefined-var-template")
+#pragma clang diagnostic pop
+#endif
+#endif
</ins><span class="cx">
</span><span class="cx"> #endif // Counters_h
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFHashCountedSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -284,7 +284,7 @@
</span><span class="cx"> EXPECT_EQ(1u, ConstructorDestructorCounter::constructionCount);
</span><span class="cx"> EXPECT_EQ(0u, ConstructorDestructorCounter::destructionCount);
</span><span class="cx">
</span><del>- EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
</del><ins>+ EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
</ins><span class="cx">
</span><span class="cx"> hashCountedSet.clear();
</span><span class="cx">
</span><span class="lines">@@ -291,7 +291,7 @@
</span><span class="cx"> EXPECT_EQ(1u, ConstructorDestructorCounter::constructionCount);
</span><span class="cx"> EXPECT_EQ(1u, ConstructorDestructorCounter::destructionCount);
</span><span class="cx">
</span><del>- EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
</del><ins>+ EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TEST(WTF_HashCountedSet, UniquePtrKey_FindUsingRawPointer)
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFHashMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp (206221 => 206222)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp 2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp 2016-09-21 18:24:43 UTC (rev 206222)
</span><span class="lines">@@ -206,7 +206,7 @@
</span><span class="cx"> EXPECT_EQ(1u, ConstructorDestructorCounter::constructionCount);
</span><span class="cx"> EXPECT_EQ(0u, ConstructorDestructorCounter::destructionCount);
</span><span class="cx">
</span><del>- EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
</del><ins>+ EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
</ins><span class="cx">
</span><span class="cx"> map.clear();
</span><span class="cx">
</span><span class="lines">@@ -213,7 +213,7 @@
</span><span class="cx"> EXPECT_EQ(1u, ConstructorDestructorCounter::constructionCount);
</span><span class="cx"> EXPECT_EQ(1u, ConstructorDestructorCounter::destructionCount);
</span><span class="cx">
</span><del>- EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
</del><ins>+ EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TEST(WTF_HashMap, UniquePtrKey_FindUsingRawPointer)
</span></span></pre>
</div>
</div>
</body>
</html>