<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206196] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206196">206196</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2016-09-20 20:10:57 -0700 (Tue, 20 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Require WTFMove for String::adopt
https://bugs.webkit.org/show_bug.cgi?id=162313
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::build):
Source/WebCore:
No change in behavior. This just makes it more clear what is going on when a String adopts a Vector.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readString):
* css/parser/CSSParser.cpp:
(WebCore::quoteCSSStringInternal):
* dom/Document.cpp:
(WebCore::canonicalizedTitle):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeSpaces):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace):
* platform/Length.cpp:
(WebCore::newCoordsArray):
* platform/URLParser.cpp:
(WebCore::URLParser::parse):
(WebCore::URLParser::serialize):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ReplicaState::cloneID):
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode):
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode):
Source/WTF:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::adopt):
* wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
* wtf/text/WTFString.h:
(WTF::String::adopt):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSStringBuilderh">trunk/Source/JavaScriptCore/runtime/JSStringBuilder.h</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextStringImplcpp">trunk/Source/WTF/wtf/text/StringImpl.cpp</a></li>
<li><a href="#trunkSourceWTFwtftextStringImplh">trunk/Source/WTF/wtf/text/StringImpl.h</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringh">trunk/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSParsercpp">trunk/Source/WebCore/css/parser/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dcpp">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLTreeBuildercpp">trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformLengthcpp">trunk/Source/WebCore/platform/Length.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformURLParsercpp">trunk/Source/WebCore/platform/URLParser.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp">trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextLocaleICUcpp">trunk/Source/WebCore/platform/text/LocaleICU.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextTextCodecUTF16cpp">trunk/Source/WebCore/platform/text/TextCodecUTF16.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextTextCodecUTF8cpp">trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextmacTextCodecMaccpp">trunk/Source/WebCore/platform/text/mac/TextCodecMac.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformwinFileSystemWincpp">trunk/Source/WebCore/platform/win/FileSystemWin.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-09-20 Alex Christensen <achristensen@webkit.org>
+
+ Require WTFMove for String::adopt
+ https://bugs.webkit.org/show_bug.cgi?id=162313
+
+ Reviewed by Yusuke Suzuki.
+
+ * runtime/JSStringBuilder.h:
+ (JSC::JSStringBuilder::build):
+
</ins><span class="cx"> 2016-09-20 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r205692): Minified builds have broken inspector
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSStringBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSStringBuilder.h (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSStringBuilder.h 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/JavaScriptCore/runtime/JSStringBuilder.h 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -79,12 +79,12 @@
</span><span class="cx"> buffer8.shrinkToFit();
</span><span class="cx"> if (!buffer8.data())
</span><span class="cx"> return throwOutOfMemoryError(exec, scope);
</span><del>- return jsString(exec, String::adopt(buffer8));
</del><ins>+ return jsString(exec, String::adopt(WTFMove(buffer8)));
</ins><span class="cx"> }
</span><span class="cx"> buffer16.shrinkToFit();
</span><span class="cx"> if (!buffer16.data())
</span><span class="cx"> return throwOutOfMemoryError(exec, scope);
</span><del>- return jsString(exec, String::adopt(buffer16));
</del><ins>+ return jsString(exec, String::adopt(WTFMove(buffer16)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WTF/ChangeLog 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-09-20 Alex Christensen <achristensen@webkit.org>
+
+ Require WTFMove for String::adopt
+ https://bugs.webkit.org/show_bug.cgi?id=162313
+
+ Reviewed by Yusuke Suzuki.
+
+ * wtf/text/StringImpl.cpp:
+ (WTF::StringImpl::removeCharacters):
+ (WTF::StringImpl::simplifyMatchedCharactersToSpace):
+ (WTF::StringImpl::adopt):
+ * wtf/text/StringImpl.h:
+ (WTF::StringImpl::adopt):
+ * wtf/text/WTFString.h:
+ (WTF::String::adopt):
+
</ins><span class="cx"> 2016-09-20 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Make MarkedBlock state tracking support overlapped allocation and marking state
</span></span></pre></div>
<a id="trunkSourceWTFwtftextStringImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/StringImpl.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/StringImpl.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WTF/wtf/text/StringImpl.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -831,7 +831,7 @@
</span><span class="cx">
</span><span class="cx"> data.shrink(outc);
</span><span class="cx">
</span><del>- return adopt(data);
</del><ins>+ return adopt(WTFMove(data));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<StringImpl> StringImpl::removeCharacters(CharacterMatchFunctionPtr findMatch)
</span><span class="lines">@@ -875,7 +875,7 @@
</span><span class="cx">
</span><span class="cx"> data.shrink(outc);
</span><span class="cx">
</span><del>- return adopt(data);
</del><ins>+ return adopt(WTFMove(data));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<StringImpl> StringImpl::simplifyWhiteSpace()
</span><span class="lines">@@ -2002,7 +2002,7 @@
</span><span class="cx"> return U_LEFT_TO_RIGHT;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<StringImpl> StringImpl::adopt(StringBuffer<LChar>& buffer)
</del><ins>+Ref<StringImpl> StringImpl::adopt(StringBuffer<LChar>&& buffer)
</ins><span class="cx"> {
</span><span class="cx"> unsigned length = buffer.length();
</span><span class="cx"> if (!length)
</span><span class="lines">@@ -2010,7 +2010,7 @@
</span><span class="cx"> return adoptRef(*new StringImpl(buffer.release(), length));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ref<StringImpl> StringImpl::adopt(StringBuffer<UChar>& buffer)
</del><ins>+Ref<StringImpl> StringImpl::adopt(StringBuffer<UChar>&& buffer)
</ins><span class="cx"> {
</span><span class="cx"> unsigned length = buffer.length();
</span><span class="cx"> if (!length)
</span></span></pre></div>
<a id="trunkSourceWTFwtftextStringImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/StringImpl.h (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/StringImpl.h 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -426,7 +426,7 @@
</span><span class="cx"> static unsigned dataOffset() { return OBJECT_OFFSETOF(StringImpl, m_data8); }
</span><span class="cx">
</span><span class="cx"> template<typename CharType, size_t inlineCapacity, typename OverflowHandler>
</span><del>- static Ref<StringImpl> adopt(Vector<CharType, inlineCapacity, OverflowHandler>& vector)
</del><ins>+ static Ref<StringImpl> adopt(Vector<CharType, inlineCapacity, OverflowHandler>&& vector)
</ins><span class="cx"> {
</span><span class="cx"> if (size_t size = vector.size()) {
</span><span class="cx"> ASSERT(vector.data());
</span><span class="lines">@@ -437,8 +437,8 @@
</span><span class="cx"> return *empty();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- WTF_EXPORT_STRING_API static Ref<StringImpl> adopt(StringBuffer<UChar>&);
- WTF_EXPORT_STRING_API static Ref<StringImpl> adopt(StringBuffer<LChar>&);
</del><ins>+ WTF_EXPORT_STRING_API static Ref<StringImpl> adopt(StringBuffer<UChar>&&);
+ WTF_EXPORT_STRING_API static Ref<StringImpl> adopt(StringBuffer<LChar>&&);
</ins><span class="cx">
</span><span class="cx"> unsigned length() const { return m_length; }
</span><span class="cx"> static ptrdiff_t lengthMemoryOffset() { return OBJECT_OFFSETOF(StringImpl, m_length); }
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.h (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.h 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -138,10 +138,10 @@
</span><span class="cx">
</span><span class="cx"> void swap(String& o) { m_impl.swap(o.m_impl); }
</span><span class="cx">
</span><del>- static String adopt(StringBuffer<LChar>& buffer) { return StringImpl::adopt(buffer); }
- static String adopt(StringBuffer<UChar>& buffer) { return StringImpl::adopt(buffer); }
</del><ins>+ static String adopt(StringBuffer<LChar>&& buffer) { return StringImpl::adopt(WTFMove(buffer)); }
+ static String adopt(StringBuffer<UChar>&& buffer) { return StringImpl::adopt(WTFMove(buffer)); }
</ins><span class="cx"> template<typename CharacterType, size_t inlineCapacity, typename OverflowHandler>
</span><del>- static String adopt(Vector<CharacterType, inlineCapacity, OverflowHandler>& vector) { return StringImpl::adopt(vector); }
</del><ins>+ static String adopt(Vector<CharacterType, inlineCapacity, OverflowHandler>&& vector) { return StringImpl::adopt(WTFMove(vector)); }
</ins><span class="cx">
</span><span class="cx"> bool isNull() const { return !m_impl; }
</span><span class="cx"> bool isEmpty() const { return !m_impl || !m_impl->length(); }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/ChangeLog 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2016-09-20 Alex Christensen <achristensen@webkit.org>
+
+ Require WTFMove for String::adopt
+ https://bugs.webkit.org/show_bug.cgi?id=162313
+
+ Reviewed by Yusuke Suzuki.
+
+ No change in behavior. This just makes it more clear what is going on when a String adopts a Vector.
+
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::CloneDeserializer::readString):
+ * css/parser/CSSParser.cpp:
+ (WebCore::quoteCSSStringInternal):
+ * dom/Document.cpp:
+ (WebCore::canonicalizedTitle):
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::normalizeSpaces):
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace):
+ * platform/Length.cpp:
+ (WebCore::newCoordsArray):
+ * platform/URLParser.cpp:
+ (WebCore::URLParser::parse):
+ (WebCore::URLParser::serialize):
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::ReplicaState::cloneID):
+ * platform/text/TextCodecUTF16.cpp:
+ (WebCore::TextCodecUTF16::decode):
+ * platform/text/TextCodecUTF8.cpp:
+ (WebCore::TextCodecUTF8::decode):
+ * platform/text/mac/TextCodecMac.cpp:
+ (WebCore::TextCodecMac::decode):
+
</ins><span class="cx"> 2016-09-20 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> Adopt MRMediaRemoteSetParentApplication.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -1707,7 +1707,7 @@
</span><span class="cx"> readLittleEndian(ptr, end, ch);
</span><span class="cx"> buffer.append(ch);
</span><span class="cx"> }
</span><del>- str = String::adopt(buffer);
</del><ins>+ str = String::adopt(WTFMove(buffer));
</ins><span class="cx"> #endif
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -13644,7 +13644,7 @@
</span><span class="cx"> buffer[index++] = '\'';
</span><span class="cx">
</span><span class="cx"> ASSERT(quotedStringSize == index);
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // We use single quotes for now because markup.cpp uses double quotes.
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -1574,7 +1574,7 @@
</span><span class="cx"> // Replace the backslashes with currency symbols if the encoding requires it.
</span><span class="cx"> document->displayBufferModifiedByEncoding(buffer.characters(), buffer.length());
</span><span class="cx">
</span><del>- return StringWithDirection(String::adopt(buffer), titleWithDirection.direction());
</del><ins>+ return StringWithDirection(String::adopt(WTFMove(buffer)), titleWithDirection.direction());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Document::updateTitle(const StringWithDirection& title)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Dcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -2357,7 +2357,7 @@
</span><span class="cx"> if (isSpaceThatNeedsReplacing(charVector[i]))
</span><span class="cx"> charVector[i] = ' ';
</span><span class="cx"> }
</span><del>- text = String::adopt(charVector);
</del><ins>+ text = String::adopt(WTFMove(charVector));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<TextMetrics> CanvasRenderingContext2D::measureText(const String& text)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLTreeBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -219,7 +219,7 @@
</span><span class="cx"> if (whitespace.isEmpty())
</span><span class="cx"> return String();
</span><span class="cx">
</span><del>- return String::adopt(whitespace);
</del><ins>+ return String::adopt(WTFMove(whitespace));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLengthcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Length.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Length.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/Length.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> else
</span><span class="cx"> spacified[i] = cc;
</span><span class="cx"> }
</span><del>- RefPtr<StringImpl> str = StringImpl::adopt(spacified);
</del><ins>+ RefPtr<StringImpl> str = StringImpl::adopt(WTFMove(spacified));
</ins><span class="cx">
</span><span class="cx"> str = str->simplifyWhiteSpace();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformURLParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/URLParser.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/URLParser.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/URLParser.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -1599,10 +1599,10 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (m_unicodeFragmentBuffer.isEmpty()) {
- // FIXME: String::adopt should require a WTFMove.
- m_url.m_string = String::adopt(m_asciiBuffer);
- } else {
</del><ins>+ if (m_unicodeFragmentBuffer.isEmpty())
+ m_url.m_string = String::adopt(WTFMove(m_asciiBuffer));
+ else {
+ // FIXME: This should use a Vector<UChar> and adopt it.
</ins><span class="cx"> StringBuilder builder;
</span><span class="cx"> builder.reserveCapacity(m_asciiBuffer.size() + m_unicodeFragmentBuffer.size());
</span><span class="cx"> builder.append(m_asciiBuffer.data(), m_asciiBuffer.size());
</span><span class="lines">@@ -2212,7 +2212,7 @@
</span><span class="cx"> output.append('=');
</span><span class="cx"> serializeURLEncodedForm(tuple.second, output);
</span><span class="cx"> }
</span><del>- return String::adopt(output);
</del><ins>+ return String::adopt(WTFMove(output));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool URLParser::allValuesEqual(const URL& a, const URL& b)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscaGraphicsLayerCAcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -2570,7 +2570,7 @@
</span><span class="cx"> currChar = (currChar << 1) | m_replicaBranches[i];
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return String::adopt(result);
</del><ins>+ return String::adopt(WTFMove(result));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<PlatformCALayer> GraphicsLayerCA::replicatedLayerRoot(ReplicaState& replicaState)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextLocaleICUcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/LocaleICU.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/LocaleICU.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/text/LocaleICU.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> unum_getSymbol(m_numberFormat, symbol, buffer.data(), bufferLength, &status);
</span><span class="cx"> if (U_FAILURE(status))
</span><span class="cx"> return String();
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String LocaleICU::decimalTextAttribute(UNumberFormatTextAttribute tag)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> ASSERT(U_SUCCESS(status));
</span><span class="cx"> if (U_FAILURE(status))
</span><span class="cx"> return String();
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx"> udat_toPattern(dateFormat, TRUE, buffer.data(), length, &status);
</span><span class="cx"> if (U_FAILURE(status))
</span><span class="cx"> return emptyString();
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<Vector<String>> LocaleICU::createLabelVector(const UDateFormat* dateFormat, UDateFormatSymbolType type, int32_t startIndex, int32_t size)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> udat_getSymbols(dateFormat, type, startIndex + i, buffer.data(), length, &status);
</span><span class="cx"> if (U_FAILURE(status))
</span><span class="cx"> return std::make_unique<Vector<String>>();
</span><del>- labels->append(String::adopt(buffer));
</del><ins>+ labels->append(String::adopt(WTFMove(buffer)));
</ins><span class="cx"> }
</span><span class="cx"> return WTFMove(labels);
</span><span class="cx"> }
</span><span class="lines">@@ -270,7 +270,7 @@
</span><span class="cx"> status = U_ZERO_ERROR;
</span><span class="cx"> udatpg_getBestPattern(patternGenerator, skeleton, skeletonLength, buffer.data(), length, &status);
</span><span class="cx"> if (U_SUCCESS(status))
</span><del>- format = String::adopt(buffer);
</del><ins>+ format = String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx"> udatpg_close(patternGenerator);
</span><span class="cx"> return format;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextTextCodecUTF16cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/TextCodecUTF16.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/TextCodecUTF16.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/text/TextCodecUTF16.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx">
</span><span class="cx"> buffer.shrink(q - buffer.characters());
</span><span class="cx">
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CString TextCodecUTF16::encode(const UChar* characters, size_t length, UnencodableHandling)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextTextCodecUTF8cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -343,7 +343,7 @@
</span><span class="cx">
</span><span class="cx"> buffer.shrink(destination - buffer.characters());
</span><span class="cx">
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx">
</span><span class="cx"> upConvertTo16Bit:
</span><span class="cx"> StringBuffer<UChar> buffer16(m_partialSequenceSize + length);
</span><span class="lines">@@ -419,7 +419,7 @@
</span><span class="cx">
</span><span class="cx"> buffer16.shrink(destination16 - buffer16.characters());
</span><span class="cx">
</span><del>- return String::adopt(buffer16);
</del><ins>+ return String::adopt(WTFMove(buffer16));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CString TextCodecUTF8::encode(const UChar* characters, size_t length, UnencodableHandling)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextmacTextCodecMaccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/mac/TextCodecMac.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/mac/TextCodecMac.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/text/mac/TextCodecMac.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> result.append(buffer, bytesWritten / sizeof(UChar));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- String resultString = String::adopt(result);
</del><ins>+ String resultString = String::adopt(WTFMove(result));
</ins><span class="cx">
</span><span class="cx"> // <rdar://problem/3225472>
</span><span class="cx"> // Simplified Chinese pages use the code A3A0 to mean "full-width space".
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformwinFileSystemWincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/win/FileSystemWin.cpp (206195 => 206196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/win/FileSystemWin.cpp 2016-09-21 02:46:17 UTC (rev 206195)
+++ trunk/Source/WebCore/platform/win/FileSystemWin.cpp 2016-09-21 03:10:57 UTC (rev 206196)
</span><span class="lines">@@ -190,7 +190,7 @@
</span><span class="cx">
</span><span class="cx"> buffer.shrink(wcslen(buffer.data()));
</span><span class="cx">
</span><del>- return String::adopt(buffer);
</del><ins>+ return String::adopt(WTFMove(buffer));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if !USE(CF)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx"> if (FAILED(SHGetFolderPathW(0, pathIdentifier | CSIDL_FLAG_CREATE, 0, 0, buffer.data())))
</span><span class="cx"> return String();
</span><span class="cx"> buffer.resize(wcslen(buffer.data()));
</span><del>- String directory = String::adopt(buffer);
</del><ins>+ String directory = String::adopt(WTFMove(buffer));
</ins><span class="cx">
</span><span class="cx"> DEPRECATED_DEFINE_STATIC_LOCAL(String, companyNameDirectory, (ASCIILiteral("Apple Computer\\")));
</span><span class="cx"> directory = pathByAppendingComponent(directory, companyNameDirectory + bundleName());
</span></span></pre>
</div>
</div>
</body>
</html>