<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206140] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206140">206140</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-09-19 21:22:31 -0700 (Mon, 19 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
https://bugs.webkit.org/show_bug.cgi?id=162244
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset:
- https://html.spec.whatwg.org/#the-source-element
We already support the corresponding content attributes internally. However, we
are missing the corresponding IDL attributes that are supposed to reflect them.
Chrome and Firefox support them. We already had those IDL attributes on
HTMLImageElement.
No new tests, rebaselined existing test.
* html/HTMLSourceElement.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSourceElementidl">trunk/Source/WebCore/html/HTMLSourceElement.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206139 => 206140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-20 04:22:31 UTC (rev 206140)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-09-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
+ https://bugs.webkit.org/show_bug.cgi?id=162244
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-09-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Align HTMLAppletElement with the specification
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=162240
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (206139 => 206140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-09-20 04:22:31 UTC (rev 206140)
</span><span class="lines">@@ -1405,7 +1405,7 @@
</span><span class="cx"> PASS HTMLHRElement interface: existence and properties of interface prototype object
</span><span class="cx"> PASS HTMLHRElement interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS HTMLHRElement interface: attribute align
</span><del>-FAIL HTMLHRElement interface: attribute color assert_true: The prototype object must have a property "color" expected true got false
</del><ins>+PASS HTMLHRElement interface: attribute color
</ins><span class="cx"> PASS HTMLHRElement interface: attribute noShade
</span><span class="cx"> PASS HTMLHRElement interface: attribute size
</span><span class="cx"> PASS HTMLHRElement interface: attribute width
</span><span class="lines">@@ -1412,7 +1412,7 @@
</span><span class="cx"> PASS HTMLHRElement must be primary interface of document.createElement("hr")
</span><span class="cx"> PASS Stringification of document.createElement("hr")
</span><span class="cx"> PASS HTMLHRElement interface: document.createElement("hr") must inherit property "align" with the proper type (0)
</span><del>-FAIL HTMLHRElement interface: document.createElement("hr") must inherit property "color" with the proper type (1) assert_inherits: property "color" not found in prototype chain
</del><ins>+PASS HTMLHRElement interface: document.createElement("hr") must inherit property "color" with the proper type (1)
</ins><span class="cx"> PASS HTMLHRElement interface: document.createElement("hr") must inherit property "noShade" with the proper type (2)
</span><span class="cx"> PASS HTMLHRElement interface: document.createElement("hr") must inherit property "size" with the proper type (3)
</span><span class="cx"> PASS HTMLHRElement interface: document.createElement("hr") must inherit property "width" with the proper type (4)
</span><span class="lines">@@ -1950,15 +1950,15 @@
</span><span class="cx"> PASS HTMLSourceElement interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS HTMLSourceElement interface: attribute src
</span><span class="cx"> PASS HTMLSourceElement interface: attribute type
</span><del>-FAIL HTMLSourceElement interface: attribute srcset assert_true: The prototype object must have a property "srcset" expected true got false
-FAIL HTMLSourceElement interface: attribute sizes assert_true: The prototype object must have a property "sizes" expected true got false
</del><ins>+PASS HTMLSourceElement interface: attribute srcset
+PASS HTMLSourceElement interface: attribute sizes
</ins><span class="cx"> PASS HTMLSourceElement interface: attribute media
</span><span class="cx"> PASS HTMLSourceElement must be primary interface of document.createElement("source")
</span><span class="cx"> PASS Stringification of document.createElement("source")
</span><span class="cx"> PASS HTMLSourceElement interface: document.createElement("source") must inherit property "src" with the proper type (0)
</span><span class="cx"> PASS HTMLSourceElement interface: document.createElement("source") must inherit property "type" with the proper type (1)
</span><del>-FAIL HTMLSourceElement interface: document.createElement("source") must inherit property "srcset" with the proper type (2) assert_inherits: property "srcset" not found in prototype chain
-FAIL HTMLSourceElement interface: document.createElement("source") must inherit property "sizes" with the proper type (3) assert_inherits: property "sizes" not found in prototype chain
</del><ins>+PASS HTMLSourceElement interface: document.createElement("source") must inherit property "srcset" with the proper type (2)
+PASS HTMLSourceElement interface: document.createElement("source") must inherit property "sizes" with the proper type (3)
</ins><span class="cx"> PASS HTMLSourceElement interface: document.createElement("source") must inherit property "media" with the proper type (4)
</span><span class="cx"> PASS HTMLTrackElement interface: existence and properties of interface object
</span><span class="cx"> PASS HTMLTrackElement interface object length
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206139 => 206140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/Source/WebCore/ChangeLog 2016-09-20 04:22:31 UTC (rev 206140)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-09-19 Chris Dumez <cdumez@apple.com>
+
+ Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
+ https://bugs.webkit.org/show_bug.cgi?id=162244
+
+ Reviewed by Alex Christensen.
+
+ Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset:
+ - https://html.spec.whatwg.org/#the-source-element
+
+ We already support the corresponding content attributes internally. However, we
+ are missing the corresponding IDL attributes that are supposed to reflect them.
+
+ Chrome and Firefox support them. We already had those IDL attributes on
+ HTMLImageElement.
+
+ No new tests, rebaselined existing test.
+
+ * html/HTMLSourceElement.idl:
+
</ins><span class="cx"> 2016-09-19 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Suppress JavaScript prompts early on in certain cases
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSourceElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSourceElement.idl (206139 => 206140)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSourceElement.idl 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/Source/WebCore/html/HTMLSourceElement.idl 2016-09-20 04:22:31 UTC (rev 206140)
</span><span class="lines">@@ -24,7 +24,9 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> interface HTMLSourceElement : HTMLElement {
</span><del>-[Reflect, URL] attribute USVString src;
-attribute DOMString type;
-attribute DOMString media;
</del><ins>+ [Reflect, URL] attribute USVString src;
+ attribute DOMString type;
+ [Reflect] attribute USVString srcset;
+ [Reflect] attribute DOMString sizes;
+ attribute DOMString media;
</ins><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>