<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206075] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206075">206075</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2016-09-17 22:38:24 -0700 (Sat, 17 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Inline functions in URLParser
https://bugs.webkit.org/show_bug.cgi?id=162106
Reviewed by Antti Koivisto.
No change in behavior. Just make URLParser faster.
* platform/URLParser.cpp:
(WebCore::isC0Control):
(WebCore::isC0ControlOrSpace):
(WebCore::isTabOrNewline):
(WebCore::isInSimpleEncodeSet):
(WebCore::isInDefaultEncodeSet):
(WebCore::isInUserInfoEncodeSet):
(WebCore::isInvalidDomainCharacter):
(WebCore::isPercentOrNonASCII):
(WebCore::isSlashQuestionOrHash):
(WebCore::isWindowsDriveLetter):
(WebCore::shouldCopyFileURL):
(WebCore::percentEncode):
(WebCore::utf8PercentEncode):
(WebCore::utf8PercentEncodeQuery):
(WebCore::encodeQuery):
(WebCore::isDefaultPort):
(WebCore::isSpecialScheme):
(WebCore::copyASCIIStringUntil):
(WebCore::isPercentEncodedDot):
(WebCore::isSingleDotPathSegment):
(WebCore::isDoubleDotPathSegment):
(WebCore::consumeSingleDotPathSegment):
(WebCore::consumeDoubleDotPathSegment):
(WebCore::serializeIPv4):
(WebCore::zeroSequenceLength):
(WebCore::findLongestZeroSequence):
(WebCore::serializeIPv6Piece):
(WebCore::serializeIPv6):
(WebCore::parseIPv4Number):
(WebCore::pow256):
(WebCore::parseIPv4Host):
(WebCore::parseIPv6Host):
(WebCore::percentDecode):
(WebCore::containsOnlyASCII):
(WebCore::domainToASCII):
(WebCore::hasInvalidDomainCharacter):
(WebCore::formURLDecode):
(WebCore::serializeURLEncodedForm):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformURLParsercpp">trunk/Source/WebCore/platform/URLParser.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (206074 => 206075)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-17 11:14:38 UTC (rev 206074)
+++ trunk/Source/WebCore/ChangeLog 2016-09-18 05:38:24 UTC (rev 206075)
</span><span class="lines">@@ -1,3 +1,52 @@
</span><ins>+2016-09-17 Alex Christensen <achristensen@webkit.org>
+
+ Inline functions in URLParser
+ https://bugs.webkit.org/show_bug.cgi?id=162106
+
+ Reviewed by Antti Koivisto.
+
+ No change in behavior. Just make URLParser faster.
+
+ * platform/URLParser.cpp:
+ (WebCore::isC0Control):
+ (WebCore::isC0ControlOrSpace):
+ (WebCore::isTabOrNewline):
+ (WebCore::isInSimpleEncodeSet):
+ (WebCore::isInDefaultEncodeSet):
+ (WebCore::isInUserInfoEncodeSet):
+ (WebCore::isInvalidDomainCharacter):
+ (WebCore::isPercentOrNonASCII):
+ (WebCore::isSlashQuestionOrHash):
+ (WebCore::isWindowsDriveLetter):
+ (WebCore::shouldCopyFileURL):
+ (WebCore::percentEncode):
+ (WebCore::utf8PercentEncode):
+ (WebCore::utf8PercentEncodeQuery):
+ (WebCore::encodeQuery):
+ (WebCore::isDefaultPort):
+ (WebCore::isSpecialScheme):
+ (WebCore::copyASCIIStringUntil):
+ (WebCore::isPercentEncodedDot):
+ (WebCore::isSingleDotPathSegment):
+ (WebCore::isDoubleDotPathSegment):
+ (WebCore::consumeSingleDotPathSegment):
+ (WebCore::consumeDoubleDotPathSegment):
+ (WebCore::serializeIPv4):
+ (WebCore::zeroSequenceLength):
+ (WebCore::findLongestZeroSequence):
+ (WebCore::serializeIPv6Piece):
+ (WebCore::serializeIPv6):
+ (WebCore::parseIPv4Number):
+ (WebCore::pow256):
+ (WebCore::parseIPv4Host):
+ (WebCore::parseIPv6Host):
+ (WebCore::percentDecode):
+ (WebCore::containsOnlyASCII):
+ (WebCore::domainToASCII):
+ (WebCore::hasInvalidDomainCharacter):
+ (WebCore::formURLDecode):
+ (WebCore::serializeURLEncodedForm):
+
</ins><span class="cx"> 2016-09-17 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> MainThreadBridge needs an isolatedCopy() of SecurityOrigin
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformURLParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/URLParser.cpp (206074 => 206075)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/URLParser.cpp 2016-09-17 11:14:38 UTC (rev 206074)
+++ trunk/Source/WebCore/platform/URLParser.cpp 2016-09-18 05:38:24 UTC (rev 206075)
</span><span class="lines">@@ -383,19 +383,19 @@
</span><span class="cx"> QueryPercent, // 0xFF
</span><span class="cx"> };
</span><span class="cx">
</span><del>-template<typename CharacterType> static bool isC0Control(CharacterType character) { return character <= 0x1F; }
-template<typename CharacterType> static bool isC0ControlOrSpace(CharacterType character) { return character <= 0x20; }
-template<typename CharacterType> static bool isTabOrNewline(CharacterType character) { return character <= 0xD && character >= 0x9 && character != 0xB && character != 0xC; }
-template<typename CharacterType> static bool isInSimpleEncodeSet(CharacterType character) { return character > 0x7E || isC0Control(character); }
-template<typename CharacterType> static bool isInDefaultEncodeSet(CharacterType character) { return character > 0x7E || characterClassTable[character] & Default; }
-template<typename CharacterType> static bool isInUserInfoEncodeSet(CharacterType character) { return character > 0x7E || characterClassTable[character] & UserInfo; }
-template<typename CharacterType> static bool isInvalidDomainCharacter(CharacterType character) { return character <= ']' && characterClassTable[character] & InvalidDomain; }
-template<typename CharacterType> static bool isPercentOrNonASCII(CharacterType character) { return !isASCII(character) || character == '%'; }
-template<typename CharacterType> static bool isSlashQuestionOrHash(CharacterType character) { return character <= '\\' && characterClassTable[character] & SlashQuestionOrHash; }
</del><ins>+template<typename CharacterType> inline static bool isC0Control(CharacterType character) { return character <= 0x1F; }
+template<typename CharacterType> inline static bool isC0ControlOrSpace(CharacterType character) { return character <= 0x20; }
+template<typename CharacterType> inline static bool isTabOrNewline(CharacterType character) { return character <= 0xD && character >= 0x9 && character != 0xB && character != 0xC; }
+template<typename CharacterType> inline static bool isInSimpleEncodeSet(CharacterType character) { return character > 0x7E || isC0Control(character); }
+template<typename CharacterType> inline static bool isInDefaultEncodeSet(CharacterType character) { return character > 0x7E || characterClassTable[character] & Default; }
+template<typename CharacterType> inline static bool isInUserInfoEncodeSet(CharacterType character) { return character > 0x7E || characterClassTable[character] & UserInfo; }
+template<typename CharacterType> inline static bool isInvalidDomainCharacter(CharacterType character) { return character <= ']' && characterClassTable[character] & InvalidDomain; }
+template<typename CharacterType> inline static bool isPercentOrNonASCII(CharacterType character) { return !isASCII(character) || character == '%'; }
+template<typename CharacterType> inline static bool isSlashQuestionOrHash(CharacterType character) { return character <= '\\' && characterClassTable[character] & SlashQuestionOrHash; }
</ins><span class="cx"> static bool shouldPercentEncodeQueryByte(uint8_t byte) { return characterClassTable[byte] & QueryPercent; }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static bool isWindowsDriveLetter(CodePointIterator<CharacterType> iterator)
</del><ins>+inline static bool isWindowsDriveLetter(CodePointIterator<CharacterType> iterator)
</ins><span class="cx"> {
</span><span class="cx"> if (iterator.atEnd() || !isASCIIAlpha(*iterator))
</span><span class="cx"> return false;
</span><span class="lines">@@ -405,7 +405,7 @@
</span><span class="cx"> return *iterator == ':' || *iterator == '|';
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool isWindowsDriveLetter(const Vector<LChar>& buffer, size_t index)
</del><ins>+inline static bool isWindowsDriveLetter(const Vector<LChar>& buffer, size_t index)
</ins><span class="cx"> {
</span><span class="cx"> if (buffer.size() < index + 2)
</span><span class="cx"> return false;
</span><span class="lines">@@ -413,7 +413,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static bool shouldCopyFileURL(CodePointIterator<CharacterType> iterator)
</del><ins>+inline static bool shouldCopyFileURL(CodePointIterator<CharacterType> iterator)
</ins><span class="cx"> {
</span><span class="cx"> if (isWindowsDriveLetter(iterator))
</span><span class="cx"> return true;
</span><span class="lines">@@ -428,7 +428,7 @@
</span><span class="cx"> return !isSlashQuestionOrHash(*iterator);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void percentEncode(uint8_t byte, Vector<LChar>& buffer)
</del><ins>+inline static void percentEncode(uint8_t byte, Vector<LChar>& buffer)
</ins><span class="cx"> {
</span><span class="cx"> buffer.append('%');
</span><span class="cx"> buffer.append(upperNibbleToASCIIHexDigit(byte));
</span><span class="lines">@@ -435,7 +435,7 @@
</span><span class="cx"> buffer.append(lowerNibbleToASCIIHexDigit(byte));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void utf8PercentEncode(UChar32 codePoint, Vector<LChar>& destination, bool(*isInCodeSet)(UChar32))
</del><ins>+inline static void utf8PercentEncode(UChar32 codePoint, Vector<LChar>& destination, bool(*isInCodeSet)(UChar32))
</ins><span class="cx"> {
</span><span class="cx"> if (isInCodeSet(codePoint)) {
</span><span class="cx"> uint8_t buffer[U8_MAX_LENGTH];
</span><span class="lines">@@ -451,7 +451,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void utf8PercentEncodeQuery(UChar32 codePoint, Vector<LChar>& destination)
</del><ins>+inline static void utf8PercentEncodeQuery(UChar32 codePoint, Vector<LChar>& destination)
</ins><span class="cx"> {
</span><span class="cx"> uint8_t buffer[U8_MAX_LENGTH];
</span><span class="cx"> int32_t offset = 0;
</span><span class="lines">@@ -468,7 +468,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void encodeQuery(const StringBuilder& source, Vector<LChar>& destination, const TextEncoding& encoding)
</del><ins>+inline static void encodeQuery(const StringBuilder& source, Vector<LChar>& destination, const TextEncoding& encoding)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: It is unclear in the spec what to do when encoding fails. The behavior should be specified and tested.
</span><span class="cx"> CString encoded = encoding.encode(source.toStringPreserveCapacity(), URLEncodedEntitiesForUnencodables);
</span><span class="lines">@@ -483,7 +483,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool isDefaultPort(StringView scheme, uint16_t port)
</del><ins>+inline static bool isDefaultPort(StringView scheme, uint16_t port)
</ins><span class="cx"> {
</span><span class="cx"> static const uint16_t ftpPort = 21;
</span><span class="cx"> static const uint16_t gopherPort = 70;
</span><span class="lines">@@ -543,7 +543,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool isSpecialScheme(StringView scheme)
</del><ins>+inline static bool isSpecialScheme(StringView scheme)
</ins><span class="cx"> {
</span><span class="cx"> auto length = scheme.length();
</span><span class="cx"> if (!length)
</span><span class="lines">@@ -638,7 +638,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void copyASCIIStringUntil(Vector<LChar>& destination, const String& string, size_t lengthIf8Bit, size_t lengthIf16Bit)
</del><ins>+inline static void copyASCIIStringUntil(Vector<LChar>& destination, const String& string, size_t lengthIf8Bit, size_t lengthIf16Bit)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(destination.isEmpty());
</span><span class="cx"> if (string.is8Bit()) {
</span><span class="lines">@@ -717,7 +717,7 @@
</span><span class="cx"> static const char* dotASCIICode = "2e";
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static bool isPercentEncodedDot(CodePointIterator<CharacterType> c)
</del><ins>+inline static bool isPercentEncodedDot(CodePointIterator<CharacterType> c)
</ins><span class="cx"> {
</span><span class="cx"> if (c.atEnd())
</span><span class="cx"> return false;
</span><span class="lines">@@ -735,7 +735,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static bool isSingleDotPathSegment(CodePointIterator<CharacterType> c)
</del><ins>+inline static bool isSingleDotPathSegment(CodePointIterator<CharacterType> c)
</ins><span class="cx"> {
</span><span class="cx"> if (c.atEnd())
</span><span class="cx"> return false;
</span><span class="lines">@@ -759,7 +759,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static bool isDoubleDotPathSegment(CodePointIterator<CharacterType> c)
</del><ins>+inline static bool isDoubleDotPathSegment(CodePointIterator<CharacterType> c)
</ins><span class="cx"> {
</span><span class="cx"> if (c.atEnd())
</span><span class="cx"> return false;
</span><span class="lines">@@ -783,7 +783,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static void consumeSingleDotPathSegment(CodePointIterator<CharacterType>& c)
</del><ins>+inline static void consumeSingleDotPathSegment(CodePointIterator<CharacterType>& c)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isSingleDotPathSegment(c));
</span><span class="cx"> if (*c == '.') {
</span><span class="lines">@@ -811,7 +811,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static void consumeDoubleDotPathSegment(CodePointIterator<CharacterType>& c)
</del><ins>+inline static void consumeDoubleDotPathSegment(CodePointIterator<CharacterType>& c)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(isDoubleDotPathSegment(c));
</span><span class="cx"> if (*c == '.')
</span><span class="lines">@@ -1588,7 +1588,7 @@
</span><span class="cx"> destination.append(p, end - p);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void serializeIPv4(uint32_t address, Vector<LChar>& buffer)
</del><ins>+inline static void serializeIPv4(uint32_t address, Vector<LChar>& buffer)
</ins><span class="cx"> {
</span><span class="cx"> append<uint8_t>(buffer, address >> 24);
</span><span class="cx"> buffer.append('.');
</span><span class="lines">@@ -1599,7 +1599,7 @@
</span><span class="cx"> append<uint8_t>(buffer, address);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static size_t zeroSequenceLength(const std::array<uint16_t, 8>& address, size_t begin)
</del><ins>+inline static size_t zeroSequenceLength(const std::array<uint16_t, 8>& address, size_t begin)
</ins><span class="cx"> {
</span><span class="cx"> size_t end = begin;
</span><span class="cx"> for (; end < 8; end++) {
</span><span class="lines">@@ -1609,7 +1609,7 @@
</span><span class="cx"> return end - begin;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static Optional<size_t> findLongestZeroSequence(const std::array<uint16_t, 8>& address)
</del><ins>+inline static Optional<size_t> findLongestZeroSequence(const std::array<uint16_t, 8>& address)
</ins><span class="cx"> {
</span><span class="cx"> Optional<size_t> longest;
</span><span class="cx"> size_t longestLength = 0;
</span><span class="lines">@@ -1626,7 +1626,7 @@
</span><span class="cx"> return longest;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void serializeIPv6Piece(uint16_t piece, Vector<LChar>& buffer)
</del><ins>+inline static void serializeIPv6Piece(uint16_t piece, Vector<LChar>& buffer)
</ins><span class="cx"> {
</span><span class="cx"> bool printed = false;
</span><span class="cx"> if (auto nibble0 = piece >> 12) {
</span><span class="lines">@@ -1644,7 +1644,7 @@
</span><span class="cx"> buffer.append(lowerNibbleToLowercaseASCIIHexDigit(piece & 0xF));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void serializeIPv6(std::array<uint16_t, 8> address, Vector<LChar>& buffer)
</del><ins>+inline static void serializeIPv6(std::array<uint16_t, 8> address, Vector<LChar>& buffer)
</ins><span class="cx"> {
</span><span class="cx"> buffer.append('[');
</span><span class="cx"> auto compressPointer = findLongestZeroSequence(address);
</span><span class="lines">@@ -1668,7 +1668,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static Optional<uint32_t> parseIPv4Number(CodePointIterator<CharacterType>& iterator)
</del><ins>+inline static Optional<uint32_t> parseIPv4Number(CodePointIterator<CharacterType>& iterator)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: Check for overflow.
</span><span class="cx"> enum class State : uint8_t {
</span><span class="lines">@@ -1728,7 +1728,7 @@
</span><span class="cx"> return value;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static uint64_t pow256(size_t exponent)
</del><ins>+inline static uint64_t pow256(size_t exponent)
</ins><span class="cx"> {
</span><span class="cx"> RELEASE_ASSERT(exponent <= 4);
</span><span class="cx"> uint64_t values[5] = {1, 256, 256 * 256, 256 * 256 * 256, 256ull * 256 * 256 * 256 };
</span><span class="lines">@@ -1736,7 +1736,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static Optional<uint32_t> parseIPv4Host(CodePointIterator<CharacterType> iterator)
</del><ins>+inline static Optional<uint32_t> parseIPv4Host(CodePointIterator<CharacterType> iterator)
</ins><span class="cx"> {
</span><span class="cx"> Vector<uint32_t, 4> items;
</span><span class="cx"> items.reserveInitialCapacity(4);
</span><span class="lines">@@ -1767,7 +1767,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename CharacterType>
</span><del>-static Optional<std::array<uint16_t, 8>> parseIPv6Host(CodePointIterator<CharacterType> c)
</del><ins>+inline static Optional<std::array<uint16_t, 8>> parseIPv6Host(CodePointIterator<CharacterType> c)
</ins><span class="cx"> {
</span><span class="cx"> if (c.atEnd())
</span><span class="cx"> return Nullopt;
</span><span class="lines">@@ -1860,7 +1860,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: This should return a CString.
</span><del>-static String percentDecode(const LChar* input, size_t length)
</del><ins>+inline static String percentDecode(const LChar* input, size_t length)
</ins><span class="cx"> {
</span><span class="cx"> StringBuilder output;
</span><span class="cx">
</span><span class="lines">@@ -1880,7 +1880,7 @@
</span><span class="cx"> return output.toStringPreserveCapacity();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool containsOnlyASCII(const String& string)
</del><ins>+inline static bool containsOnlyASCII(const String& string)
</ins><span class="cx"> {
</span><span class="cx"> if (string.is8Bit())
</span><span class="cx"> return charactersAreAllASCII(string.characters8(), string.length());
</span><span class="lines">@@ -1887,7 +1887,7 @@
</span><span class="cx"> return charactersAreAllASCII(string.characters16(), string.length());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static Optional<String> domainToASCII(const String& domain)
</del><ins>+inline static Optional<String> domainToASCII(const String& domain)
</ins><span class="cx"> {
</span><span class="cx"> const unsigned hostnameBufferLength = 2048;
</span><span class="cx">
</span><span class="lines">@@ -1920,7 +1920,7 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static bool hasInvalidDomainCharacter(const String& asciiDomain)
</del><ins>+inline static bool hasInvalidDomainCharacter(const String& asciiDomain)
</ins><span class="cx"> {
</span><span class="cx"> RELEASE_ASSERT(asciiDomain.is8Bit());
</span><span class="cx"> const LChar* characters = asciiDomain.characters8();
</span><span class="lines">@@ -2073,7 +2073,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static Optional<String> formURLDecode(StringView input)
</del><ins>+inline static Optional<String> formURLDecode(StringView input)
</ins><span class="cx"> {
</span><span class="cx"> auto utf8 = input.utf8(StrictConversion);
</span><span class="cx"> if (utf8.isNull())
</span><span class="lines">@@ -2103,7 +2103,7 @@
</span><span class="cx"> return output;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void serializeURLEncodedForm(const String& input, Vector<LChar>& output)
</del><ins>+inline static void serializeURLEncodedForm(const String& input, Vector<LChar>& output)
</ins><span class="cx"> {
</span><span class="cx"> auto utf8 = input.utf8(StrictConversion);
</span><span class="cx"> const char* data = utf8.data();
</span></span></pre>
</div>
</div>
</body>
</html>