<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[206063] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/206063">206063</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-16 20:53:29 -0700 (Fri, 16 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed cleanup of some inspector tests.
* TestExpectations:
Start skipping some debugger stepping test flakeyness on
Debug builds until that bug is addressed.
* inspector/debugger/break-on-exception-throw-in-promise.html:
Remove debug only.
* inspector/debugger/paused-scopes.html: Added.
This test was missing for 3 months. Its expectations got added
but the test itself got lost after a rollout and re-land.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakonexceptionthrowinpromisehtml">trunk/LayoutTests/inspector/debugger/break-on-exception-throw-in-promise.html</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectordebuggerpausedscopeshtml">trunk/LayoutTests/inspector/debugger/paused-scopes.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (206062 => 206063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-09-17 03:18:45 UTC (rev 206062)
+++ trunk/LayoutTests/ChangeLog        2016-09-17 03:53:29 UTC (rev 206063)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-09-16 Joseph Pecoraro <pecoraro@apple.com>
+
+ Unreviewed cleanup of some inspector tests.
+
+ * TestExpectations:
+ Start skipping some debugger stepping test flakeyness on
+ Debug builds until that bug is addressed.
+
+ * inspector/debugger/break-on-exception-throw-in-promise.html:
+ Remove debug only.
+
+ * inspector/debugger/paused-scopes.html: Added.
+ This test was missing for 3 months. Its expectations got added
+ but the test itself got lost after a rollout and re-land.
+
</ins><span class="cx"> 2016-09-16 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Cancelling one frame's load cancels load in other frames that have the same URL as well
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (206062 => 206063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations        2016-09-17 03:18:45 UTC (rev 206062)
+++ trunk/LayoutTests/TestExpectations        2016-09-17 03:53:29 UTC (rev 206063)
</span><span class="lines">@@ -144,6 +144,9 @@
</span><span class="cx"> # This test is fast enough in release but quite slow in debug builds.
</span><span class="cx"> [ Debug ] inspector/debugger/debugger-stack-overflow.html [ Skip ]
</span><span class="cx">
</span><ins>+# Debugger stepping tests can timeout if they run slowly due to a short timer scheduled in the frontend.
+webkit.org/b/161951 [ Debug ] inspector/debugger/paused-scopes.html [ Skip ]
+
</ins><span class="cx"> # Doesn't work yet, relies on network replay functionality (webkit.org/b/130728, webkit.org/b/129391)
</span><span class="cx"> webkit.org/b/131318 http/tests/inspector/replay/document-last-modified-fallback-value.html [ Skip ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakonexceptionthrowinpromisehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/break-on-exception-throw-in-promise.html (206062 => 206063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/break-on-exception-throw-in-promise.html        2016-09-17 03:18:45 UTC (rev 206062)
+++ trunk/LayoutTests/inspector/debugger/break-on-exception-throw-in-promise.html        2016-09-17 03:53:29 UTC (rev 206063)
</span><span class="lines">@@ -12,8 +12,6 @@
</span><span class="cx">
</span><span class="cx"> let suite = InspectorTest.createAsyncSuite("BreakOnAnyException.Promise");
</span><span class="cx">
</span><del>- InspectorTest.debug();
-
</del><span class="cx"> function addTestCase({name, description, expression}) {
</span><span class="cx"> suite.addTestCase({
</span><span class="cx"> name, description,
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerpausedscopeshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/inspector/debugger/paused-scopes.html (0 => 206063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/paused-scopes.html         (rev 0)
+++ trunk/LayoutTests/inspector/debugger/paused-scopes.html        2016-09-17 03:53:29 UTC (rev 206063)
</span><span class="lines">@@ -0,0 +1,117 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../http/tests/inspector/resources/inspector-test.js"></script>
+<script src="resources/paused-scopes.js"></script>
+<script>
+function test()
+{
+ function scopeTypeName(type) {
+ switch (type) {
+ case WebInspector.ScopeChainNode.Type.Local: return "Local";
+ case WebInspector.ScopeChainNode.Type.Global: return "Global";
+ case WebInspector.ScopeChainNode.Type.GlobalLexicalEnvironment: return "GlobalLexicalEnvironment";
+ case WebInspector.ScopeChainNode.Type.With: return "With";
+ case WebInspector.ScopeChainNode.Type.Closure: return "Closure";
+ case WebInspector.ScopeChainNode.Type.Catch: return "Catch";
+ case WebInspector.ScopeChainNode.Type.FunctionName: return "FunctionName";
+ case WebInspector.ScopeChainNode.Type.Block: return "Block";
+ default: return "Unknown!";
+ };
+ }
+
+ function sanitizeHash(hash) {
+ return hash.replace(/:(.*?):/, ":<sourceID>:");
+ }
+
+ function collectScopeChainProperties(scopeChain) {
+ let scopeChainData = [];
+
+ let promises = [];
+ for (let scope of scopeChain) {
+ let data = {scope, properties: []};
+ scopeChainData.push(data);
+ if (scope.type === WebInspector.ScopeChainNode.Type.Global)
+ continue;
+
+ for (let scopeObject of scope.objects) {
+ promises.push(new Promise((resolve, reject) => {
+ scopeObject.getAllPropertyDescriptors((propertyDescriptors) => {
+ data.properties = data.properties.concat(propertyDescriptors);
+ resolve();
+ });
+ }));
+ }
+ }
+
+ return Promise.all(promises)
+ .then(() => scopeChainData);
+ }
+
+ function dumpScopeChainData(scopeChainData) {
+ for (let {scope, properties} of scopeChainData) {
+ InspectorTest.log(` SCOPE: Name (${scope.name}) - Type (${scopeTypeName(scope.type)}) - Hash (${sanitizeHash(scope.hash)})`);
+ for (let propertyDescriptor of properties)
+ InspectorTest.log(` - ${propertyDescriptor.name}`);
+ }
+ }
+
+ function dumpCallFrame(callFrame) {
+ return Promise.all([
+ collectScopeChainProperties(callFrame.scopeChain),
+ collectScopeChainProperties(callFrame.mergedScopeChain()),
+ ]).then((results) => {
+ let [scopeChainData, mergedScopeChainData] = results;
+ InspectorTest.log(`CALLFRAME: ${callFrame.functionName}`);
+ InspectorTest.log("\n---- Scope Chain ----");
+ dumpScopeChainData(scopeChainData);
+ InspectorTest.log("\n---- Merged Scope Chain ----");
+ dumpScopeChainData(mergedScopeChainData);
+ InspectorTest.log("");
+ });
+ }
+
+ function dumpCallFrames() {
+ let callFrames = WebInspector.debuggerManager.callFrames;
+ let chain = Promise.resolve();
+ for (let callFrame of callFrames)
+ chain = chain.then(() => dumpCallFrame(callFrame));
+ return chain;
+ }
+
+
+ let suite = InspectorTest.createAsyncSuite("PausedCallFrameScope");
+
+ suite.addTestCase({
+ name: "TriggerFirstPause",
+ description: "Verify CallFrames and Scopes with the first pause.",
+ test: (resolve, reject) => {
+ InspectorTest.evaluateInPage("setTimeout(entry)");
+ WebInspector.debuggerManager.singleFireEventListener(WebInspector.DebuggerManager.Event.CallFramesDidChange, (event) => {
+ dumpCallFrames().then(resolve, reject);
+ });
+ }
+ });
+
+ suite.addTestCase({
+ name: "TriggerSecondPause",
+ description: "Verify CallFrames and Scopes with the first pause.",
+ test: (resolve, reject) => {
+ WebInspector.debuggerManager.resume();
+ WebInspector.debuggerManager.singleFireEventListener(WebInspector.DebuggerManager.Event.CallFramesDidChange, (event) => {
+ dumpCallFrames().then(() => {
+ WebInspector.debuggerManager.resume();
+ resolve();
+ }, reject);
+ });
+ }
+ });
+
+ suite.runTestCasesAndFinish();
+}
+</script>
+</head>
+<body onload="runTest()">
+<p>Check scope chains for different call frames at different pauses.</p>
+</body>
+</html>
</ins></span></pre>
</div>
</div>
</body>
</html>