<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[205967] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205967">205967</a></dd>

<dt>Author</dt> <dd>ossy@webkit.org</dd>

<dt>Date</dt> <dd>2016-09-15 04:18:08 -0700 (Thu, 15 Sep 2016)</dd>

</dl>

<h3>Log Message</h3>

<pre>js/stringimpl-to-jsstring-on-large-strings tests consume huge memory

https://bugs.webkit.org/show_bug.cgi?id=159807

Reviewed by Saam Barati.

Tools:

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.

* Scripts/run-javascriptcore-tests:

(runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.

* Scripts/run-jsc-stress-tests: Typo fix.

LayoutTests:

* js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js: Skipped on memory limited devices.

* js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js: Skipped on memory limited devices.

* js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js: Skipped on memory limited devices.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestsjsscripttestsstringimpltojsstringonlargestrings1js">trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js</a></li>

<li><a href="#trunkLayoutTestsjsscripttestsstringimpltojsstringonlargestrings2js">trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js</a></li>

<li><a href="#trunkLayoutTestsjsscripttestsstringimpltojsstringonlargestrings3js">trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js</a></li>

<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg</a></li>

<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>

<li><a href="#trunkToolsScriptsrunjavascriptcoretests">trunk/Tools/Scripts/run-javascriptcore-tests</a></li>

<li><a href="#trunkToolsScriptsrunjscstresstests">trunk/Tools/Scripts/run-jsc-stress-tests</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/LayoutTests/ChangeLog        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -1,3 +1,14 @@

</span><ins>+2016-09-15  Csaba Osztrogonác  &lt;ossy@webkit.org&gt;

+

+        js/stringimpl-to-jsstring-on-large-strings tests consume huge memory

+        https://bugs.webkit.org/show_bug.cgi?id=159807

+

+        Reviewed by Saam Barati.

+

+        * js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js: Skipped on memory limited devices.

+        * js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js: Skipped on memory limited devices.

+        * js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js: Skipped on memory limited devices.

+

</ins><span class="cx"> 2016-09-07  Sergio Villar Senin  &lt;svillar@igalia.com&gt;

</span><span class="cx"> 

</span><span class="cx">         [css-grid] Implement fit-content track size

</span></span></pre></div>

<a id="trunkLayoutTestsjsscripttestsstringimpltojsstringonlargestrings1js"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -1,3 +1,5 @@

</span><ins>+//@largeHeap

+

</ins><span class="cx"> &quot;use strict&quot;

</span><span class="cx"> 

<span class="cx"> // Based on André Bargull's test case.

</span></span></pre></div>

<a id="trunkLayoutTestsjsscripttestsstringimpltojsstringonlargestrings2js"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -1,3 +1,5 @@

</span><ins>+//@largeHeap

+

</ins><span class="cx"> &quot;use strict&quot;

</span><span class="cx"> 

<span class="cx"> // Based on André Bargull's test case.

</span></span></pre></div>

<a id="trunkLayoutTestsjsscripttestsstringimpltojsstringonlargestrings3js"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -1,3 +1,5 @@

</span><ins>+//@largeHeap

+

</ins><span class="cx"> &quot;use strict&quot;

</span><span class="cx"> 

<span class="cx"> // This test passes if it does not crash.

</span></span></pre></div>

<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg"></a>

<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -325,7 +325,7 @@

</span><span class="cx"> 

</span><span class="cx"> class RunRemoteJavaScriptCoreTests(RunJavaScriptCoreTests):

</span><span class="cx">     def start(self):

</span><del>-        self.setCommand(self.command + [&quot;--remote-config-file&quot;, &quot;../../remote-jsc-tests-config.json&quot;])

</del><ins>+        self.setCommand(self.command + [&quot;--memory-limited&quot;, &quot;--remote-config-file&quot;, &quot;../../remote-jsc-tests-config.json&quot;])

</ins><span class="cx">         return RunJavaScriptCoreTests.start(self)

</span><span class="cx"> 

</span><span class="cx"> 

</span></span></pre></div>

<a id="trunkToolsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/ChangeLog        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/Tools/ChangeLog        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -1,3 +1,16 @@

</span><ins>+2016-09-15  Csaba Osztrogonác  &lt;ossy@webkit.org&gt;

+

+        js/stringimpl-to-jsstring-on-large-strings tests consume huge memory

+        https://bugs.webkit.org/show_bug.cgi?id=159807

+

+        Reviewed by Saam Barati.

+

+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

+        (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.

+        * Scripts/run-javascriptcore-tests:

+        (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.

+        * Scripts/run-jsc-stress-tests: Typo fix.

+

</ins><span class="cx"> 2016-09-14  Wenson Hsieh  &lt;wenson_hsieh@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Media controls behave strangely when changing media sources

</span></span></pre></div>

<a id="trunkToolsScriptsrunjavascriptcoretests"></a>

<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-javascriptcore-tests (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/Scripts/run-javascriptcore-tests        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/Tools/Scripts/run-javascriptcore-tests        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -52,6 +52,7 @@

</span><span class="cx"> my $childProcesses;

</span><span class="cx"> my $shellRunner;

</span><span class="cx"> my $makeRunner;

</span><ins>+my $memoryLimited;

</ins><span class="cx"> 

</span><span class="cx"> my $buildJSC = 1;

</span><span class="cx"> 

</span><span class="lines">@@ -131,6 +132,10 @@

<span class="cx">   --shell-runner                Uses the shell-based test runner instead of the default make-based runner.

<span class="cx">                                 In general the shell runner is slower than the make runner.

<span class="cx">   --make-runner                 Uses the faster make-based runner.

</span><ins>+

+  --memory-limited              Indicate that we are targeting the test for a memory limited device.

+                                Skip tests tagged with //\@largeHeap

+

</ins><span class="cx">   --filter                      Only run tests whose name matches the given regular expression.

<span class="cx">   --env-vars                    Pass a list of environment variables to set before running tests.

<span class="cx">                                 Each environment variable should be separated by a space.

</span><span class="lines">@@ -160,6 +165,7 @@

</span><span class="cx">     'child-processes=s' =&gt; \$childProcesses,

</span><span class="cx">     'shell-runner' =&gt; \$shellRunner,

</span><span class="cx">     'make-runner' =&gt; \$makeRunner,

</span><ins>+    'memory-limited' =&gt; \$memoryLimited,

</ins><span class="cx">     'filter=s' =&gt; \$filter,

</span><span class="cx">     'help' =&gt; \$showHelp,

</span><span class="cx">     'env-vars=s' =&gt; \$envVars,

</span><span class="lines">@@ -338,6 +344,10 @@

</span><span class="cx">         push(@jscStressDriverCmd, &quot;--make-runner&quot;);

</span><span class="cx">     }

</span><span class="cx"> 

</span><ins>+    if ($memoryLimited) {

+        push(@jscStressDriverCmd, &quot;--memory-limited&quot;);

+    }

+

</ins><span class="cx">     if ($filter) {

</span><span class="cx">         push(@jscStressDriverCmd, &quot;--filter&quot;);

</span><span class="cx">         push(@jscStressDriverCmd, $filter);

</span></span></pre></div>

<a id="trunkToolsScriptsrunjscstresstests"></a>

<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-jsc-stress-tests (205966 => 205967)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Tools/Scripts/run-jsc-stress-tests        2016-09-15 09:45:36 UTC (rev 205966)

+++ trunk/Tools/Scripts/run-jsc-stress-tests        2016-09-15 11:18:08 UTC (rev 205967)

</span><span class="lines">@@ -125,7 +125,7 @@

</span><span class="cx">     puts &quot;--no-copy                   Do not copy the JavaScriptCore build product before testing.&quot;

</span><span class="cx">     puts &quot;                            --jsc specifies an already present JavaScriptCore to test.&quot;

</span><span class="cx">     puts &quot;--memory-limited            Indicate that we are targeting the test for a memory limited device.&quot;

</span><del>-    puts &quot;                            Skip tests tagged with //@large-heap&quot;

</del><ins>+    puts &quot;                            Skip tests tagged with //@largeHeap&quot;

</ins><span class="cx">     puts &quot;--no-jit                    Do not run JIT specific tests.&quot;

</span><span class="cx">     puts &quot;--output-dir         (-o)   Path where to put results. Default is #{$outputDir}.&quot;

</span><span class="cx">     puts &quot;--verbose            (-v)   Print more things while running.&quot;

</span></span></pre>

</div>

</div>

</body>

</html>