<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205970] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205970">205970</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-09-15 08:42:47 -0700 (Thu, 15 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Cleanup RenderLayer::shouldBeNormalFlowOnly
https://bugs.webkit.org/show_bug.cgi?id=161981
Reviewed by Simon Fraser.
Source/WebCore:
This patch changes the logic of figuring about if a particular layer is normal flow only by simply checking
if the layer creates a stacking context. If it does, we assume that it can't be a normal flow layer anymore.
This patch slightly changes behaviour by making layers with isolation and reflection to be non normal flow layers anymore.
Covered by existing testcases.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
LayoutTests:
Rebaselining.
* fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasttableoverflowtablecollapsedborderssectionselfpaintinglayerpaintingexpectedtxt">trunk/LayoutTests/fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatormediaaudiorepaintexpectedtxt">trunk/LayoutTests/platform/ios-simulator/media/audio-repaint-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (205969 => 205970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-09-15 15:40:55 UTC (rev 205969)
+++ trunk/LayoutTests/ChangeLog 2016-09-15 15:42:47 UTC (rev 205970)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-09-15 Zalan Bujtas <zalan@apple.com>
+
+ Cleanup RenderLayer::shouldBeNormalFlowOnly
+ https://bugs.webkit.org/show_bug.cgi?id=161981
+
+ Reviewed by Simon Fraser.
+
+ Rebaselining.
+
+ * fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt:
+
</ins><span class="cx"> 2016-09-15 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
</span></span></pre></div>
<a id="trunkLayoutTestsfasttableoverflowtablecollapsedborderssectionselfpaintinglayerpaintingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt (205969 => 205970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt 2016-09-15 15:40:55 UTC (rev 205969)
+++ trunk/LayoutTests/fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt 2016-09-15 15:42:47 UTC (rev 205970)
</span><span class="lines">@@ -5,6 +5,22 @@
</span><span class="cx"> RenderBody {BODY} at (8,8) size 784x540
</span><span class="cx"> layer at (8,8) size 70x60 clip at (18,18) size 50x40 scrollWidth 80
</span><span class="cx"> RenderTable {DIV} at (0,0) size 70x60 [color=#008000] [border: (10px solid #000000)]
</span><ins>+layer at (8,68) size 70x60 clip at (18,78) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,60) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,128) size 70x60 clip at (18,138) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,120) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,188) size 70x60 clip at (18,198) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,180) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,248) size 70x60 clip at (18,258) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,240) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,308) size 70x60 clip at (18,318) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,300) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,368) size 70x60 clip at (18,378) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,360) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,428) size 70x60 clip at (18,438) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,420) size 70x60 [color=#008000] [border: (10px solid #000000)]
+layer at (8,488) size 70x60 clip at (18,498) size 50x40 scrollWidth 80
+ RenderTable {DIV} at (0,480) size 70x60 [color=#008000] [border: (10px solid #000000)]
</ins><span class="cx"> layer at (18,18) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -12,8 +28,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,68) size 70x60 clip at (18,78) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,60) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,78) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -22,8 +36,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,128) size 70x60 clip at (18,138) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,120) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,138) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -32,8 +44,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,188) size 70x60 clip at (18,198) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,180) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,198) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -41,8 +51,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,248) size 70x60 clip at (18,258) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,240) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,258) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -51,8 +59,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,308) size 70x60 clip at (18,318) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,300) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,318) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -62,8 +68,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,368) size 70x60 clip at (18,378) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,360) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,378) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -72,8 +76,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,428) size 70x60 clip at (18,438) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,420) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,438) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span><span class="lines">@@ -82,8 +84,6 @@
</span><span class="cx"> RenderInline {SPAN} at (0,0) size 70x10 [color=#0000FF]
</span><span class="cx"> RenderText {#text} at (10,10) size 70x10
</span><span class="cx"> text run at (10,10) width 70: "XXXXXXX"
</span><del>-layer at (8,488) size 70x60 clip at (18,498) size 50x40 scrollWidth 80
- RenderTable {DIV} at (0,480) size 70x60 [color=#008000] [border: (10px solid #000000)]
</del><span class="cx"> layer at (18,498) size 50x40
</span><span class="cx"> RenderTableSection {DIV} at (10,10) size 50x40
</span><span class="cx"> RenderTableRow {DIV} at (0,0) size 50x40
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatormediaaudiorepaintexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/media/audio-repaint-expected.txt (205969 => 205970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/media/audio-repaint-expected.txt 2016-09-15 15:40:55 UTC (rev 205969)
+++ trunk/LayoutTests/platform/ios-simulator/media/audio-repaint-expected.txt 2016-09-15 15:42:47 UTC (rev 205970)
</span><span class="lines">@@ -12,6 +12,14 @@
</span><span class="cx"> RenderBR {BR} at (260,39) size 0x0
</span><span class="cx"> RenderBR {BR} at (260,103) size 0x0
</span><span class="cx"> RenderBR {BR} at (260,196) size 0x0
</span><ins>+layer at (8,44) size 260x39 scrollHeight 89
+ RenderFlexibleBox {DIV} at (0,0) size 260x39
+layer at (8,44) size 260x39
+ RenderBlock (positioned) {DIV} at (0,0) size 260x39
+layer at (8,44) size 260x39
+ RenderFlexibleBox {DIV} at (0,0) size 260x39 [bgcolor=#D4D4D4]
+layer at (12,44) size 42x39 blendMode: plus-darker
+ RenderButton {BUTTON} at (4,0) size 42x39 [bgcolor=#000000]
</ins><span class="cx"> layer at (8,83) size 260x39 isolatesBlending
</span><span class="cx"> RenderMedia {AUDIO} at (0,39) size 260x39
</span><span class="cx"> layer at (8,83) size 260x39 scrollHeight 89
</span><span class="lines">@@ -22,14 +30,6 @@
</span><span class="cx"> RenderFlexibleBox {DIV} at (0,0) size 260x39 [bgcolor=#D4D4D4]
</span><span class="cx"> layer at (12,83) size 42x39 blendMode: plus-darker
</span><span class="cx"> RenderButton {BUTTON} at (4,0) size 42x39 [bgcolor=#000000]
</span><del>-layer at (8,44) size 260x39 scrollHeight 89
- RenderFlexibleBox {DIV} at (0,0) size 260x39
-layer at (8,44) size 260x39
- RenderBlock (positioned) {DIV} at (0,0) size 260x39
-layer at (8,44) size 260x39
- RenderFlexibleBox {DIV} at (0,0) size 260x39 [bgcolor=#D4D4D4]
-layer at (12,44) size 42x39 blendMode: plus-darker
- RenderButton {BUTTON} at (4,0) size 42x39 [bgcolor=#000000]
</del><span class="cx"> layer at (8,174) size 260x39 isolatesBlending
</span><span class="cx"> RenderMedia {AUDIO} at (0,130) size 260x39
</span><span class="cx"> layer at (8,174) size 260x39 scrollHeight 89
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205969 => 205970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-15 15:40:55 UTC (rev 205969)
+++ trunk/Source/WebCore/ChangeLog 2016-09-15 15:42:47 UTC (rev 205970)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-09-15 Zalan Bujtas <zalan@apple.com>
+
+ Cleanup RenderLayer::shouldBeNormalFlowOnly
+ https://bugs.webkit.org/show_bug.cgi?id=161981
+
+ Reviewed by Simon Fraser.
+
+ This patch changes the logic of figuring about if a particular layer is normal flow only by simply checking
+ if the layer creates a stacking context. If it does, we assume that it can't be a normal flow layer anymore.
+ This patch slightly changes behaviour by making layers with isolation and reflection to be non normal flow layers anymore.
+
+ Covered by existing testcases.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::calculateClipRects):
+
</ins><span class="cx"> 2016-09-07 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [css-grid] Implement fit-content track size
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (205969 => 205970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2016-09-15 15:40:55 UTC (rev 205969)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2016-09-15 15:42:47 UTC (rev 205970)
</span><span class="lines">@@ -6477,35 +6477,43 @@
</span><span class="cx"> return createsGraphicalGroup || (renderer.style().willChange() && renderer.style().willChange()->canCreateGraphicalGroup());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static bool createsStackingContext(const RenderLayer& layer)
+{
+ auto& renderer = layer.renderer();
+ return renderer.hasTransformRelatedProperty()
+ || renderer.isPositioned()
+ || layer.needsCompositedScrolling()
+ || renderer.style().hasFlowFrom()
+ || renderer.hasReflection()
+ || renderer.style().hasIsolation()
+#if PLATFORM(IOS)
+ || layer.hasAcceleratedTouchScrolling()
+#endif
+ // FIXME: Check if willChange()->canCreateStackingContext() is more accurate here.
+ || mayCreateGraphicalGroup(renderer);
+}
+
</ins><span class="cx"> bool RenderLayer::shouldBeNormalFlowOnly() const
</span><span class="cx"> {
</span><del>- return (renderer().hasOverflowClip()
- || renderer().hasReflection()
- || renderer().hasMask()
</del><ins>+ if (createsStackingContext(*this))
+ return false;
+
+ return renderer().hasOverflowClip()
</ins><span class="cx"> || renderer().isCanvas()
</span><span class="cx"> || renderer().isVideo()
</span><span class="cx"> || renderer().isEmbeddedObject()
</span><span class="cx"> || renderer().isRenderIFrame()
</span><span class="cx"> || (renderer().style().specifiesColumns() && !isRootLayer())
</span><del>- || renderer().isInFlowRenderFlowThread())
- && !renderer().hasTransformRelatedProperty()
- && !renderer().isPositioned()
- && !needsCompositedScrolling()
- && !renderer().style().hasFlowFrom()
-#if PLATFORM(IOS)
- && !hasAcceleratedTouchScrolling()
-#endif
- && !mayCreateGraphicalGroup(renderer());
</del><ins>+ || renderer().isInFlowRenderFlowThread();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool RenderLayer::shouldBeSelfPaintingLayer() const
</span><span class="cx"> {
</span><del>- return !isNormalFlowOnly()
- || hasOverlayScrollbars()
</del><ins>+ if (!isNormalFlowOnly())
+ return true;
+
+ return hasOverlayScrollbars()
</ins><span class="cx"> || needsCompositedScrolling()
</span><del>- || isolatesBlending()
- || renderer().hasReflection()
- || renderer().hasMask()
</del><span class="cx"> || renderer().isTableRow()
</span><span class="cx"> || renderer().isCanvas()
</span><span class="cx"> || renderer().isVideo()
</span></span></pre>
</div>
</div>
</body>
</html>