<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205825] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205825">205825</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-12 14:42:31 -0700 (Mon, 12 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: WKWebView for macOS does not allow configuration of tabsToLinks
https://bugs.webkit.org/show_bug.cgi?id=161394
Patch by DAN SAUNDERS <dasau@microsoft.com> on 2016-09-12
Reviewed by Anders Carlsson.
Source/WebKit2:
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
(-[WKPreferences tabFocusesLinks]):
(-[WKPreferences setTabFocusesLinks:]):
Tools:
* TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaCodingmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (205824 => 205825)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-12 21:42:31 UTC (rev 205825)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-09-12 DAN SAUNDERS <dasau@microsoft.com>
+
+ AX: WKWebView for macOS does not allow configuration of tabsToLinks
+ https://bugs.webkit.org/show_bug.cgi?id=161394
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKPreferences.h:
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences encodeWithCoder:]):
+ (-[WKPreferences initWithCoder:]):
+ (-[WKPreferences tabFocusesLinks]):
+ (-[WKPreferences setTabFocusesLinks:]):
+
</ins><span class="cx"> 2016-09-12 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Add WebKit support for an option in Safari's debug menu similar to "Get Bytecode Profile" but for the Sampling Profiler's data
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h (205824 => 205825)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2016-09-12 21:42:31 UTC (rev 205825)
</span><span class="lines">@@ -63,6 +63,13 @@
</span><span class="cx"> @discussion The default value is NO.
</span><span class="cx"> */
</span><span class="cx"> @property (nonatomic) BOOL plugInsEnabled;
</span><ins>+
+/*!
+ @property tabFocusesLinks
+ @abstract If tabFocusesLinks is YES, the tab key will focus links and form controls.
+ The option key temporarily reverses this preference.
+ */
+@property (nonatomic) BOOL tabFocusesLinks WK_API_AVAILABLE(macosx(WK_MAC_TBA));
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> @end
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (205824 => 205825)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2016-09-12 21:42:31 UTC (rev 205825)
</span><span class="lines">@@ -66,6 +66,7 @@
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> [coder encodeBool:self.javaEnabled forKey:@"javaEnabled"];
</span><span class="cx"> [coder encodeBool:self.plugInsEnabled forKey:@"plugInsEnabled"];
</span><ins>+ [coder encodeBool:self.tabFocusesLinks forKey:@"tabFocusesLinks"];
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -81,6 +82,7 @@
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> self.javaEnabled = [coder decodeBoolForKey:@"javaEnabled"];
</span><span class="cx"> self.plugInsEnabled = [coder decodeBoolForKey:@"plugInsEnabled"];
</span><ins>+ self.tabFocusesLinks = [coder decodeBoolForKey:@"tabFocusesLinks"];
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> return self;
</span><span class="lines">@@ -140,6 +142,16 @@
</span><span class="cx"> _preferences->setPluginsEnabled(plugInsEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)tabFocusesLinks
+{
+ return _preferences->tabsToLinks();
+}
+
+- (void)setTabFocusesLinks:(BOOL)tabFocusesLinks
+{
+ _preferences->setTabsToLinks(tabFocusesLinks);
+}
+
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #pragma mark WKObject protocol implementation
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (205824 => 205825)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Tools/ChangeLog 2016-09-12 21:42:31 UTC (rev 205825)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-09-12 DAN SAUNDERS <dasau@microsoft.com>
+
+ AX: WKWebView for macOS does not allow configuration of tabsToLinks
+ https://bugs.webkit.org/show_bug.cgi?id=161394
+
+ Reviewed by Anders Carlsson.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
+ (TEST):
+
</ins><span class="cx"> 2016-09-12 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove trailing control characters and spaces before parsing a URL
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaCodingmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm (205824 => 205825)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm 2016-09-12 21:30:30 UTC (rev 205824)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm 2016-09-12 21:42:31 UTC (rev 205825)
</span><span class="lines">@@ -51,6 +51,7 @@
</span><span class="cx"> [a setJavaScriptCanOpenWindowsAutomatically:NO];
</span><span class="cx"> [a setJavaEnabled:YES];
</span><span class="cx"> [a setPlugInsEnabled:YES];
</span><ins>+ [a setTabFocusesLinks:YES];
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> auto b = encodeAndDecode(a.get());
</span><span class="lines">@@ -62,6 +63,7 @@
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> EXPECT_EQ([a javaEnabled], [b javaEnabled]);
</span><span class="cx"> EXPECT_EQ([a plugInsEnabled], [b plugInsEnabled]);
</span><ins>+ EXPECT_EQ([a tabFocusesLinks], [b tabFocusesLinks]);
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>