<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205810] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205810">205810</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2016-09-12 09:08:52 -0700 (Mon, 12 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>DFG::forAllKilledOperands() could use a faster bitvector scan in the same-inline-stack fast path
https://bugs.webkit.org/show_bug.cgi?id=161849
Reviewed by Saam Barati.
Source/JavaScriptCore:
This is a fairly obvious change. This turns a loop that would query each bit individually
into a loop that will process a word at a time. I would expect a very tiny progression in
DFG compile times.
This also gave me an opportunity to test and fix the new FastBitVector functionality.
* dfg/DFGForAllKills.h:
(JSC::DFG::forAllKilledOperands):
Source/WTF:
It turns out that templates make private fields weird. FastBitVectorImpl can't necessarily
touch privates in instances of different template specializations of itself. So, I added a
public method called wordView() that exposes the necessary private field.
* wtf/FastBitVector.h:
(WTF::FastBitVectorImpl::operator&):
(WTF::FastBitVectorImpl::operator|):
(WTF::FastBitVectorImpl::operator~):
(WTF::FastBitVectorImpl::forEachSetBit):
(WTF::FastBitVectorImpl::wordView):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGForAllKillsh">trunk/Source/JavaScriptCore/dfg/DFGForAllKills.h</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfFastBitVectorh">trunk/Source/WTF/wtf/FastBitVector.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (205809 => 205810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-09-12 15:50:17 UTC (rev 205809)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-09-12 16:08:52 UTC (rev 205810)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-09-11 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><ins>+ DFG::forAllKilledOperands() could use a faster bitvector scan in the same-inline-stack fast path
+ https://bugs.webkit.org/show_bug.cgi?id=161849
+
+ Reviewed by Saam Barati.
+
+ This is a fairly obvious change. This turns a loop that would query each bit individually
+ into a loop that will process a word at a time. I would expect a very tiny progression in
+ DFG compile times.
+
+ This also gave me an opportunity to test and fix the new FastBitVector functionality.
+
+ * dfg/DFGForAllKills.h:
+ (JSC::DFG::forAllKilledOperands):
+
+2016-09-11 Filip Pizlo <fpizlo@apple.com>
+
</ins><span class="cx"> FastBitVector should have efficient and easy-to-use vector-vector operations
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=161847
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGForAllKillsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGForAllKills.h (205809 => 205810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGForAllKills.h 2016-09-12 15:50:17 UTC (rev 205809)
+++ trunk/Source/JavaScriptCore/dfg/DFGForAllKills.h 2016-09-12 16:08:52 UTC (rev 205810)
</span><span class="lines">@@ -76,14 +76,10 @@
</span><span class="cx"> const FastBitVector& liveBefore = fullLiveness.getLiveness(before.bytecodeIndex);
</span><span class="cx"> const FastBitVector& liveAfter = fullLiveness.getLiveness(after.bytecodeIndex);
</span><span class="cx">
</span><del>- // FIXME: Consider doing this instead:
- // (liveBefore & ~liveAfter).forEachSetBit(...)
- // https://bugs.webkit.org/show_bug.cgi?id=161849
- for (unsigned relativeLocal = codeBlock->m_numCalleeLocals; relativeLocal--;) {
- if (liveBefore[relativeLocal] && !liveAfter[relativeLocal])
</del><ins>+ (liveBefore & ~liveAfter).forEachSetBit(
+ [&] (size_t relativeLocal) {
</ins><span class="cx"> functor(virtualRegisterForLocal(relativeLocal) + stackOffset);
</span><del>- }
-
</del><ins>+ });
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (205809 => 205810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-09-12 15:50:17 UTC (rev 205809)
+++ trunk/Source/WTF/ChangeLog 2016-09-12 16:08:52 UTC (rev 205810)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2016-09-11 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><ins>+ DFG::forAllKilledOperands() could use a faster bitvector scan in the same-inline-stack fast path
+ https://bugs.webkit.org/show_bug.cgi?id=161849
+
+ Reviewed by Saam Barati.
+
+ It turns out that templates make private fields weird. FastBitVectorImpl can't necessarily
+ touch privates in instances of different template specializations of itself. So, I added a
+ public method called wordView() that exposes the necessary private field.
+
+ * wtf/FastBitVector.h:
+ (WTF::FastBitVectorImpl::operator&):
+ (WTF::FastBitVectorImpl::operator|):
+ (WTF::FastBitVectorImpl::operator~):
+ (WTF::FastBitVectorImpl::forEachSetBit):
+ (WTF::FastBitVectorImpl::wordView):
+
+2016-09-11 Filip Pizlo <fpizlo@apple.com>
+
</ins><span class="cx"> FastBitVector should have efficient and easy-to-use vector-vector operations
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=161847
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFwtfFastBitVectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/FastBitVector.h (205809 => 205810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/FastBitVector.h 2016-09-12 15:50:17 UTC (rev 205809)
+++ trunk/Source/WTF/wtf/FastBitVector.h 2016-09-12 16:08:52 UTC (rev 205810)
</span><span class="lines">@@ -258,7 +258,7 @@
</span><span class="cx"> private:
</span><span class="cx"> View m_view;
</span><span class="cx"> };
</span><del>-
</del><ins>+
</ins><span class="cx"> class FastBitVector;
</span><span class="cx">
</span><span class="cx"> template<typename Words>
</span><span class="lines">@@ -323,24 +323,24 @@
</span><span class="cx"> template<typename OtherWords>
</span><span class="cx"> FastBitVectorImpl<FastBitVectorAndWords<typename Words::ViewType, typename OtherWords::ViewType>> operator&(const FastBitVectorImpl<OtherWords>& other) const
</span><span class="cx"> {
</span><del>- return FastBitVectorImpl<FastBitVectorAndWords<typename Words::ViewType, typename OtherWords::ViewType>>(FastBitVectorAndWords<typename Words::ViewType, typename OtherWords::ViewType>(m_words.view(), other.m_words.view()));
</del><ins>+ return FastBitVectorImpl<FastBitVectorAndWords<typename Words::ViewType, typename OtherWords::ViewType>>(FastBitVectorAndWords<typename Words::ViewType, typename OtherWords::ViewType>(wordView(), other.wordView()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename OtherWords>
</span><span class="cx"> FastBitVectorImpl<FastBitVectorOrWords<typename Words::ViewType, typename OtherWords::ViewType>> operator|(const FastBitVectorImpl<OtherWords>& other) const
</span><span class="cx"> {
</span><del>- return FastBitVectorImpl<FastBitVectorOrWords<typename Words::ViewType, typename OtherWords::ViewType>>(FastBitVectorOrWords<typename Words::ViewType, typename OtherWords::ViewType>(m_words.view(), other.m_words.view()));
</del><ins>+ return FastBitVectorImpl<FastBitVectorOrWords<typename Words::ViewType, typename OtherWords::ViewType>>(FastBitVectorOrWords<typename Words::ViewType, typename OtherWords::ViewType>(wordView(), other.wordView()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FastBitVectorImpl<FastBitVectorNotWords<typename Words::ViewType>> operator~() const
</span><span class="cx"> {
</span><del>- return FastBitVectorImpl<FastBitVectorNotWords<typename Words::ViewType>>(FastBitVectorNotWords<typename Words::ViewType>(m_words.view()));
</del><ins>+ return FastBitVectorImpl<FastBitVectorNotWords<typename Words::ViewType>>(FastBitVectorNotWords<typename Words::ViewType>(wordView()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename Func>
</span><span class="cx"> ALWAYS_INLINE void forEachSetBit(const Func& func) const
</span><span class="cx"> {
</span><del>- size_t n = m_words.arrayLength();
</del><ins>+ size_t n = arrayLength();
</ins><span class="cx"> for (size_t i = 0; i < n; ++i) {
</span><span class="cx"> uint32_t word = m_words.word(i);
</span><span class="cx"> size_t j = i * 32;
</span><span class="lines">@@ -416,6 +416,8 @@
</span><span class="cx"> out.print((*this)[i] ? "1" : "-");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ typename Words::ViewType wordView() const { return m_words.view(); }
+
</ins><span class="cx"> private:
</span><span class="cx"> // You'd think that we could remove this friend if we used protected, but you'd be wrong,
</span><span class="cx"> // because templates.
</span></span></pre>
</div>
</div>
</body>
</html>